[jira] [Assigned] (KAFKA-2328) merge-kafka-pr.py script should not leave user in a detached branch

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-2328: -- Assignee: Ismael Juma merge-kafka-pr.py script should not leave user in a detached branch

Re: [VOTE] Drop support for Scala 2.9 for the next release

2015-07-17 Thread Ashish Singh
+1 (non-binding) On Friday, July 17, 2015, Stevo Slavić ssla...@gmail.com wrote: +1 (non-binding) On Fri, Jul 17, 2015 at 12:26 PM, Ismael Juma ism...@juma.me.uk javascript:; wrote: Hi all, I would like to start a vote on dropping support for Scala 2.9 for the next release. People

[jira] [Updated] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-1595: --- Status: Patch Available (was: In Progress) Mailing list thread:

Re: Review Request 36548: Patch for KAFKA-2336

2015-07-17 Thread Grant Henke
On July 17, 2015, 4:26 a.m., Jiangjie Qin wrote: Looks good to me. Jiangjie Qin wrote: Actually do we need to talk to Zookeeper every time? Can we read the data from topic metadata cache directly? Gwen Shapira wrote: Good point, Jiangjie - looks like partitionFor is called

[jira] [Commented] (KAFKA-2328) merge-kafka-pr.py script should not leave user in a detached branch

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631432#comment-14631432 ] Ismael Juma commented on KAFKA-2328: OK, I was wrong, there is code to restore the

Re: [VOTE] Drop support for Scala 2.9 for the next release

2015-07-17 Thread Grant Henke
+1 (non-binding) On Fri, Jul 17, 2015 at 9:44 AM, Ashish Singh asi...@cloudera.com wrote: +1 (non-binding) On Friday, July 17, 2015, Stevo Slavić ssla...@gmail.com wrote: +1 (non-binding) On Fri, Jul 17, 2015 at 12:26 PM, Ismael Juma ism...@juma.me.uk javascript:; wrote: Hi all,

Review Request 36570: Patch for KAFKA-2337

2015-07-17 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/ --- Review request for kafka. Bugs: KAFKA-2337

[jira] [Commented] (KAFKA-2337) Verify that metric names will not collide when creating new topics

2015-07-17 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631468#comment-14631468 ] Grant Henke commented on KAFKA-2337: Created reviewboard

[jira] [Updated] (KAFKA-2337) Verify that metric names will not collide when creating new topics

2015-07-17 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2337: --- Status: Patch Available (was: In Progress) Verify that metric names will not collide when creating

[jira] [Updated] (KAFKA-2337) Verify that metric names will not collide when creating new topics

2015-07-17 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2337: --- Attachment: KAFKA-2337.patch Verify that metric names will not collide when creating new topics

[jira] [Commented] (KAFKA-2337) Verify that metric names will not collide when creating new topics

2015-07-17 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631474#comment-14631474 ] Grant Henke commented on KAFKA-2337: This patch: - Checks all topic creation including

[jira] [Commented] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

2015-07-17 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630836#comment-14630836 ] Ashish K Singh commented on KAFKA-2345: --- Created reviewboard

[jira] [Updated] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

2015-07-17 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2345: -- Attachment: KAFKA-2345.patch Attempt to delete a topic already marked for deletion throws

[jira] [Updated] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

2015-07-17 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2345: -- Status: Patch Available (was: Open) Attempt to delete a topic already marked for deletion

Review Request 36565: Patch for KAFKA-2345

2015-07-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/ --- Review request for kafka. Bugs: KAFKA-2345

[DISCUSS] KIP-27 - Conditional Publish

2015-07-17 Thread Ben Kirwin
Hi there, I just added a KIP for a 'conditional publish' operation: a simple CAS-like mechanism for the Kafka producer. The wiki page is here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-27+-+Conditional+Publish And there's some previous discussion on the ticket and the users list:

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-17 Thread Ben Kirwin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630870#comment-14630870 ] Ben Kirwin commented on KAFKA-2260: --- Opened a KIP for this here:

[jira] [Assigned] (KAFKA-2339) broker becomes unavailable if bad data is passed through the protocol

2015-07-17 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen reassigned KAFKA-2339: --- Assignee: Timothy Chen broker becomes unavailable if bad data is passed through the

[jira] [Created] (KAFKA-2346) modified typo api.html in 0.8.2 and 0.8.3

2015-07-17 Thread Asano Ryohei (JIRA)
Asano Ryohei created KAFKA-2346: --- Summary: modified typo api.html in 0.8.2 and 0.8.3 Key: KAFKA-2346 URL: https://issues.apache.org/jira/browse/KAFKA-2346 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2344) Improvements for the pr-merge tool

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630894#comment-14630894 ] Ismael Juma commented on KAFKA-2344: To avoid confusion since that wiki age has a lot

[jira] [Updated] (KAFKA-2346) modified typo api.html in 0.8.2 and 0.8.3

2015-07-17 Thread Asano Ryohei (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Asano Ryohei updated KAFKA-2346: Attachment: KAFKA_api_typo-0.8.3.patch KAFKA_api_typo-0.8.2.patch modified typo

Build failed in Jenkins: KafkaPreCommit #155

2015-07-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/155/changes Changes: [cshapi] KAFKA-2324; Update to Scala 2.11.7 -- [...truncated 1137 lines...] kafka.consumer.ZookeeperConsumerConnectorTest testLeaderSelectionForPartition PASSED

[jira] [Commented] (KAFKA-2344) Improvements for the pr-merge tool

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630887#comment-14630887 ] Ismael Juma commented on KAFKA-2344: Good point about the reviewers. I noticed that

[jira] [Commented] (KAFKA-2339) broker becomes unavailable if bad data is passed through the protocol

2015-07-17 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630981#comment-14630981 ] Timothy Chen commented on KAFKA-2339: - Somehow I can't produce this with kafkacat and

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630874#comment-14630874 ] Guozhang Wang commented on KAFKA-1835: -- Hmm, so although partitionsFor() returns you

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631048#comment-14631048 ] Ismael Juma commented on KAFKA-2203: I just did a `gradlew build` with JDK 8u60 EA and

Re: [VOTE] Drop support for Scala 2.9 for the next release

2015-07-17 Thread Brock Noland
+1 (non-binding) On Friday, July 17, 2015, Grant Henke ghe...@cloudera.com wrote: +1 (non-binding) On Fri, Jul 17, 2015 at 9:44 AM, Ashish Singh asi...@cloudera.com javascript:; wrote: +1 (non-binding) On Friday, July 17, 2015, Stevo Slavić ssla...@gmail.com javascript:; wrote:

Re: Review Request 36570: Patch for KAFKA-2337

2015-07-17 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/ --- (Updated July 17, 2015, 4:17 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2328) merge-kafka-pr.py script should not leave user in a detached branch

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2328: --- Status: Patch Available (was: Open) Looks like definite bug, PR fixes it. [~gwenshap] or

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-17 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631502#comment-14631502 ] Jiangjie Qin commented on KAFKA-2260: - [~bkirwi] The question 1 I had is actually for

Re: Review Request 36570: Patch for KAFKA-2337

2015-07-17 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92092 --- core/src/main/scala/kafka/common/Topic.scala (lines 53 - 54)

Re: Review Request 36570: Patch for KAFKA-2337

2015-07-17 Thread Grant Henke
On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote: core/src/main/scala/kafka/common/Topic.scala, line 64 https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64 *Maybe* this method name could be renamed to 'collide' to make it more like a verb instead of a

Re: [VOTE] Drop support for Scala 2.9 for the next release

2015-07-17 Thread Neha Narkhede
+1 (binding) On Fri, Jul 17, 2015 at 8:33 AM, Brock Noland br...@apache.org wrote: +1 (non-binding) On Friday, July 17, 2015, Grant Henke ghe...@cloudera.com wrote: +1 (non-binding) On Fri, Jul 17, 2015 at 9:44 AM, Ashish Singh asi...@cloudera.com javascript:; wrote: +1

[GitHub] kafka pull request: KAFKA-2328; merge-kafka-pr.py script should no...

2015-07-17 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/84 KAFKA-2328; merge-kafka-pr.py script should not leave user in a detached branch The right command to get the branch name is `git rev-parse --abbrev-ref HEAD` instead of `git rev-parse HEAD`. The

[jira] [Commented] (KAFKA-2328) merge-kafka-pr.py script should not leave user in a detached branch

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631543#comment-14631543 ] ASF GitHub Bot commented on KAFKA-2328: --- GitHub user ijuma opened a pull request:

Re: Review Request 36570: Patch for KAFKA-2337

2015-07-17 Thread Grant Henke
On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote: core/src/main/scala/kafka/common/Topic.scala, line 64 https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64 *Maybe* this method name could be renamed to 'collide' to make it more like a verb instead of a

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-17 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631512#comment-14631512 ] Jay Kreps commented on KAFKA-2260: -- [~yasuhiro.matsuda] had a good variation on this

Re: Review Request 35867: Patch for KAFKA-1901

2015-07-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92078 ---

Re: Review Request 36565: Patch for KAFKA-2345

2015-07-17 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/#review92088 --- Ship it! Ship It! - Sriharsha Chintalapani On July 17, 2015,

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-17 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631509#comment-14631509 ] Jiangjie Qin commented on KAFKA-1835: - I am thinking partitionsFor() will not use

Re: Review Request 36570: Patch for KAFKA-2337

2015-07-17 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92089 --- core/src/main/scala/kafka/common/Topic.scala (line 64)

Re: Review Request 36565: Patch for KAFKA-2345

2015-07-17 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/#review92090 ---

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-07-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1901: -- Status: In Progress (was: Patch Available) Move Kafka version to be generated in code by build

Re: [VOTE] Drop support for Scala 2.9 for the next release

2015-07-17 Thread Stevo Slavić
+1 (non-binding) On Fri, Jul 17, 2015 at 12:26 PM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on dropping support for Scala 2.9 for the next release. People seemed to be in favour of the idea in previous discussions: *

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

2015-07-17 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631105#comment-14631105 ] Stevo Slavic commented on KAFKA-2203: - On a clean clone of trunk, with gradle 2.5 and

[jira] [Comment Edited] (KAFKA-2203) Get gradle build to work with Java 8

2015-07-17 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631105#comment-14631105 ] Stevo Slavic edited comment on KAFKA-2203 at 7/17/15 9:50 AM: --

[GitHub] kafka pull request: KAFKA-1595; Remove deprecated and slower scala...

2015-07-17 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/83 KAFKA-1595; Remove deprecated and slower scala JSON parser Tested that we only use Jackson methods introduced in 2.0 in the main codebase by compiling it with the older version locally. We use a

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631210#comment-14631210 ] ASF GitHub Bot commented on KAFKA-1595: --- GitHub user ijuma opened a pull request:

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631114#comment-14631114 ] Ismael Juma commented on KAFKA-2203: I was planning to start a [VOTE] thread in the

[VOTE] Drop support for Scala 2.9 for the next release

2015-07-17 Thread Ismael Juma
Hi all, I would like to start a vote on dropping support for Scala 2.9 for the next release. People seemed to be in favour of the idea in previous discussions: * http://search-hadoop.com/m/uyzND1uIW3k2fZVfU1 * http://search-hadoop.com/m/uyzND1KMLNK11Rmo72 Summary of why we should drop Scala

[jira] [Updated] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-1595: --- Attachment: (was: KAFKA-1595.patch) Remove deprecated and slower scala JSON parser from

[jira] [Commented] (KAFKA-2203) Get gradle build to work with Java 8

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631106#comment-14631106 ] Ismael Juma commented on KAFKA-2203: Stevo, Scala 2.9.x doesn't support Java 8. That's

[jira] [Assigned] (KAFKA-2344) Improvements for the pr-merge tool

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-2344: -- Assignee: Ismael Juma Improvements for the pr-merge tool --

[jira] [Commented] (KAFKA-2344) kafka-merge-pr should support reviewers in commit message

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631564#comment-14631564 ] Ismael Juma commented on KAFKA-2344: I renamed the JIRA title, I hope you don't mind.

Re: [VOTE] Drop support for Scala 2.9 for the next release

2015-07-17 Thread Gwen Shapira
+1 (binding) On Fri, Jul 17, 2015 at 3:26 AM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on dropping support for Scala 2.9 for the next release. People seemed to be in favour of the idea in previous discussions: * http://search-hadoop.com/m/uyzND1uIW3k2fZVfU1

Re: Review Request 36565: Patch for KAFKA-2345

2015-07-17 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/#review92106 --- Ship it! - Gwen Shapira On July 17, 2015, 5:21 p.m., Ashish

Re: Review Request 36548: Patch for KAFKA-2336

2015-07-17 Thread Jiangjie Qin
On July 17, 2015, 4:26 a.m., Jiangjie Qin wrote: Looks good to me. Jiangjie Qin wrote: Actually do we need to talk to Zookeeper every time? Can we read the data from topic metadata cache directly? Gwen Shapira wrote: Good point, Jiangjie - looks like partitionFor is called

Re: Build failed in Jenkins: KafkaPreCommit #156

2015-07-17 Thread Gwen Shapira
Ick. It seemed to work locally. I'm checking what went wrong. Let me know if you want a revert. On Fri, Jul 17, 2015 at 10:39 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/KafkaPreCommit/156/changes Changes: [cshapi] KAFKA-2345; Attempt to

[jira] [Updated] (KAFKA-2344) kafka-merge-pr should support reviewers in commit message

2015-07-17 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2344: --- Summary: kafka-merge-pr should support reviewers in commit message (was: Improvements for the

Re: Review Request 36565: Patch for KAFKA-2345

2015-07-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/ --- (Updated July 17, 2015, 5:21 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

2015-07-17 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631618#comment-14631618 ] Ashish K Singh commented on KAFKA-2345: --- Updated reviewboard

[jira] [Updated] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

2015-07-17 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2345: -- Attachment: KAFKA-2345_2015-07-17_10:20:55.patch Attempt to delete a topic already marked for

Re: [DISCUSS] KIP-27 - Conditional Publish

2015-07-17 Thread Flavio Junqueira
I like this feature, it reminds me of conditional updates in zookeeper. I'm not sure if it'd be best to have some mechanism for fencing rather than a conditional write like you're proposing. The reason I'm saying this is that the conditional write applies to requests individually, while it

[jira] [Commented] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

2015-07-17 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631645#comment-14631645 ] Gwen Shapira commented on KAFKA-2345: - Thanks for the patch [~singhashish] and for the

Re: Review Request 36548: Patch for KAFKA-2336

2015-07-17 Thread Grant Henke
On July 17, 2015, 4:26 a.m., Jiangjie Qin wrote: Looks good to me. Jiangjie Qin wrote: Actually do we need to talk to Zookeeper every time? Can we read the data from topic metadata cache directly? Gwen Shapira wrote: Good point, Jiangjie - looks like partitionFor is called

[jira] [Commented] (KAFKA-2344) kafka-merge-pr should support reviewers in commit message

2015-07-17 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631614#comment-14631614 ] Gwen Shapira commented on KAFKA-2344: - Good with me [~ijuma]. The JIRA issue was my

Re: Review Request 36565: Patch for KAFKA-2345

2015-07-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/#review92105 ---

[jira] [Updated] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

2015-07-17 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2345: Resolution: Fixed Reviewer: Gwen Shapira Fix Version/s: 0.8.3 Status:

Build failed in Jenkins: KafkaPreCommit #156

2015-07-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/156/changes Changes: [cshapi] KAFKA-2345; Attempt to delete a topic already marked for deletion throws ZkNodeExistsException; patched by Ashish Singh; reviewed by Sriharsha Chintalapani and Ismael Juma

Re: Review Request 36570: Patch for KAFKA-2337

2015-07-17 Thread Grant Henke
On July 17, 2015, 4:05 p.m., Edward Ribeiro wrote: core/src/main/scala/kafka/common/Topic.scala, lines 53-54 https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line53 This method name is sort of a misnomer is a it is checking for special characters that could lead

Re: Review Request 36570: Patch for KAFKA-2337

2015-07-17 Thread Edward Ribeiro
On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote: core/src/main/scala/kafka/common/Topic.scala, line 64 https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64 *Maybe* this method name could be renamed to 'collide' to make it more like a verb instead of a

[jira] [Commented] (KAFKA-2337) Verify that metric names will not collide when creating new topics

2015-07-17 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631525#comment-14631525 ] Grant Henke commented on KAFKA-2337: Updated reviewboard

[jira] [Updated] (KAFKA-2337) Verify that metric names will not collide when creating new topics

2015-07-17 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2337: --- Attachment: KAFKA-2337_2015-07-17_11:17:30.patch Verify that metric names will not collide when

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-17 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631772#comment-14631772 ] Aditya Auradkar commented on KAFKA-2205: [~junrao] Another patch ready!

Re: [VOTE] Drop support for Scala 2.9 for the next release

2015-07-17 Thread Jakob Homan
+1 (binding) On 17 July 2015 at 10:06, Gwen Shapira gshap...@cloudera.com wrote: +1 (binding) On Fri, Jul 17, 2015 at 3:26 AM, Ismael Juma ism...@juma.me.uk wrote: Hi all, I would like to start a vote on dropping support for Scala 2.9 for the next release. People seemed to be in favour of

Build failed in Jenkins: KafkaPreCommit #157

2015-07-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/157/changes Changes: [cshapi] Adding a file missed while committing KAFKA-2345 -- [...truncated 797 lines...] kafka.log.OffsetMapTest testBasicValidation PASSED kafka.log.LogManagerTest

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-17 Thread Aditya Auradkar
On July 17, 2015, 4:43 a.m., Jun Rao wrote: core/src/main/scala/kafka/server/ConfigHandler.scala, lines 64-65 https://reviews.apache.org/r/34554/diff/5/?file=1011630#file1011630line64 Could we just use Pool? Nice.. didn't know about that util. - Aditya

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-17 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631699#comment-14631699 ] Aditya A Auradkar commented on KAFKA-2205: -- Updated reviewboard

Build failed in Jenkins: Kafka-trunk #549

2015-07-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/549/changes Changes: [cshapi] KAFKA-2345; Attempt to delete a topic already marked for deletion throws ZkNodeExistsException; patched by Ashish Singh; reviewed by Sriharsha Chintalapani and Ismael Juma [cshapi] Adding a file missed while

Official Kafka Gitter Room?

2015-07-17 Thread Grant Henke
With more of Kafka's development moving to Github is there any interest in creating a Gitter chat room? I think it could be useful to have a place to chat that is associated with the Kafka repo. Note that we do currently have an IRC channel, but from my experience its a ghost town. I am also

Re: Official Kafka Gitter Room?

2015-07-17 Thread Ashish Singh
+1, will be helpful. On Fri, Jul 17, 2015 at 11:28 AM, Grant Henke ghe...@cloudera.com wrote: With more of Kafka's development moving to Github is there any interest in creating a Gitter chat room? I think it could be useful to have a place to chat that is associated with the Kafka repo.

Re: Build failed in Jenkins: KafkaPreCommit #156

2015-07-17 Thread Gwen Shapira
my bad, I missed a file while committing. I did a trivial commit with the missing file and I think the build looks ok now. On Fri, Jul 17, 2015 at 10:42 AM, Gwen Shapira csh...@gmail.com wrote: Ick. It seemed to work locally. I'm checking what went wrong. Let me know if you want a revert.

Re: Build failed in Jenkins: KafkaPreCommit #156

2015-07-17 Thread Ismael Juma
It's a bit easy for this to happen with the patch workflow. The GitHub one via the merge script fixes it nicely. There are a couple of improvements that need to be done and then I will start a vote on switching to it. Hopefully early next week. Ismael On 17 Jul 2015 18:55, Gwen Shapira

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-17 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:14 p.m.) Review request for kafka, Joel Koshy and

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-17 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631694#comment-14631694 ] Aditya A Auradkar commented on KAFKA-2205: -- Updated reviewboard

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-17 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:14 p.m.) Review request for kafka, Joel Koshy and

[jira] [Updated] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-17 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2205: - Attachment: KAFKA-2205_2015-07-17_11:14:26.patch Generalize TopicConfigManager to handle

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-07-17 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631700#comment-14631700 ] Gwen Shapira commented on KAFKA-1595: - [~ijuma] - I'll be happy to review, but can't

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-17 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:18 p.m.) Review request for kafka, Joel Koshy and

[jira] [Updated] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-17 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2205: - Attachment: KAFKA-2205_2015-07-17_11:18:31.patch Generalize TopicConfigManager to handle

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-17 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 17, 2015, 6:20 p.m.) Review request for kafka, Joel Koshy and

Re: [DISCUSS] KIP-27 - Conditional Publish

2015-07-17 Thread Mayuresh Gharat
If we have 2 producers producing to a partition, they can be out of order, then how does one producer know what offset to expect as it does not interact with other producer? Can you give an example flow that explains how it works with single producer and with multiple producers? Thanks,

Merge improvements back into Kafka Metrics?

2015-07-17 Thread Felix GV
Hi, We've been using the new Kafka Metrics within Voldemort for a little while now, and we have made some improvements to the library that you might like to copy back into Kafka proper. You can view the changes that went in after we forked here: https://github.com/tehuti-io/tehuti/commits/master

Review Request 36578: Patch for KAFKA-2338

2015-07-17 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/ --- Review request for kafka. Bugs: KAFKA-2338

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

2015-07-17 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338.patch Warn users if they change max.message.bytes that they also need

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

2015-07-17 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631784#comment-14631784 ] Edward Ribeiro commented on KAFKA-2338: --- Created reviewboard

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

2015-07-17 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631785#comment-14631785 ] Edward Ribeiro commented on KAFKA-2338: --- Hi [~ewencp], as this my first official

Review Request 36590: Patch for KAFKA-2275

2015-07-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/ --- Review request for kafka. Bugs: KAFKA-2275

[jira] [Updated] (KAFKA-2275) Add a ListTopics() API to the new consumer

2015-07-17 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2275: -- Status: Patch Available (was: Open) Add a ListTopics() API to the new consumer

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

2015-07-17 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632137#comment-14632137 ] Ashish K Singh commented on KAFKA-2275: --- Created reviewboard

  1   2   >