Re: [VOTE] KIP-997: Partition-Level Throughput Metrics

2023-11-28 Thread Vahid Hashemian
+1 (binding). Thanks! --Vahid On Tue, Nov 21, 2023, 1:00 AM Qichao Chu wrote: > Hi All, > > It would be nice if we could have more people to review and vote for this > KIP. > Many thanks! > > Qichao > > > On Mon, Nov 20, 2023 at 2:43 PM Qichao Chu wrote: > > > @Matthias: yeah it should be

Re: [DISCUSS] KIP-977: Partition-Level Throughput Metrics

2023-11-28 Thread Vahid Hashemian
Hi Qichao, Thanks for answering my questions and updating the KIP accordingly. It looks good to me. --Vahid On Tue, Nov 28, 2023, 7:22 PM Qichao Chu wrote: > Hi Vahid, > > Thank you for taking the time to review the KIP and asking great questions. > > The execution path mentioned is exactly

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2426

2023-11-28 Thread Apache Jenkins Server
See Changes: -- [...truncated 408263 lines...] Gradle Test Run :connect:runtime:test > Gradle Test Executor 46 > org.apache.kafka.connect.util.TopicAdminTest >

Re: [DISCUSS] KIP-977: Partition-Level Throughput Metrics

2023-11-28 Thread Qichao Chu
Hi Vahid, Thank you for taking the time to review the KIP and asking great questions. The execution path mentioned is exactly how this KIP is going to function. We believe this config, compared with many other configurations like quota, will not pose significant alteration to the broker's

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2425

2023-11-28 Thread Apache Jenkins Server
See

Re: Having a Hard Time Unsubscribing

2023-11-28 Thread Matthias J. Sax
When you send an email to unsubscribe..., there should be a response from the bot. Check your spam folder. You need to ack the unsubscribe by replying the the response email the bot sent. HTH. -Matthias On 11/28/23 6:10 AM, Dasun Nirmitha wrote: Hello Kafka devs, I'm aware that it's a

Re: Having a Hard Time Unsubscribing

2023-11-28 Thread Justine Olshan
Hey there -- did you receive the followup email when you sent the email to dev-unsubscr...@kafka.apache.org? There is one more email you have to send to a custom address to get the process to complete. Likewise with the other lists. Let me know if it still doesn't work, Justine On Tue, Nov 28,

[jira] [Created] (KAFKA-15922) Add MetadataVersion for JBOD

2023-11-28 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-15922: Summary: Add MetadataVersion for JBOD Key: KAFKA-15922 URL: https://issues.apache.org/jira/browse/KAFKA-15922 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] Should we continue to merge without a green build? No!

2023-11-28 Thread Sophie Blee-Goldman
Thanks for that link Ismael -- I'd never seen it before. That's super useful In fact, it helped me realize another area where we could really improve things. I took a look at the worst offenders on that chart and was debugging the 2nd most flaky Streams test when I expanded the timeframe and saw

[jira] [Created] (KAFKA-15921) Flaky test - SaslScramSslEndToEndAuthorizationTest.testAuthentications

2023-11-28 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-15921: Summary: Flaky test - SaslScramSslEndToEndAuthorizationTest.testAuthentications Key: KAFKA-15921 URL: https://issues.apache.org/jira/browse/KAFKA-15921 Project:

[jira] [Created] (KAFKA-15920) Flaky test - PlaintextConsumerTest.testCoordinatorFailover

2023-11-28 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-15920: Summary: Flaky test - PlaintextConsumerTest.testCoordinatorFailover Key: KAFKA-15920 URL: https://issues.apache.org/jira/browse/KAFKA-15920 Project: Kafka

[jira] [Created] (KAFKA-15919) Flaky test - BrokerLifecycleManagerTest.testAlwaysSendsAccumulatedOfflineDirs

2023-11-28 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-15919: Summary: Flaky test - BrokerLifecycleManagerTest.testAlwaysSendsAccumulatedOfflineDirs Key: KAFKA-15919 URL: https://issues.apache.org/jira/browse/KAFKA-15919

[jira] [Created] (KAFKA-15918) Flaky test - OffsetsApiIntegrationTest. testResetSinkConnectorOffsets

2023-11-28 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-15918: Summary: Flaky test - OffsetsApiIntegrationTest. testResetSinkConnectorOffsets Key: KAFKA-15918 URL: https://issues.apache.org/jira/browse/KAFKA-15918 Project: Kafka

[jira] [Created] (KAFKA-15917) Flaky test - OffsetsApiIntegrationTest. testAlterSinkConnectorOffsetsZombieSinkTasks

2023-11-28 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-15917: Summary: Flaky test - OffsetsApiIntegrationTest. testAlterSinkConnectorOffsetsZombieSinkTasks Key: KAFKA-15917 URL: https://issues.apache.org/jira/browse/KAFKA-15917

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2424

2023-11-28 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs

2023-11-28 Thread Jason Gustafson
Hey Raman, Thanks for the KIP! I think it makes sense. I agree that this becomes especially useful in the context of KIP-939 because transactions can last an indefinite amount of time, but it is useful even today. A large cluster may have a very large number of ongoing transactions at any time,

[jira] [Resolved] (KAFKA-15544) Enable existing client integration tests for new protocol

2023-11-28 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-15544. Resolution: Fixed > Enable existing client integration tests for new protocol >

[jira] [Created] (KAFKA-15916) Flaky test - testClientSideTimeoutAfterFailureToReceiveResponse - KafkaAdminClientTest

2023-11-28 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15916: -- Summary: Flaky test - testClientSideTimeoutAfterFailureToReceiveResponse - KafkaAdminClientTest Key: KAFKA-15916 URL: https://issues.apache.org/jira/browse/KAFKA-15916

[jira] [Created] (KAFKA-15915) Flaky test - testUnrecoverableError - ProducerIdManagerTest

2023-11-28 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15915: -- Summary: Flaky test - testUnrecoverableError - ProducerIdManagerTest Key: KAFKA-15915 URL: https://issues.apache.org/jira/browse/KAFKA-15915 Project: Kafka

[jira] [Created] (KAFKA-15914) Flaky test - testAlterSinkConnectorOffsetsOverriddenConsumerGroupId - OffsetsApiIntegrationTest

2023-11-28 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15914: -- Summary: Flaky test - testAlterSinkConnectorOffsetsOverriddenConsumerGroupId - OffsetsApiIntegrationTest Key: KAFKA-15914 URL:

[jira] [Created] (KAFKA-15913) Remove excessive use of spy in CosumerTestBuilder

2023-11-28 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15913: -- Summary: Remove excessive use of spy in CosumerTestBuilder Key: KAFKA-15913 URL: https://issues.apache.org/jira/browse/KAFKA-15913 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-996: Pre-Vote

2023-11-28 Thread Alyssa Huang
Thanks Jose, I've updated the KIP to reflect your and Jason's suggestions! On Tue, Nov 28, 2023 at 9:54 AM José Armando García Sancio wrote: > Hi Alyssa > > On Mon, Nov 27, 2023 at 1:40 PM Jason Gustafson > wrote: > > 2. Do you think the pretend epoch bump is necessary? Would it be simpler >

Re: [DISCUSS] KIP-996: Pre-Vote

2023-11-28 Thread José Armando García Sancio
Hi Alyssa On Mon, Nov 27, 2023 at 1:40 PM Jason Gustafson wrote: > 2. Do you think the pretend epoch bump is necessary? Would it be simpler to > change the prevote acceptance check to assert a greater than or equal epoch? I agree with Jason it would be better if all of the requests always sent

Re: [DISCUSS] KIP-996: Pre-Vote

2023-11-28 Thread Jason Gustafson
Hey Alyssa, Thanks for the response. I am not sure if `ProposedEpoch` is completely satisfying either. When the prevote flag is unset, the voters are expected to bump their own epoch when receiving the request. I think it makes the protocol a little simpler if the candidate epoch is always the

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #2423

2023-11-28 Thread Apache Jenkins Server
See

Re: Apache Kafka 3.6.1 release

2023-11-28 Thread Kirk True
Agreed. Thanks! On Thu, Nov 23, 2023, at 8:43 AM, Ismael Juma wrote: > I agree that we should not block 3.6.1 if it's not a regression. > > Ismael > > On Thu, Nov 23, 2023 at 8:13 AM Mickael Maison > wrote: > > > Hi Kirk, > > > > It's pretty late, I was hoping to build RC0 tomorrow morning

Re: [DISCUSS] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs

2023-11-28 Thread Kirk True
Hi Raman, Thanks for the KIP! Questions/comments: 1. Is there a Jira created for this? The Jira link still points to KAFKA-1. 2. There's a minor typo in the ListTransactionsRequest documentation for the DurationFilter: trsanactions. 3. Is the TransactionStartTimeMs return value in the

Re: [DISCUSS] Should we continue to merge without a green build? No!

2023-11-28 Thread Chris Egerton
Hi David, Thanks for continuing to drive this. Yes, ignoreFailures does come with some risk and it's only suitable as an intermediate step as part of a long-term plan that eventually gates all merges on builds with passing tests. I brought it up because it would allow us to immediately prevent

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-11-28 Thread Igor Soarez
Hi everyone, There have been a number of further changes. I have updated the KIP to reflect them, but for reference, I'd also like to update this thread with a summary. 1. The reserved Uuids and their names for directories have changed. The first 100 Uuids are reserved for future use. 2.

Having a Hard Time Unsubscribing

2023-11-28 Thread Dasun Nirmitha
Hello Kafka devs, I'm aware that it's a self-process to unsubscribe but I've sent multiple emails to dev-unsubscr...@kafka.apache.org, jira-unsubscr...@kafka.apache.org, users-unsubscr...@kafka.apache.org all to no avail. Any Kafka admins here, could you guys kindly look into this please? As the

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2422

2023-11-28 Thread Apache Jenkins Server
See Changes: -- [...truncated 330725 lines...] Gradle Test Run :streams:test > Gradle Test Executor 90 > DefaultTaskManagerTest >

Re: [PR] MINOR Add note about KAFKA-15552 to 3.6 upgrade section [kafka-site]

2023-11-28 Thread via GitHub
mimaison commented on code in PR #560: URL: https://github.com/apache/kafka-site/pull/560#discussion_r1407624587 ## 36/upgrade.html: ## @@ -84,7 +84,9 @@ Upgrading KRaft-based cl Notable changes in 3.6.0 -Apache Kafka now supports having both an IPv4 and

[jira] [Created] (KAFKA-15912) Parallelize conversion and transformation steps in Connect

2023-11-28 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-15912: -- Summary: Parallelize conversion and transformation steps in Connect Key: KAFKA-15912 URL: https://issues.apache.org/jira/browse/KAFKA-15912 Project: Kafka

Re: [PR] MINOR: Fix typo in 3.2.0 upgrade notes [kafka-site]

2023-11-28 Thread via GitHub
mimaison merged PR #569: URL: https://github.com/apache/kafka-site/pull/569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Update docs for 3.6.1 [kafka-site]

2023-11-28 Thread via GitHub
jlprat commented on code in PR #568: URL: https://github.com/apache/kafka-site/pull/568#discussion_r1407604199 ## 36/javadoc/allclasses-index.html: ## @@ -11,7 +11,7 @@ - Review Comment: Makes sense -- This is an automated message from the Apache Git Service. To

Re: [PR] MINOR: Update docs for 3.6.1 [kafka-site]

2023-11-28 Thread via GitHub
mimaison commented on code in PR #568: URL: https://github.com/apache/kafka-site/pull/568#discussion_r1407562619 ## 36/javadoc/allclasses-index.html: ## @@ -11,7 +11,7 @@ - Review Comment: It's because the previous javadoc files were generated using a different JVM.

[PR] MINOR: Fix typo in 3.2.0 upgrade notes [kafka-site]

2023-11-28 Thread via GitHub
mimaison opened a new pull request, #569: URL: https://github.com/apache/kafka-site/pull/569 Port of https://github.com/apache/kafka/commit/3c0840d28e216cc4f0cf7acf508afa0732d8c3c5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Update docs for 3.6.1 [kafka-site]

2023-11-28 Thread via GitHub
jlprat commented on code in PR #568: URL: https://github.com/apache/kafka-site/pull/568#discussion_r1407530950 ## 36/javadoc/allclasses-index.html: ## @@ -11,7 +11,7 @@ - Review Comment: why the downgrade? How were the `3.6.0` javadoc files generated? -- This is

Re: [DISCUSS] KIP-956: Tiered Storage Quotas

2023-11-28 Thread Luke Chen
Hi Abhijeet, Thanks for the KIP! This is an important feature for tiered storage. Some comments: 1. Will we introduce new metrics for this tiered storage quotas? This is important because the admin can know the throttling status by checking the metrics while the remote write/read are slow, like

Re: [VOTE] 3.6.1 RC0

2023-11-28 Thread Josep Prat
Hi Mickael, Thanks for running the release. It's a +1 for me (non-binding). I did the following: - Verified artifact's signatures and hashes - Checked JavaDoc (with navigation to Oracle JavaDoc) - Compiled source code - Run unit tests and integration tests - Run getting started with ZK and KRaft

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2421

2023-11-28 Thread Apache Jenkins Server
See