Re: [DISCUSS] KIP-966: Eligible Leader Replicas

ecovery.strategy, the cluster level config unclean.recovery.Enabled, the controller can calculate the correct methods to use right? On Fri, Sep 15, 2023 at 10:02 AM Colin McCabe wrote: > On Thu, Sep 14, 2023, at 22:23, Calvin Liu wrote: > > Hi Colin > > 1. I t

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

. kafka.controller.unclean_recovery_finished_count On Wed, Sep 13, 2023 at 10:46 AM Colin McCabe wrote: > On Tue, Sep 12, 2023, at 17:21, Calvin Liu wrote: > > Hi Colin > > Thanks for the comments! > > > > Hi Calvin, > > Thanks again for the KIP. > > One meta-comment: it's usually better to just do

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

gt; is updated we will always take the more thoughtful unclean election process > (ie, inspect the logs) > > Overall though, the general KIP is pretty solid. Looking at the rejected > alternatives, it looks like a lot was considered, so it's nice to see the > final proposal. >

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

m > "delivery plan" to the bullet points. > > Justine > > On Thu, Aug 31, 2023 at 4:04 PM Calvin Liu > wrote: > > > Hi Justine > > Thanks for the questions! > > *a. For my understanding, will we block replication? Or just the high > > waterma

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

the other metadata > > requests like MetadataRequest, this should be served by brokers. > > > > It's a bit confusing why both topic ID and topic name are provided to > > this API. Is the intention that callers should set one but not the > > other? Or both? This needs t

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

> LastKnownLeader is preferred." Do we wait strictly for the lastKnownLeader > until it's unfenced or do we select the first unfenced replica from > LastKnownELR? > > Thanks, > > Jun > > On Fri, Sep 8, 2023 at 2:56 PM Calvin Liu > wrote: > > > Hi Artem > >

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

Hi Jun, I have a second thought on the kafka.replication.electable_replicas_count. I don't think it is a useful metric and it seems wasteful to have a per partition metric to track the sum(ISR, ELR). I will remove this metric. On Tue, Sep 12, 2023 at 3:35 PM Calvin Liu wrote: > Hi Jun, >

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

t; 27. "min.insync.replicas now applies to the replication of all kinds of > messages." Not sure that I follow. Could you explain a bit more? > > 28. "But later, the current leader will put the follower into the pending > ISR" : It would be useful to clarify this is afte

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

artition and replica ids -- what are those? > Would those be just the whole replica assignment or just LastKnownELR? > > -Artem > > On Thu, Aug 10, 2023 at 3:47 PM Calvin Liu > wrote: > > > Hi everyone, > > I'd like to discuss a series of enhancement to the re

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

> 3. You still need to describe the changes to AdminClient that are needed > to use DescribeTopicRequest. > > Keep at it. It's looking better. :) > > best, > Colin > > > On Thu, Sep 14, 2023, at 11:03, Calvin Liu wrote: > > Hi Colin > > Thanks for the comments!

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

s. The only thing > that is not modeled is the unclean recovery though I may leave that as the > specification is already very large. > > Jack > > On 2023/09/01 22:27:10 Calvin Liu wrote: > > Hi Justine > > 1. With the new proposal, in order to let the consumer consume

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

> > One more comment. > > > > "The first partition to fetch details for. -1 means to fetch all > > partitions." It seems that FirstPartitionId of 0 naturally means fetching > > all partitions? > > > > Thanks, > > > > Jun > >

Re: [VOTE]KIP-966: Eligible Leader Replicas

Hi, The KIP has received 3 binding votes from Justine Olshan, Jun Rao and Colin McCabe. Also thanks to Jeff Kim, Jack Vanlightly, Artem Livshits, David Arthur, David Jacot for the comments to make the KIP better. Thanks for the help! On Mon, Oct 9, 2023 at 10:20 AM Calvin Liu wrote: > Hi Co

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

idea of using none, balanced, > > aggressive. We also had an offline discussion about why it is good to > use a > > new config key (basically, so that we can deprecate the old one which had > > only false/true values in 4.0) With these changes, I am +1. >

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

> > 54. Downgrade: Is that indeed possible? I thought earlier you said that > > > once the new version of the records are in the metadata log, one can't > > > downgrade since the old broker doesn't know how to parse the new > version > > of > > > the metadata

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

ersRequest.DesiredLeaders: Should it be nullable since a > > > user > > > > may not specify DesiredLeaders? > > > > > > > > 54. Downgrade: Is that indeed possible? I thought earlier you said > that > > > > once the new version of the records

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

MV > is > > > not supported? I think Kafka typically tries to support downgrades, > and I > > > couldn't think of other examples. > > > > > > Thanks, > > > Justine > > > > > > On Wed, Oct 4, 2023 at 9:40 AM Calvin

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

fy the changes to the admin api to > accommodate the new or updated apis. Do you plan to add them? > > Best, > David > > Le mer. 4 oct. 2023 à 20:39, Calvin Liu a > écrit : > > > Hi Jun, > > After the MV downgrade, the controller will write in the old ve

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

. Balanced. It is the balance point of the availability first(Aggressive) and least availability(None). The controller performs unclean recovery when both ISR and ELR are empty. On Fri, Sep 15, 2023 at 11:42 AM Calvin Liu wrote: > Hi Colin, > > > So, the proposal is that if

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

, 2023 at 3:51 PM Calvin Liu wrote: > Hi Colin, > For the unclean.recovery.strategy config name, how about we use the > following > None. It basically means no unclean recovery will be performed. > Aggressive. It means availability goes first. Whenever the partition can't > elect

[VOTE]KIP-966: Eligible Leader Replicas

Hi all, I'd like to call for a vote on KIP-966 which includes a series of enhancements to the current ISR model. - Introduce the new HWM advancement requirement which enables the system to have more potentially data-safe replicas. - Introduce Eligible Leader Replicas(ELR) to represent

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

a cluster has updated to > its MetadataVersion. It's simpler to disable the feature through config > rather than going through a MetadataVersion downgrade (once that's > supported). > > Does that make sense? > > -David > > On Wed, Oct 11, 2023 at 1:40 PM Calvin Liu > w

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

cribeTopicRequest. > > 62. Should ElectLeadersRequest.DesiredLeaders be at the same level as > ElectLeadersRequest.TopicPartitions.Partitions? In the KIP, it looks like > it's at the same level as ElectLeadersRequest.TopicPartitions. > > Thanks, > > Jun > > On Wed, Oct 4, 2023 at 3:55 PM C

Re: [VOTE]KIP-966: Eligible Leader Replicas

; > wrote: > > > >> Thanks Calvin. > >> I think this will be very helpful going forward to minimize data loss. > >> > >> +1 from me (binding) > >> > >> Justine > >> > >> On Wed, Sep 20, 2023 at 3:42 PM Calvin Liu >

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

the range query has errors for some of the partitions, do we expect > different responses when querying particular partitions? > > Thanks, > > Jun > > On Tue, Oct 10, 2023 at 10:50 AM Calvin Liu > wrote: > > > Hi Jun > > 60. Yes, it is a good question. I was t

Permissions Request to contribute to Apache Kafka

Hi, I am working on the ticket https://issues.apache.org/jira/browse/KAFKA-14139. The change is worth a KIP. Can Anyone grant me the permission for KIP? Wiki id: caliu Jira id: CalvinLiu

Re: [VOTE] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

The KIP is accepted with 3 binding votes (David, Jun, Jason) and 1 non-binding vote (Alexandre). Thanks! On Tue, Feb 28, 2023 at 3:06 PM Jason Gustafson wrote: > Thanks Calvin, +1 from me. > > On Mon, Feb 27, 2023 at 9:41 AM Calvin Liu > wrote: > > > Hi Jason, &

Re: [VOTE] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

scenarios? On Wed, Feb 22, 2023 at 11:08 AM Calvin Liu wrote: > To Jason: > 1. Related to the Fetch Request fields change, previously you suggested > deprecating the ReplicaId and moving it into a BrokerState field. How about > we just make the BrokerEpoch a tag field? > - The Replica

Re: [VOTE] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

. - We can still make the optional BrokerEpoch out of the request when it is not needed. On Tue, Feb 21, 2023 at 10:39 PM Calvin Liu wrote: > To Jason: > 1. We can make the BrokerEpoch a tagged field. But I am not sure about > your proposed metadata structure. In the BrokerState, d

Re: [VOTE] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

To Jason: 1. We can make the BrokerEpoch a tagged field. But I am not sure about your proposed metadata structure. In the BrokerState, do we need to store the BrokerId again? It would duplicate with ReplicaId. 2. Considering that the broker reboot data loss case is rare and Kraft is coming soon.

Re: [VOTE] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

: "14+", > "entityType": "brokerId", > "about": "The broker ID of the follower, of -1 if this request is > from a consumer." }, > { "name": "BrokerEpoch", "type": "int64", "versions": &qu

RE: Re: [DISCUSS] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

equivalent of IBP) during upgrade? > > Jun > > > On Fri, Feb 3, 2023 at 10:55 AM Calvin Liu > wrote: > > > Hi everyone, > > I'd like to discuss the fix for the broker reboot data loss KAFKA-14139 > > <https://issues.apache.org/jira/browse/KAFKA-14139>.

Re: [DISCUSS] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

> > > > The KIP mentions that we would explicitly do something special in ZK > mode > > > in order to not implement new functionality. I think it may be easier > to > > > implement functionality for both ZK and KRraft mode than adding code to > > > disa

Re: [DISCUSS] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

able at all. > > Thanks, > Alexandre > > Le mer. 8 févr. 2023 à 23:57, Calvin Liu a > écrit : > > > > For Jun: > > --- Since this KIP changes the inter-broker protocol, should we bump up > the > > metadata version (the equivalent of IBP) during the upgra

Re: [DISCUSS] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

the > IBP/metadata version to gate the version of the fetch request used. > Therefore, the version 14 will be used only when the IBP/metadata version > is upgraded. > > Besides those two points, the KIP looks good to me. > > Thanks, > David > > On Fri, Feb 10, 20

[DISCUSS] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

Hi everyone, I'd like to discuss the fix for the broker reboot data loss KAFKA-14139 . It changes the Fetch and AlterPartition requests to include the broker epochs. Then the controller can use these epochs to help reject the stale AlterPartition

[VOTE] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

Hi all, I'd like to call for a vote on KIP-903, which proposes a fix to the broker reboot data loss KAFKA-14139 It changes the Fetch and AlterPartition requests to include the broker epochs. Then the controller can use these epochs to help

Re: [DISCUSS] KIP-903: Replicas with stale broker epoch should not be allowed to join the ISR

to account. It will be easier like > this vs having to put gates everywhere. > > Best, > David > > On Thu, Feb 9, 2023 at 7:27 PM Calvin Liu > wrote: > > > Hi Alexandre, > > 104: I am not aware of any proposals around the up-to-date replica > > election. It

[DISCUSS] KIP-966: Eligible Leader Replicas

Hi everyone, I'd like to discuss a series of enhancement to the replication protocol. A partition replica can experience local data loss in unclean shutdown scenarios where unflushed data in the OS page cache is lost - such as an availability zone power outage or a server error. The Kafka

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

g to broker 2? > > Thanks, > Jeff > > On Thu, Aug 10, 2023 at 6:48 PM Calvin Liu > wrote: > > > Hi everyone, > > I'd like to discuss a series of enhancement to the replication protocol. > > > > A partition replica can experience local data loss in uncl

Re: [DISCUSS] KIP-966: Eligible Leader Replicas

describeTopics(TopicCollection topics, DescribeTopicsOptions options); David and I would prefer the first Consumer version which works better as a stream purposes. On Wed, Oct 11, 2023 at 4:28 PM Calvin Liu wrote: > Hi David, > Thanks for the comment. > Yes, we can separate the ELR enable

[jira] [Created] (KAFKA-15579) KIP-966: Eligible Leader Replicas

Calvin Liu created KAFKA-15579: -- Summary: KIP-966: Eligible Leader Replicas Key: KAFKA-15579 URL: https://issues.apache.org/jira/browse/KAFKA-15579 Project: Kafka Issue Type: New Feature

[jira] [Created] (KAFKA-15585) DescribeTopic API

Calvin Liu created KAFKA-15585: -- Summary: DescribeTopic API Key: KAFKA-15585 URL: https://issues.apache.org/jira/browse/KAFKA-15585 Project: Kafka Issue Type: Sub-task Reporter

[jira] [Created] (KAFKA-15581) Introduce ELR

Calvin Liu created KAFKA-15581: -- Summary: Introduce ELR Key: KAFKA-15581 URL: https://issues.apache.org/jira/browse/KAFKA-15581 Project: Kafka Issue Type: Sub-task Reporter: Calvin

[jira] [Created] (KAFKA-15583) High watermark can only advance if ISR size is larger than min ISR

Calvin Liu created KAFKA-15583: -- Summary: High watermark can only advance if ISR size is larger than min ISR Key: KAFKA-15583 URL: https://issues.apache.org/jira/browse/KAFKA-15583 Project: Kafka

[jira] [Created] (KAFKA-15584) ELR leader election

Calvin Liu created KAFKA-15584: -- Summary: ELR leader election Key: KAFKA-15584 URL: https://issues.apache.org/jira/browse/KAFKA-15584 Project: Kafka Issue Type: Sub-task Reporter

[jira] [Created] (KAFKA-15580) KIP-966: Unclean Recovery

Calvin Liu created KAFKA-15580: -- Summary: KIP-966: Unclean Recovery Key: KAFKA-15580 URL: https://issues.apache.org/jira/browse/KAFKA-15580 Project: Kafka Issue Type: New Feature

[jira] [Created] (KAFKA-15582) Clean shutdown detection, broker side

Calvin Liu created KAFKA-15582: -- Summary: Clean shutdown detection, broker side Key: KAFKA-15582 URL: https://issues.apache.org/jira/browse/KAFKA-15582 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-15586) Clean shutdown detection, server side

Calvin Liu created KAFKA-15586: -- Summary: Clean shutdown detection, server side Key: KAFKA-15586 URL: https://issues.apache.org/jira/browse/KAFKA-15586 Project: Kafka Issue Type: Sub-task

[jira] [Resolved] (KAFKA-15581) Introduce ELR

[ https://issues.apache.org/jira/browse/KAFKA-15581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15581. Reviewer: David Arthur Resolution: Fixed > Introduce

[jira] [Created] (KAFKA-15700) FetchFromFollowerIntegrationTest is flaky

Calvin Liu created KAFKA-15700: -- Summary: FetchFromFollowerIntegrationTest is flaky Key: KAFKA-15700 URL: https://issues.apache.org/jira/browse/KAFKA-15700 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-15699) MirrorConnectorsIntegrationBaseTest is flaky

Calvin Liu created KAFKA-15699: -- Summary: MirrorConnectorsIntegrationBaseTest is flaky Key: KAFKA-15699 URL: https://issues.apache.org/jira/browse/KAFKA-15699 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-15760) org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated is flaky

Calvin Liu created KAFKA-15760: -- Summary: org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated is flaky Key: KAFKA-15760 URL: https://issues.apache.org/jira/browse/KAFKA

[jira] [Created] (KAFKA-15759) DescribeClusterRequestTest is flaky

Calvin Liu created KAFKA-15759: -- Summary: DescribeClusterRequestTest is flaky Key: KAFKA-15759 URL: https://issues.apache.org/jira/browse/KAFKA-15759 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-15584) ELR leader election

[ https://issues.apache.org/jira/browse/KAFKA-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15584. Resolution: Fixed > ELR leader election > --- > >

[jira] [Created] (KAFKA-15762) ClusterConnectionStatesTest.testSingleIP is flaky

Calvin Liu created KAFKA-15762: -- Summary: ClusterConnectionStatesTest.testSingleIP is flaky Key: KAFKA-15762 URL: https://issues.apache.org/jira/browse/KAFKA-15762 Project: Kafka Issue Type

[jira] [Created] (KAFKA-15761) ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector is flaky

Calvin Liu created KAFKA-15761: -- Summary: ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector is flaky Key: KAFKA-15761 URL: https://issues.apache.org/jira/browse/KAFKA-15761 Project

[jira] [Created] (KAFKA-15690) Flaky integration tests

Calvin Liu created KAFKA-15690: -- Summary: Flaky integration tests Key: KAFKA-15690 URL: https://issues.apache.org/jira/browse/KAFKA-15690 Project: Kafka Issue Type: Bug Reporter

[jira] [Created] (KAFKA-15590) Replica.updateFetchState should also fence updates with stale leader epoch

Calvin Liu created KAFKA-15590: -- Summary: Replica.updateFetchState should also fence updates with stale leader epoch Key: KAFKA-15590 URL: https://issues.apache.org/jira/browse/KAFKA-15590 Project

[jira] [Created] (KAFKA-15665) Enforce min ISR when complete partition reassignment

Calvin Liu created KAFKA-15665: -- Summary: Enforce min ISR when complete partition reassignment Key: KAFKA-15665 URL: https://issues.apache.org/jira/browse/KAFKA-15665 Project: Kafka Issue Type

[jira] [Created] (KAFKA-14617) Replicas with stale broker epoch should not be allowed to join the ISR

Calvin Liu created KAFKA-14617: -- Summary: Replicas with stale broker epoch should not be allowed to join the ISR Key: KAFKA-14617 URL: https://issues.apache.org/jira/browse/KAFKA-14617 Project: Kafka

[jira] [Resolved] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-14139. Resolution: Fixed > Replaced disk can lead to loss of committed data even with non-empty

[jira] [Created] (KAFKA-15221) Potential race condition between requests from rebooted followers

Calvin Liu created KAFKA-15221: -- Summary: Potential race condition between requests from rebooted followers Key: KAFKA-15221 URL: https://issues.apache.org/jira/browse/KAFKA-15221 Project: Kafka

[jira] [Created] (KAFKA-15332) Eligible Leader Replicas

Calvin Liu created KAFKA-15332: -- Summary: Eligible Leader Replicas Key: KAFKA-15332 URL: https://issues.apache.org/jira/browse/KAFKA-15332 Project: Kafka Issue Type: New Feature

[jira] [Created] (KAFKA-16250) Consumer group coordinator should perform sanity check on the offset commits.

Calvin Liu created KAFKA-16250: -- Summary: Consumer group coordinator should perform sanity check on the offset commits. Key: KAFKA-16250 URL: https://issues.apache.org/jira/browse/KAFKA-16250 Project

[jira] [Created] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

Calvin Liu created KAFKA-16217: -- Summary: Transactional producer stuck in IllegalStateException during close Key: KAFKA-16217 URL: https://issues.apache.org/jira/browse/KAFKA-16217 Project: Kafka

[jira] [Created] (KAFKA-15820) Add a metric to track the number of partitions under min ISR

Calvin Liu created KAFKA-15820: -- Summary: Add a metric to track the number of partitions under min ISR Key: KAFKA-15820 URL: https://issues.apache.org/jira/browse/KAFKA-15820 Project: Kafka

[jira] [Created] (KAFKA-15873) Improve the performance of the DescribeTopicPartitions API

Calvin Liu created KAFKA-15873: -- Summary: Improve the performance of the DescribeTopicPartitions API Key: KAFKA-15873 URL: https://issues.apache.org/jira/browse/KAFKA-15873 Project: Kafka Issue

[jira] [Created] (KAFKA-16479) Add pagination supported describeTopic interface

Calvin Liu created KAFKA-16479: -- Summary: Add pagination supported describeTopic interface Key: KAFKA-16479 URL: https://issues.apache.org/jira/browse/KAFKA-16479 Project: Kafka Issue Type

[jira] [Resolved] (KAFKA-15583) High watermark can only advance if ISR size is larger than min ISR

[ https://issues.apache.org/jira/browse/KAFKA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15583. Resolution: Fixed > High watermark can only advance if ISR size is larger than min

[jira] [Created] (KAFKA-16540) Update partitions when the min isr config is updated.

Calvin Liu created KAFKA-16540: -- Summary: Update partitions when the min isr config is updated. Key: KAFKA-16540 URL: https://issues.apache.org/jira/browse/KAFKA-16540 Project: Kafka Issue Type

[jira] [Resolved] (KAFKA-15586) Clean shutdown detection, server side

[ https://issues.apache.org/jira/browse/KAFKA-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15586. Resolution: Fixed > Clean shutdown detection, server s

[jira] [Resolved] (KAFKA-15585) DescribeTopic API

[ https://issues.apache.org/jira/browse/KAFKA-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15585. Resolution: Fixed > DescribeTopic API > - > > Key:

[jira] [Resolved] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-16217. Fix Version/s: (was: 3.6.3) Resolution: Fixed > Transactional producer st