Hi all,
The Kafka build currently includes support for Scala 2.9, which means that
it cannot take advantage of features introduced in Scala 2.10 or depend on
libraries that require it.
This restricts the solutions available while trying to solve existing
issues. I was browsing JIRA looking for
93550e8f24071f88eb1ea5b41373efee27e4b8b7
Diff: https://reviews.apache.org/r/33383/diff/
Testing
---
Thanks,
Ismael Juma
/JsonTest.scala
93550e8f24071f88eb1ea5b41373efee27e4b8b7
Diff: https://reviews.apache.org/r/33383/diff/
Testing (updated)
---
`testAll` succeeded eventually (it seems like some tests that rely on timings
can sometimes fail).
Thanks,
Ismael Juma
/browse/KAFKA-2034
Repository: kafka
Description
---
KAFKA-2034; Set sourceCompatibility in build.gradle
Diffs
-
build.gradle 4775ee46c480eab7b8250e61ba1705d00f72a6aa
Diff: https://reviews.apache.org/r/33410/diff/
Testing
---
Thanks,
Ismael Juma
)
---
Compiled with JDK 8 and verified that the target level in the bytecode was `50`
(ie Java 6) instead of `52`:
find . -name '*.class' | xargs javap -verbose | grep major version: | sort |
uniq
major version: 50
Thanks,
Ismael Juma
d42108eacf7011688249bc5428cf8a2dec9d9f6e
examples/src/main/java/kafka/examples/SimpleConsumerDemo.java
e5096f03bd34ef7257506afd0d91c866e9c46f6c
Diff: https://reviews.apache.org/r/33420/diff/
Testing
---
Thanks,
Ismael Juma
Hi all,
Kafka currently uses a combination of Review Board and JIRA for
contributions and code review. In my opinion, this makes contribution and
code review a bit harder than it has to be.
I think the approach used by Spark would improve the current situation:
Generally, Spark uses JIRA to
Hi Jun,
On Sat, May 2, 2015 at 2:50 PM, Jun Rao j...@confluent.io wrote:
We will also need to figure out if we need CONTRIBUTING.md like the
following to take care of the Apache licensing stuff.
https://github.com/apache/spark/blob/master/CONTRIBUTING.md
Yes indeed. That is in step 3 of
Hi Ewen,
Comments inline.
On Fri, May 1, 2015 at 8:38 AM, Ewen Cheslack-Postava e...@confluent.io
wrote:
Also +1. There are some drawbacks to using Github for reviews, e.g. lots of
emails for each review because they don't let you publish your entire
review in one go like RB does, but it
`gradle` and then ran various build commands
like:
- ./gradlew releaseTarGz
- ./gradlew jarAll
- ./gradlew test
- ./gradlew -PscalaVersion=2.11.6 test
Thanks,
Ismael Juma
https://issues.apache.org/jira/browse/KAFKA-2185
Repository: kafka
Description
---
Update gradle to 2.4
Diffs (updated)
-
build.gradle fef515b3b2276b1f861e7cc2e33e74c3ce5e405b
Diff: https://reviews.apache.org/r/34056/diff/
Testing
---
Thanks,
Ismael Juma
/browse/KAFKA-2185
Repository: kafka
Description
---
Update gradle to 2.4
Diffs
-
build.gradle fef515b3b2276b1f861e7cc2e33e74c3ce5e405b
Diff: https://reviews.apache.org/r/34056/diff/
Testing
---
Thanks,
Ismael Juma
fef515b3b2276b1f861e7cc2e33e74c3ce5e405b
Diff: https://reviews.apache.org/r/34144/diff/
Testing (updated)
---
Tests pass when compiled with Scala 2.10.5 and 2.11.6.
Thanks,
Ismael Juma
Diff: https://reviews.apache.org/r/34144/diff/
Testing
---
Thanks,
Ismael Juma
Hi,
In order to edit the Patch submission and review page with information on
how to merge GitHub pull requests, it would be helpful to have edit
permission for Kafka's Confluence pages. My Confluence account id is
`ijuma`[1].
Thanks,
Ismael
[1]
/browse/KAFKA-2187
Repository: kafka
Description
---
KAFKA-2187; Introduce merge-kafka-pr.py script
Diffs
-
kafka-merge-pr.py PRE-CREATION
Diff: https://reviews.apache.org/r/34502/diff/
Testing
---
Thanks,
Ismael Juma
-2187
https://issues.apache.org/jira/browse/KAFKA-2187
Repository: kafka
Description
---
KAFKA-2187; Introduce merge-kafka-pr.py script
Diffs (updated)
-
kafka-merge-pr.py PRE-CREATION
Diff: https://reviews.apache.org/r/34502/diff/
Testing
---
Thanks,
Ismael Juma
On Fri, May 1, 2015 at 8:38 AM, Ewen Cheslack-Postava e...@confluent.io
wrote:
One thing I noticed is that when you try to generate a PR it defaults to
the 0.8.2 branch. Can we fix that up to be trunk by default?
I filed an INFRA ticket for this:
`python kafka-merge-pr-py`, choosing to merge PR 3
(https://github.com/ijuma/kafka/pull/3) and answered the prompts, including the
one that asked whether I wanted to close the relevant JIRA
(https://issues.apache.org/jira/browse/KAFKA-2187)
Thanks,
Ismael Juma
On Thu, May 21, 2015 at 11:51 PM, Joel Koshy jjkosh...@gmail.com wrote:
Sorry about that - should work now.
Thank you. It does indeed.
Best,
Ismael
On Wed, May 20, 2015 at 11:54 PM, Joel Koshy jjkosh...@gmail.com wrote:
Done
Thank you Joel, but the Edit link is still not available to me.
Best,
Ismael
On Wed, May 20, 2015 at 11:45:48PM +0100, Ismael Juma wrote:
Hi,
In order to edit the Patch submission and review page
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36265/#review90740
---
Ship it!
Ship It!
- Ismael Juma
On July 7, 2015, 4:53 p.m
Hi Gwen,
Nice to see this. There is no deprecation cycle for breakages?
Ismael
On Wed, Aug 12, 2015 at 11:05 PM, Gwen Shapira g...@confluent.io wrote:
Hi Team Kafka,
Ewen just added stability annotations to Apache Kafka (KAFKA-2429).
In the same PR, we marked the new Consumer API as
On July 27, 2015, 1:32 p.m., Ismael Juma wrote:
clients/src/main/java/org/apache/kafka/common/config/SSLConfigs.java, line
29
https://reviews.apache.org/r/33620/diff/13/?file=1021968#file1021968line29
SSL is deprecated
(https://ma.ttias.be/rfc-7568-ssl-3-0-is-now-officially
is:
```
* lists will be cleared at the beginning of each {@link #poll(long)} call
and repopulated by the call if there is
* any completed I/O.```
- Ismael Juma
On Aug. 17, 2015, 3:41 a.m., Sriharsha Chintalapani wrote
-14703175
Best,
Ismael
On Wed, Aug 12, 2015 at 10:00 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi Gwen,
I filed KAFKA-2425 as KAFKA-2364 is about improving the website
documentation. Aseem Bansal seemed interested in helping us with the move
so I pinged him in the issue.
Best,
Ismael
On Wed
I should clarify: it's not possible unless we add an additional step that
moves the docs from the code repo to the website repo.
Ismael
On Wed, Aug 19, 2015 at 4:42 PM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
It looks like it's not feasible to update the code and website in the same
Juma ism...@juma.me.uk
wrote:
I should clarify: it's not possible unless we add an additional
step
that
moves the docs from the code repo to the website repo.
Ismael
On Wed, Aug 19, 2015 at 4:42 PM, Ismael Juma
ism...@juma.me.uk
wrote
/security/auth/SimpleAclAuthorizer.scala (line 146)
https://reviews.apache.org/r/34493/#comment151236
`inReadLock` returns a value. No need for the `var` above.
- Ismael Juma
On May 20, 2015, 8:03 p.m., Parth Brahmbhatt wrote
On Aug. 21, 2015, 2:31 p.m., Ismael Juma wrote:
Thanks for this Parth. I did an initial pass where I left a number comments
(many of them style-related, see http://kafka.apache.org/coding-guide.html
for reference). I know, we should have a tool that checks some of these
things
Hmm, looks like something in Jenkins is different than my local setup. Will
investigate and submit a follow-up.
Ismael
On Fri, Aug 21, 2015 at 8:10 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See https://builds.apache.org/job/Kafka-trunk/595/changes
Changes:
[cshapi]
Looks like I pushed an earlier iteration of the fix to the PR, sorry. Fix:
https://github.com/apache/kafka/pull/159
Ismael
On 21 Aug 2015 20:31, Ismael Juma ism...@juma.me.uk wrote:
Hmm, looks like something in Jenkins is different than my local setup.
Will investigate and submit a follow-up
On Aug. 21, 2015, 6:14 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 264
https://reviews.apache.org/r/36652/diff/4/?file=1039545#file1039545line264
Yes that's exactly what we need. Any reason why we shouldn't use
`NonFatal` as is? i.e., if we
On Aug. 21, 2015, 5:57 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 264
https://reviews.apache.org/r/36652/diff/4/?file=1039545#file1039545line264
Thanks for the reference - we currently have this pattern all over the
place. We can keep what
`. This applies to
all the tests.
- Ismael Juma
On Aug. 11, 2015, 1:32 a.m., Parth Brahmbhatt wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492
the large
SSL/TLS patch has now been merged (not sure if there are any conflicts).
- Ismael Juma
On Aug. 11, 2015, 1:32 a.m., Parth Brahmbhatt wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Wed, Jul 29, 2015 at 4:52 PM, Guozhang Wang wangg...@gmail.com wrote:
It is likely that we make two commits at roughly the same time that
triggers two builds, how could this issue be resolve under this case?
It should not happen in a typical configuration, but hard to tell what is
wrong
/SubscriptionState.java
(line 86)
https://reviews.apache.org/r/36871/#comment147616
A minor optimisation is to use `ArrayList` here to avoid rehashing the
items in the list.
- Ismael Juma
On July 28, 2015, 4:59 a.m., Ashish Singh wrote
Hi Gwen,
Thanks for the feedback. Comments below.
On Wed, Jul 29, 2015 at 6:40 PM, Gwen Shapira gshap...@cloudera.com wrote:
The jira comment is a way for the committer to say thank you to
people who were involved in the review process.
If we just want to say thank you, then why not just
Hi Parth,
On Wed, Jul 29, 2015 at 6:50 PM, Parth Brahmbhatt
pbrahmbh...@hortonworks.com wrote:
+1 on Gwen¹s suggestion.
Consider this as my thank you for all the reviews everyone has done in
past and are going to do in future. Don¹t make me say thanks on every
single commit. Introducing
: should be `numIterations`.
core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala (line 389)
https://reviews.apache.org/r/28096/#comment147940
Space missing before `=` for a couple of `vals`.
- Ismael Juma
On June 24, 2015, 6:14 p.m., Ashish Singh wrote
On Wed, Jul 29, 2015 at 7:38 PM, Gwen Shapira gshap...@cloudera.com wrote:
I guess we see the reviewer part with different interpretations.
Yes. As you know, Git was created for and initially used by the Linux
Kernel. As such they were very influential in conventions, terminology and
best
Hi Jay,
Good points. A few remarks below.
On Wed, Jul 29, 2015 at 11:16 PM, Jay Kreps j...@confluent.io wrote:
I suggest we focus on threading and the current event-loop style of api
design since I think that is really the crux.
Agreed.
I think ultimately though what you need to think
On July 31, 2015, 4:32 p.m., Sriharsha Chintalapani wrote:
core/src/test/scala/integration/kafka/api/SSLConsumerTest.scala, line 218
https://reviews.apache.org/r/33620/diff/13/?file=1022004#file1022004line218
If we want to enforce this coding convention.Lets open up a new JIRA
/SSLConsumerTest.scala (line 218)
https://reviews.apache.org/r/33620/#comment148139
Code convention: space after `while`. There's a few more instances of this
in the file.
- Ismael Juma
On July 25, 2015, 7:11 p.m., Sriharsha Chintalapani wrote
On July 31, 2015, 4:29 p.m., Sriharsha Chintalapani wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
line 162
https://reviews.apache.org/r/33620/diff/13/?file=1021979#file1021979line162
hasRemaining doesn't work here. Hence the reason to go
On Fri, Jul 31, 2015 at 8:37 PM, Jay Kreps j...@confluent.io wrote:
The issue last time was that Apache has special infrastructure for web
hosting built around svn called svnpubsub. This is what takes the content
changes and pushes them live to the site. They didn't yet have a gitpubsub
at
On July 27, 2015, 1:32 p.m., Ismael Juma wrote:
clients/src/main/java/org/apache/kafka/common/config/SSLConfigs.java, line
29
https://reviews.apache.org/r/33620/diff/13/?file=1021968#file1021968line29
SSL is deprecated
(https://ma.ttias.be/rfc-7568-ssl-3-0-is-now-officially
It looks like two builds are running in the same workspace at the same time
somehow.
Ismael
On Wed, Jul 29, 2015 at 1:44 AM, Guozhang Wang wangg...@gmail.com wrote:
Anyone knows how this Could not open buildscript class issue could happen
and can we fix it on our side or it is a general
, so can't say if this
is the best way to do it (seems OK though).
- Ismael Juma
On July 28, 2015, 4:17 p.m., Ashish Singh wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36871
for local `vals` (there are a
number of instances of this).
- Ismael Juma
On July 22, 2015, 12:08 a.m., Parth Brahmbhatt wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492
Hi all,
As a general rule, we credit reviewers in the commit message. This is good.
However, it is not clear to me if there are guidelines on who should be
included as a reviewer (please correct me if I am wrong). I can think of a
few options:
1. Anyone that commented on the patch (in the
Thanks for making it clearer Gwen. One less item on my to-do list. :) More
below.
On Tue, Aug 4, 2015 at 11:56 PM, Gwen Shapira g...@confluent.io wrote:
There's always a plan!
The contributor page only lists github as a valid contribution method.
Theoretically the committers / reviewers
Hi Gwen,
I moved some text from
https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review
to https://cwiki.apache.org/confluence/display/KAFKA/Patch+Review+Tool and
made a few other minor tweaks. I think it's even clearer this way. Please
let me know if you disagree.
Thanks,
On Thu, Jul 30, 2015 at 6:04 PM, Gwen Shapira gshap...@cloudera.com wrote:
I wasn't aware of this history, thanks for explaining!
No problem. :)
In most Apache projects I contributed to, the list of things that are
stated in reviewed by are implied in a committer committing the
patch.
);
}
`
https://github.com/jpountz/lz4-java/blob/master/src/java-unsafe/net/jpountz/util/UnsafeUtils.java#L60
clients/src/main/java/org/apache/kafka/common/record/KafkaLZ4BlockOutputStream.java
(line 183)
https://reviews.apache.org/r/37357/#comment149628
Same as above.
- Ismael Juma
On Aug
in the upstream
library, it would probably be good to do more testing than just the unit tests.
- Ismael Juma
On Aug. 11, 2015, 6:56 p.m., Rajini Sivaram wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Thu, Aug 13, 2015 at 8:36 AM, Ewen Cheslack-Postava e...@confluent.io
wrote:
On deprecation, I think we should definitely use the standard annotation to
handle this.
Thanks Ewen. I agree that we should use @Deprecated for language-level
deprecations. My question was regarding the
On Thu, Aug 13, 2015 at 10:41 PM, Gwen Shapira g...@confluent.io wrote:
IMO, both old producer and old consumer APIs should be marked as deprecated
for 0.8.3 (since the new code will be in and we want to encourage the
switch).
I can see the appeal of this, but it's also worth considering the
On Aug. 10, 2015, 3:47 p.m., Grant Henke wrote:
My apologies for not looking at this sooner, or suggesting this sooner.
Given that this code change and scope is fairly large, would it be too much
work to break out the patches reviews by each new protocol message? Then
reviews can be
On Wed, Aug 12, 2015 at 1:29 AM, Gwen Shapira g...@confluent.io wrote:
+1 on not breaking git blame
-1 on rewriting Kafka in Java
+1 on upping our Scala game (as Ismael pointed out)
I filed a couple of JIRAs, and I'll look at introducing Scalastyle once
some of the bigger patches/PRs are
On Wed, Aug 12, 2015 at 1:23 AM, Jason Gustafson ja...@confluent.io wrote:
Can the java code be indented without affecting the results of git blame?
If not, then I'd vote to leave it as it is.
Nope.
Ismael
, we post the documentation of the new
release
to
the
website
Gwen
On Thu, Aug 6, 2015 at 12:20 AM, Ismael Juma
ism...@juma.me.uk
wrote:
Hi,
For reference, here is the previous discussion on moving the
website
Hi,
For reference, here is the previous discussion on moving the website to Git:
http://search-hadoop.com/m/uyzND11JliU1E8QU92
People were positive to the idea as Jay said. I would like to see a bit of
a discussion around whether the website should be part of the same repo as
the code or not.
I think this is a good idea as the change is minimal on our side and it has
been tested in production for some time by the reporter.
Best,
Ismael
On Fri, Aug 14, 2015 at 1:15 PM, Jun Rao j...@confluent.io wrote:
Hi, Everyone,
Since the release of Kafka 0.8.2.1, a number of people have
/SSLTransportLayer.java
(lines 46 - 57)
https://reviews.apache.org/r/33620/#comment146806
Some of these fields can be `final`.
- Ismael Juma
On July 20, 2015, 7 p.m., Sriharsha Chintalapani wrote:
---
This is an automatically generated e-mail
/network/SSLFactory.java (line 199)
https://reviews.apache.org/r/33620/#comment146804
You can use try with resources now that we require Java 7.
- Ismael Juma
On July 20, 2015, 7 p.m., Sriharsha Chintalapani wrote
/#comment147381
Left by mistake?
- Ismael Juma
On July 25, 2015, 7:11 p.m., Sriharsha Chintalapani wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620
On July 27, 2015, 1:32 p.m., Ismael Juma wrote:
core/src/main/scala/kafka/api/FetchResponse.scala, line 82
https://reviews.apache.org/r/33620/diff/13/?file=1021998#file1021998line82
Casts are to be avoided in Scala, pattern matching is a better way to
do
Hi,
On 22 Jul 2015 19:32, Jiangjie Qin j...@linkedin.com.invalid wrote:
+1 (non binding)
Can we have a wiki for procedure and let people verify the steps? After
that we can update the Apache project page.
Yes, I linked to the page in the original message:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670/#review92744
---
Ship it!
Ship It!
- Ismael Juma
On July 23, 2015, 1:23 a.m
On July 23, 2015, 12:37 a.m., Edward Ribeiro wrote:
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala, line 269
https://reviews.apache.org/r/36670/diff/1/?file=1018343#file1018343line269
I disagree because we are issuing two `deleteTopic` operations, the
first one should
Hi Jay,
On Fri, Jul 24, 2015 at 2:00 AM, Jay Kreps j...@confluent.io wrote:
- Wait for java 8 to become common so we don't have to translate to java 7
...
Even ignoring those items I don't think we would dare take this on right
now because there are so many other projects in flight but it
On Tue, Jul 21, 2015 at 4:11 PM, Ashish Singh asi...@cloudera.com wrote:
+1 non-binding.
A suggestion, we should try to phase out old system of reviews gradually,
instead of forcing it over a night.
I agree.
Maybe a time bound switch? We can say
like in x months from now we will
Hi Gwen,
On Sun, Jul 19, 2015 at 2:26 AM, Gwen Shapira gshap...@cloudera.com wrote:
So, as an experiment, I created:
https://apachekafka.slack.com
I figured we'll give it a whirl for a week or two for dev discussions,
see how it goes and if we have activity we can add this to the website
On Mon, Jul 20, 2015 at 10:45 PM, Grant Henke ghe...@cloudera.com wrote:
In one run of the core tests I found the following:
- 4584 regular files (REG)
- 376 .jar files
- Not much one can/should do here. Many are from gradle itself.
- 2392 kafka .log files
-
: TopicAlreadyMarkedForDeletionException` clause maybe?
- Ismael Juma
On July 22, 2015, 1:46 a.m., Edward Ribeiro wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670
` and
`IllegalArgumentException` are enough? Also, you would it be better to use
`IOException` instead of `ClosedChannelException`?
What happens if other exceptions are thrown? Will we still have a socket
leak?
- Ismael Juma
On July 22, 2015, 5:02 a.m., Jiangjie Qin wrote
On Fri, Jul 24, 2015 at 2:00 AM, Jay Kreps j...@confluent.io wrote:
I do agree that working with a mixture of scala and java is a pain in the
butt. What about considering the more extreme idea of just moving the
remaining server-side scala into java? I like Scala, but the tooling and
On July 23, 2015, 7:19 a.m., Ashish Singh wrote:
core/src/test/scala/integration/kafka/api/ConsumerTest.scala, line 198
https://reviews.apache.org/r/36681/diff/2/?file=1019198#file1019198line198
I don't think it is an issue. Hope it's OK to drop the issue. Thanks
for the review
`. Let's see what others say though.
- Ismael Juma
On July 18, 2015, 2:46 a.m., benoyantony wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32841
On Thu, Jul 23, 2015 at 5:39 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
BUILD FAILED
This build job seems to be failing almost every time:
https://builds.apache.org/job/KafkaPreCommit/
Also, it seems to be running at a similar time as:
On July 22, 2015, 10:40 a.m., Ismael Juma wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 401
https://reviews.apache.org/r/36664/diff/2/?file=1018375#file1018375line401
Is it intentional to ignore `java.lang.Error` too?
Jiangjie Qin wrote:
I think
On Thu, Jul 23, 2015 at 6:39 PM, Ashish Singh asi...@cloudera.com wrote:
Isamel, thats true. It will be nice to see this fixed, however as we are
now moving to Github PRs should we start using travis CI?
We are currently using Jenkins for PR builds:
On July 22, 2015, 10:40 a.m., Ismael Juma wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 467
https://reviews.apache.org/r/36664/diff/2/?file=1018375#file1018375line467
As far as I can see `ClosedChannelException`, `IllegalStateException
On July 22, 2015, 10:40 a.m., Ismael Juma wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 467
https://reviews.apache.org/r/36664/diff/2/?file=1018375#file1018375line467
As far as I can see `ClosedChannelException`, `IllegalStateException
On July 21, 2015, 11:15 p.m., Gwen Shapira wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 465
https://reviews.apache.org/r/36664/diff/1/?file=1018238#file1018238line465
Turns out that catching Throwable is a really bad idea:
On July 16, 2015, 4:53 p.m., Edward Ribeiro wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 454
https://reviews.apache.org/r/36548/diff/1/?file=1013403#file1013403line454
It looks like there's a mix of if( and if (, with the latter being
more used than the
/coding-guide.html
Spaces after if statements is not mentioned. I don't have strong feeling
either way.
Grant Henke wrote:
I will drop this issue for this specific patch. A standard can definitely
be addressed and made uniform in a new Jira.
Ismael Juma wrote:
The Scala
On 24 Jul 2015 18:03, Jay Kreps j...@confluent.io wrote:
Does this make sense to people? If so let's try it and if we like it
better
we can formally make that the process for this kind of big thing.
Yes, sounds good to me.
Best,
Ismael
Hi Ewen,
On Fri, Jul 24, 2015 at 5:32 AM, Ewen Cheslack-Postava e...@confluent.io
wrote:
One other thing that might be worth mentioning in The Review Process
section is the hub tool: https://hub.github.com/ I only ever use one
feature, but it's immensely useful if you're reviewing PRs on
. It is likely
that people will move to the new way gradually and organically. At some
point, a separate discussion may be started about requiring the new way,
but let's see how it goes.
Best,
Ismael
On Tue, Jul 21, 2015 at 12:28 PM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
I would like to start
Hi all,
Guozhang raised this topic in the [DISCUSS] Using GitHub Pull Requests for
contributions and code review thread and suggested starting a new thread
for it.
In the Spark project, they say:
If the change is new, then it usually needs a new JIRA. However, trivial
changes, where what should
and such. The JIRA hooks also provide in
comment
updates too.
What issue are you having or looking to-do?
~ Joe Stein
On Mon, Jul 13, 2015 at 6:52 AM, Ismael Juma ism...@juma.me.uk wrote:
Hi all,
Guozhang raised this topic in the [DISCUSS] Using GitHub Pull Requests
for
contributions
On Mon, Jul 13, 2015 at 2:41 PM, Joe Stein joe.st...@stealth.ly wrote:
If the patch lives on a pull request and is a simple hotfix a committer
could +1 and commit it. I don't see anything in the
https://cwiki.apache.org/confluence/display/KAFKA/Bylaws preventing this
already now.
Good.
I
Hi Jun,
On Tue, Jul 14, 2015 at 2:09 AM, Jun Rao j...@confluent.io wrote:
Ismael,
I followed the instructions in KAFKA-2320 and created a new Jenkins job (
https://builds.apache.org/job/kafka-trunk-git-pr/). Could you check if it
works?
Thanks! It seems to be building when trunk changes
On Tue, Jul 14, 2015 at 10:46 PM, Joe Stein joe.st...@stealth.ly wrote:
Fasterxml/Jackson +1 to that. The scala databinds to case classes are gr8.
To be clear, case classes support would require the Scala module for
Jackson and the Scala versions headache that goes with it (2.9 support is
Hi Jay,
Comments inline.
On Tue, Jul 14, 2015 at 11:04 PM, Jay Kreps j...@confluent.io wrote:
Is this going to become a dependency for core and then transitively for the
old clients?
That's right.
The current json library is definitely not great, but it does
parse json and it's not used
Ewen,
On Tue, Jul 14, 2015 at 10:41 PM, Ewen Cheslack-Postava e...@confluent.io
wrote:
Currently the clients/server mismatch wouldn't be an issue since there are
no client-side uses of JSON, right? That said, if Copycat ends up included
in Kafka we'll need to provide at least one serializer
On Tue, Jul 14, 2015 at 6:15 PM, Jun Rao j...@confluent.io wrote:
I made a couple of changes to the new Jenkins job. Could you try again?
It's still not working, unfortunately. It may or may not be related to:
https://blogs.apache.org/infra/entry/mirroring_to_github_issues
For b, if we can't
1 - 100 of 5342 matches
Mail list logo
