[jira] [Assigned] (KAFKA-633) AdminTest.testShutdownBroker fails

[ https://issues.apache.org/jira/browse/KAFKA-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-633: Assignee: Joel Koshy AdminTest.testShutdownBroker fails --

[jira] [Updated] (KAFKA-598) decouple fetch size from max message size

[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-598: - Attachment: KAFKA-598-v1.patch I spent the better part of a day rebasing - serves me right for letting

[jira] [Updated] (KAFKA-633) AdminTest.testShutdownBroker fails

[ https://issues.apache.org/jira/browse/KAFKA-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-633: - Attachment: KAFKA-633-v1.patch This is a timing issue that affects low-volume topics (and in this case an

[jira] [Closed] (KAFKA-633) AdminTest.testShutdownBroker fails

[ https://issues.apache.org/jira/browse/KAFKA-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-633. Checked into 0.8. Will file separate jira to protect the ISR from re-expansion.

[jira] [Resolved] (KAFKA-633) AdminTest.testShutdownBroker fails

[ https://issues.apache.org/jira/browse/KAFKA-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-633. -- Resolution: Fixed AdminTest.testShutdownBroker fails --

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13526876#comment-13526876 ] Joel Koshy commented on KAFKA-664: -- To clarify, the map itself shouldn't grow indefinitely

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13526883#comment-13526883 ] Joel Koshy commented on KAFKA-664: -- Okay I'm slightly confused. Even on expiration the

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529313#comment-13529313 ] Joel Koshy commented on KAFKA-664: -- Agreed that we should checkin this fix + the

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529489#comment-13529489 ] Joel Koshy commented on KAFKA-664: -- One problem with the updated patch is the following:

[jira] [Commented] (KAFKA-604) Add missing metrics in 0.8

[ https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530165#comment-13530165 ] Joel Koshy commented on KAFKA-604: -- The rebased patch does not really comment on/address

[jira] [Updated] (KAFKA-664) Kafka server threads die due to OOME during long running test

[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-664: - Attachment: KAFKA-664-v3.patch Here is a simpler and hopefully safer approach of using a global request

[jira] [Created] (KAFKA-671) DelayedProduce requests should not hold full producer request data

Joel Koshy created KAFKA-671: Summary: DelayedProduce requests should not hold full producer request data Key: KAFKA-671 URL: https://issues.apache.org/jira/browse/KAFKA-671 Project: Kafka

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530254#comment-13530254 ] Joel Koshy commented on KAFKA-664: -- Also, just filed KAFKA-671 to address the issue that

[jira] [Updated] (KAFKA-664) Kafka server threads die due to OOME during long running test

[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-664: - Attachment: KAFKA-664-v4.patch All good points - here is v4 with those changes. Kafka

[jira] [Updated] (KAFKA-598) decouple fetch size from max message size

[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-598: - Attachment: KAFKA-598-v3.patch Quick overview of revised patch: 1 - Addressed your comment about the

[jira] [Resolved] (KAFKA-664) Kafka server threads die due to OOME during long running test

[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-664. -- Resolution: Fixed Committed on 0.8 Kafka server threads die due to OOME during long

[jira] [Commented] (KAFKA-598) decouple fetch size from max message size

[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536227#comment-13536227 ] Joel Koshy commented on KAFKA-598: -- Thanks for taking the time to review. 30. I think

[jira] [Commented] (KAFKA-682) java.lang.OutOfMemoryError: Java heap space

[ https://issues.apache.org/jira/browse/KAFKA-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544119#comment-13544119 ] Joel Koshy commented on KAFKA-682: -- You might need to increase your heap size. What do you

[jira] [Commented] (KAFKA-682) java.lang.OutOfMemoryError: Java heap space

[ https://issues.apache.org/jira/browse/KAFKA-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547129#comment-13547129 ] Joel Koshy commented on KAFKA-682: -- That's why I asked for the configured

[jira] [Commented] (KAFKA-598) decouple fetch size from max message size

[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551383#comment-13551383 ] Joel Koshy commented on KAFKA-598: -- The full scope should probably move out of 0.8 - i.e.,

[jira] [Commented] (KAFKA-705) Controlled shutdown doesn't seem to work on more than one broker in a cluster

[ https://issues.apache.org/jira/browse/KAFKA-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555352#comment-13555352 ] Joel Koshy commented on KAFKA-705: -- I set up a local cluster of three brokers and created

[jira] [Commented] (KAFKA-705) Controlled shutdown doesn't seem to work on more than one broker in a cluster

[ https://issues.apache.org/jira/browse/KAFKA-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557481#comment-13557481 ] Joel Koshy commented on KAFKA-705: -- I think this is why it happens:

[jira] [Created] (KAFKA-712) Controlled shutdown tool should provide a meaningful message if a controller failover occurs during the operation

Joel Koshy created KAFKA-712: Summary: Controlled shutdown tool should provide a meaningful message if a controller failover occurs during the operation Key: KAFKA-712 URL:

[jira] [Commented] (KAFKA-705) Controlled shutdown doesn't seem to work on more than one broker in a cluster

[ https://issues.apache.org/jira/browse/KAFKA-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559121#comment-13559121 ] Joel Koshy commented on KAFKA-705: -- I committed the fix to 0.8 with a small edit: used the

[jira] [Updated] (KAFKA-705) Controlled shutdown doesn't seem to work on more than one broker in a cluster

[ https://issues.apache.org/jira/browse/KAFKA-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-705: - Attachment: kafka-705-incremental-v2.patch Here is what I meant in my last comment.

[jira] [Created] (KAFKA-817) Implement a zookeeper path-based controlled shutdown tool

Joel Koshy created KAFKA-817: Summary: Implement a zookeeper path-based controlled shutdown tool Key: KAFKA-817 URL: https://issues.apache.org/jira/browse/KAFKA-817 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-827) improve list topic output format

[ https://issues.apache.org/jira/browse/KAFKA-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13614434#comment-13614434 ] Joel Koshy commented on KAFKA-827: -- While you are touching this, would it be reasonable to

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616783#comment-13616783 ] Joel Koshy commented on KAFKA-826: -- Thank you for looking into this. Metrics 2.x had a few

[jira] [Created] (KAFKA-872) Socket server does not set send/recv buffer sizes

Joel Koshy created KAFKA-872: Summary: Socket server does not set send/recv buffer sizes Key: KAFKA-872 URL: https://issues.apache.org/jira/browse/KAFKA-872 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-872) Socket server does not set send/recv buffer sizes

[ https://issues.apache.org/jira/browse/KAFKA-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-872: - Attachment: KAFKA-872-v1.patch Socket server does not set send/recv buffer sizes

[jira] [Created] (KAFKA-880) NoLeaderPartitionSet should be cleared before leader finder thread is started up

Joel Koshy created KAFKA-880: Summary: NoLeaderPartitionSet should be cleared before leader finder thread is started up Key: KAFKA-880 URL: https://issues.apache.org/jira/browse/KAFKA-880 Project: Kafka

[jira] [Updated] (KAFKA-880) NoLeaderPartitionSet should be cleared before leader finder thread is started up

[ https://issues.apache.org/jira/browse/KAFKA-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-880: - Description: This was a recent regression. This could prevent the consumer from progressing because

[jira] [Commented] (KAFKA-890) The list of brokers for fetching metadata should be shuffled

[ https://issues.apache.org/jira/browse/KAFKA-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13645736#comment-13645736 ] Joel Koshy commented on KAFKA-890: -- +1 It is worth noting that this is useful even in the

[jira] [Commented] (KAFKA-886) Update info on Controlled shutdown and Preferred replica election tool

[ https://issues.apache.org/jira/browse/KAFKA-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646092#comment-13646092 ] Joel Koshy commented on KAFKA-886: -- Thanks for the great write-up. Couple of comments: 1)

[jira] [Commented] (KAFKA-901) Kafka server can become unavailable if clients send several metadata requests

[ https://issues.apache.org/jira/browse/KAFKA-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13654667#comment-13654667 ] Joel Koshy commented on KAFKA-901: -- Haven't looked at the patch yet, but went through the

[jira] [Created] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

Joel Koshy created KAFKA-914: Summary: Deadlock between initial rebalance and watcher-triggered rebalances Key: KAFKA-914 URL: https://issues.apache.org/jira/browse/KAFKA-914 Project: Kafka

[jira] [Commented] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

[ https://issues.apache.org/jira/browse/KAFKA-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13663146#comment-13663146 ] Joel Koshy commented on KAFKA-914: -- One more point: [td3] above does not need to originate

[jira] [Updated] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

[ https://issues.apache.org/jira/browse/KAFKA-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-914: - Attachment: KAFKA-914-v1.patch Patch with the mentioned fix. 1 - I added comments with some detail since

[jira] [Created] (KAFKA-916) Deadlock between fetcher shutdown and handling partitions with error

Joel Koshy created KAFKA-916: Summary: Deadlock between fetcher shutdown and handling partitions with error Key: KAFKA-916 URL: https://issues.apache.org/jira/browse/KAFKA-916 Project: Kafka

[jira] [Resolved] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

[ https://issues.apache.org/jira/browse/KAFKA-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-914. -- Resolution: Fixed Thanks for the review. Committed after removing the unnecessary assignment in

[jira] [Closed] (KAFKA-914) Deadlock between initial rebalance and watcher-triggered rebalances

[ https://issues.apache.org/jira/browse/KAFKA-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-914. Deadlock between initial rebalance and watcher-triggered rebalances

[jira] [Commented] (KAFKA-911) Bug in controlled shutdown logic in controller leads to controller not sending out some state change request

[ https://issues.apache.org/jira/browse/KAFKA-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666532#comment-13666532 ] Joel Koshy commented on KAFKA-911: -- I had to revisit the notes from KAFKA-340. I think

[jira] [Updated] (KAFKA-916) Deadlock between fetcher shutdown and handling partitions with error

[ https://issues.apache.org/jira/browse/KAFKA-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-916: - Attachment: KAFKA-916-v1.patch Agreed - I think that should fix the issue. Deadlock

[jira] [Closed] (KAFKA-916) Deadlock between fetcher shutdown and handling partitions with error

[ https://issues.apache.org/jira/browse/KAFKA-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-916. Thanks for the review. Committed to 0.8 Deadlock between fetcher shutdown and handling

[jira] [Updated] (KAFKA-921) Expose max lag mbean for consumers and replica fetchers

[ https://issues.apache.org/jira/browse/KAFKA-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-921: - Attachment: KAFKA-921-v1.patch This provides a max lag mbean for both consumer fetcher manager and

[jira] [Updated] (KAFKA-921) Expose max lag mbean for consumers and replica fetchers

[ https://issues.apache.org/jira/browse/KAFKA-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-921: - Attachment: KAFKA-921-v2.patch Yes - I think that would be better. Moved it to AbstractFetcherManager. So

[jira] [Updated] (KAFKA-921) Expose max lag mbean for consumers and replica fetchers

[ https://issues.apache.org/jira/browse/KAFKA-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-921: - Attachment: KAFKA-921-v3.patch One caveat in this approach is that if a fetcher is wedged for any reason,

[jira] [Updated] (KAFKA-921) Expose max lag mbean for consumers and replica fetchers

[ https://issues.apache.org/jira/browse/KAFKA-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-921: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the reviews. Committed with

[jira] [Commented] (KAFKA-927) Integrate controlled shutdown into kafka shutdown hook

[ https://issues.apache.org/jira/browse/KAFKA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13674598#comment-13674598 ] Joel Koshy commented on KAFKA-927: -- +1 - sorry I got to this late. Small nit: the

[jira] [Commented] (KAFKA-938) High CPU usage when more or less idle

[ https://issues.apache.org/jira/browse/KAFKA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681479#comment-13681479 ] Joel Koshy commented on KAFKA-938: -- Excellent catch Sam! One comment: I think the

[jira] [Commented] (KAFKA-937) ConsumerFetcherThread can deadlock

[ https://issues.apache.org/jira/browse/KAFKA-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681787#comment-13681787 ] Joel Koshy commented on KAFKA-937: -- +1 on the patch. Additionally, can you make this

[jira] [Created] (KAFKA-940) Scala match error in javaapi.Implicits

Joel Koshy created KAFKA-940: Summary: Scala match error in javaapi.Implicits Key: KAFKA-940 URL: https://issues.apache.org/jira/browse/KAFKA-940 Project: Kafka Issue Type: Bug Affects

[jira] [Commented] (KAFKA-947) isr-expiration-thread may block LeaderAndIsr request for a relatively long period

[ https://issues.apache.org/jira/browse/KAFKA-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688719#comment-13688719 ] Joel Koshy commented on KAFKA-947: -- +1 thanks for the patch!

[jira] [Assigned] (KAFKA-559) Garbage collect old consumer metadata entries

[ https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-559: Assignee: Tejas Patil Assigning to Tejas, since he has done some work on this recently.

[jira] [Commented] (KAFKA-559) Garbage collect old consumer metadata entries

[ https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698307#comment-13698307 ] Joel Koshy commented on KAFKA-559: -- One additional recommendation: support a --dry-run

[jira] [Commented] (KAFKA-960) Upgrade Metrics to 3.x

[ https://issues.apache.org/jira/browse/KAFKA-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699211#comment-13699211 ] Joel Koshy commented on KAFKA-960: -- Given that there are API changes and mbean name

[jira] [Commented] (KAFKA-960) Upgrade Metrics to 3.x

[ https://issues.apache.org/jira/browse/KAFKA-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699545#comment-13699545 ] Joel Koshy commented on KAFKA-960: -- Not really. However, my point is that given that going

[jira] [Commented] (KAFKA-961) state.change.logger: Error on broker 1 while processing LeaderAndIsr request correlationId 6 received from controller 1 epoch 1 for partition (page_visits,0)

[ https://issues.apache.org/jira/browse/KAFKA-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699567#comment-13699567 ] Joel Koshy commented on KAFKA-961: -- Passing in null for time would definitely lead to that

[jira] [Commented] (KAFKA-915) System Test - Mirror Maker testcase_5001 failed

[ https://issues.apache.org/jira/browse/KAFKA-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699641#comment-13699641 ] Joel Koshy commented on KAFKA-915: -- This failure is due to the fact that the leaderAndIsr

[jira] [Commented] (KAFKA-966) Allow high level consumer to 'nak' a message and force Kafka to close the KafkaStream without losing that message

[ https://issues.apache.org/jira/browse/KAFKA-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703755#comment-13703755 ] Joel Koshy commented on KAFKA-966: -- One way to accomplish this is to turn off autocommit

[jira] [Commented] (KAFKA-969) Need to prevent failure of rebalance when there are no brokers available when consumer comes up

[ https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705340#comment-13705340 ] Joel Koshy commented on KAFKA-969: -- This seems reasonable, but I'm not fully convinced

[jira] [Commented] (KAFKA-969) Need to prevent failure of rebalance when there are no brokers available when consumer comes up

[ https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705490#comment-13705490 ] Joel Koshy commented on KAFKA-969: -- As I already said, I'm +1 on this patch for what it

[jira] [Resolved] (KAFKA-705) Controlled shutdown doesn't seem to work on more than one broker in a cluster

[ https://issues.apache.org/jira/browse/KAFKA-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-705. -- Resolution: Fixed Controlled shutdown doesn't seem to work on more than one broker in a cluster

[jira] [Commented] (KAFKA-705) Controlled shutdown doesn't seem to work on more than one broker in a cluster

[ https://issues.apache.org/jira/browse/KAFKA-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709525#comment-13709525 ] Joel Koshy commented on KAFKA-705: -- Yes we can close this. Controlled

[jira] [Closed] (KAFKA-705) Controlled shutdown doesn't seem to work on more than one broker in a cluster

[ https://issues.apache.org/jira/browse/KAFKA-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-705. Controlled shutdown doesn't seem to work on more than one broker in a cluster

[jira] [Commented] (KAFKA-973) Messages From Producer Not being Partitioned

[ https://issues.apache.org/jira/browse/KAFKA-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709531#comment-13709531 ] Joel Koshy commented on KAFKA-973: -- Can you try sending more messages? The default

[jira] [Commented] (KAFKA-957) MirrorMaker needs to preserve the key in the source cluster

[ https://issues.apache.org/jira/browse/KAFKA-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710571#comment-13710571 ] Joel Koshy commented on KAFKA-957: -- Thanks for incorporating 5 and 6. Couple additional

[jira] [Commented] (KAFKA-967) Use key range in ProducerPerformance

[ https://issues.apache.org/jira/browse/KAFKA-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710589#comment-13710589 ] Joel Koshy commented on KAFKA-967: -- +1 - thanks for the patch. Use key

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713045#comment-13713045 ] Joel Koshy commented on KAFKA-347: -- Thank you for the patch. Couple of comments, all very

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714259#comment-13714259 ] Joel Koshy commented on KAFKA-347: -- Thanks for patch v2. I'm +1 on this as is, but if you

[jira] [Commented] (KAFKA-982) Logo for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13716285#comment-13716285 ] Joel Koshy commented on KAFKA-982: -- +1 for 298, and I like Jakob's recursive suggestion as

[jira] [Commented] (KAFKA-925) Add optional partition key override in producer

[ https://issues.apache.org/jira/browse/KAFKA-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13716593#comment-13716593 ] Joel Koshy commented on KAFKA-925: -- +1 , looks good to me. DefaultPartitioner: Do we need

[jira] [Updated] (KAFKA-957) MirrorMaker needs to preserve the key in the source cluster

[ https://issues.apache.org/jira/browse/KAFKA-957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-957: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed to 0.8

[jira] [Closed] (KAFKA-957) MirrorMaker needs to preserve the key in the source cluster

[ https://issues.apache.org/jira/browse/KAFKA-957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-957. MirrorMaker needs to preserve the key in the source cluster

[jira] [Commented] (KAFKA-957) MirrorMaker needs to preserve the key in the source cluster

[ https://issues.apache.org/jira/browse/KAFKA-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718690#comment-13718690 ] Joel Koshy commented on KAFKA-957: -- +1 MirrorMaker needs to preserve the

[jira] [Commented] (KAFKA-991) Reduce the queue size in hadoop producer

[ https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726958#comment-13726958 ] Joel Koshy commented on KAFKA-991: -- +1 Committed to 0.8 Minor comment: - queue size is

[jira] [Commented] (KAFKA-991) Reduce the queue size in hadoop producer

[ https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727092#comment-13727092 ] Joel Koshy commented on KAFKA-991: -- Thanks for the follow-up patch. totalBytes is set to

[jira] [Updated] (KAFKA-991) Reduce the queue size in hadoop producer

[ https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-991: - Resolution: Fixed Status: Resolved (was: Patch Available) Reduce the queue size in hadoop

[jira] [Closed] (KAFKA-991) Reduce the queue size in hadoop producer

[ https://issues.apache.org/jira/browse/KAFKA-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-991. +1 Committed to 0.8 Reduce the queue size in hadoop producer

[jira] [Commented] (KAFKA-915) System Test - Mirror Maker testcase_5001 failed

[ https://issues.apache.org/jira/browse/KAFKA-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728247#comment-13728247 ] Joel Koshy commented on KAFKA-915: -- +1 on the patch. I actually could not reproduce the

[jira] [Closed] (KAFKA-915) System Test - Mirror Maker testcase_5001 failed

[ https://issues.apache.org/jira/browse/KAFKA-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-915. System Test - Mirror Maker testcase_5001 failed ---

[jira] [Resolved] (KAFKA-915) System Test - Mirror Maker testcase_5001 failed

[ https://issues.apache.org/jira/browse/KAFKA-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-915. -- Resolution: Fixed System Test - Mirror Maker testcase_5001 failed

[jira] [Commented] (KAFKA-992) Double Check on Broker Registration to Avoid False NodeExist Exception

[ https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731187#comment-13731187 ] Joel Koshy commented on KAFKA-992: -- Delayed review - looks good to me, although I still

[jira] [Commented] (KAFKA-992) Double Check on Broker Registration to Avoid False NodeExist Exception

[ https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731282#comment-13731282 ] Joel Koshy commented on KAFKA-992: -- ok nm the comment about timestamp. I had forgotten

[jira] [Commented] (KAFKA-992) Double Check on Broker Registration to Avoid False NodeExist Exception

[ https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731337#comment-13731337 ] Joel Koshy commented on KAFKA-992: -- and nm for my comments about controller/consumers as

[jira] [Commented] (KAFKA-990) Fix ReassignPartitionCommand and improve usability

[ https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733837#comment-13733837 ] Joel Koshy commented on KAFKA-990: -- - Topics to move json file format seems unnecessarily

[jira] [Commented] (KAFKA-990) Fix ReassignPartitionCommand and improve usability

[ https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735120#comment-13735120 ] Joel Koshy commented on KAFKA-990: -- Can you elaborate on the change to shutdownBroker in

[jira] [Commented] (KAFKA-990) Fix ReassignPartitionCommand and improve usability

[ https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735653#comment-13735653 ] Joel Koshy commented on KAFKA-990: -- Looks like I might have looked at the wrong patch.

[jira] [Commented] (KAFKA-990) Fix ReassignPartitionCommand and improve usability

[ https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737010#comment-13737010 ] Joel Koshy commented on KAFKA-990: -- The rebased patch looks good - the shutdown changes I

[jira] [Commented] (KAFKA-990) Fix ReassignPartitionCommand and improve usability

[ https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737024#comment-13737024 ] Joel Koshy commented on KAFKA-990: -- It should be liveOrShuttingDownBrokerIds. This is

[jira] [Commented] (KAFKA-937) ConsumerFetcherThread can deadlock

[ https://issues.apache.org/jira/browse/KAFKA-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756807#comment-13756807 ] Joel Koshy commented on KAFKA-937: -- The delta patch slipped through the cracks. We hit

[jira] [Commented] (KAFKA-998) Producer should not retry on non-recoverable error codes

[ https://issues.apache.org/jira/browse/KAFKA-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758450#comment-13758450 ] Joel Koshy commented on KAFKA-998: -- Apologies for the late review. Couple of comments: * I

[jira] [Commented] (KAFKA-998) Producer should not retry on non-recoverable error codes

[ https://issues.apache.org/jira/browse/KAFKA-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759257#comment-13759257 ] Joel Koshy commented on KAFKA-998: -- Oh I thought this was for 0.8 - it does apply on

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765763#comment-13765763 ] Joel Koshy commented on KAFKA-1053: --- I'll take a look today - would like to try it out

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767216#comment-13767216 ] Joel Koshy commented on KAFKA-1053: --- Ran into this while following the instructions. May

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767225#comment-13767225 ] Joel Koshy commented on KAFKA-1053: --- Probably because I did both yum install

[jira] [Updated] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1049: -- Attachment: KAFKA-1049.patch Encoder implementations are required to provide an undocumented

[jira] [Commented] (KAFKA-1049) Encoder implementations are required to provide an undocumented constructor.

[ https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770182#comment-13770182 ] Joel Koshy commented on KAFKA-1049: --- Created reviewboard

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770270#comment-13770270 ] Joel Koshy commented on KAFKA-1053: --- Nice - I tried this on KAFKA-1049 (as a test - that

[jira] [Created] (KAFKA-1089) Migration tool system tests soft-fail on 0.8 and trunk

Joel Koshy created KAFKA-1089: - Summary: Migration tool system tests soft-fail on 0.8 and trunk Key: KAFKA-1089 URL: https://issues.apache.org/jira/browse/KAFKA-1089 Project: Kafka Issue Type:

  1   2   3   4   5   6   7   8   >