Re: [DISCUSS] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-08-24 Thread Kirk True
5. I agree with Ron, We should move the public classes to > "o.a.k.c.s.oauthbearer.secured" package. Sounds good. I made the change in the KIP. > Thanks, > Manikumar Thanks for your feedback! > > On Thu, Aug 19, 2021 at 11:46 PM Kirk True wrote: > > >

[DISCUSS] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-08-13 Thread Kirk True
Hi all! I have created a new KIP for a new OAuth/OIDC related authentication feature. This task is to provide a concrete implementation of the interfaces defined in KIP-255 to allow Kafka to connect to an OAuth / OIDC identity provider for authentication and token retrieval. While KIP-255

Re: Requesting permission to contribute to Apache Kafka

2021-08-13 Thread Kirk True
Thanks! On Thu, Aug 12, 2021, at 6:42 PM, Bill Bejeck wrote: > Hi Kirk, > > You're all set now. Thanks for your interest in Apache Kafka. > > -Bill > > On Thu, Aug 12, 2021 at 1:40 PM Kirk True wrote: > > > Hi all, > > > > I'd like to contrib

Re: [DISCUSS] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-08-19 Thread Kirk True
eader) isn't `none` and > matches the expected algorithm for the JWK ID > Thanks again -- very exciting! Thanks for the feedback!!! Kirk > > Ron > > > > > > On Fri, Aug 13, 2021 at 3:53 PM Kirk True wrote: > > > Hi all! > > > > I ha

Requesting permission to contribute to Apache Kafka

2021-08-12 Thread Kirk True
Hi all, I'd like to contribute to Apache Kafka. My Confluence and Jira IDs are both kirktrue. Thanks, Kirk

Re: [DISCUSS] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-09-23 Thread Kirk True
quot;free." I've added a couple of sentences to that effect to the KIP. Thanks, Kirk > > Jun > > On Wed, Aug 25, 2021 at 8:54 PM Manikumar wrote: > > > Thanks for the reply, > > > > Can we also update the KIP about the testing approach? > > > >

Re: [DISCUSS] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-09-23 Thread Kirk True
75#KIP768:ExtendSASL/OAUTHBEARERwithSupportforOIDC-Testing Thanks, Kirk > Thanks, > > On Wed, Aug 25, 2021 at 12:01 AM Kirk True wrote: >> __ >> Hi Manikumar! >> >> On Mon, Aug 23, 2021, at 12:59 PM, Manikumar wrote: >>> Hi Kirk, >>> >>> Tha

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-18 Thread Kirk True
ink the timeouts may need a bit of > tweaking still. We can update the KIP and the thread if we decide to do that > as part of the PR review. > > Ismael > > On Thu, Oct 14, 2021 at 11:59 AM Kirk True wrote: >> __ >> Hi Ismael, >> >> Thanks for reviewing the

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-14 Thread Kirk True
clear that it's a Command versus a test suite? I changed the name to OAuthCompatibilityTool. Can you elaborate on what compatibility guarantees you'd like to see listed? I may just be misunderstanding the request. Thanks, Kirk > > Thanks! > > Ismael > > On Mon, Sep 27, 2

Re: [DISCUSS] Apache Kafka 3.1.0 release

2021-09-28 Thread Kirk True
Hi David, Is it possible to try to get KIP-768 in 3.1? I have put it up for a vote and have much of it implemented already. Thanks, Kirk On Tue, Sep 28, 2021, at 3:11 AM, Israel Ekpo wrote: > Ok. Sounds good, David. > > Let’s forge ahead. The plan looks good. > > On Tue, Sep 28, 2021 at 4:02

Re: [DISCUSS] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-06 Thread Kirk True
son why we chose to use system properties rather than command >line options for OAuthCompatibilityTest? I think I convinced myself that it made things easier and avoided a lot of boilerplate. I'll take another look. Thanks! Kirk > > > Regards, > > Rajini > >

Re: [DISCUSS] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-07 Thread Kirk True
Hi Rajini, I've updated the KIP with your feedback. Let me know if there's anything still amiss. Thanks, Kirk On Wed, Oct 6, 2021, at 5:27 PM, Kirk True wrote: > Hi Rajini, > > Thank you very much for your in-depth review! You highlighted a lot of dark > corners :) > > &

[VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-09-27 Thread Kirk True
Hi all! I'd like to start a vote for KIP-768 that allows Kafka to connect to an OAuth/OIDC identity provider for authentication and token retrieval: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186877575 Thanks! Kirk

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-09-27 Thread Kirk True
; s/defaults to scope/defaults to sub/ > Thanks! Fixed. Kirk > Ron > > > On Mon, Sep 27, 2021 at 1:20 PM Kirk True wrote: > > > Hi all! > > > > I'd like to start a vote for KIP-768 that allows Kafka to connect to an > > OAuth/OIDC identity provider for

Re: [ANNOUNCE] New Kafka PMC member: David Jacot

2021-12-17 Thread Kirk True
Congrats! On Fri, Dec 17, 2021, at 8:55 PM, Luke Chen wrote: > Congrats, David! > Well deserved. > > Luke > > deng ziming 於 2021年12月18日 週六 上午7:47 寫道: > > > Congrats David! > > > > -- > > Ziming Deng > > > > > On Dec 18, 2021, at 7:08 AM, Gwen Shapira wrote: > > > > > > Hi everyone, > > > > >

Re: 1% Kafka 3.0 unit test always fails

2022-01-05 Thread Kirk True
Hi! Can you post the results of the unit test failures either inline or post it online somewhere to view? Thanks, Kirk On Wed, Jan 5, 2022, at 8:59 AM, mohammad shadab wrote: > Hi All, > > I have build binaries from kafka 3.0.0 source code (downloaded from >

Re: [DISCUSS] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-28 Thread Kirk True
specified without listener prefix as well). > > Regards, > > Rajini > > > On Thu, Oct 7, 2021 at 6:51 PM Kirk True wrote: >> __ >> Hi Rajini, >> >> I've updated the KIP with your feedback. Let me know if there's anything >> still amiss.

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-12-13 Thread Kirk True
Hi Jun, On Thu, Dec 9, 2021, at 2:28 PM, Jun Rao wrote: > 13. Using OpenTelemetry. Does that require runtime dependency > on OpenTelemetry library? How good is the compatibility story > of OpenTelemetry? This is important since an application could have other > OpenTelemetry dependencies than the

Re: [DISCUSS] KIP-824 Allowing dumping segmentlogs limiting the batches in the output

2022-03-04 Thread Kirk True
Hi Sergio, Thanks for the KIP. I don't know anything about the log segment internals, but the logic and implementation seem sound. Three questions: 1. Since the --max-batches-size unit is bytes, does it matter if that size doesn't align to a record boundary? 2. Can you add a check to make

Re: [DISCUSS] KIP-714: Client metrics and observability

2022-03-09 Thread Kirk True
histogram. > > > > > > > I believe a population/distribution should preferably be represented as a > > histogram, space permitting, > > and only secondarily as a Gauge average. > > While we might not want to maintain a bunch of histograms for e

Re: Spotting stale KIPs with a better "Under Discussion" table

2022-03-03 Thread Kirk True
Hi Tom, This is great! I've just begun reading through the KIPs and I've noticed the status on the KIP list and on the KIP itself isn't always up-to-date. It would be great to have a "consistency checker" to verify high-level status details are consistent and up-to-date. Great work! Thanks,

Re: Spotting stale KIPs with a better "Under Discussion" table

2022-03-03 Thread Kirk True
Since this is on GitHub, you might look into GitHub Actions to implement the cron job to update the table. Thanks! On Wed, Mar 2, 2022, at 10:27 AM, Thomas Cooper wrote: > Hi All, > > I am hoping to get more involved in the upstream Kafka community. To that > end, I was trying to keep up with

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2022-02-07 Thread Kirk True
Hi Seamus, Is there a conflict between KIP-799 and KAFKA-12841 ? A related fix for the latter issue was just merged a few days ago (https://github.com/apache/kafka/pull/11689) and it seems like there's some overlap or discrepancy between the

Re: [DISCUSS] KIP-977: Partition-Level Throughput Metrics

2023-09-12 Thread Kirk True
Hi Qichao, Thanks for the KIP! Divij—questions/comments inline... > On Sep 11, 2023, at 4:32 AM, Divij Vaidya wrote: > > Thank you for the proposal Qichao. > > I agree with the motivation here and understand the tradeoff here > between observability vs. increased metric dimensions (metric

Re: [DISCUSS] KIP-977: Partition-Level Throughput Metrics

2023-09-12 Thread Kirk True
Oh, and does metrics.partition.level.reporting.topics allow for regex? > On Sep 12, 2023, at 8:26 AM, Kirk True wrote: > > Hi Qichao, > > Thanks for the KIP! > > Divij—questions/comments inline... > >> On Sep 11, 2023, at 4:32 AM, Divij Vaidya wrote: >>

Re: [ANNOUNCE] New committer: Lucas Brutschy

2023-09-21 Thread Kirk True
Congratulations, Lucas! > On Sep 21, 2023, at 9:16 AM, Sagar wrote: > > Congrats Lucas ! > > On Thu, 21 Sep 2023 at 9:15 PM, Bruno Cadonna wrote: > >> Hi all, >> >> The PMC of Apache Kafka is pleased to announce a new Kafka committer >> Lucas Brutschy. >> >> Lucas' major contributions are

Re: [ANNOUNCE] New Kafka PMC Member: Justine Olshan

2023-09-24 Thread Kirk True
Congratulations Justine! Thanks for all your great work! > On Sep 24, 2023, at 8:37 AM, John Roesler wrote: > > Congratulations, Justine! > -John > > On Sun, Sep 24, 2023, at 05:05, Mickael Maison wrote: >> Congratulations Justine! >> >> On Sun, Sep 24, 2023 at 5:04 AM Sophie Blee-Goldman >>

Re: [DISCUSS] KIP-714: Client metrics and observability

2023-09-22 Thread Kirk True
Hi Andrew/Jun, I want to make sure I understand question/comment #119… In the case where a cluster without a metrics client receiver is later reconfigured and restarted to include a metrics client receiver, do we want the client to thereafter begin pushing metrics to the cluster? From Andrew’s

Re: [DISCUSS] KIP-839: Provide builders for KafkaProducer/KafkaConsumer and KafkaStreams

2022-05-18 Thread Kirk True
Hi François, Thanks for the KIP! A couple of questions: 1. Do the builders have defaults for the serializers/deserializers? 2. Can the build method be called more than once on a given builder? Thanks, Kirk On Wed, May 18, 2022, at 10:11 AM, François Rosière wrote: > Hi all, > > KIP to

Re: [DISCUSS] KIP-714: Client metrics and observability

2022-06-23 Thread Kirk True
cific metrics runs the thread of a caveat emptor situation. > 103. "Are there any inobvious security/privacy-related edge cases where > shipping certain metrics to the broker would be "bad?"" I am not sure. But > if a metric can be shipped to the server, it would be useful for t

Re: [DISCUSS] KIP-714: Client metrics and observability

2022-06-21 Thread Kirk True
code. There's also the precedent set by the existing (JMX-based) client metrics. Though these are applicable only to the Java client, we can see that having a standardized naming convention there has helped with communication. So, IMO, it makes sense to define the metric names via the KIP mechanism

Re: [DISCUSS] KIP-714: Client metrics and observability

2022-06-16 Thread Kirk True
Hi Jun, I'll try to answer the questions posed... On Tue, Jun 7, 2022, at 4:32 PM, Jun Rao wrote: > Hi, Magnus, > > Thanks for the reply. > > So, the standard set of generic metrics is just a recommendation and not a > requirement? This sounds good to me since it makes the adoption of the KIP

Re: [DISCUSS] KIP-854 Separate configuration for producer ID expiry

2022-07-28 Thread Kirk True
Hi Justine, Thanks for the KIP. I appreciated the background context and clarity you added. On Wed, Jul 27, 2022, at 2:57 AM, Sagar wrote: > Thanks Justine for the KIP. I think it might be better to document the > correlation between the new config and delivery.timeout.ms in the Public >

Re: KafkaConsumer refactor proposal

2022-09-15 Thread Kirk True
Hi Philip! Thanks for the write-up. On Tue, Sep 13, 2022, at 2:13 PM, Philip Nee wrote: > Hi all, > > Here is the proposal to refactor the Kafka Consumer > . > The 1-pager is on the wiki, so please

Re: [ANNOUNCE] Apache Kafka 3.2.1

2022-08-03 Thread Kirk True
. > > A big thank you for the following 19 contributors to this release! > > Akhilesh Chaganti, Bruno Cadonna, Christopher L. Shannon, David > Arthur, Divij Vaidya, Eugene Tolbakov, Guozhang Wang, Ismael Juma, > James Hughes, Jason Gustafson, Kirk True, Lucas Bradstreet, Luke Chen,

[DISCUSS] Recommendations for managing long-running projects

2023-04-27 Thread Kirk True
Hi all, A handful of engineers are collaborating on a fairly sizable project to improve the Java consumer client [1]. We are using as many ASF tools as possible for the work (wiki, Jira, mailing list, and Slack thus far). There are yet two areas where we need recommendations: 1. Project

Re: [DISCUSS] KIP-909: Allow clients to rebootstrap DNS lookup failure

2023-04-07 Thread Kirk True
t is a hard > > failure (like, misconfiguration of the host name), it should be logged and > > errored out after the expiration. > > > > P > > > > On Wed, Mar 8, 2023 at 8:12 AM Kirk True wrote: > > > >> Hi Philip, > >> > &

Re: [VOTE] KIP-909: DNS Resolution Fallures Should Not Fail the Client

2023-04-13 Thread Kirk True
+1 (non-binding) > On Apr 10, 2023, at 1:53 PM, Philip Nee wrote: > > Hey everyone! > > I'm starting a vote for KIP-909: DNS Resolution Fallures Should Not Fail > the Client > > Please refer to the discussion thread here: >

Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-14 Thread Kirk True
Hi Mayank/José, > On Jul 13, 2023, at 8:20 AM, José Armando García Sancio > wrote: > > Hi Mayank, thanks for the KIP. I look forward to this improvement for > new clients. > > Some comments below. > > On Thu, Jul 13, 2023 at 7:15 AM Mayank Shekhar Narula > wrote: >> Following KIP is up for

Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-14 Thread Kirk True
Hi Andrew, Good point. Sorry to be dim bulb, but I’m still not sure I understand the downsides of bumping the version. The broker and all client implementations would have to change to fully support this feature anyway, but down version clients are handled by brokers already. Thanks, Kirk >

Re: [VOTE] KIP-944 Support async runtimes in consumer, votes needed!

2023-07-14 Thread Kirk True
Hi Erik, Thanks for the KIP! I empathize with your frustration over the radio silence. It gets like that sometimes, and I apologize for my lack of feedback. I’d personally like to see this lively exchange move over to the DISCUSS thread you’d created before. Thanks, Kirk > On Jul 14, 2023,

Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-14 Thread Kirk True
Hi Mayank, > On Jul 14, 2023, at 11:25 AM, Mayank Shekhar Narula > wrote: > > Kirk > > >> Is the requested restructuring of the response “simply” to preserve bytes, >> or is it possible that the fetch response could/should/would return >> leadership changes for partitions that we’re

Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-14 Thread Kirk True
Hi Mayank, Thanks for the KIP! Questions: 1. From the standpoint of the client, does it matter if the cluster is running in KRaft mode vs. Zookeeper? Will the behavior somehow be subtlety different given that metadata propagation is handled differently between the two? 2. Is there anything

Re: KafkaConsumer refactor proposal

2023-07-14 Thread Kirk True
Hi Erik, Regarding the consumer refactor project, we’re in the process of converting Philip’s design to a “proper” KIP here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-945%3A+Update+threading+model+for+Consumer It’s still very much a draft and not ready for a formal DISCUSS

Re: KafkaConsumer refactor proposal

2023-07-14 Thread Kirk True
Hi Erik, Thanks for your interest in the client world :) I agree that the current implementation of how we handle callbacks is problematic in that it introduces race conditions and/or bottlenecks. I don’t have as much experience with the callbacks from an application developer standpoint. Is

Re: [DISCUSS] Regarding Old PRs

2023-06-01 Thread Kirk True
Hi Josep, Sounds like an important task for the community & project. I would be happy to help in reaching out to the PR authors. Thanks, Kirk > On Jun 1, 2023, at 9:24 AM, Josep Prat wrote: > > Hi Kafka devs, > > Seeing that we have over a 1000 PRs and that we want to try to keep the >

Re: [DISCUSS] KIP-937 Improve Message Timestamp Validation

2023-06-07 Thread Kirk True
Hi Mehari, Thanks for the KIP and keeping it up-to-date with the discussions here! Question: 1. Is it possible to check for invalid timestamps in the client? Suppose we were to develop a means to determine with high confidence that the user had provided a timestamp in nanoseconds vs.

Re: [DISCUSS] KIP-937 Improve Message Timestamp Validation

2023-06-07 Thread Kirk True
Hi Divij/all, > On Jun 6, 2023, at 5:42 AM, Divij Vaidya wrote: > > Hi Luke > > Thank you for your participation in reviewing this KIP. > > #1 Updated the KIP with correct configuration names and hyperlinks. > > #2 Yes, the semantics change from a perspective that the difference is > always

Re: oauthbearer client -- override ssl.property (unable to do so)

2023-06-07 Thread Kirk True
Hi Neil, > On Jun 7, 2023, at 10:35 AM, Neil Buesing wrote: > > The code "AccessTokenRetrieverFactory" uses the "jaasConfig"'s for the > properties used for building the socket factory. > > Shouldn't "jou.createSSLSockerFactor()" use the kafka configs for sasl/ssl > overrides? > > I am

Re: Increase in flaky test failures

2023-07-25 Thread Kirk True
Hi Divij, I’m hitting something similar in my pull request test run (https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13990/26/pipeline/10): > Task :clients:testClasses Unexpected exception thrown. org.gradle.internal.remote.internal.MessageIOException: Could

Debugging Jenkins test failures

2023-07-25 Thread Kirk True
Hi all! I’ve noticed that we’re back in the state where it’s tough to get a clean PR Jenkins test run. Spot checking the top ~10 pull request runs show this doesn’t appear to be an issue with just my PRs :P I know we have some chronic flaky tests, but I’ve seen at least two other classes of

Re: [VOTE] KIP-951: Leader discovery optimisations for the client

2023-07-26 Thread Kirk True
+1 (non-binding) Thanks Mayank! On Mon, Jul 24, 2023, at 11:24 AM, Mayank Shekhar Narula wrote: > Hi all > > Opening the voting process for this KIP, given the deadline for KIP > acceptance for 3.6 is impending. Open to keep the discussion going if the > community needs more time to converge. >

Re: Flaky tests need attention (clients, Connect, Mirror Maker, Streams, etc.)

2023-08-08 Thread Kirk True
is being reported here. >> >> It includes both trunk and PR branch test runs. I’ll see how easy it is to >> filter them out. >> >> Thanks! >> >>> >>> Thanks for sharing though! This is a useful tool that we've needed for a >>> while. &g

Re: Debugging Jenkins test failures

2023-08-08 Thread Kirk True
I created this INFRA Jira just now to see if they can help resolve some of the intermittent Jenkins build issues: https://issues.apache.org/jira/browse/INFRA-24874 > On Aug 1, 2023, at 4:04 PM, Kirk True wrote: > > Hi Divij, > > Thanks for the pointer to Gradle Enterprise!

Re: Flaky tests need attention (clients, Connect, Mirror Maker, Streams, etc.)

2023-08-08 Thread Kirk True
a > while. > > Justine > > On Tue, Aug 1, 2023 at 4:38 PM Kirk True wrote: > >> Hi! >> >> According to the Gradle Enterprise statistics on our recent Kafka builds, >> over 90% have flaky tests [1]. >> >> We also have 106 open Jiras wit

Re: [VOTE] KIP-714: Client metrics and observability

2023-08-09 Thread Kirk True
Hi Andrew, +1 (non-binding) This is a huge step in enabling end-to-end observability for users and hopefully even help us get a better idea where we can improvement the client behavior. And +100 re: librdkafka team involvement. Thanks! > On Aug 8, 2023, at 4:00 AM, Milind Luthra > wrote:

Re: Debugging Jenkins test failures

2023-08-01 Thread Kirk True
2. https://issues.apache.org/jira/browse/KAFKA-15052 (this test passes > only 49% of the time) > > > [1] > https://ge.apache.org/scans/tests?search.relativeStartTime=P28D=kafka=Europe/Berlin > [2] > https://ge.apache.org/scans/failures?search.relativeStartTime=P28

Flaky tests need attention (clients, Connect, Mirror Maker, Streams, etc.)

2023-08-01 Thread Kirk True
Hi! According to the Gradle Enterprise statistics on our recent Kafka builds, over 90% have flaky tests [1]. We also have 106 open Jiras with the “flaky-test” label across several functional areas of the project [2]. Can I ask that those familiar with those different functional areas take a

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-17 Thread Kirk True
+1 (non-binding) Thanks Mehari! > On Jun 16, 2023, at 6:29 PM, Luke Chen wrote: > > +1 (binding) from me. > > Thanks. > Luke > > On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari > wrote: > >> Hello everyone, >> >> I am opening the Volte on KIP-937 here. If we have more to discuss, please

Re: [DISCUSS] KIP-941: Range queries to accept null lower and upper bounds

2023-06-21 Thread Kirk True
k for every store. > Obviously, you may also want to add some specific unit tests in addition. > > See > https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java > > Thanks again! > -John > >

Re: [DISCUSS] KIP-941: Range queries to accept null lower and upper bounds

2023-06-21 Thread Kirk True
Hi Lucia, Thanks for the KIP! The KIP wasn’t in the email and I didn’t see it on the main KIP directory. Here it is: https://cwiki.apache.org/confluence/display/KAFKA/KIP-941%3A+Range+queries+to+accept+null+lower+and+upper+bounds Can the KIP be added to the main KIP page

Re: [DISCUSS] KIP-940: Broker extension point for validating record contents at produce time

2023-06-21 Thread Kirk True
Hi Edo/Adrian! Thanks for the KIP. I have some questions, and apologies that the may fall under the “stupid” column because I’m not that familiar with this area :) 1. Does record.validation.policy.class.name support multiple classes, or just one? I’m probably not wrapping my head around it,

Re: [DISCUSS] KIP-941: Range queries to accept null lower and upper bounds

2023-06-21 Thread Kirk True
that use Optional directly? What’s the benefit of introducing what appears to be a very thin utility facade? Thanks, Kirk > On Jun 21, 2023, at 9:51 AM, Kirk True wrote: > > Hi Lucia, > > Thanks for the KIP! > > The KIP wasn’t in the email and I didn’t see it on the main K

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Kirk True
Congrats Well deserved! On Tue, Jun 13, 2023, at 9:22 AM, Greg Harris wrote: > Congratulations! > > On Tue, Jun 13, 2023 at 9:15 AM Mickael Maison > wrote: > > > > Congratulations! > > > > On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: > > > > > > Congratulations Divij! > > > > > > On

Re: [DISCUSS] KIP-714: Client metrics and observability

2023-06-20 Thread Kirk True
Hi Andrew, > On Jun 13, 2023, at 8:06 AM, Andrew Schofield > wrote: > > Hi, > I would like to start a new discussion thread on KIP-714: Client metrics and > observability. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability > > I have edited

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-11 Thread Kirk True
+1 (non-binding) Thanks ShunKang! On Wed, May 10, 2023, at 7:26 PM, Luke Chen wrote: > +1(binding) from me. > Thanks for the improvement! > > Luke > > On Sun, May 7, 2023 at 6:34 PM Divij Vaidya wrote: > > > Vote +1 (non binding) > > > > I think that this is a nice improvement as it prevents

Re: [DISCUSS] KIP-931: Flag to ignore unused message attribute field

2023-05-12 Thread Kirk True
Hi David, For my own edification, when you refer to this change possibly putting "more pressure on the brokers," is that from the downconversion of the message format, specifically, or something else? Thanks, Kirk On Fri, May 12, 2023, at 1:59 AM, Luke Chen wrote: > Hi David, > > I know what

Re: [ANNOUNCE] New Kafka PMC Member: Divij Vaidya

2023-12-27 Thread Kirk True
Congrats Divij!!! On Wed, Dec 27, 2023, at 1:44 PM, Jorge Esteban Quilcate Otoya wrote: > Congratulations Divij!! > > On Wed 27. Dec 2023 at 14.56, Tom Bentley wrote: > > > Congratulations! > > > > On Thu, 28 Dec 2023 at 06:17, Philip Nee wrote: > > > > > congrats divij! > > > > > > On Wed,

Re: [VOTE] 3.7.0 RC2

2024-01-15 Thread Kirk True
Hi Stanislav, On Sun, Jan 14, 2024, at 1:17 PM, Stanislav Kozlovski wrote: > Hey Kirk and Chris, > > Unless I'm missing something - KAFKALESS-16029 is simply a bad log due to > improper closing. And the PR description implies this has been present > since 3.5. While annoying, I don't see a

Re: [VOTE] 3.7.0 RC2

2024-01-12 Thread Kirk True
Hi Chris/Stanislav, I'm working on the 'Unable to find FetchSessionHandler' log problem (KAFKA-16029) and have put out a draft PR (https://github.com/apache/kafka/pull/15186). I will use the quickstart approach as a second means to reproduce/verify while I wait for the PR's Jenkins job to

Re: Apache Kafka 3.6.1 release

2023-11-28 Thread Kirk True
as hoping to build RC0 tomorrow morning (EU > > time). This does not seem like it's a regression or a major bug so I > > don't consider it a blocker. > > If you can get it merged and backported to 3.6 overnight, fine, but I > > don't think we need to wait for it. > > >

Re: [DISCUSS] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs

2023-11-28 Thread Kirk True
Hi Raman, Thanks for the KIP! Questions/comments: 1. Is there a Jira created for this? The Jira link still points to KAFKA-1. 2. There's a minor typo in the ListTransactionsRequest documentation for the DurationFilter: trsanactions. 3. Is the TransactionStartTimeMs return value in the

Re: Apache Kafka 3.6.1 release

2023-11-22 Thread Kirk True
Hi Mickael, Is there still time to put in another fix? I'd like to propose we include https://issues.apache.org/jira/browse/KAFKA-15817. Thanks, Kirk On Fri, Nov 17, 2023, at 6:15 AM, Mickael Maison wrote: > Hi, > > Quick update on 3.6.1: > We have 1 blocker issue left: KAFKA-15802. Once it's

Re: [ANNOUNCE] Apache Kafka 3.7.0

2024-02-28 Thread Kirk True
rez, > iit2009060, Ismael Juma, Jakub Scholz, James Cheng, Jason Gustafson, > Jay Wang, Jeff Kim, Jim Galasyn, John Roesler, Jorge Esteban Quilcate > Otoya, Josep Prat, José Armando García Sancio, Jotaniya Jeel, Jouni > Tenhunen, Jun Rao, Justine Olshan, Kamal Chandraprakash, Kirk True, >

Re: Newbie need some help

2024-02-28 Thread Kirk True
Hi Chia, Welcome! One suggestion is to look at the list of open Jiras that are marked with the “newbie” label: https://issues.apache.org/jira/issues/?jql=project %3D KAFKA AND labels IN (newbie%2C "newbie%2B%2B") AND status in (Open%2C Reopened) ORDER BY created DESC

Shortened URLs for KIPs?

2024-02-28 Thread Kirk True
Hi all, Is it possible to set up shortened URLs for KIPs? So instead of, say: https://cwiki.apache.org/confluence/display/KAFKA/KIP-966%3A+Eligible+Leader+Replicas We could refer to it as: https://cwiki.apache.org/confluence/display/KAFKA/KIP-966 Or maybe even go so far as to have something

Re: Shortened URLs for KIPs?

2024-02-28 Thread Kirk True
I just found https://s.apache.org/, which is an Apache shortened URL service. That might provide the needed infrastructure, but it requires a login, so someone (a committer(?)) to create that for each KIP :( > On Feb 28, 2024, at 2:40 PM, Kirk True wrote: > > Hi all, > >

Re: [DISCUSS] KIP-1025: Optionally URL-encode clientID and clientSecret in authorization header

2024-03-18 Thread Kirk True
Hi Nelson, Thank you for writing up the KIP! My apologies for the delay in response :( Questions: 1. Is the long-term plan to keep the configuration default set to “false"? I understand the short-term benefits, but in general, configuration defaults should prefer compliance with standards

Re: [DISCUSS] KIP-1025: Optionally URL-encode clientID and clientSecret in authorization header

2024-03-19 Thread Kirk True
.header.urlencode" in > the KIP, I'm gonna update PR once KIP is accepted. > > Thanks, > > On Tue, Mar 19, 2024 at 3:45 AM Kirk True wrote: > >> Hi Nelson, >> >> Thank you for writing up the KIP! My apologies for the delay in response :( >> >>

Re: [VOTE] KIP-1025: Optionally URL-encode clientID and clientSecret in authorization header

2024-04-07 Thread Kirk True
+1 (non-binding) Apologies. I thought I’d already voted :( > On Apr 7, 2024, at 10:48 AM, Nelson B. wrote: > > Hi all, > > Just wanted to bump up this thread for visibility. > > Thanks! > > On Thu, Mar 28, 2024 at 3:40 AM Doğuşcan Namal > wrote: > >> Thanks for checking it out Nelson.

Re: [ANNOUNCE] New committer: Christo Lolov

2024-03-26 Thread Kirk True
Congratulations Christo! > On Mar 26, 2024, at 7:27 AM, Satish Duggana wrote: > > Congratulations Christo! > > On Tue, 26 Mar 2024 at 19:20, Ivan Yurchenko wrote: >> >> Congrats! >> >> On Tue, Mar 26, 2024, at 14:48, Lucas Brutschy wrote: >>> Congrats! >>> >>> On Tue, Mar 26, 2024 at 2:44 

Re: [DISCUSS] KIP-1036: Extend RecordDeserializationException exception

2024-04-10 Thread Kirk True
Hi Fred, Thanks for the KIP! Questions/comments: How do we handle the case where CompletedFetch.parseRecord isn’t able to construct a well-formed ConsumerRecord (i.e. the values it needs are missing/corrupted/etc.)? Please change RecordDeserializationException’s getConsumerRecord() method to

Re: [DISCUSS] KIP-1036: Extend RecordDeserializationException exception

2024-04-23 Thread Kirk True
Hi Fred, Thanks for the updates! Questions: K11. Can we reconsider the introduction of two new exception subclasses? Perhaps I don’t understand the benefit? Technically both the key and the value could have deserialization errors, right? K12. Is there a benefit to exposing both the

Re: [DISCUSS] KIP-1038: Add Custom Error Handler to Producer

2024-04-23 Thread Kirk True
Hi Alieh, Thanks for the KIP! A few questions: K1. What is the expected behavior for the producer if it generates a RecordTooLargeException, but the handler returns RETRY? K2. How do we determine which Record was responsible for the UnknownTopicOrPartitionException since we get that response

Re: [DISCUSS] KIP-1038: Add Custom Error Handler to Producer

2024-04-25 Thread Kirk True
blems than we are solving. It is still unclear to me how >> we expect to handle the errors. Perhaps we could include an example? It >> seems like there is a specific use case in mind and maybe we can make a >> design that is tighter and supports that case. >> >> Justine

Re: [VOTE] KIP-1036: Extend RecordDeserializationException exception

2024-05-13 Thread Kirk True
+1 (non-binding) Thanks Fred! > On May 13, 2024, at 5:46 AM, Bill Bejeck wrote: > > Thanks for the KIP! > > +1 (binding) > > -Bill > > > On Tue, May 7, 2024 at 6:16 PM Sophie Blee-Goldman > wrote: > >> +1 (binding) >> >> thanks for the KIP! >> >> On Fri, May 3, 2024 at 9:13 AM Matthias

Re: [VOTE] KIP-1038: Add Custom Error Handler to Producer

2024-05-20 Thread Kirk True
+1 (non-binding) Thanks Alieh! > On May 20, 2024, at 6:00 AM, Walker Carlson > wrote: > > Hey Alieh, > > Thanks for the KIP. > > +1 binding > > Walker > > On Tue, May 7, 2024 at 10:57 AM Alieh Saeedi > wrote: > >> Hi all, >> >> It seems that we have no more comments, discussions, or

[jira] [Created] (KAFKA-13202) KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-08-13 Thread Kirk True (Jira)
Kirk True created KAFKA-13202: - Summary: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC Key: KAFKA-13202 URL: https://issues.apache.org/jira/browse/KAFKA-13202 Project: Kafka Issue Type

[jira] [Created] (KAFKA-13558) NioEchoServer fails to close resources

2021-12-20 Thread Kirk True (Jira)
Kirk True created KAFKA-13558: - Summary: NioEchoServer fails to close resources Key: KAFKA-13558 URL: https://issues.apache.org/jira/browse/KAFKA-13558 Project: Kafka Issue Type: Bug Affects

[jira] [Created] (KAFKA-13444) Fix OAuthCompatibilityTool help and add SSL options

2021-11-10 Thread Kirk True (Jira)
Kirk True created KAFKA-13444: - Summary: Fix OAuthCompatibilityTool help and add SSL options Key: KAFKA-13444 URL: https://issues.apache.org/jira/browse/KAFKA-13444 Project: Kafka Issue Type

[jira] [Created] (KAFKA-13443) Kafka broker exits when OAuth enabled and certain configuration not specified

2021-11-10 Thread Kirk True (Jira)
Kirk True created KAFKA-13443: - Summary: Kafka broker exits when OAuth enabled and certain configuration not specified Key: KAFKA-13443 URL: https://issues.apache.org/jira/browse/KAFKA-13443 Project

[jira] [Created] (KAFKA-13446) Remove JWT access token from logs

2021-11-10 Thread Kirk True (Jira)
Kirk True created KAFKA-13446: - Summary: Remove JWT access token from logs Key: KAFKA-13446 URL: https://issues.apache.org/jira/browse/KAFKA-13446 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-13445) Add ECDSA test for JWT validation

2021-11-10 Thread Kirk True (Jira)
Kirk True created KAFKA-13445: - Summary: Add ECDSA test for JWT validation Key: KAFKA-13445 URL: https://issues.apache.org/jira/browse/KAFKA-13445 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

2022-03-09 Thread Kirk True (Jira)
Kirk True created KAFKA-13725: - Summary: KIP-768 OAuth code mixes public and internal classes in same package Key: KAFKA-13725 URL: https://issues.apache.org/jira/browse/KAFKA-13725 Project: Kafka

[jira] [Resolved] (KAFKA-15543) Send HB request right after reconciliation completes

2023-10-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-15543. --- Resolution: Duplicate > Send HB request right after reconciliation comple

[jira] [Resolved] (KAFKA-14761) Integration Tests for the New Consumer Implementation

2023-10-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-14761. --- Fix Version/s: 3.6.0 Resolution: Fixed > Integration Tests for the New Consu

[jira] [Created] (KAFKA-15615) Improve handling of fetching during metadata updates

2023-10-16 Thread Kirk True (Jira)
Kirk True created KAFKA-15615: - Summary: Improve handling of fetching during metadata updates Key: KAFKA-15615 URL: https://issues.apache.org/jira/browse/KAFKA-15615 Project: Kafka Issue Type

[jira] [Created] (KAFKA-15617) Determine if testFetchingPendingPartitions and testInflightFetchOnPendingPartitions overlap

2023-10-16 Thread Kirk True (Jira)
Kirk True created KAFKA-15617: - Summary: Determine if testFetchingPendingPartitions and testInflightFetchOnPendingPartitions overlap Key: KAFKA-15617 URL: https://issues.apache.org/jira/browse/KAFKA-15617

[jira] [Created] (KAFKA-15652) Investigate resetting offsets in SubscriptionState.resetInitializingPositions()

2023-10-19 Thread Kirk True (Jira)
Kirk True created KAFKA-15652: - Summary: Investigate resetting offsets in SubscriptionState.resetInitializingPositions() Key: KAFKA-15652 URL: https://issues.apache.org/jira/browse/KAFKA-15652 Project

[jira] [Created] (KAFKA-15651) Investigate auto commit guarantees during Consumer.assign()

2023-10-19 Thread Kirk True (Jira)
Kirk True created KAFKA-15651: - Summary: Investigate auto commit guarantees during Consumer.assign() Key: KAFKA-15651 URL: https://issues.apache.org/jira/browse/KAFKA-15651 Project: Kafka Issue

  1   2   3   >