Re: Speeding up integration tests

2019-04-01 Thread Damian Guy
Just to throw my 2c in here. It would also be good if we could run the tests that failed "last time" first. That way at least if they are broken then we'd fail fast rather than waiting for ever. Not much sucks more than waiting for 2 hours to find out a test failed when it fails regularly and you

Re: [VOTE] KIP-443: Return to default segment.ms and segment.index.bytes in Streams repartition topics

2019-03-29 Thread Damian Guy
+1 On Fri, 29 Mar 2019 at 01:59, John Roesler wrote: > +1 (nonbinding) from me. > > On Thu, Mar 28, 2019 at 7:08 PM Guozhang Wang wrote: > > > Hello folks, > > > > I'd like to directly start a voting thread on this simple KIP to change > the > > default override values for repartition topics:

Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-03-29 Thread Damian Guy
+1 On Wed, 27 Mar 2019 at 21:38, John Roesler wrote: > Ah, good point, Guozhang. I'll remove that mention from the KIP. > > On Wed, Mar 27, 2019 at 3:30 PM Bill Bejeck wrote: > > > +1 for me, > > > > Thanks, > > Bill > > > > On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang > wrote: > > > > > +1

Re: [ANNOUNCE] New Committer: Bill Bejeck

2019-02-13 Thread Damian Guy
Congratulations Bill! On Wed, 13 Feb 2019 at 16:51, Satish Duggana wrote: > Congratulations Bill! > > On Thu, Feb 14, 2019 at 6:41 AM Marcelo Barbosa > wrote: > > > > Wow! Congrats Bill! > > Cheers, > > Barbosa > > Em quarta-feira, 13 de fevereiro de 2019 23:03:54 BRST, Guozhang > Wang

Re: [VOTE] KIP-420: Add Single Value Fetch in Session Stores

2019-01-24 Thread Damian Guy
+1 On Wed, 23 Jan 2019 at 23:23, Guozhang Wang wrote: > Hello Matthias, > > Cool. I'd add it to the wiki page as well. > > > Guozhang > > On Sat, Jan 19, 2019 at 10:59 AM Matthias J. Sax > wrote: > > > Thanks for the KIP Guozhang! > > > > Would it make sense to add a default implementation for

Re: [VOTE] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-16 Thread Damian Guy
+1 On Wed, 16 Jan 2019 at 05:09, Patrik Kleindl wrote: > +1 (non-binding) > Thanks too > Best regards > Patrik > > > Am 16.01.2019 um 03:30 schrieb Bill Bejeck : > > > > Thanks for the KIP Matthias. > > > > +1 > > > > -Bill > > > > On Tue, Jan 15, 2019 at 7:33 PM Matthias J. Sax > > wrote: > >

Re: [VOTE] KIP-379: Multiple Consumer Group Management

2019-01-15 Thread Damian Guy
+1 (binding) thanks On Tue, 15 Jan 2019 at 09:43, Alex D wrote: > Hello guys, > > 2 votes from Jason, Gwen > Any binding votes? > > > Hello M Manna, > If migrating to JSON makes sense, you can post a new KIP for this purpose. > > Thanks, > Alex Dunayevsky > > On Tue, 15 Jan 2019, 04:24 Jason

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-11 Thread Damian Guy
+1 binding On Thu, 10 Jan 2019 at 16:57, Bill Bejeck wrote: > +1 from me. Great job on the KIP. > > -Bill > > On Thu, Jan 10, 2019 at 11:35 AM John Roesler wrote: > > > It's a +1 (nonbinding) from me as well. > > > > Thanks for sticking with this, Adam! > > -John > > > > On Wed, Jan 9, 2019

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-11 Thread Damian Guy
+1 On Fri, 11 Jan 2019 at 05:09, John Roesler wrote: > Hi Guozhang, > > It sounds reasonable to me. I'm +1 (nonbinding). > > -John > > On Tue, Jan 8, 2019 at 8:51 PM Guozhang Wang wrote: > > > Hello folks, > > > > I'd like to start a voting process for the following KIP: > > > > > > >

Re: [VOTE] [REMINDER] KIP-383 Pluggable interface for SSL Factory

2018-12-21 Thread Damian Guy
ras. > > > > -Original Message- > > From: Damian Guy [mailto:damian@gmail.com] > > Sent: Wednesday, December 19, 2018 7:38 AM > > To: dev > > Subject: Re: [VOTE] [REMINDER] KIP-383 Pluggable interface for SSL > Factory > > > > Hi Clement, >

Re: [VOTE] [REMINDER] KIP-383 Pluggable interface for SSL Factory

2018-12-19 Thread Damian Guy
Hi Clement, You should start a separate thread for the vote, i.e., one with a subject of [VOTE] KIP-383 ... Looks like you haven't done this? On Tue, 18 Dec 2018 at 17:33, Harsha wrote: > Yes. +1 binding. > > Thanks, > Harsha > > On Mon, Dec 17, 2018, at 5:21 AM, Pellerin, Clement wrote: > >

Re: Vote for KIP-393 (Fix time windowed serde to deserialize changelog topic)

2018-12-13 Thread Damian Guy
+1 (binding) On Wed, 12 Dec 2018 at 13:27, Adam Bellemare wrote: > +1 (non-binding) from me. Looks like a pretty clear-cut case. > > > > On Tue, Dec 11, 2018 at 1:11 AM Shawn Nguyen > wrote: > > > Thanks for the feedback Guozhang! I updated the KIP. > > > > In the meantime, could I ask for

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

2018-10-22 Thread Damian Guy
Thanks +1 binding On Sun, 7 Oct 2018 at 03:16, Chia-Ping Tsai wrote: > (just bump) > > We have following votes: > > non-binding > 1. John Roesler > 2. vito jeng > 3. Richard Yu > 4. Bill Bejeck > 5. Satish Duggana > > binding > 1. Matthias J. Sax > 2. Ismael Juma > > it needs one more ticket

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

2018-10-10 Thread Damian Guy
Hi Wladimir, Of the two approaches in the KIP - i feel the second approach is cleaner. However, am i correct in assuming that you want to have the `ConfiguredStreamsFactory` as a ctor arg in `StreamsConfig` so that Spring can inject this for you? Otherwise you could just put the

Re: [VOTE] KIP-302 - Enable Kafka clients to use all DNS resolved IP addresses

2018-09-24 Thread Damian Guy
Thanks +1 (binding) On Sun, 23 Sep 2018 at 23:43 Edoardo Comar wrote: > bumping the thread as the KIP needs 2 more binding votes ... pretty please > ... > -- > > Edoardo Comar > > IBM Event Streams > IBM UK Ltd, Hursley Park, SO21 2JN > > > > >

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-20 Thread Damian Guy
+1 (binding) On Tue, 18 Sep 2018 at 16:33 Bill Bejeck wrote: > All, > > In starting work on the PR for KIP-372, the Grouped interface needed some > method renaming to be more consistent with the other configuration classes > (Joined, Produced, etc.). As such I've updated the Grouped code

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-17 Thread Damian Guy
Thanks +1 (binding) On Sun, 16 Sep 2018 at 19:37 Nikolay Izhikov wrote: > Dear commiters, > > I got two binding +1 in [VOTE] thread for this KIP [1]. > I still need one more. > > Please, take a look at KIP. > > [1] >

Re: [VOTE] KIP-366 - Make FunctionConversations private

2018-09-14 Thread Damian Guy
+1 (binding) Thanks On Fri, 14 Sep 2018 at 10:00 Joan Goyeau wrote: > Ok so we have only one binding vote up to now. I guess we need at least 3 > binding votes. > > Thanks > > On Fri, 14 Sep 2018 at 09:59 Joan Goyeau wrote: > > > Matt, This is now all updated. > > > > On Fri, 7 Sep 2018 at

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

2018-09-03 Thread Damian Guy
+1 On Sun, 2 Sep 2018 at 15:20 Matthias J. Sax wrote: > +1 (binding) > > On 9/1/18 2:40 PM, Guozhang Wang wrote: > > +1 (binding). > > > > On Mon, Aug 27, 2018 at 5:20 PM, Dongjin Lee wrote: > > > >> +1 (non-binding) > >> > >> On Tue, Aug 28, 2018 at 8:53 AM Bill Bejeck wrote: > >> > >>> +1 >

Re: [VOTE] KIP-353: Allow Users to Configure Multi-Streams Timestamp Synchronization Behavior

2018-08-15 Thread Damian Guy
+1 On Tue, 14 Aug 2018 at 19:35 Ted Yu wrote: > +1 > Original message From: Bill Bejeck > Date: 8/14/18 11:09 AM (GMT-08:00) To: dev@kafka.apache.org Subject: > Re: [VOTE] KIP-353: Allow Users to Configure Multi-Streams Timestamp > Synchronization Behavior > +1 > > Thanks, >

Re: [VOTE] KIP-356: Add withCachingDisabled() to StoreBuilder

2018-08-15 Thread Damian Guy
+1 On Tue, 14 Aug 2018 at 22:58 Matthias J. Sax wrote: > +1 (binding) > > On 8/14/18 11:16 AM, Eno Thereska wrote: > > +1 (non binding) > > > > Thanks > > Eno > > > > On Tue, Aug 14, 2018 at 10:53 AM, Bill Bejeck wrote: > > > >> Thanks for the KIP. > >> > >> +1 > >> > >> -Bill > >> > >> On

Re: [VOTE] KIP-328: Ability to suppress updates for KTables

2018-08-03 Thread Damian Guy
Thanks John! +1 On Mon, 30 Jul 2018 at 23:58 Guozhang Wang wrote: > Yes, the addendum lgtm as well. Thanks! > > On Mon, Jul 30, 2018 at 3:34 PM, John Roesler wrote: > > > Another thing that came up after I started working on an implementation > is > > that in addition to deprecating

Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

2018-08-02 Thread Damian Guy
t;> >> If we want to improve on this situation with Optional, we'd need to do it >> on all of these functions. Also note that for `Source#toString()` and >> `Sink#toString()` we should only include the specified field in the >> resulted representation. >> >>

Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

2018-08-01 Thread Damian Guy
gt; Damian -- if we make that Optional, shouldn't the methods on Source also > be Optional types? > > -Ewen > > On Mon, Jul 30, 2018 at 11:13 PM Damian Guy wrote: > >> Hi Nishanth, >> >> I have one nit on the KIP. I think the topicNameExtractor method should

Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

2018-07-31 Thread Damian Guy
Hi Nishanth, I have one nit on the KIP. I think the topicNameExtractor method should return Optional rather than null. Sorry I'm late here. Thanks, Damian On Tue, 31 Jul 2018 at 01:14 Nishanth Pradeep wrote: > We need one more binding vote. > > Binding Votes: > >- Matthias J. Sax >-

Re: [ANNOUNCE] Apache Kafka 2.0.0 Released

2018-07-30 Thread Damian Guy
t; > > > > > > > Apache Kafka is in use at large and small companies worldwide, including > > Capital One, Goldman Sachs, ING, LinkedIn, Netflix, Pinterest, Rabobank, > > Target, The New York Times, Uber, Yelp, and Zalando, among others. > > > > > >

Re: [VOTE] KIP-313: Add KStream.flatTransform and KStream.flatTransformValues

2018-06-28 Thread Damian Guy
+1 On Mon, 25 Jun 2018 at 02:16 Matthias J. Sax wrote: > +1 (binding) > > > -Matthias > > On 6/22/18 10:25 AM, Bill Bejeck wrote: > > Thanks for the KIP, +1. > > > > -Bill > > > > On Fri, Jun 22, 2018 at 1:08 PM Ted Yu wrote: > > > >> +1 > >> > >> On Fri, Jun 22, 2018 at 2:50 AM, Bruno Cadonna

Re: [VOTE] KIP-330: Add retentionPeriod in SessionBytesStoreSupplier

2018-06-28 Thread Damian Guy
+1 On Thu, 28 Jun 2018 at 02:16 Ted Yu wrote: > +1 > > On Wed, Jun 27, 2018 at 4:40 PM, Bill Bejeck wrote: > > > +1 > > > > -Bill > > > > On Wed, Jun 27, 2018 at 7:39 PM Guozhang Wang > wrote: > > > > > Hello folks, > > > > > > I'd like to start a voting thread on KIP-330. I've intentionally

Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-28 Thread Damian Guy
+1 On Tue, 26 Jun 2018 at 17:22 Bill Bejeck wrote: > +1 > > On Mon, Jun 25, 2018 at 11:07 PM Matthias J. Sax > wrote: > > > +1 (binding) > > > > On 6/25/18 3:00 PM, Guozhang Wang wrote: > > > +1 > > > > > > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu wrote: > > > > > >> +1 > > >> > > >> On Mon,

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Damian Guy
+1 (binding) Thanks On Wed, 27 Jun 2018 at 18:50 Bill Bejeck wrote: > +1 > > -Bill > > On Wed, Jun 27, 2018 at 12:47 PM Manikumar > wrote: > > > +1 (non-binding) > > > > Thanks. > > > > On Wed, Jun 27, 2018 at 10:15 PM Matthias J. Sax > > wrote: > > > > > +1 (binding) > > > > > > On 6/26/18

Re: [VOTE] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

2018-06-25 Thread Damian Guy
Thanks Bill! +1 On Mon, 25 Jun 2018 at 18:57 Ted Yu wrote: > +1 > > On Mon, Jun 25, 2018 at 9:45 AM, Guozhang Wang wrote: > > > +1. > > > > On Mon, Jun 25, 2018 at 8:12 AM, Matthias J. Sax > > wrote: > > > > > +1 (binding) > > > > > > On 6/25/18 6:11 AM, Bill Bejeck wrote: > > > > All, > > >

Re: [DISCUSS] KIP-313: Add KStream.flatTransform and KStream.flatTransformValues

2018-06-11 Thread Damian Guy
Thanks for the KIP. LGTM On Mon, 11 Jun 2018 at 00:44 Matthias J. Sax wrote: > Thanks for the KIP. > > I don't have any comments at this pint. Overall I am +1 on the KIP. > > > -Matthias > > On 6/8/18 2:56 PM, Bruno Cadonna wrote: > > Hi list, > > > > I created KIP-313 [1] for JIRA issue

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2018-05-31 Thread Damian Guy
Hi Florian, Thanks for the KIP. What about KTable and other DSL interfaces? Will they not want to be able to do the same thing? It would be good to see a complete set of the public API changes. Cheers, Damian On Wed, 30 May 2018 at 19:45 Guozhang Wang wrote: > Hello Florian, > > Thanks for

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-22 Thread Damian Guy
+1 On Tue, 22 May 2018 at 00:12, Gwen Shapira wrote: > Recasting my +1 > > On Mon, May 21, 2018 at 3:38 PM, Guozhang Wang wrote: > > > Thanks Matthias, will do. > > > > On Mon, May 21, 2018 at 3:35 PM, Matthias J. Sax > > wrote: >

Re: [VOTE] KIP-255: OAuth Authentication via SASL/OAUTHBEARER

2018-05-21 Thread Damian Guy
+1 (binding) Thanks On Mon, 21 May 2018 at 04:59 Ron Dagostino wrote: > Hi Committers. One more binding affirmative vote is required if KIP 255 > is to have a chance of being included in the 2.0.0 release. Please vote > today. > > Ron > > > On May 18, 2018, at 9:27 PM, Ron

Re: [VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-21 Thread Damian Guy
+1 (binding) On Sat, 19 May 2018 at 03:51 Piyush Vijay wrote: > Hi everyone, > > I would like to start a vote for > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-290%3A+Support+for+wildcard+suffixed+ACLs > . > > The KIP proposes a way to support

Re: [VOTE] KIP-277 - Fine Grained ACL for CreateTopics API

2018-05-21 Thread Damian Guy
+1 (binding) Thanks On Mon, 21 May 2018 at 11:26 Edoardo Comar wrote: > Hi, KIP freeze is tomorrow. Anyone else would like to cast their vote ? > > voting so far : > binding: Guozhang, Rajini > non-binding: Ted, Stephane, Vahid, Colin, Manikumar, Matt > > On 18 May 2018 at

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Damian Guy
Thanks Guozhang. +1 Note: the link to the KIP is broken On Thu, 17 May 2018 at 11:38 Guozhang Wang wrote: > Hello folks, > > I'd like to start a voting thread on adding dynamic routing functionality > in Streams sink node. Please find a KIP here: > >

Re: [DISCUSS] KIP-303: Add Dynamic Routing in Streams Sink

2018-05-17 Thread Damian Guy
as > of now since they will be subsumed soon? > > > Guozhang > > > On Wed, May 16, 2018 at 2:59 PM, Damian Guy <damian@gmail.com> wrote: > >> Overall i'm a +1 on this, but i'm not a big fan of using the >> KeyValueMapper >> to choose the topic. It is a bi

Re: [DISCUSS] KIP-303: Add Dynamic Routing in Streams Sink

2018-05-16 Thread Damian Guy
Overall i'm a +1 on this, but i'm not a big fan of using the KeyValueMapper to choose the topic. It is a bit counter-intuitve to me. I'd prefer to add a class specifically for it and possibly pass in the RecordContext On Wed, 16 May 2018 at 13:22 Guozhang Wang wrote: > Hello

Re: [VOTE] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

2018-05-16 Thread Damian Guy
+1 On Tue, 15 May 2018 at 15:04, Ted Yu wrote: > +1 > Original message From: Guozhang Wang > Date: 5/15/18 2:34 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: > [VOTE] KIP-295: Add Streams Configuration Allowing for Optional

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

2018-05-15 Thread Damian Guy
Thanks. +1 (binding) On Tue, 15 May 2018 at 01:04 Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > @Guozhang added. Thanks! > > El mar., 15 may. 2018 a las 5:50, Matthias J. Sax ( >) > escribió: > > > +1 (binding) > > > > Thanks a lot for the KIP! > > > >

Re: [VOTE] KIP-292: Add KTable#transformValues() method in Kafka Streams DSL

2018-05-14 Thread Damian Guy
+1 On Fri, 11 May 2018 at 14:30 Matthias J. Sax wrote: > +1 (binding) > > > On 5/11/18 2:17 PM, Ted Yu wrote: > > +1 > > > > On Fri, May 11, 2018 at 2:16 PM, Guozhang Wang > wrote: > > > >> +1 (binding) > >> > >> Also slightly changed the title beyond

Re: [VOTE] KIP-206: Add support for UUID serialization and deserialization

2018-05-11 Thread Damian Guy
+1 (binding) On Fri, 4 May 2018 at 08:55 Rajini Sivaram wrote: > Hi Brandon, > > +1 (binding) > > Thanks for the KIP! > > Regards, > > Rajini > > On Fri, May 4, 2018 at 2:14 PM, Brandon Kirchner < > brandon.kirch...@gmail.com > > wrote: > > > I'd like to resurrect this

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Damian Guy
sofmer.init() / > > > > process() to be able to access N stores, with N stores specified with > > the > > > > stateStoreNames, but not the one specified in materialized.name()? > > > > Personally I think it should be the case as the materialized store > >

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-08 Thread Damian Guy
Initially i thought materializing a store would be overkill, but from a consistency point of view it makes sense to add an overload that takes a `Materialized` and only create the store if that is supplied. On Sun, 6 May 2018 at 17:52 Matthias J. Sax wrote: > Andy, > >

Re: [VOTE] KIP-276 Add StreamsConfig prefix for different consumers

2018-04-25 Thread Damian Guy
Thanks +1 On Fri, 20 Apr 2018 at 23:41 Bill Bejeck wrote: > +1 > > Thanks, > Bill > > On Thu, Apr 19, 2018 at 9:50 AM, Boyang Chen wrote: > > > Thanks guys! > > > > Sent from my iPhone > > > > > On Apr 19, 2018, at 8:28 PM, Matthias J. Sax

Re: [VOTE] KIP-279: Fix log divergence between leader and follower after fast leader fail over

2018-04-15 Thread Damian Guy
Thanks Anna +1 On Sun, 15 Apr 2018 at 15:40, Guozhang Wang wrote: > Anna, thanks for the KIP! +1 from me. > > Just one minor comment: `Broker A will respond with offset 11`, seems it > should be `21`. > > On Sun, Apr 15, 2018 at 3:48 AM, Dong Lin wrote:

Re: [VOTE] KIP-270 A Scala wrapper library for Kafka Streams

2018-04-12 Thread Damian Guy
Thanks for the KIP Debasish - +1 binding On Wed, 11 Apr 2018 at 12:16 Ted Yu wrote: > +1 > Original message From: Debasish Ghosh < > debasish.gh...@lightbend.com> Date: 4/11/18 3:09 AM (GMT-08:00) To: > dev@kafka.apache.org Subject: [VOTE] KIP-270 A Scala

Re: [VOTE] KIP-284 Set default retention ms for Streams repartition topics to Long.MAX_VALUE

2018-04-10 Thread Damian Guy
+1 binding On Mon, 9 Apr 2018 at 21:20 Guozhang Wang wrote: > +1 (binding) > > On Mon, Apr 9, 2018 at 11:21 AM, Matthias J. Sax > wrote: > > > +1 (binding) > > > > -Matthias > > > > On 4/9/18 8:57 AM, Bill Bejeck wrote: > > > Thanks for the KIP. > > >

Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-05 Thread Damian Guy
+1 On Thu, 5 Apr 2018 at 01:56 Matthias J. Sax wrote: > +1 (binding) on the latest proposal. > > > -Matthias > > > On 4/2/18 12:10 PM, Richard Yu wrote: > > +1 > > > > On Mon, Apr 2, 2018 at 8:42 AM, Guozhang Wang > wrote: > > > >> +1 (binding). > >>

Re: Subject: [VOTE] 1.1.0 RC3

2018-03-21 Thread Damian Guy
t; > > > Given that Windows is not an officially supported platform, and the > > exceptions with Linux/Java 9 are not breaking the functionality, my vote > > is a +1 (non-binding). > > > > Thanks. > > --Vahid > > > > > >

Re: [VOTE] KIP-268: Simplify Kafka Streams Rebalance Metadata Upgrade

2018-03-21 Thread Damian Guy
+1 On Wed, 21 Mar 2018 at 01:44 abel-sun wrote: > >Thanks you of your offer ,agree with you! > > On 2018/03/21 00:56:11, Richard Yu wrote: > > Hi Matthias, > > Thanks for setting up the upgrade path. > > > > +1 (non-binding) > > > >

Re: Subject: [VOTE] 1.1.0 RC3

2018-03-18 Thread Damian Guy
> exceptions with Linux/Java 9 are not breaking the functionality, my vote > is a +1 (non-binding). > > Thanks. > --Vahid > > > > > From: Damian Guy <damian@gmail.com> > To: dev@kafka.apache.org, us...@kafka.apache.org, > kafka-clie..

Re: [DISCUSS] KIP-270 A Scala wrapper library for Kafka Streams

2018-03-16 Thread Damian Guy
Hi Debasish, Thanks for the KIP - will be a great addition to streams. I've only had a quick scan, but seeing as the Scala classes are going to be in their own package could we drop the S at the end of the class names? Thanks, Damian On Fri, 16 Mar 2018 at 15:25 Debasish Ghosh

Subject: [VOTE] 1.1.0 RC3

2018-03-15 Thread Damian Guy
Hello Kafka users, developers and client-developers, This is the fourth candidate for release of Apache Kafka 1.1.0. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75957546 A few highlights: * Significant Controller improvements (much faster and session expiration edge cases

Re: [VOTE] 1.1.0 RC2

2018-03-15 Thread Damian Guy
gt; Ran tests > > Ran a 3 node cluster to test basic operations. > > > > Thanks, > > Harsha > > > > On Wed, Mar 14, 2018, at 9:04 AM, Ted Yu wrote: > > > +1 > > > > > > Ran test suite - passed (apart from testMetricsLeak which is flaky). &

Re: [VOTE] 1.1.0 RC2

2018-03-14 Thread Damian Guy
t; Hi Damian, > > Given release plan link in earlier mail is about 1.0 release. You may > want > > to replace that with 1.1.0 release plan link[1]. > > > > 1 - https://cwiki.apache.org/confluence/pages/viewpage. > > action?pageId=75957546 > > > > Thanks,

[VOTE] 1.1.0 RC2

2018-03-13 Thread Damian Guy
Hello Kafka users, developers and client-developers, This is the third candidate for release of Apache Kafka 1.1.0. This is minor version release of Apache Kakfa. It Includes 29 new KIPs. Please see the release plan for more details:

Re: [VOTE] KIP-267: Add Processor Unit Test Support to Kafka Streams Test Utils

2018-03-12 Thread Damian Guy
+1 On Fri, 9 Mar 2018 at 21:30, Matthias J. Sax wrote: > Guozhang, renaming the class is an internal change and I think it's not > required to cover it in the KIP. > > > +1 (binding) > > > -Matthias > > On 3/9/18 1:26 PM, Guozhang Wang wrote: > > Hi John, > > > > You

Re: Want to contribute

2018-03-09 Thread Damian Guy
Hi Sanket, Done. Thanks, Damian On Fri, 9 Mar 2018 at 14:56 Sanket Band <band.sanke...@gmail.com> wrote: > Hi Damian, Matthias > > Could you add me to the KAFKA project on jira, my jira id is sband > > Thanks > Sanket > > On Fri, 9 Mar 2018, 20:23 Damian Guy

Re: Want to contribute

2018-03-09 Thread Damian Guy
Hi Eduardo, There are usually JIRAs that have the newbie label. This would be a good place to start. Cheers, Damian On Fri, 9 Mar 2018 at 13:57 Eduardo Mello wrote: > Hello, > I want to begin to code for open sources projects in my free time and I > want to help the

Re: [VOTE] 1.1.0 RC1

2018-03-09 Thread Damian Guy
gt;. As 3.4.12 isn't > released yet, it might be better to have 3.4.10 included instead. > > Jeff > Heroku > > > On Tue, Mar 6, 2018 at 1:19 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > +1 > > > > Checked signature > > Ran test suite - apart from fl

Re: [VOTE] KIP-265: Make Windowed Serde to public APIs

2018-03-08 Thread Damian Guy
Thanks Guozhang +1 On Tue, 6 Mar 2018 at 00:26 Hu Xi wrote: > +1 (non-binding) > > > 发件人: Matthias J. Sax > 发送时间: 2018年3月6日 8:19 > 收件人: dev@kafka.apache.org > 主题: Re: [VOTE] KIP-265: Make Windowed Serde to public APIs

[VOTE] 1.1.0 RC1

2018-03-06 Thread Damian Guy
: https://builds.apache.org/job/kafka-1.1-jdk7/68 System tests: https://jenkins.confluent.io/job/system-test-kafka/job/1.1/30/ /** Thanks, Damian Guy

Re: [kafka-clients] Re: [VOTE] 1.1.0 RC0

2018-03-02 Thread Damian Guy
d also be useful to include KAFKA-6111, which prevents >> deleteLogDirEventNotifications >> path to be deleted correctly from Zookeeper. The patch should be committed >> later today. >> >> Thanks, >> >> Jun >> >> On Thu, Mar 1, 2018 at 1:47 P

Re: [DISCUSS] KIP-265: Make Windowed Serde to public APIs

2018-03-02 Thread Damian Guy
Thanks Guozhang, LGTM On Fri, 2 Mar 2018 at 03:00 Hu Xi wrote: > Guozhang, > > > Thanks for this KIP. Please help confirm questions below: > > 1. Do we also need to retrofit `SimpleConsumerShell` to have it > support these newly-added serdes? > 2. Does this KIP

Re: [VOTE] 1.1.0 RC0

2018-03-01 Thread Damian Guy
Thanks Jason. Assuming the system tests pass i'll cut RC1 tomorrow. Thanks, Damian On Thu, 1 Mar 2018 at 19:10 Jason Gustafson <ja...@confluent.io> wrote: > The fix has been merged to 1.1. > > Thanks, > Jason > > On Wed, Feb 28, 2018 at 11:35 AM, Damian Guy <

Re: [VOTE] 1.1.0 RC0

2018-02-28 Thread Damian Guy
>> at > > >> > > >> org.apache.kafka.connect.runtime.standalone.StandaloneHerder. > > putConnectorConfig(StandaloneHerder.java:164) > > >> > > >> at > > >> > > >> org.apache.kafka.connect.cli.ConnectStandalone.main( >

Re: [VOTE] KIP-261: Add Single Value Fetch in Window Stores

2018-02-24 Thread Damian Guy
Thanks Guozhang! +1 On Sat, 24 Feb 2018 at 19:12 Ted Yu wrote: > +1 > > On Sat, Feb 24, 2018 at 11:10 AM, Guozhang Wang > wrote: > > > Hi all, > > > > I want to start voting on KIP-261 to add a new API for window stores in > > order to optimize our

[VOTE] 1.1.0 RC0

2018-02-24 Thread Damian Guy
Hello Kafka users, developers and client-developers, This is the first candidate for release of Apache Kafka 1.1.0. This is minor version release of Apache Kakfa. It Includes 29 new KIPs. Please see the release plan for more details:

Re: [DISCUSS] KIP-261: Add Single Value Fetch in Window Stores

2018-02-23 Thread Damian Guy
Thanks Guozhang. +1 On Thu, 22 Feb 2018 at 23:44 Guozhang Wang wrote: > Thanks Ted, have updated the wiki page. > > On Thu, Feb 22, 2018 at 1:48 PM, Ted Yu wrote: > > > +1 > > > > There were some typos: > > CachingWindowedStore -> CachingWindowStore > >

Re: [VOTE] 1.0.1 RC2

2018-02-23 Thread Damian Guy
+1 Built src and ran tests Ran streams quickstart On Thu, 22 Feb 2018 at 21:32 Ted Yu wrote: > +1 > > MetricsTest#testMetricsLeak failed but it is flaky test > > On Wed, Feb 21, 2018 at 4:06 PM, Ewen Cheslack-Postava > wrote: > > > Hello Kafka users,

[jira] [Resolved] (KAFKA-6577) Connect standalone SASL file source and sink test fails without explanation

2018-02-22 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy resolved KAFKA-6577. --- Resolution: Fixed Fix Version/s: 1.2.0 Issue resolved by pull request 4610 [https://github.com

Re: 1.1 release progress

2018-02-19 Thread Damian Guy
Hi, A quick update on the 1.1 release. I'm in the process of generating RC0, but I'm waiting to get a passing system test build before pushing. Stay tuned! Thanks, Damian On Fri, 16 Feb 2018 at 09:49 Damian Guy <damian@gmail.com> wrote: > Hi Becket, > > Thanks for

Re: 1.1 release progress

2018-02-16 Thread Damian Guy
just created another ticket KAFKA-6568, which I believe should also > > be > > > a > > > > blocker unless people disagree. > > > > > > > > Thanks, > > > > > > > > Jiangjie (Becket) Qin > > >

Re: 1.1 release progress

2018-02-14 Thread Damian Guy
. Hopefully before the end of the week. Regards, Damian On Mon, 5 Feb 2018 at 18:04 Damian Guy <damian@gmail.com> wrote: > Hi all, > > We are just over a week away from code freeze. We currently have 44 issues > in progress and 3 open blockers: > https://issues.apache.or

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-02-09 Thread Damian Guy
Thanks Matthias, +1 On Fri, 9 Feb 2018 at 02:42 Ted Yu wrote: > +1 > Original message From: "Matthias J. Sax" < > matth...@confluent.io> Date: 2/8/18 6:05 PM (GMT-08:00) To: > dev@kafka.apache.org Subject: [VOTE] KIP-251: Allow timestamp > manipulation in

1.1 release progress

2018-02-05 Thread Damian Guy
Hi all, We are just over a week away from code freeze. We currently have 44 issues in progress and 3 open blockers: https://issues.apache.org/jira/projects/KAFKA/versions/12339769 If you have something that is in progress that is not going to make it into 1.1 can you please move it to a future

New release branch 1.1

2018-02-01 Thread Damian Guy
Hello Kafka developers and friends, We now have a release branch for the 1.1 release (with 1.1.0 as the version). Trunk has been bumped to 1.2.0-SNAPSHOT. I'll be going over the JIRAs to move every non-blocker from this release to the next release. >From this point, most changes should go to

[jira] [Resolved] (KAFKA-6378) NullPointerException on KStream-GlobalKTable leftJoin when KeyValueMapper returns null

2018-01-31 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy resolved KAFKA-6378. --- Resolution: Fixed Fix Version/s: 1.1.0 Issue resolved by pull request 4424 [https://github.com

1.1 release progress

2018-01-26 Thread Damian Guy
Hi, Just a quick updated on the 1.1 release. Feature freeze is on the 30th of January, so please ensure any major features have been merged and that any minor features have PRs by this time. We currently have 57 issues in progress and 117 todo:

Re: 1.1 KIPs

2018-01-25 Thread Damian Guy
che.org/msg84851.html > > Thanks for running the release. > --Vahid > > > > > From: Damian Guy <damian@gmail.com> > To: dev@kafka.apache.org > Date: 01/24/2018 01:20 PM > Subject:Re: 1.1 KIPs > > > > Hi, > > The KIP deadline has pass

Re: 1.1 KIPs

2018-01-24 Thread Damian Guy
sure any major features have been committed by then. Thanks, Damian On Tue, 23 Jan 2018 at 15:29 Damian Guy <damian@gmail.com> wrote: > Hi, > > Today is the KIP deadline. Tomorrow I'll update the release page with any > KIPS that have recently been voted on and

Re: 1.1 KIPs

2018-01-23 Thread Damian Guy
, Damian On Thu, 18 Jan 2018 at 12:47 Damian Guy <damian@gmail.com> wrote: > Gentle reminder that KIP deadline is just 5 days away. If there is > anything that wants to be in 1.1 and hasn't been voted on yet, now is the > time! > > On Thu, 18 Jan 2018 at 08:49 Damian Guy

Re: [VOTE] KIP-208: Add SSL support to Kafka Connect REST interface

2018-01-19 Thread Damian Guy
Thanks Jakub! +1 (binding) On Thu, 18 Jan 2018 at 23:49 Jakub Scholz wrote: > Hi all, > > We still need at least 2 more binding +1s. I think that the PR ( > https://github.com/apache/kafka/pull/4429) is shaping good. If we get the > votes, we should be able to make the 1.1.0

Re: 1.1 KIPs

2018-01-18 Thread Damian Guy
Gentle reminder that KIP deadline is just 5 days away. If there is anything that wants to be in 1.1 and hasn't been voted on yet, now is the time! On Thu, 18 Jan 2018 at 08:49 Damian Guy <damian@gmail.com> wrote: > Hi Xavier, > I'll add it to the plan. > > Thanks, > Dami

Re: [VOTE] KIP-247: Add public test utils for Kafka Streams

2018-01-18 Thread Damian Guy
+1 On Thu, 18 Jan 2018 at 15:14 Bill Bejeck wrote: > Thanks for the KIP. > > +1 > > -Bill > > On Wed, Jan 17, 2018 at 9:09 PM, Matthias J. Sax > wrote: > > > Hi, > > > > I would like to start the vote for KIP-247: > >

Re: [ANNOUNCE] New Kafka PMC Member: Rajini Sivaram

2018-01-18 Thread Damian Guy
Congratulations Rajini! On Thu, 18 Jan 2018 at 00:57 Hu Xi wrote: > Congratulations, Rajini Sivaram. Very well deserved! > > > > 发件人: Konstantine Karantasis > 发送时间: 2018年1月18日 6:23 > 收件人: dev@kafka.apache.org >

Re: 1.1 KIPs

2018-01-18 Thread Damian Guy
6, 2018 at 5:13 AM Damian Guy <damian@gmail.com> wrote: > > > Hi, > > > > This is a reminder that we have one week left until the KIP deadline of > Jan > > 23. There are still some KIPs that are under discussion and/or being > voted > > on.

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

2018-01-16 Thread Damian Guy
Thanks for the KIP! +1 On Sat, 13 Jan 2018 at 12:30 Boyang Chen wrote: > Hey Matt and Guozhang, > > > I have already updated the pull request: > https://github.com/apache/kafka/pull/4354 > > and the KIP: >

1.1 KIPs

2018-01-16 Thread Damian Guy
Hi, This is a reminder that we have one week left until the KIP deadline of Jan 23. There are still some KIPs that are under discussion and/or being voted on. Please keep in mind that the voting needs to be complete before the deadline for the KIP to be added to the release.

Re: [ANNOUNCE] New committer: Matthias J. Sax

2018-01-12 Thread Damian Guy
Congrats Matthias! Very well deserved On Sat, 13 Jan 2018 at 00:57, Bill Bejeck <bbej...@gmail.com> wrote: > Congratulations Matthias! > > -Bill > > On Fri, Jan 12, 2018 at 7:43 PM, Damian Guy <damian@gmail.com> wrote: > > > Can't think of anyone me

Re: [ANNOUNCE] New committer: Matthias J. Sax

2018-01-12 Thread Damian Guy
Can't think of anyone me deserving! Congratulations Matthias! On Sat, 13 Jan 2018 at 00:17, Ismael Juma wrote: > Congratulations Matthias! > > On 12 Jan 2018 10:59 pm, "Guozhang Wang" wrote: > > > Hello everyone, > > > > The PMC of Apache Kafka is pleased

[DISCUSS] February Release Plan

2018-01-12 Thread Damian Guy
Hi all, I would like to volunteer to be the release manager for our next time-based feature release (v1.1.0). See https://cwiki.apache.org/ confluence/display/KAFKA/Time+Based+Release+Plan if you missed previous communication on time-based releases or need a reminder. I put together a draft

[jira] [Resolved] (KAFKA-6412) Improve synchronization in CachingKeyValueStore methods

2018-01-10 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy resolved KAFKA-6412. --- Resolution: Fixed Fix Version/s: 1.1.0 Issue resolved by pull request 4372 [https://github.com

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2018-01-09 Thread Damian Guy
+1 On Wed, 3 Jan 2018 at 03:49 Matthias J. Sax wrote: > It must be two different names, as we add two processor to the topology: > a source processor that only read the data from a topic, and the actual > processor that maintains the global table. > > > -Matthias > > On

Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable

2017-12-21 Thread Damian Guy
+1 On Wed, 20 Dec 2017 at 21:09 Ted Yu wrote: > Ping for more (binding) votes. > > The pull request is ready. > > On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang > wrote: > > > +1 (binding), thanks! > > > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu

Re: [VOTE] KIP-220: Add AdminClient into Kafka Streams' ClientSupplier

2017-12-19 Thread Damian Guy
gt; > > > > > > > > Guozhang > > > > > > > > > > > > > > > On Mon, Nov 20, 2017 at 11:12 AM, Guozhang Wang <wangg...@gmail.com> > > wrote: > > > > > >> +1 from myself as well. > > >> &g

[jira] [Created] (KAFKA-6360) RocksDB segments not removed when store is closed causes re-initialization to fail

2017-12-13 Thread Damian Guy (JIRA)
Damian Guy created KAFKA-6360: - Summary: RocksDB segments not removed when store is closed causes re-initialization to fail Key: KAFKA-6360 URL: https://issues.apache.org/jira/browse/KAFKA-6360 Project

  1   2   3   4   5   6   7   8   >