[DISCUSS] KIP-623: Add "internal-topics" option to streams application reset tool

2020-06-24 Thread Joel Wee
Hi all I would like to start a vote for KIP-623, which adds the option --internal-topics to the streams-application-reset-tool: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862177. Please let me know what you think. Best Joel

Re: [DISCUSS] KIP-623: Add "internal-topics" option to streams application reset tool

2020-06-12 Thread Joel Wee Hotmail
Hi Bruce Thank you for the comments. I agree with 1 and 3 and have updated the KIP. 2. Yes, the user needs to execute the script twice. Once with `--dry-run` and once without. There are no confirmation prompts when executing without `--dry-run`. I have updated the KIP to make this clearer.

Re: [DISCUSS] KIP-623: Add "internal-topics" option to streams application reset tool

2020-06-12 Thread Bruno Cadonna
Hi Joel, Thank you for the KIP. The KIP is well motivated. I have a couple comments: 1. I would not describe the new option with Java code that you want to add to the `StreamsResetter` class since this class is not part of the public API. Only the script kafka-streams-application-reset.sh in

Re: [DISCUSS] KIP-623: Add "internal-topics" option to streams application reset tool

2020-06-12 Thread Joel Wee Hotmail
Thanks Boyang, that’s helpful! Have made the changes and updated the KIP now. Joel > On 11 Jun 2020, at 5:38 PM, Boyang Chen wrote: > > Thanks for the KIP Joel! Some quick questions and suggestions: > > 1. The KIP links to a wrong JIRA, which should be >

Re: [DISCUSS] KIP-623: Add "internal-topics" option to streams application reset tool

2020-06-11 Thread Boyang Chen
Thanks for the KIP Joel! Some quick questions and suggestions: 1. The KIP links to a wrong JIRA, which should be https://issues.apache.org/jira/browse/KAFKA-6435 2. Typo: *deletes all topic that *-> *deletes all topics that* 3. We need to explain in the Motivation section that we want to

[DISCUSS] KIP-623: Add "internal-topics" option to streams application reset tool

2020-06-10 Thread Joel Wee
Hi all I would like to start the discussion for KIP-623 which proposes adding an “internal-topics” option to the streams application reset tool: https://cwiki.apache.org/confluence/x/YQt4CQ Thanks Joel