Thanks.
Here is the PR for this catch: https://github.com/apache/kafka/pull/14187
On Thu, 10 Aug 2023 at 19:04, Matthias J. Sax wrote:
> Good catch about the JavaDocs.
>
> Seems we missed to update them when we did K10277. Would you like to do
> a PR to fix them right away for upcoming 3.6
Good catch about the JavaDocs.
Seems we missed to update them when we did K10277. Would you like to do
a PR to fix them right away for upcoming 3.6 release?
If there is no more other comments, I think you can start a VOTE thread.
-Matthias
On 8/10/23 4:22 AM, Florin Akermann wrote:
Thank
Thank you for the feedback.
> Not sure if this is the right phrasing?
You are right. I adjusted the phrasing accordingly.
Given your description of the current behavior, do I understand correctly
that the current documentation for the left join KStream-GlobalKtable is
out of date?
Thanks for the KIP.
left join KStream-GlobalTable: no longer drop left records with null-key and
call KeyValueMapper with 'null' for left key. The case where KeyValueMapper
returns null is already handled in the current implementation.
Not sure if this is the right phrasing? In the end,
Hi All,
I added a remark about the repartition of null-key records.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-962%3A+Relax+non-null+key+requirement+in+Kafka+Streams#KIP962:RelaxnonnullkeyrequirementinKafkaStreams-Repartitionofnull-keyrecords
Can we relax this constraint for any kind
Hi Lucas,
Thanks. I added the point about the upgrade guide as well.
Florin
On Mon, 7 Aug 2023 at 11:06, Lucas Brutschy
wrote:
> Hi Florin,
>
> thanks for the KIP! This looks good to me. I agree that the precise
> Java doc wording doesn't have to be discussed as part of the KIP.
>
> I would
Hi Florin,
thanks for the KIP! This looks good to me. I agree that the precise
Java doc wording doesn't have to be discussed as part of the KIP.
I would also suggest to include an update to
https://kafka.apache.org/documentation/streams/upgrade-guide
Cheers,
Lucas
On Mon, Aug 7, 2023 at 10:51
Hi Both,
Thanks.
I added remarks to account for this.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-962%3A+Relax+non-null+key+requirement+in+Kafka+Streams#KIP962:RelaxnonnullkeyrequirementinKafkaStreams-Remarks
In short, let's add a note in the Java docs? The exact wording of the note
I'm just thinking we can try to encourage users to migrate from XX to
XXWithKey in the docs, giving this as one good example that the latter
can help you distinguish different scenarios whereas the former
cannot.
On Fri, Aug 4, 2023 at 6:32 PM Matthias J. Sax wrote:
>
> Guozhang,
>
> thanks for
Guozhang,
thanks for pointing out ValueJoinerWithKey. In the end, it's just a
documentation change, ie, point out that the passed in key could be
`null` and similar?
-Matthias
On 8/2/23 3:20 PM, Guozhang Wang wrote:
Thanks Florin for the writeup,
One quick thing I'd like to bring up is
Thanks Florin for the writeup,
One quick thing I'd like to bring up is that in KIP-149
(https://cwiki.apache.org/confluence/display/KAFKA/KIP-149%3A+Enabling+key+access+in+ValueTransformer%2C+ValueMapper%2C+and+ValueJoiner)
we introduced ValueJoinerWithKey which is aimed to enhance
ValueJoiner.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-962%3A+Relax+non-null+key+requirement+in+Kafka+Streams
12 matches
Mail list logo
