Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Hi Jun, Good catch! The new configuration is indeed compression.zstd.level instead of compression.snappy.level. I've updated the KIP. Thanks, Mickael On Wed, Feb 21, 2024 at 7:38 PM Jun Rao wrote: > > Hi, Mickael, > > Thanks for the updated KIP. > > There is a typo. The KIP says that it adds a

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Hi, Mickael, Thanks for the updated KIP. There is a typo. The KIP says that it adds a new option compression.snappy.level, but later says that Snappy is excluded. Otherwise, the changes look good to me. Jun On Wed, Feb 7, 2024 at 6:40 AM Mickael Maison wrote: > Hi Divij, > > Thanks for

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

m: Mickael Maison > Sent: Wednesday, February 7, 2024 6:40 AM > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-390: Support Compression Level (rebooted) > > Hi Divij, > > Thanks for bringing that point. After reading KIP-984, I don't think it > supersedes KIP-390/KIP-780. Bein

RE: [VOTE] KIP-390: Support Compression Level (rebooted)

list but I will update the KIP -984 accordingly as well. Assane -Original Message- From: Mickael Maison Sent: Wednesday, February 7, 2024 6:40 AM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-390: Support Compression Level (rebooted) Hi Divij, Thanks for bringing that point. After

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Sounds good. I am onboard to start with first steps and eventually move towards a place where compression codec settings are more generic / pluggable. -- Divij Vaidya On Wed, Feb 7, 2024 at 3:40 PM Mickael Maison wrote: > Hi Divij, > > Thanks for bringing that point. After reading KIP-984, I

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Hi Divij, Thanks for bringing that point. After reading KIP-984, I don't think it supersedes KIP-390/KIP-780. Being able to tune the built-in codecs would directly benefit many users. It may also cover some scenarios that motivated KIP-984 without requiring users to write a custom codec. I've not

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Hey Mickael Since this KIP was written, we have a new proposal to make the compression completely pluggable https://cwiki.apache.org/confluence/display/KAFKA/KIP-984%3A+Add+pluggable+compression+interface+to+Kafka. If we implement that KIP, would it supersede the need for adding fine grain

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Hi, I'm resurrecting this old thread as this KIP would be a nice improvement and almost 3 years later the PR for this KIP has still not been merged! The reason is that during reviews we noticed the proposed configuration, compression.level, was not easy to use as each codec has its own valid

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

This KIP is now passed with: - binding: +3 (Ismael, Tom, Konstantine) - non-binding: +1 (Ryanne) Thanks again to all the supporters. I also updated the KIP by moving the compression buffer option into the 'Future Works' section, as Ismael proposed. Best, Dongjin On Fri, Jun 11, 2021 at 3:03

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Makes sense. Looks like a good improvement. Thanks for including the evaluation in the proposal Dongjin. +1 (binding) Konstantine On Wed, Jun 9, 2021 at 6:59 PM Dongjin Lee wrote: > Thanks Ismel, Tom and Ryanne, > > I am now updating the KIP about the further works. Sure, You won't be >

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Thanks Ismel, Tom and Ryanne, I am now updating the KIP about the further works. Sure, You won't be disappointed. As of Present: - binding: +2 (Ismael, Tom) - non-binding: +1 (Ryanne) Anyone else? Best, Dongjin On Thu, Jun 10, 2021 at 2:03 AM Tom Bentley wrote: > Hi Dongjin, > > Thanks for

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Hi Dongjin, Thanks for the KIP, +1 (binding). Kind regards, Tom On Wed, Jun 9, 2021 at 5:16 PM Ismael Juma wrote: > I'm +1 on the proposed change. As I stated in the discuss thread, I don't > think we should rule out the buffer size config, but we could list that as > future work vs rejected

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

I'm +1 on the proposed change. As I stated in the discuss thread, I don't think we should rule out the buffer size config, but we could list that as future work vs rejected alternatives. Ismael On Sat, Jun 5, 2021 at 2:37 PM Dongjin Lee wrote: > Hi all, > > I'd like to open a voting thread for

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

Bumping up the voting thread. Please note that today is the KIP freeze day. +1 non-binding until now. Thanks, Dongjin On Sun, Jun 6, 2021 at 11:47 PM Ryanne Dolan wrote: > +1 (non-binding), thanks! > > Ryanne > > On Sat, Jun 5, 2021, 4:37 PM Dongjin Lee wrote: > > > Hi all, > > > > I'd like

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

+1 (non-binding), thanks! Ryanne On Sat, Jun 5, 2021, 4:37 PM Dongjin Lee wrote: > Hi all, > > I'd like to open a voting thread for KIP-390: Support Compression Level > (rebooted): > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Support+Compression+Level > > Best, > Dongjin

[VOTE] KIP-390: Support Compression Level (rebooted)

Hi all, I'd like to open a voting thread for KIP-390: Support Compression Level (rebooted): https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Support+Compression+Level Best, Dongjin -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: