Re: [VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-10-24 Thread ShunKang Lin
Hi everyone, Thanks Luke. I have submitted a PR https://github.com/apache/kafka/pull/12545, please take a look. Best, ShunKang Luke Chen 于2022年10月24日周一 09:56写道: > Hi ShunKang, > Yes, this vote can be concluded. > You can start to implement it. > > Thanks. > Luke > > > On Fri, Oct 21, 2022 at

Re: [VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-10-23 Thread Luke Chen
Hi ShunKang, Yes, this vote can be concluded. You can start to implement it. Thanks. Luke On Fri, Oct 21, 2022 at 9:45 PM ShunKang Lin wrote: > Hi everyone, > > Thank you for the vote. I've got three +1 votes (Guozhang, Luke, Chris), > can this vote be concluded? > > Best, > ShunKang > >

Re: [VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-10-21 Thread ShunKang Lin
Hi everyone, Thank you for the vote. I've got three +1 votes (Guozhang, Luke, Chris), can this vote be concluded? Best, ShunKang Chris Egerton 于2022年10月12日周三 23:17写道: > +1 (binding) > Thanks ShunKang! > > On Tue, Oct 11, 2022 at 9:26 PM Luke Chen wrote: > > > +1 from me. > > Thanks for the

Re: [VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-10-12 Thread Chris Egerton
+1 (binding) Thanks ShunKang! On Tue, Oct 11, 2022 at 9:26 PM Luke Chen wrote: > +1 from me. > Thanks for the KIP. > > Luke > > On Fri, Sep 23, 2022 at 1:50 AM Guozhang Wang wrote: > > > +1, thanks ShunKang. > > > > Though its proposed motivation is on consumer fetcher's deserialization, > I >

Re: [VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-10-11 Thread Luke Chen
+1 from me. Thanks for the KIP. Luke On Fri, Sep 23, 2022 at 1:50 AM Guozhang Wang wrote: > +1, thanks ShunKang. > > Though its proposed motivation is on consumer fetcher's deserialization, I > think adding an overloaded method with ByteBuffer would help with other > serde places on the client

Re: [VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread Guozhang Wang
+1, thanks ShunKang. Though its proposed motivation is on consumer fetcher's deserialization, I think adding an overloaded method with ByteBuffer would help with other serde places on the client side as well. Guozhang On Thu, Sep 22, 2022 at 9:41 AM ShunKang Lin wrote: > Hi everyone, > > I'd

[VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread ShunKang Lin
Hi everyone, I'd like to open the vote for KIP-863, which proposes to reduce memory allocation and memory copying in Fetcher#parseRecord(TopicPartition, RecordBatch, Record). The proposal is here: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=225152035 Thanks to all who