[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224394#comment-14224394
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Updated reviewboard https://reviews.apache.org/r/27634/diff/
against branch origin/trunk
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch, KAFKA-1667_2014-11-07_14:28:14.patch,
KAFKA-1667_2014-11-12_12:49:11.patch, KAFKA-1667_2014-11-16_18:31:34.patch,
KAFKA-1667_2014-11-16_18:33:10.patch, KAFKA-1667_2014-11-25_12:03:56.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213977#comment-14213977
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Updated reviewboard https://reviews.apache.org/r/27634/diff/
against branch origin/trunk
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch, KAFKA-1667_2014-11-07_14:28:14.patch,
KAFKA-1667_2014-11-12_12:49:11.patch, KAFKA-1667_2014-11-16_18:31:34.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213978#comment-14213978
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Updated reviewboard https://reviews.apache.org/r/27634/diff/
against branch origin/trunk
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch, KAFKA-1667_2014-11-07_14:28:14.patch,
KAFKA-1667_2014-11-12_12:49:11.patch, KAFKA-1667_2014-11-16_18:31:34.patch,
KAFKA-1667_2014-11-16_18:33:10.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212477#comment-14212477
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Bump. Anyone willing to review?
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch, KAFKA-1667_2014-11-07_14:28:14.patch,
KAFKA-1667_2014-11-12_12:49:11.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207957#comment-14207957
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Updated reviewboard https://reviews.apache.org/r/27634/diff/
against branch origin/trunk
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch, KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch, KAFKA-1667_2014-11-07_14:28:14.patch,
KAFKA-1667_2014-11-12_12:49:11.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207968#comment-14207968
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Can't assign issue to myself. Get an exception when running
kafka-patch-review.py.
{code}jira.exceptions.JIRAError: HTTP 400: Field 'assignee' cannot be set. It
is not on the appropriate screen, or unknown{code}
Also don't have Assign to me button in JIRA.
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch, KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch, KAFKA-1667_2014-11-07_14:28:14.patch,
KAFKA-1667_2014-11-12_12:49:11.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207668#comment-14207668
]
Gwen Shapira commented on KAFKA-1667:
-
btw. [~edio], you probably want to assign the JIRA to yourself, and click on
submit patch so this will be more visible as something that needs review +
commit.
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch, KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch, KAFKA-1667_2014-11-07_14:28:14.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202026#comment-14202026
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Updated reviewboard https://reviews.apache.org/r/27634/diff/
against branch origin/trunk
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch, KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch, KAFKA-1667_2014-11-07_14:28:14.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200370#comment-14200370
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Updated reviewboard https://reviews.apache.org/r/27634/diff/
against branch origin/trunk
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch, KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200381#comment-14200381
]
Dmytro Kostiuchenko commented on KAFKA-1667:
The main issue with the old patch was handling {{Properties}} defaults.
When properties were passed to {{fromProps(Properties)}} method, {{Properties}}
object has been exposed as a {{Map}}. {{Map.get()}}, though is implemented in
{{Hashtable}} and thus knows nothing about {{Properties}} defaults. Fixed that,
added few trivial tests to check general correctness.
There is an impact on the client code though: boolean values are now parsed via
{{Boolean.parseBoolean}} throwing no exception but instead falling back to
{{false}} for invalid input.
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch, KAFKA-1667_2014-11-05_19:43:53.patch,
KAFKA-1667_2014-11-06_17:10:14.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198212#comment-14198212
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Hi. I'm willing to work on this.
Currently I have few questions:
# What should be of a higher priority: keeping same interface for LogConfig or
making code consistent with other configs based on ConfigDef? In the latter
case changes would also impact AdminUtils, TopicCommand and perhaps some other
classes.
# Are there any guidelines to assigning priorities?
# Is there some place to check for valid ranges for properties? It is always
possible to induce them from the code, but would be easier, of course, to have
some reference doc.
Thanks
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198533#comment-14198533
]
Jun Rao commented on KAFKA-1667:
For now, we can probably just keep LogConfig and add the validation in
LogConfig.fromProps(). Later on, we can change all broker side configs
(KafkaConfig, ZKConfig, TopicConfig) to use ConfigDef together.
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198614#comment-14198614
]
Jun Rao commented on KAFKA-1667:
If you already started on converting LogConfig to ConfigDef, that's fine too.
To start with, I will assign medium importance to all those topic level config
properties.
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198637#comment-14198637
]
Dmytro Kostiuchenko commented on KAFKA-1667:
As suggested on mailing list, moving discussion to JIRA.
Currently I have an initial patch, which seems to work. I would like to know,
whether overall code is ok. Also there are few TODOs in the
code
# I haven't added documentation to the properties, as {{ConfigDef}} suggests.
Should I?
# I'm not sure what Importance should be assigned to properties. It is
{{MEDIUM}} for all properties. Where can I find some info on this?
# Not totally sure, that validations are correct. Tried to figure that out from
the code, still might miss something.
Please, find the patch attached.
Thanks
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198663#comment-14198663
]
Gwen Shapira commented on KAFKA-1667:
-
Can you load the patch to RB too? It makes reviewing and commenting much easier.
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198670#comment-14198670
]
Gwen Shapira commented on KAFKA-1667:
-
I think we can do better validations. For example:
.define(MinCleanableDirtyRatioProp, DOUBLE, Defaults.MinCleanableDirtyRatio,
atLeast(0), MEDIUM, )
Can be:
.define(MinCleanableDirtyRatioProp, DOUBLE, Defaults.MinCleanableDirtyRatio,
between(0,1), MEDIUM, )
Since its a ratio.
Once you have RB, I can add more detail for other configs.
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198829#comment-14198829
]
Dmytro Kostiuchenko commented on KAFKA-1667:
Updated reviewboard https://reviews.apache.org/r/27634/diff/
against branch origin/trunk
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
Attachments: KAFKA-1667.patch, KAFKA-1667_2014-11-05_19:43:53.patch
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182253#comment-14182253
]
Jun Rao commented on KAFKA-1667:
The server side already has a dependency on clients. So, we can start using
ConfigDef on the broker side as well.
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1667) topic-level configuration not validated
[
https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161318#comment-14161318
]
Gwen Shapira commented on KAFKA-1667:
-
Looks like LogConfig has very few validations.
I think it makes sense to refactor it to use either ConfigDef (actually part of
the client code, but has really nice validators) or at least
ValidatedProperties instead of just Properties - and then we can add proper
validation for each config.
Any thoughts on whether ConfigDef can be used in the server, or if we should
keep on using ValidatedProperties?
topic-level configuration not validated
Key: KAFKA-1667
URL: https://issues.apache.org/jira/browse/KAFKA-1667
Project: Kafka
Issue Type: Bug
Affects Versions: 0.8.1.1
Reporter: Ryan Berdeen
Labels: newbie
I was able to set the configuration for a topic to these invalid values:
{code}
Topic:topic-config-test PartitionCount:1ReplicationFactor:2
Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol
{code}
It seems that the values are saved as long as they are the correct type, but
are not validated like the corresponding broker-level properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
