RE: Re: [DISCUSS] KIP-904 Kafka Streams - Guarantee subtractor is called before adder if key has not changed

2023-02-26 Thread Fq Public
I have started the voting thread here: https://lists.apache.org/thread/pn846910dovg3d0z3k8pmq5opj0tb9w5 Please vote :) Thanks, Farooq On 2023/02/23 07:27:14 "Matthias J. Sax" wrote: > Thanks for the KIP. Overall LGTM. > > I think you can start a VOTE. > > > -Matthias > > On 2/22/23 5:56

Re: [DISCUSS] KIP-904 Kafka Streams - Guarantee subtractor is called before adder if key has not changed

2023-02-22 Thread Matthias J. Sax
Thanks for the KIP. Overall LGTM. I think you can start a VOTE. -Matthias On 2/22/23 5:56 PM, Fq Public wrote: Just wanted to bump this thread for visbility. Thanks to everyone who has participated in the discussion so far. Thanks, Farooq On 2023/02/14 19:32:53 Guozhang Wang wrote: Thanks

RE: Re: Re: [DISCUSS] KIP-904 Kafka Streams - Guarantee subtractor is called before adder if key has not changed

2023-02-22 Thread Fq Public
Just wanted to bump this thread for visbility. Thanks to everyone who has participated in the discussion so far. Thanks, Farooq On 2023/02/14 19:32:53 Guozhang Wang wrote: > Thanks Farooq, that looks good to me. > > Guozhang > > On Sun, Feb 12, 2023 at 9:01 AM Dharin Shah wrote: > > > >

Re: Re: [DISCUSS] KIP-904 Kafka Streams - Guarantee subtractor is called before adder if key has not changed

2023-02-14 Thread Guozhang Wang
Thanks Farooq, that looks good to me. Guozhang On Sun, Feb 12, 2023 at 9:01 AM Dharin Shah wrote: > > Hello Farooq, > > This is actually a great idea, we have dealt with this by using an array > instead of a set. > +1 to this :) > > Thank you, > Dharin > > On Sun, Feb 12, 2023 at 8:11 PM Fq

Re: Re: [DISCUSS] KIP-904 Kafka Streams - Guarantee subtractor is called before adder if key has not changed

2023-02-12 Thread Dharin Shah
Hello Farooq, This is actually a great idea, we have dealt with this by using an array instead of a set. +1 to this :) Thank you, Dharin On Sun, Feb 12, 2023 at 8:11 PM Fq Public wrote: > Hi Guozhang, > > Thanks for reading over my proposal! > > > Regarding the format, I'm just thinking if we

RE: Re: [DISCUSS] KIP-904 Kafka Streams - Guarantee subtractor is called before adder if key has not changed

2023-02-12 Thread Fq Public
Hi Guozhang, Thanks for reading over my proposal! > Regarding the format, I'm just thinking if we can change the type of "INT > newDataLength" to UINT32? Good idea, I've updated the KIP to reflect UINT32 since it makes clear the value can never be less than zero. > `.equals` default

Re: [DISCUSS] KIP-904 Kafka Streams - Guarantee subtractor is called before adder if key has not changed

2023-02-07 Thread Guozhang Wang
Hello Farooq, Thanks for the very detailed proposal! I think this is a great idea. Just a few thoughts: 1. I regret that we over-optimized the Changed serde format for footprint while making it less extensible. It seems to me that a two rolling bounce migration is unavoidable.. Regarding the