---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/#review80620
---
Thanks for the patch. Sorry for the late review. A few comments
Ah, gotcha. Given that, I think I made the right adjustment. Thanks for the
clarification!
On Sun, Aug 10, 2014 at 10:38 PM, Guozhang Wang guw...@linkedin.com wrote:
On Aug. 10, 2014, 9:12 p.m., Jonathan Natkins wrote:
core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 114
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/
---
(Updated Aug. 11, 2014, 6:03 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/#review50264
---
Looks good to me. Can other committers double-check it?
- Guozhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/#review50126
---
core/src/test/scala/unit/kafka/admin/AdminTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/#review50137
---
Thanks for the patch. One comment below.
On Aug. 10, 2014, 9:12 p.m., Jonathan Natkins wrote:
core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 114
https://reviews.apache.org/r/24006/diff/3-4/?file=646111#file646111line114
I wasn't totally sure I understood this comment, so I made a change
that I think reflects
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/#review50060
---
Ship it!
Looks good to me, just a couple minor comments below.
On Aug. 1, 2014, 9:27 p.m., Guozhang Wang wrote:
core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 134
https://reviews.apache.org/r/24006/diff/3/?file=646111#file646111line134
What I was actually thinking is that probably we can define these two
variables at the top of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/#review49382
---
core/src/test/scala/unit/kafka/admin/AdminTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/
---
(Updated July 30, 2014, 6:18 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/
---
(Updated July 30, 2014, 6:24 p.m.)
Review request for kafka.
Bugs:
On July 30, 2014, 12:22 a.m., Guozhang Wang wrote:
core/src/test/scala/unit/kafka/admin/AdminTest.scala, line 314
https://reviews.apache.org/r/24006/diff/1/?file=643839#file643839line314
Is there a specific reason we want to use 10 seconds instead of default
5 seconds?
Sorry,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/#review49139
---
core/src/test/scala/unit/kafka/admin/AdminTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/#review49049
---
core/src/test/scala/unit/kafka/admin/AdminTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/
---
Review request for kafka.
Bugs: KAFKA-1420
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24006/
---
(Updated July 28, 2014, 8:52 p.m.)
Review request for kafka.
Bugs:
17 matches
Mail list logo
