Re: Use of a formatter like Scalafmt

2018-05-10 Thread Joan Goyeau
> > > > > If we don't want to do a big bang commit then I'm thinking we might > > want > > > to > > > > make it gradually by applying it module by module? > > > > This is one idea do you have any other? > > > > > > > > I know fo

Re: Use of a formatter like Scalafmt

2018-05-09 Thread Jeff Widman
make it gradually by applying it module by module? > > > This is one idea do you have any other? > > > > > > I know formatting sounds like the useless thing that doesn't matter > and I > > > totally agree with this, that's why I don't want to care about it w

Re: Use of a formatter like Scalafmt

2018-05-09 Thread Ismael Juma
s > > > > On Thu, 10 May 2018 at 00:15 Ted Yu <yuzhih...@gmail.com> wrote: > > > >> Applying the tool across code base would result in massive changes. > >> How would this be handled ? > >> Original message From: Joan Goyeau <j...@goyeau.

Re: Use of a formatter like Scalafmt

2018-05-09 Thread Matthias J. Sax
l message From: Joan Goyeau <j...@goyeau.com> >> Date: 5/9/18 3:31 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Use >> of a formatter like Scalafmt >> Hi, >> >> Contributing to Kafka Streams' Scala API, I've been kinda lost on how >> shoul

Re: Use of a formatter like Scalafmt

2018-05-09 Thread Joan Goyeau
lt;j...@goyeau.com> > Date: 5/9/18 3:31 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Use > of a formatter like Scalafmt > Hi, > > Contributing to Kafka Streams' Scala API, I've been kinda lost on how > should I format my code. > I know formatting is the start of religion

Re: Use of a formatter like Scalafmt

2018-05-09 Thread Ted Yu
Applying the tool across code base would result in massive changes. How would this be handled ? Original message From: Joan Goyeau <j...@goyeau.com> Date: 5/9/18 3:31 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Use of a formatter like Scalafmt Hi, Contributing to

Use of a formatter like Scalafmt

2018-05-09 Thread Joan Goyeau
Hi, Contributing to Kafka Streams' Scala API, I've been kinda lost on how should I format my code. I know formatting is the start of religion wars but personally I have no preference at all. I just want consistency across the codebase, no unnecessary formatting diffs in PRs and offload the