Re: Version alignment report for Karaf 4.2.3-SNAPSHOT - 1/2

2019-01-08 Thread Grzegorz Grzybek
Hello wt., 8 sty 2019 o 20:08 Benjamin Graf napisał(a): > Hi Grzegorz, > > is there a reason why the plugin goal for generateConsistencyReport does > not filter the features that were chosen in custom distributions? Using > the report that way generates many "false friends" that are actually

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread Jean-Baptiste Onofré
No, as the example just works fine: the etc/startup.properties is populated and the distribution starts without problem. Regards JB On 09/01/2019 06:37, James Carman wrote: > We should likely update the example? > >

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread James Carman
We should likely update the example? https://github.com/apache/karaf/blob/master/examples/karaf-maven-example/karaf-maven-example-assembly/pom.xml On Wed, Jan 9, 2019 at 12:02 AM Jean-Baptiste Onofré wrote: > Hi James, > > I wasn't clear sorry. You need the framework features (in addition of

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread Jean-Baptiste Onofré
By the way, I just check startup from the assembly archetype (which use the karaf-assembly packaging) and the startup.properties is correctly generated. Regards JB On 08/01/2019 20:50, James Carman wrote: > When I change the kar scope to "provided", I get: > > Failed to execute goal >

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread Jean-Baptiste Onofré
Hi James, I wasn't clear sorry. You need the framework features (in addition of kar) with runtime scope. I also see that the install kar is not performed by the karaf-assembly. I created a PR on your project fixing the issues. Anyway, it confirms what I sent some weeks ago: creating a custom

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread James Carman
When I change the kar scope to "provided", I get: Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.2.2:assembly (default-assembly) on project custom-karaf-example: Unable to build assembly: Can't determine framework to use (framework, framework-logback, static-framework,

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread Jean-Baptiste Onofré
Exactly, the scope should be provided ;) Regards JB On 08/01/2019 19:11, James Carman wrote: > On Tue, Jan 8, 2019 at 12:59 PM Jean-Baptiste Onofré > wrote: > >> Hi James, >> >> no the startup.properties is generated by the plugin, using the scope. >> So, karaf framework kar is probably

Re: Version alignment report for Karaf 4.2.3-SNAPSHOT - 1/2

2019-01-08 Thread Benjamin Graf
Hi Grzegorz, is there a reason why the plugin goal for generateConsistencyReport does not filter the features that were chosen in custom distributions? Using the report that way generates many "false friends" that are actually not needed to resolve. Maybe it should also interact with more than

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread James Carman
On Tue, Jan 8, 2019 at 12:59 PM Jean-Baptiste Onofré wrote: > Hi James, > > no the startup.properties is generated by the plugin, using the scope. > So, karaf framework kar is probably missing in your project. > > You mean this?

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread Jean-Baptiste Onofré
Hi James, no the startup.properties is generated by the plugin, using the scope. So, karaf framework kar is probably missing in your project. I can take a look if you want. Regards JB On 08/01/2019 18:09, James Carman wrote: > But, that begs the question, should we really have to do that? Is

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread James Carman
But, that begs the question, should we really have to do that? Is something wrong with the plugin that it isn't copying the "standard" startup.properties file from the base distro? On Tue, Jan 8, 2019 at 11:56 AM James Carman wrote: > That got it working for me. Thanks, Johan! > > > On Tue,

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread James Carman
That got it working for me. Thanks, Johan! On Tue, Jan 8, 2019 at 11:55 AM Johan Edstrom wrote: > I compared to a 4.2.2, > it is missing startup.properties in the generation. > > Adding; > > # Bundles to be started on startup, with startlevel >

Re: Custom Distribution Hangs on Startup...

2019-01-08 Thread Johan Edstrom
I compared to a 4.2.2, it is missing startup.properties in the generation. Adding; # Bundles to be started on startup, with startlevel mvn\:org.apache.karaf.features/org.apache.karaf.features.extension/4.2.2 = 1 mvn\:org.apache.felix/org.apache.felix.metatype/1.2.2 = 5

Custom Distribution Hangs on Startup...

2019-01-08 Thread James Carman
I am trying to create a custom distribution: https://github.com/jwcarman/custom-karaf-example/tree/vanilla When I cd into the target/assembly directory and do: bin/karaf the logs stop after this: Jan 08, 2019 11:11:01 AM org.apache.karaf.main.Main launch INFO: Installing and starting initial

Re: Version alignment report for Karaf 4.2.3-SNAPSHOT - 2/2

2019-01-08 Thread Grzegorz Grzybek
Hello With https://github.com/apache/karaf/commit/80d4a7fcf126d8dd33f365c0b32bb93550c2f2e3 I've added "consistency" profile. With this profile, assemblies/apache-karaf artifact will have 3 additional attached artifacts: $ ll total 42632 -rw-rw-r--+ 1 ggrzybek ggrzybek 113553 01-08 15:38

Re: Enterprise Feature Repository Causing Invalid Custom Distribution...

2019-01-08 Thread Jean-Baptiste Onofré
And I have some more documentation to do ;) Regards JB On 08/01/2019 15:21, James Carman wrote: > Oh, guess I have some reading to do! Thanks, JB! > On Tue, Jan 8, 2019 at 8:29 AM Jean-Baptiste Onofré wrote: > >> It's already possible via cap/req in features (as we do in Pax Web for >>

Re: Enterprise Feature Repository Causing Invalid Custom Distribution...

2019-01-08 Thread James Carman
Oh, guess I have some reading to do! Thanks, JB! On Tue, Jan 8, 2019 at 8:29 AM Jean-Baptiste Onofré wrote: > It's already possible via cap/req in features (as we do in Pax Web for > instance). > > Regards > JB > > On 08/01/2019 13:50, James Carman wrote: > > I see the changes in the ActiveMQ to

Re: Enterprise Feature Repository Causing Invalid Custom Distribution...

2019-01-08 Thread Jean-Baptiste Onofré
It's already possible via cap/req in features (as we do in Pax Web for instance). Regards JB On 08/01/2019 13:50, James Carman wrote: > I see the changes in the ActiveMQ to make it more “open” (didn’t know that > was what it’s called). I like that much better. Too bad we can’t declare a >

Re: Version alignment report for Karaf 4.2.3-SNAPSHOT - 1/2

2019-01-08 Thread Grzegorz Grzybek
For now, I can enable the report to generate into assembles/apache-karaf/target - I'm not sure how to expose it from Jenkins... We can always attach these files as deployable maven artifacts and they'll go to Maven Central ;) regards Grzegorz wt., 8 sty 2019 o 13:36 Andrea Cosentino napisał(a):

Version alignment report for Karaf 4.2.3-SNAPSHOT - 2/2

2019-01-08 Thread Grzegorz Grzybek
Hello again First (tl;dr), we can do this now in etc/org.apache.karaf.features.xml: (thanks to https://issues.apache.org/jira/browse/KARAF-5376) - we can "override" not only a version, but also groupId / artifactId. Here's a list of _duplicates_ that should rather be resolved, to have

Re: Enterprise Feature Repository Causing Invalid Custom Distribution...

2019-01-08 Thread James Carman
I see the changes in the ActiveMQ to make it more “open” (didn’t know that was what it’s called). I like that much better. Too bad we can’t declare a requirement on another repository and not a full import. Perhaps we can enhance the feature repository format to allow for that? On Tue, Jan 8, 2019

Re: How to Install Spring 4.3.21 on Karaf 4.2.2

2019-01-08 Thread Jean-Baptiste Onofré
Hi, you have to register the spring-legacy features repo: feature:repo-add spring-legacy spring features repo only provides latest Spring version. Previous Spring versions are provided by the spring-legacy features repo. Regards JB On 08/01/2019 13:28, Sai Sankar wrote: > Hi Team > > From

Re: Enterprise Feature Repository Causing Invalid Custom Distribution...

2019-01-08 Thread Jean-Baptiste Onofré
Hi James, I guess you mean "open" features (where features repo are used at runtime) compared to "close" features (where features repo uses inner ). The approach also depends of your deployment option. For instance: 1. when I'm using Karaf as a runtime, where I install several applications,

Re: Version alignment report for Karaf 4.2.3-SNAPSHOT - 1/2

2019-01-08 Thread Andrea Cosentino
I think a Jenkins profile is really a good idea. Great! -- Andrea Cosentino  -- Apache Camel PMC Chair Apache Karaf Committer Apache Servicemix PMC Member Email: ancosen1...@yahoo.com Twitter: @oscerd2 Github: oscerd On Tuesday, January 8, 2019, 1:34:35 PM

How to Install Spring 4.3.21 on Karaf 4.2.2

2019-01-08 Thread Sai Sankar
Hi Team >From the page https://karaf.apache.org/news.html , the latest karaf 4.2.2 supports Spring 4.3.21 too along with spring 5. But when i installed karaf 4.2.2, by default i am able to see only Spring 5.0.10 and 5.1. 3 only but my project needs spring 4.3.21. How can i get the spring

Re: Apache Karaf Pom Missing from Maven Central

2019-01-08 Thread Jean-Baptiste Onofré
Hi Eric, you are right, but I think I have a quick fix for 4.2.2 ;) Let me update that. Regards JB On 08/01/2019 13:10, Eric Lilja wrote: > Hi JB and thanks for your continued work on this! I guess it has only been > fixed for the upcoming 4.2.3, because 4.2.2 is still "broken" in this >

Re: Version alignment report for Karaf 4.2.3-SNAPSHOT - 1/2

2019-01-08 Thread Jean-Baptiste Onofré
Nice Greg. What do you think about enabling this report via Jenkins (using a profile) ? Regards JB On 08/01/2019 13:28, Grzegorz Grzybek wrote: > Hello > > For any custom Karaf distro we can enable generation of "consistency > report" - check sample here: >

Version alignment report for Karaf 4.2.3-SNAPSHOT - 1/2

2019-01-08 Thread Grzegorz Grzybek
Hello For any custom Karaf distro we can enable generation of "consistency report" - check sample here: http://people.apache.org/~ggrzybek/bundle-report-full-karaf.xml (requires browser that can do XSLT transformation using ) it can be configured using: org.apache.karaf.tooling

Re: Apache Karaf Pom Missing from Maven Central

2019-01-08 Thread Eric Lilja
Hi JB and thanks for your continued work on this! I guess it has only been fixed for the upcoming 4.2.3, because 4.2.2 is still "broken" in this regard. Any way to publish the missing POM for 4.2.2 posthumously so to speak? On Tue, Jan 8, 2019 at 6:13 AM Jean-Baptiste Onofré wrote: > Hi guys, >

Re: Enterprise Feature Repository Causing Invalid Custom Distribution...

2019-01-08 Thread James Carman
I’m really not a big fan of features files pulling in karaf feature repository files. We avoid that at work and just have our features files refer to other features by name only (no versions and no repositories). That’s a more controlled environment, of course. What’s the “best practice” for the