We should likely update the example? https://github.com/apache/karaf/blob/master/examples/karaf-maven-example/karaf-maven-example-assembly/pom.xml
On Wed, Jan 9, 2019 at 12:02 AM Jean-Baptiste Onofré <[email protected]> wrote: > Hi James, > > I wasn't clear sorry. You need the framework features (in addition of > kar) with runtime scope. > > I also see that the install kar is not performed by the karaf-assembly. > > I created a PR on your project fixing the issues. > > Anyway, it confirms what I sent some weeks ago: creating a custom > distribution is not as simple as it should. I will simplify this. > > Regards > JB > > On 08/01/2019 20:50, James Carman wrote: > > When I change the kar scope to "provided", I get: > > > > Failed to execute goal > > org.apache.karaf.tooling:karaf-maven-plugin:4.2.2:assembly > > (default-assembly) on project custom-karaf-example: Unable to build > > assembly: Can't determine framework to use (framework, framework-logback, > > static-framework, static-framework-logback, custom). Please specify valid > > "framework" option or add Maven dependency with "kar" type and "compile" > > scope for one of standard Karaf KARs. > > > > I have updated the example I linked above to reflect the change. Did I > do > > something wrong? > > > > On Tue, Jan 8, 2019 at 2:24 PM Jean-Baptiste Onofré <[email protected]> > wrote: > > > >> Exactly, the scope should be provided ;) > >> > >> Regards > >> JB > >> > >> On 08/01/2019 19:11, James Carman wrote: > >>> On Tue, Jan 8, 2019 at 12:59 PM Jean-Baptiste Onofré <[email protected]> > >>> wrote: > >>> > >>>> Hi James, > >>>> > >>>> no the startup.properties is generated by the plugin, using the scope. > >>>> So, karaf framework kar is probably missing in your project. > >>>> > >>>> > >>> You mean this? > >>> > >>> > >> > https://github.com/jwcarman/custom-karaf-example/blob/vanilla/pom.xml#L18 > >>> > >> > >> -- > >> Jean-Baptiste Onofré > >> [email protected] > >> http://blog.nanthrax.net > >> Talend - http://www.talend.com > >> > > > > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com >
