Re: [PROPOSAL] - Jenkins build
Hi, So basically, it means creating a build pipeline per build job. It sounds good to me. I think it makes sense to do that for master and PR build. I can do the changes once Karaf 4.2.1 is out. Thanks Regards JB On 31/07/2018 06:48, Francois Papon wrote: > Hi, > > With the new livecycle of JDK releases (9,10,11,GraalVM..), I think we > could add some JDK dedicated build on the Jenkins like this : > > https://builds.apache.org/job/maven-box/job/maven-pdf-plugin/job/master/ > > Now that we have some examples include in the itests, it's more > convenient to have a check of the JDK compatibility. > > Thoughts ? > > regards, > -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
[PROPOSAL] - Jenkins build
Hi, With the new livecycle of JDK releases (9,10,11,GraalVM..), I think we could add some JDK dedicated build on the Jenkins like this : https://builds.apache.org/job/maven-box/job/maven-pdf-plugin/job/master/ Now that we have some examples include in the itests, it's more convenient to have a check of the JDK compatibility. Thoughts ? regards, -- François Papon fpa...@apache.org
Re: JUnit test failure when playing with time zones
Thanks for the report. AFAIR, we already did a couple of fixes around that. Let me check. Regards JB On 30/07/2018 17:36, Lukasz Lech wrote: > Hello, > > After pulling master of apache/karaf I've noticed test failure. Under Linux > it fails in Audit :: Core : > > [ERROR] testFileSize(org.apache.karaf.audit.logger.EventLoggerTest) Time > elapsed: 0.118 s <<< FAILURE! > java.lang.AssertionError: expected:<[file-2017-11-17-2.log, > file-2017-11-17.log, file.log]> but was:<[file-2017-11-18-2.log, > file-2017-11-18.log, file.log]> > at > org.apache.karaf.audit.logger.EventLoggerTest.testFileSize(EventLoggerTest.java:230) > > I've forgotten that I've played with my time zone and set it to New Zealand > (in order to test our application if it deals correctly with > non-central-european time zones). After switching to CEST the tests run > correctly, however, being in CEST I'm now in the same day as GMT. I'm not > sure if Java somehow 'know' that time zone set by timedatectl is not my > 'real' time zone (for example, by saving original timezone somewhere during > installation) and the problem would not occur for people that are really in > New Zealand, but I feel that Junit tests shouldn't fail because of such > configuration. > > Could someone from that region (or working very late) check if the test fail > always when GMT shows other day than local time? > > Btw. On Windows build fails (it was always failing, but anytime in other > place). This time in : > [ERROR] Errors: > [ERROR] ProfilesTest.testProfilesApi:75 ▒ IllegalArgument character to be > escaped is m... > (Profile :: Core) > > Best regards, > Lukasz Lech > -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
JUnit test failure when playing with time zones
Hello, After pulling master of apache/karaf I've noticed test failure. Under Linux it fails in Audit :: Core : [ERROR] testFileSize(org.apache.karaf.audit.logger.EventLoggerTest) Time elapsed: 0.118 s <<< FAILURE! java.lang.AssertionError: expected:<[file-2017-11-17-2.log, file-2017-11-17.log, file.log]> but was:<[file-2017-11-18-2.log, file-2017-11-18.log, file.log]> at org.apache.karaf.audit.logger.EventLoggerTest.testFileSize(EventLoggerTest.java:230) I've forgotten that I've played with my time zone and set it to New Zealand (in order to test our application if it deals correctly with non-central-european time zones). After switching to CEST the tests run correctly, however, being in CEST I'm now in the same day as GMT. I'm not sure if Java somehow 'know' that time zone set by timedatectl is not my 'real' time zone (for example, by saving original timezone somewhere during installation) and the problem would not occur for people that are really in New Zealand, but I feel that Junit tests shouldn't fail because of such configuration. Could someone from that region (or working very late) check if the test fail always when GMT shows other day than local time? Btw. On Windows build fails (it was always failing, but anytime in other place). This time in : [ERROR] Errors: [ERROR] ProfilesTest.testProfilesApi:75 ▒ IllegalArgument character to be escaped is m... (Profile :: Core) Best regards, Lukasz Lech
