[GitHub] [knox] pzampino commented on a change in pull request #358: KNOX-2395 - Make Gateway Services Pluggable

2020-07-09 Thread GitBox
pzampino commented on a change in pull request #358: URL: https://github.com/apache/knox/pull/358#discussion_r452261472 ## File path: gateway-server/src/main/java/org/apache/knox/gateway/services/factory/RemoteRegistryClientServiceFactory.java ## @@ -26,20 +26,26 @@ import or

[GitHub] [knox] pzampino commented on a change in pull request #358: KNOX-2395 - Make Gateway Services Pluggable

2020-07-09 Thread GitBox
pzampino commented on a change in pull request #358: URL: https://github.com/apache/knox/pull/358#discussion_r452234789 ## File path: gateway-server/src/main/java/org/apache/knox/gateway/services/factory/AliasServiceFactory.java ## @@ -44,22 +41,17 @@ public Service create(Gat

[GitHub] [knox] pzampino commented on a change in pull request #358: KNOX-2395 - Make Gateway Services Pluggable

2020-07-08 Thread GitBox
pzampino commented on a change in pull request #358: URL: https://github.com/apache/knox/pull/358#discussion_r451717422 ## File path: gateway-release/home/conf/gateway-site.xml ## @@ -18,6 +18,11 @@ limitations under the License. --> + +gateway.services Review

[GitHub] [knox] pzampino commented on a change in pull request #358: KNOX-2395 - Make Gateway Services Pluggable

2020-07-08 Thread GitBox
pzampino commented on a change in pull request #358: URL: https://github.com/apache/knox/pull/358#discussion_r451614042 ## File path: gateway-release/home/conf/gateway-site.xml ## @@ -18,6 +18,11 @@ limitations under the License. --> + +gateway.services Review

[GitHub] [knox] pzampino commented on a change in pull request #358: KNOX-2395 - Make Gateway Services Pluggable

2020-07-08 Thread GitBox
pzampino commented on a change in pull request #358: URL: https://github.com/apache/knox/pull/358#discussion_r451583820 ## File path: gateway-release/home/conf/gateway-site.xml ## @@ -18,6 +18,11 @@ limitations under the License. --> + +gateway.services Review