zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708239236
##
File path:
gateway-service-remoteconfig/src/test/java/org/apache/knox/gateway/service/config/remote/zk/RemoteConfigurationRegistryClientServiceTestBase.java
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708239012
##
File path:
gateway-server/src/test/java/org/apache/knox/gateway/services/security/impl/ZookeeperRemoteAliasServiceTest.java
##
@@ -96,6 +96,8 @@ public
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708238645
##
File path:
gateway-provider-ha/src/test/java/org/apache/knox/gateway/ha/provider/impl/KafkaZookeeperURLManagerTest.java
##
@@ -44,6 +44,7 @@
@Before
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708238056
##
File path:
gateway-i18n-logging-log4j/src/main/java/org/apache/knox/gateway/i18n/messages/loggers/log4j/Log4jMessageLogger.java
##
@@ -37,42 +33,15 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707432233
##
File path:
gateway-provider-rewrite/src/test/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteServletFilterTest.java
##
@@ -527,41 +523,35 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708197274
##
File path:
gateway-provider-ha/src/test/java/org/apache/knox/gateway/ha/provider/impl/AtlasZookeeperURLManagerTest.java
##
@@ -47,6 +47,7 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707432233
##
File path:
gateway-provider-rewrite/src/test/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteServletFilterTest.java
##
@@ -527,41 +523,35 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707417301
##
File path: gateway-provider-rewrite/src/test/resources/log4j.properties
##
@@ -1,37 +0,0 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707416593
##
File path: gateway-test/src/test/resources/log4j.properties
##
@@ -1,44 +0,0 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707386400
##
File path:
gateway-i18n-logging-log4j/src/main/java/org/apache/knox/gateway/i18n/messages/loggers/log4j/Log4jMessageLogger.java
##
@@ -37,42 +33,15 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707232725
##
File path: pom.xml
##
@@ -234,8 +234,7 @@
4.13.1
1.5
1.11
-1.2.17
-2.14.0
+2.14.0
Review comment:
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707232270
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/audit/log4j/layout/AuditLayout.java
##
@@ -20,60 +20,80 @@
import
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707226917
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/audit/log4j/audit/Log4jAuditor.java
##
@@ -52,8 +51,8 @@
}
public
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707226917
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/audit/log4j/audit/Log4jAuditor.java
##
@@ -52,8 +51,8 @@
}
public
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707223972
##
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/AbstractIdentityAssertionFilter.java
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707221222
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/audit/api/CorrelationService.java
##
@@ -23,19 +23,6 @@
* Manipulates the
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707220892
##
File path: gateway-server/src/test/resources/logging.properties
##
@@ -1,87 +0,0 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707220322
##
File path:
gateway-server/src/test/java/org/apache/knox/gateway/descriptor/xml/XmlGatewayDescriptorImporterTest.java
##
@@ -153,7 +154,7 @@ public void
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707219943
##
File path:
gateway-provider-rewrite/src/test/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteRulesDescriptorFactoryTest.java
##
@@ -98,10
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r705211761
##
File path:
gateway-i18n-logging-log4j/src/main/java/org/apache/knox/gateway/i18n/messages/loggers/log4j/Log4jMessageLogger.java
##
@@ -37,42 +31,15 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r704406704
##
File path:
gateway-i18n-logging-log4j/src/main/java/org/apache/knox/gateway/i18n/messages/loggers/log4j/Log4jMessageLogger.java
##
@@ -37,42 +31,15 @@
21 matches
Mail list logo
