[jira] [Work logged] (KNOX-3008) Add a new banner on the top of Knox UIs
[
https://issues.apache.org/jira/browse/KNOX-3008?focusedWorklogId=906977=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906977
]
ASF GitHub Bot logged work on KNOX-3008:
Author: ASF GitHub Bot
Created on: 26/Feb/24 15:27
Start Date: 26/Feb/24 15:27
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502803074
##
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
We've been already using `InetAddress.getLocalHost().getHostName()` and
`InetAddress.getLocalHost().getCanonicalHostName()` at a couple of places in
the project.
I wonder how critical is to have the real hostname in cases like this. If
this is better we might need to consider replacing the existing references of
these `InetAddress` calls.
Otherwise if this is just a nice to have information, we mightneed to
think about using the existing idom, instead of introducing a new dependency.
Since adding a new dependency is always a liability, for future maintenance
and possible CVE point of view.
Issue Time Tracking
---
Worklog Id: (was: 906977)
Time Spent: 50m (was: 40m)
> Add a new banner on the top of Knox UIs
> ---
>
> Key: KNOX-3008
> URL: https://issues.apache.org/jira/browse/KNOX-3008
> Project: Apache Knox
> Issue Type: New Feature
> Components: AdminUI, Homepage, TokenGenerationUI, TokenManagementUI
>Affects Versions: 2.1.0
>Reporter: Sandor Molnar
>Assignee: Sandor Molnar
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I got to know that Hue has a simple, but really cool feature: it can show a
> [custom HTML banner|https://gethue.com/add-a-top-banner-to-hue/] on the top
> of the Hue UI. Implementing a similar feature in Knox can help end-users to:
> # Share a message of the day like hints, tips, or planned outages.
> # Identify the cluster (e.g. Prod/Test/Dev) in case the URL is not clear
> enough.
> An additional improvement would be identifying which Knox gateway is in use,
> in case of HA deployments and if it's behind a load balancer, which can help
> with troubleshooting. This information fits perfectly into the existing
> {{General Proxy Information}} section on the Knox home page; we just need to
> add this new information as a new row in the table.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] KNOX-3008 - Displaying hostname and custom banner text on the Knox Home page and other UIs [knox]
zeroflag commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502803074
##
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
We've been already using `InetAddress.getLocalHost().getHostName()` and
`InetAddress.getLocalHost().getCanonicalHostName()` at a couple of places in
the project.
I wonder how critical is to have the real hostname in cases like this. If
this is better we might need to consider replacing the existing references of
these `InetAddress` calls.
Otherwise if this is just a nice to have information, we mightneed to
think about using the existing idom, instead of introducing a new dependency.
Since adding a new dependency is always a liability, for future maintenance
and possible CVE point of view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (KNOX-3008) Add a new banner on the top of Knox UIs
[
https://issues.apache.org/jira/browse/KNOX-3008?focusedWorklogId=906976=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906976
]
ASF GitHub Bot logged work on KNOX-3008:
Author: ASF GitHub Bot
Created on: 26/Feb/24 15:25
Start Date: 26/Feb/24 15:25
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502803074
##
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
We've been already using `InetAddress.getLocalHost().getHostName()` and
`InetAddress.getLocalHost().getCanonicalHostName()` at a couple of places in
the project.
I wonder how critical is to have the real hostname in cases like this. If
this is better we might need to consider replacing the existing references to
these `InetAddress` calls.
Otherwise if this is just a nice to have information, we mightneed to
think about using the existing idom, instead of introducing a new dependency.
Since adding a new dependency is always a liability, for future maintenance
and possible CVE point of view.
Issue Time Tracking
---
Worklog Id: (was: 906976)
Time Spent: 40m (was: 0.5h)
> Add a new banner on the top of Knox UIs
> ---
>
> Key: KNOX-3008
> URL: https://issues.apache.org/jira/browse/KNOX-3008
> Project: Apache Knox
> Issue Type: New Feature
> Components: AdminUI, Homepage, TokenGenerationUI, TokenManagementUI
>Affects Versions: 2.1.0
>Reporter: Sandor Molnar
>Assignee: Sandor Molnar
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I got to know that Hue has a simple, but really cool feature: it can show a
> [custom HTML banner|https://gethue.com/add-a-top-banner-to-hue/] on the top
> of the Hue UI. Implementing a similar feature in Knox can help end-users to:
> # Share a message of the day like hints, tips, or planned outages.
> # Identify the cluster (e.g. Prod/Test/Dev) in case the URL is not clear
> enough.
> An additional improvement would be identifying which Knox gateway is in use,
> in case of HA deployments and if it's behind a load balancer, which can help
> with troubleshooting. This information fits perfectly into the existing
> {{General Proxy Information}} section on the Knox home page; we just need to
> add this new information as a new row in the table.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] KNOX-3008 - Displaying hostname and custom banner text on the Knox Home page and other UIs [knox]
zeroflag commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502803074
##
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
We've been already using `InetAddress.getLocalHost().getHostName()` and
`InetAddress.getLocalHost().getCanonicalHostName()` at a couple of places in
the project.
I wonder how critical is to have the real hostname in cases like this. If
this is better we might need to consider replacing the existing references to
these `InetAddress` calls.
Otherwise if this is just a nice to have information, we mightneed to
think about using the existing idom, instead of introducing a new dependency.
Since adding a new dependency is always a liability, for future maintenance
and possible CVE point of view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (KNOX-3009) KNOX-SESSION missing from Manager Topology and Admin UI
[ https://issues.apache.org/jira/browse/KNOX-3009?focusedWorklogId=906966=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906966 ] ASF GitHub Bot logged work on KNOX-3009: Author: ASF GitHub Bot Created on: 26/Feb/24 14:47 Start Date: 26/Feb/24 14:47 Worklog Time Spent: 10m Work Description: lmccay commented on PR #843: URL: https://github.com/apache/knox/pull/843#issuecomment-1964320884 > Hehe...I also added the missing service in #842 Great minds! Although, I guess if mine were great, I'd see that it wasn't needed anymore? Issue Time Tracking --- Worklog Id: (was: 906966) Time Spent: 40m (was: 0.5h) > KNOX-SESSION missing from Manager Topology and Admin UI > --- > > Key: KNOX-3009 > URL: https://issues.apache.org/jira/browse/KNOX-3009 > Project: Apache Knox > Issue Type: Bug > Components: Release >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 2.1.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Due to KNOX-SESSION service missing from the default manager.xml topology, an > alert in the Admin UI is displayed while trying to retrieve the authenticated > user name and "dr. who" is displayed as the user. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] KNOX-3009 - KNOX-SESSION missing from Manager Topology and Admin UI [knox]
lmccay commented on PR #843: URL: https://github.com/apache/knox/pull/843#issuecomment-1964320884 > Hehe...I also added the missing service in #842 Great minds! Although, I guess if mine were great, I'd see that it wasn't needed anymore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (KNOX-3002) KnoxCLI command for generating descriptor for a role type from a list of hosts
[ https://issues.apache.org/jira/browse/KNOX-3002?focusedWorklogId=906907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906907 ] ASF GitHub Bot logged work on KNOX-3002: Author: ASF GitHub Bot Created on: 26/Feb/24 09:37 Start Date: 26/Feb/24 09:37 Worklog Time Spent: 10m Work Description: zeroflag merged PR #835: URL: https://github.com/apache/knox/pull/835 Issue Time Tracking --- Worklog Id: (was: 906907) Time Spent: 1h (was: 50m) > KnoxCLI command for generating descriptor for a role type from a list of hosts > -- > > Key: KNOX-3002 > URL: https://issues.apache.org/jira/browse/KNOX-3002 > Project: Apache Knox > Issue Type: New Feature > Components: KnoxCLI >Reporter: Attila Magyar >Assignee: Attila Magyar >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KNOX-3007) Make http client cookie spec parameter configurable
[
https://issues.apache.org/jira/browse/KNOX-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820645#comment-17820645
]
ASF subversion and git services commented on KNOX-3007:
---
Commit fcee4ecffd850cbb3f03ded84b0cdd0dc22578af in knox's branch
refs/heads/master from Attila Magyar
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=fcee4ecff ]
KNOX-3007 - Make http client cookie spec parameter configurable (#841)
> Make http client cookie spec parameter configurable
> ---
>
> Key: KNOX-3007
> URL: https://issues.apache.org/jira/browse/KNOX-3007
> Project: Apache Knox
> Issue Type: Improvement
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The apache http client rejects cookies if the expiration date doesn't have
> the expected format (EEE, dd-MMM-yy HH:mm:ss z).
> {code}
> 2023-11-20 17:58:51,189 XXX WARN protocol.ResponseProcessCookies
> (ResponseProcessCookies.java:processCookies(130)) - Invalid cookie header:
> "Set-Cookie: sessionid=XXX; expires=Mon, 20 Nov 2023 23:03:51 GMT; HttpOnly;
> Max-Age=300; Path=/; SameSite=Lax; Secure". Invalid 'expires' attribute: Mon,
> 20 Nov 2023 23:03:51 GMT
> {code}
> This can be reconfigured by setting different cookiespec types:
> https://hc.apache.org/httpcomponents-client-4.5.x/current/httpclient/apidocs/org/apache/http/client/config/CookieSpecs.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (KNOX-3007) Make http client cookie spec parameter configurable
[
https://issues.apache.org/jira/browse/KNOX-3007?focusedWorklogId=906908=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906908
]
ASF GitHub Bot logged work on KNOX-3007:
Author: ASF GitHub Bot
Created on: 26/Feb/24 09:37
Start Date: 26/Feb/24 09:37
Worklog Time Spent: 10m
Work Description: zeroflag merged PR #841:
URL: https://github.com/apache/knox/pull/841
Issue Time Tracking
---
Worklog Id: (was: 906908)
Time Spent: 40m (was: 0.5h)
> Make http client cookie spec parameter configurable
> ---
>
> Key: KNOX-3007
> URL: https://issues.apache.org/jira/browse/KNOX-3007
> Project: Apache Knox
> Issue Type: Improvement
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The apache http client rejects cookies if the expiration date doesn't have
> the expected format (EEE, dd-MMM-yy HH:mm:ss z).
> {code}
> 2023-11-20 17:58:51,189 XXX WARN protocol.ResponseProcessCookies
> (ResponseProcessCookies.java:processCookies(130)) - Invalid cookie header:
> "Set-Cookie: sessionid=XXX; expires=Mon, 20 Nov 2023 23:03:51 GMT; HttpOnly;
> Max-Age=300; Path=/; SameSite=Lax; Secure". Invalid 'expires' attribute: Mon,
> 20 Nov 2023 23:03:51 GMT
> {code}
> This can be reconfigured by setting different cookiespec types:
> https://hc.apache.org/httpcomponents-client-4.5.x/current/httpclient/apidocs/org/apache/http/client/config/CookieSpecs.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KNOX-3002) KnoxCLI command for generating descriptor for a role type from a list of hosts
[ https://issues.apache.org/jira/browse/KNOX-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820644#comment-17820644 ] ASF subversion and git services commented on KNOX-3002: --- Commit bb5d265d861489925f158faff761090d672205db in knox's branch refs/heads/master from Attila Magyar [ https://gitbox.apache.org/repos/asf?p=knox.git;h=bb5d265d8 ] KNOX-3002 - KnoxCLI command for generating descriptor for a role type from a list of hosts (#835) > KnoxCLI command for generating descriptor for a role type from a list of hosts > -- > > Key: KNOX-3002 > URL: https://issues.apache.org/jira/browse/KNOX-3002 > Project: Apache Knox > Issue Type: New Feature > Components: KnoxCLI >Reporter: Attila Magyar >Assignee: Attila Magyar >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] KNOX-3007 - Make http client cookie spec parameter configurable [knox]
zeroflag merged PR #841: URL: https://github.com/apache/knox/pull/841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KNOX-3002 - KnoxCLI command for generating descriptor for a role type from a list of hosts [knox]
zeroflag merged PR #835: URL: https://github.com/apache/knox/pull/835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (KNOX-3008) Add a new banner on the top of Knox UIs
[
https://issues.apache.org/jira/browse/KNOX-3008?focusedWorklogId=906906=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906906
]
ASF GitHub Bot logged work on KNOX-3008:
Author: ASF GitHub Bot
Created on: 26/Feb/24 09:33
Start Date: 26/Feb/24 09:33
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502293245
##
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
See explanation here: https://github.com/mattsheppard/gethostname4j
Issue Time Tracking
---
Worklog Id: (was: 906906)
Time Spent: 0.5h (was: 20m)
> Add a new banner on the top of Knox UIs
> ---
>
> Key: KNOX-3008
> URL: https://issues.apache.org/jira/browse/KNOX-3008
> Project: Apache Knox
> Issue Type: New Feature
> Components: AdminUI, Homepage, TokenGenerationUI, TokenManagementUI
>Affects Versions: 2.1.0
>Reporter: Sandor Molnar
>Assignee: Sandor Molnar
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I got to know that Hue has a simple, but really cool feature: it can show a
> [custom HTML banner|https://gethue.com/add-a-top-banner-to-hue/] on the top
> of the Hue UI. Implementing a similar feature in Knox can help end-users to:
> # Share a message of the day like hints, tips, or planned outages.
> # Identify the cluster (e.g. Prod/Test/Dev) in case the URL is not clear
> enough.
> An additional improvement would be identifying which Knox gateway is in use,
> in case of HA deployments and if it's behind a load balancer, which can help
> with troubleshooting. This information fits perfectly into the existing
> {{General Proxy Information}} section on the Knox home page; we just need to
> add this new information as a new row in the table.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] KNOX-3008 - Displaying hostname and custom banner text on the Knox Home page and other UIs [knox]
smolnar82 commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502293245
##
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
See explanation here: https://github.com/mattsheppard/gethostname4j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (KNOX-3008) Add a new banner on the top of Knox UIs
[
https://issues.apache.org/jira/browse/KNOX-3008?focusedWorklogId=906903=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906903
]
ASF GitHub Bot logged work on KNOX-3008:
Author: ASF GitHub Bot
Created on: 26/Feb/24 09:26
Start Date: 26/Feb/24 09:26
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502284036
##
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
Wouldn't a simple `InetAddress.getLocalHost().getHostName()` work? Do we
know how is this library implemented?
Issue Time Tracking
---
Worklog Id: (was: 906903)
Time Spent: 20m (was: 10m)
> Add a new banner on the top of Knox UIs
> ---
>
> Key: KNOX-3008
> URL: https://issues.apache.org/jira/browse/KNOX-3008
> Project: Apache Knox
> Issue Type: New Feature
> Components: AdminUI, Homepage, TokenGenerationUI, TokenManagementUI
>Affects Versions: 2.1.0
>Reporter: Sandor Molnar
>Assignee: Sandor Molnar
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I got to know that Hue has a simple, but really cool feature: it can show a
> [custom HTML banner|https://gethue.com/add-a-top-banner-to-hue/] on the top
> of the Hue UI. Implementing a similar feature in Knox can help end-users to:
> # Share a message of the day like hints, tips, or planned outages.
> # Identify the cluster (e.g. Prod/Test/Dev) in case the URL is not clear
> enough.
> An additional improvement would be identifying which Knox gateway is in use,
> in case of HA deployments and if it's behind a load balancer, which can help
> with troubleshooting. This information fits perfectly into the existing
> {{General Proxy Information}} section on the Knox home page; we just need to
> add this new information as a new row in the table.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] KNOX-3008 - Displaying hostname and custom banner text on the Knox Home page and other UIs [knox]
zeroflag commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502284036
##
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
Wouldn't a simple `InetAddress.getLocalHost().getHostName()` work? Do we
know how is this library implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (KNOX-3009) KNOX-SESSION missing from Manager Topology and Admin UI
[ https://issues.apache.org/jira/browse/KNOX-3009?focusedWorklogId=906893=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906893 ] ASF GitHub Bot logged work on KNOX-3009: Author: ASF GitHub Bot Created on: 26/Feb/24 08:16 Start Date: 26/Feb/24 08:16 Worklog Time Spent: 10m Work Description: smolnar82 commented on PR #843: URL: https://github.com/apache/knox/pull/843#issuecomment-1963545116 Hehe...I also added the missing service in #842 Issue Time Tracking --- Worklog Id: (was: 906893) Time Spent: 0.5h (was: 20m) > KNOX-SESSION missing from Manager Topology and Admin UI > --- > > Key: KNOX-3009 > URL: https://issues.apache.org/jira/browse/KNOX-3009 > Project: Apache Knox > Issue Type: Bug > Components: Release >Reporter: Larry McCay >Assignee: Larry McCay >Priority: Major > Fix For: 2.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Due to KNOX-SESSION service missing from the default manager.xml topology, an > alert in the Admin UI is displayed while trying to retrieve the authenticated > user name and "dr. who" is displayed as the user. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] KNOX-3009 - KNOX-SESSION missing from Manager Topology and Admin UI [knox]
smolnar82 commented on PR #843: URL: https://github.com/apache/knox/pull/843#issuecomment-1963545116 Hehe...I also added the missing service in #842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
