Re: Using Github for Contributions & Reviews

Count me in the "happy with gerrit" process. In particular, the thing I like the most about gerrit is the ease with which I can post a review from my dev environment without futzing about in some UI. Maybe github has a way to generate a PR with equal ease, but I often want to make a two-line fix

Re: Using Github for Contributions & Reviews

Following up on this, INFRA-17817 was resolved. Does anyone else have any opinion on this? Currently I am taking the silence as an indicator that everyone is happy with the existing tooling/process and thinks it should stay the same. On Wed,

Re: Using Github for Contributions & Reviews

I proactively opened INFRA-17817 to change this policy. Regardless of the route we take it's good to avoid any mistakes. On Wed, Feb 6, 2019 at 11:52 AM Grant Henke wrote: > I found the Kafka Infra jira to use for reference should we need it:

Re: Using Github for Contributions & Reviews

I found the Kafka Infra jira to use for reference should we need it: https://issues.apache.org/jira/browse/INFRA-16144 On Wed, Feb 6, 2019 at 11:50 AM Grant Henke wrote: > It looks like the Kudu committer merging a patch has full control over the > strategy currently: > [image: image.png] > >

Re: Using Github for Contributions & Reviews

It looks like the Kudu committer merging a patch has full control over the strategy currently: [image: image.png] But in the Kafka project they have limited the available options as seen below. I agree we should configure Kudu to be the same if we go the route of Github reviews. That likely

Re: Using Github for Contributions & Reviews

I assume if we used Github PR's we configure merges to occur without merge commits? I find them very confusing. On Wed, Feb 6, 2019 at 9:57 AM Grant Henke wrote: > Hello Kudu Developers, > > Now that Apache is integrated more closely with Github via Gitbox > I

Using Github for Contributions & Reviews

Hello Kudu Developers, Now that Apache is integrated more closely with Github via Gitbox I wanted to open a discussion on the code contribution process. We now have full control over pull requests and submissions on the Github repository meaning we could use Github