Re: [Discuss] Apache Kylin Component Owner Plan

[hongbin ma]

+1

suggest to establish more solid rules on test coverage. I've seen lots
patches without proper tests

On Fri, Feb 2, 2018 at 2:57 PM, Jianhua Peng  wrote:

> +1
>
> On 2018/02/02 02:39:38, ShaoFeng Shi  wrote:
> > Hello, Kylin community,
> >
> > In the past, we don't have a clear rule on Kylin each component's
> > ownership, which caused many external patches be pending there as no
> > reviewer to pick up.
> >
> > Now we plan to make the process and responsibility more clear. The main
> > idea is to identify the owners of each Apache Kylin component.
> >
> > - Component owners will be listed in the description field on this Apache
> > Kylin JIRA components page [1]. The owners are listed in the
> 'Description'
> > field rather than in the 'Component Lead' field because the latter only
> > allows us to list one individual whereas it is encouraged that components
> > have multiple owners.
> >
> > - Component owners are volunteers who are expert in their component
> domain
> > and may have an agenda on how they think their Apache Kylin component
> > should evolve. The owner needs to be an Apache Kylin committer at this
> > moment.
> >
> > - Owners will try and review patches that land within their component’s
> > scope.
> >
> > - Owners can rotate, based on his aspiration.
> >
> > - When nominate or vote a new committer, the nominator needs to state
> which
> > component the candidate can be the owner.
> >
> > - If you're already an Apache Kylin committer and would like to be a
> > volunteer as a component owner, just write to the dev list and we’ll sign
> > you up.
> >
> > - If you think the component list need be updated (add, remove, rename,
> > etc), write to the dev list and we’ll review that.
> >
> > Below is the component list with old component lead, which assumes to be
> > updated soon.
> >
> > [1]
> > https://issues.apache.org/jira/projects/KYLIN?
> selectedItem=com.atlassian.jira.jira-projects-plugin:components-page
> >
> > Please comment on this plan; if no objection, we will run it for some
> time
> > to see the effect. Thanks for your inputs!
> >
> > And, thanks to Apache HBase community, from where I learned this.
> >
> > --
> > Best regards,
> >
> > Shaofeng Shi 史少锋
> >
>



-- 
Regards,

*Bin Mahone | 马洪宾*

Re: Welcome new Apache Kylin committer: Jianhua Peng

[ShaoFeng Shi]

Welcome Jianhua!

2018-02-02 14:55 GMT+08:00 Jianhua Peng :

> Thank you very much! I am very happy to join the Apache Kylin project
> family and Contribute to Apache Kylin with everyone.
>
> On 2018/02/02 06:02:11, Luke Han  wrote:
> > I am very pleased to announce that the Project Management Committee
> > (PMC) of Apache Kylin has asked Jianhua Peng to becomeApache Kylin
> committer,
> > and he has already accepted.
> >
> > Jianhua has already made many contributions to Kylin community, to answer
> > others questions actively, submit patches for bug fixes and contribute to
> > some features. We are so glad to have him to be our new committer.
> >
> > Please join me to welcome Jianhua.
> >
> > Luke Han
> >
> > On behalf of the Apache Kylin PPMC
> >
>



-- 
Best regards,

Shaofeng Shi 史少锋

Re: [Discuss] Apache Kylin Component Owner Plan

[Jianhua Peng]

+1

On 2018/02/02 02:39:38, ShaoFeng Shi  wrote: 
> Hello, Kylin community,
> 
> In the past, we don't have a clear rule on Kylin each component's
> ownership, which caused many external patches be pending there as no
> reviewer to pick up.
> 
> Now we plan to make the process and responsibility more clear. The main
> idea is to identify the owners of each Apache Kylin component.
> 
> - Component owners will be listed in the description field on this Apache
> Kylin JIRA components page [1]. The owners are listed in the 'Description'
> field rather than in the 'Component Lead' field because the latter only
> allows us to list one individual whereas it is encouraged that components
> have multiple owners.
> 
> - Component owners are volunteers who are expert in their component domain
> and may have an agenda on how they think their Apache Kylin component
> should evolve. The owner needs to be an Apache Kylin committer at this
> moment.
> 
> - Owners will try and review patches that land within their component’s
> scope.
> 
> - Owners can rotate, based on his aspiration.
> 
> - When nominate or vote a new committer, the nominator needs to state which
> component the candidate can be the owner.
> 
> - If you're already an Apache Kylin committer and would like to be a
> volunteer as a component owner, just write to the dev list and we’ll sign
> you up.
> 
> - If you think the component list need be updated (add, remove, rename,
> etc), write to the dev list and we’ll review that.
> 
> Below is the component list with old component lead, which assumes to be
> updated soon.
> 
> [1]
> https://issues.apache.org/jira/projects/KYLIN?selectedItem=com.atlassian.jira.jira-projects-plugin:components-page
> 
> Please comment on this plan; if no objection, we will run it for some time
> to see the effect. Thanks for your inputs!
> 
> And, thanks to Apache HBase community, from where I learned this.
> 
> -- 
> Best regards,
> 
> Shaofeng Shi 史少锋
> 

Re: Welcome new Apache Kylin committer: Jianhua Peng

[Jianhua Peng]

Thank you very much! I am very happy to join the Apache Kylin project family 
and Contribute to Apache Kylin with everyone.

On 2018/02/02 06:02:11, Luke Han  wrote: 
> I am very pleased to announce that the Project Management Committee
> (PMC) of Apache Kylin has asked Jianhua Peng to becomeApache Kylin committer,
> and he has already accepted.
> 
> Jianhua has already made many contributions to Kylin community, to answer
> others questions actively, submit patches for bug fixes and contribute to
> some features. We are so glad to have him to be our new committer.
> 
> Please join me to welcome Jianhua.
> 
> Luke Han
> 
> On behalf of the Apache Kylin PPMC
> 

Re: [Discuss] Patch +1 Policy

[Jianhua Peng]

+1

On 2018/02/02 03:10:32, ShaoFeng Shi  wrote: 
> Hello, Apache Kylin community,
> 
> This is another proposal follows the "Component Owner" proposal;
> 
> The below policy is a suggested policy rather than a hard requirement.
> 
> Apache Kylin is made of components. Components have one or more OWNERs. See
> the 'Description' field on the components JIRA page for who the current
> owners are by component.
> 
> Patches that fit within the scope of a single component require, at least,
> a +1 by one of the component’s owners before commit. If owners are absent 
> —
> busy or otherwise — two +1s by non-owners but committers will suffice.
> 
> Patches that span components need at least two +1s before they can be
> committed, preferably +1s by owners of components touched by the
> x-component patch.
> 
> Any -1 on a patch by anyone vetoes a patch; it cannot be committed until
> the justification for the -1 is addressed.
> 
> Please review this policy and share your comments; If no objection, we will
> update it to Kylin's development process and enforce it in the future.
> Thanks!
> 
> -- 
> Best regards,
> 
> Shaofeng Shi 史少锋
> 

Re: Welcome new Apache Kylin committer: Jianhua Peng

[Liukaige]

Congratulations!

2018-02-02 14:38 GMT+08:00 Billy Liu :

> Welcome Jianhua.
>
>
>
> 2018-02-02 14:06 GMT+08:00 Dong Li :
> > Welcome Jianhua!
> >
> > Thanks,
> > Dong Li
> >
> > 2018-02-02 14:02 GMT+08:00 Luke Han :
> >
> >> I am very pleased to announce that the Project Management Committee
> >> (PMC) of Apache Kylin has asked Jianhua Peng to becomeApache Kylin
> >> committer,
> >> and he has already accepted.
> >>
> >> Jianhua has already made many contributions to Kylin community, to
> answer
> >> others questions actively, submit patches for bug fixes and contribute
> to
> >> some features. We are so glad to have him to be our new committer.
> >>
> >> Please join me to welcome Billy.
> >>
> >> Luke Han
> >>
> >> On behalf of the Apache Kylin PPMC
> >>
>



-- 
Best regards,

Kaige Liu(刘凯歌)

*"Do small things with great love." *

Re: Welcome new Apache Kylin committer: Jianhua Peng

[Billy Liu]

Welcome Jianhua.



2018-02-02 14:06 GMT+08:00 Dong Li :
> Welcome Jianhua!
>
> Thanks,
> Dong Li
>
> 2018-02-02 14:02 GMT+08:00 Luke Han :
>
>> I am very pleased to announce that the Project Management Committee
>> (PMC) of Apache Kylin has asked Jianhua Peng to becomeApache Kylin
>> committer,
>> and he has already accepted.
>>
>> Jianhua has already made many contributions to Kylin community, to answer
>> others questions actively, submit patches for bug fixes and contribute to
>> some features. We are so glad to have him to be our new committer.
>>
>> Please join me to welcome Billy.
>>
>> Luke Han
>>
>> On behalf of the Apache Kylin PPMC
>>

Re: Welcome new Apache Kylin committer: Jianhua Peng

[Dong Li]

Welcome Jianhua!

Thanks,
Dong Li

2018-02-02 14:02 GMT+08:00 Luke Han :

> I am very pleased to announce that the Project Management Committee
> (PMC) of Apache Kylin has asked Jianhua Peng to becomeApache Kylin
> committer,
> and he has already accepted.
>
> Jianhua has already made many contributions to Kylin community, to answer
> others questions actively, submit patches for bug fixes and contribute to
> some features. We are so glad to have him to be our new committer.
>
> Please join me to welcome Billy.
>
> Luke Han
>
> On behalf of the Apache Kylin PPMC
>

Welcome new Apache Kylin committer: Jianhua Peng

[Luke Han]

I am very pleased to announce that the Project Management Committee
(PMC) of Apache Kylin has asked Jianhua Peng to becomeApache Kylin committer,
and he has already accepted.

Jianhua has already made many contributions to Kylin community, to answer
others questions actively, submit patches for bug fixes and contribute to
some features. We are so glad to have him to be our new committer.

Please join me to welcome Billy.

Luke Han

On behalf of the Apache Kylin PPMC

Re: [Discuss] Patch +1 Policy

[Billy Liu]

Hi Shaofeng,

I like this idea very much. Do we need official vote?

2018-02-02 11:39 GMT+08:00 Liukaige :
> ＋1
> This policy will definitely improve the quality of codes. Pretty cool!
>
> 2018-02-02 11:10 GMT+08:00 ShaoFeng Shi :
>
>> Hello, Apache Kylin community,
>>
>> This is another proposal follows the "Component Owner" proposal;
>>
>> The below policy is a suggested policy rather than a hard requirement.
>>
>> Apache Kylin is made of components. Components have one or more OWNERs. See
>> the 'Description' field on the components JIRA page for who the current
>> owners are by component.
>>
>> Patches that fit within the scope of a single component require, at least,
>> a +1 by one of the component’s owners before commit. If owners are absent —
>> busy or otherwise — two +1s by non-owners but committers will suffice.
>>
>> Patches that span components need at least two +1s before they can be
>> committed, preferably +1s by owners of components touched by the
>> x-component patch.
>>
>> Any -1 on a patch by anyone vetoes a patch; it cannot be committed until
>> the justification for the -1 is addressed.
>>
>> Please review this policy and share your comments; If no objection, we will
>> update it to Kylin's development process and enforce it in the future.
>> Thanks!
>>
>> --
>> Best regards,
>>
>> Shaofeng Shi 史少锋
>>
>
>
>
> --
> Best regards,
>
> Kaige Liu(刘凯歌)
>
> *"Do small things with great love." *

Re: [Discuss] Patch +1 Policy

[Liukaige]

＋1
This policy will definitely improve the quality of codes. Pretty cool!

2018-02-02 11:10 GMT+08:00 ShaoFeng Shi :

> Hello, Apache Kylin community,
>
> This is another proposal follows the "Component Owner" proposal;
>
> The below policy is a suggested policy rather than a hard requirement.
>
> Apache Kylin is made of components. Components have one or more OWNERs. See
> the 'Description' field on the components JIRA page for who the current
> owners are by component.
>
> Patches that fit within the scope of a single component require, at least,
> a +1 by one of the component’s owners before commit. If owners are absent —
> busy or otherwise — two +1s by non-owners but committers will suffice.
>
> Patches that span components need at least two +1s before they can be
> committed, preferably +1s by owners of components touched by the
> x-component patch.
>
> Any -1 on a patch by anyone vetoes a patch; it cannot be committed until
> the justification for the -1 is addressed.
>
> Please review this policy and share your comments; If no objection, we will
> update it to Kylin's development process and enforce it in the future.
> Thanks!
>
> --
> Best regards,
>
> Shaofeng Shi 史少锋
>



-- 
Best regards,

Kaige Liu(刘凯歌)

*"Do small things with great love." *

[Discuss] Patch +1 Policy

[ShaoFeng Shi]

Hello, Apache Kylin community,

This is another proposal follows the "Component Owner" proposal;

The below policy is a suggested policy rather than a hard requirement.

Apache Kylin is made of components. Components have one or more OWNERs. See
the 'Description' field on the components JIRA page for who the current
owners are by component.

Patches that fit within the scope of a single component require, at least,
a +1 by one of the component’s owners before commit. If owners are absent —
busy or otherwise — two +1s by non-owners but committers will suffice.

Patches that span components need at least two +1s before they can be
committed, preferably +1s by owners of components touched by the
x-component patch.

Any -1 on a patch by anyone vetoes a patch; it cannot be committed until
the justification for the -1 is addressed.

Please review this policy and share your comments; If no objection, we will
update it to Kylin's development process and enforce it in the future.
Thanks!

-- 
Best regards,

Shaofeng Shi 史少锋

[Discuss] Apache Kylin Component Owner Plan

[ShaoFeng Shi]

Hello, Kylin community,

In the past, we don't have a clear rule on Kylin each component's
ownership, which caused many external patches be pending there as no
reviewer to pick up.

Now we plan to make the process and responsibility more clear. The main
idea is to identify the owners of each Apache Kylin component.

- Component owners will be listed in the description field on this Apache
Kylin JIRA components page [1]. The owners are listed in the 'Description'
field rather than in the 'Component Lead' field because the latter only
allows us to list one individual whereas it is encouraged that components
have multiple owners.

- Component owners are volunteers who are expert in their component domain
and may have an agenda on how they think their Apache Kylin component
should evolve. The owner needs to be an Apache Kylin committer at this
moment.

- Owners will try and review patches that land within their component’s
scope.

- Owners can rotate, based on his aspiration.

- When nominate or vote a new committer, the nominator needs to state which
component the candidate can be the owner.

- If you're already an Apache Kylin committer and would like to be a
volunteer as a component owner, just write to the dev list and we’ll sign
you up.

- If you think the component list need be updated (add, remove, rename,
etc), write to the dev list and we’ll review that.

Below is the component list with old component lead, which assumes to be
updated soon.

[1]
https://issues.apache.org/jira/projects/KYLIN?selectedItem=com.atlassian.jira.jira-projects-plugin:components-page

Please comment on this plan; if no objection, we will run it for some time
to see the effect. Thanks for your inputs!

And, thanks to Apache HBase community, from where I learned this.

-- 
Best regards,

Shaofeng Shi 史少锋

Log split

[Fei Yi]

Hi
Whether to consider the server log and query log stored in two log files,
The current log mixed together to find the content is not easy

[jira] [Created] (KYLIN-3224) data can't show when use kylin pushdown model

[peng.jianhua (JIRA)]

peng.jianhua created KYLIN-3224:
---

 Summary: data can't show when use kylin pushdown model 
 Key: KYLIN-3224
 URL: https://issues.apache.org/jira/browse/KYLIN-3224
 Project: Kylin
  Issue Type: Bug
  Components: Web 
Affects Versions: v2.2.0, v2.3.0
Reporter: peng.jianhua
Assignee: peng.jianhua


select * from kylin_sales



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KYLIN-3223) Query for the list of hybrid cubes results in NPE

[Vsevolod Ostapenko (JIRA)]

Vsevolod Ostapenko created KYLIN-3223:
-

 Summary: Query for the list of hybrid cubes results in NPE
 Key: KYLIN-3223
 URL: https://issues.apache.org/jira/browse/KYLIN-3223
 Project: Kylin
  Issue Type: Bug
  Components: REST Service
Affects Versions: v2.2.0
 Environment: HDP 2.5.6, Kylin 2.2
Reporter: Vsevolod Ostapenko
Assignee: luguosheng


Calling REST API to get the list of hybrid cubes returns stack trace with NPE 
exception.
{quote}curl -u ADMIN:KYLIN -X GET -H 'Content-Type: application/json'  -d {} 
[http://localhost:7070/kylin/api/hybrids]

{"code":"999","data":null,"msg":null,"stacktrace":"java.lang.NullPointerException\n\tat
 
java.util.concurrent.ConcurrentSkipListMap.doGet(ConcurrentSkipListMap.java:778)\n\tat
 
java.util.concurrent.ConcurrentSkipListMap.get(ConcurrentSkipListMap.java:1546)\n\tat
 
org.apache.kylin.metadata.cachesync.SingleValueCache.get(SingleValueCache.java:85)\n\tat
 
org.apache.kylin.metadata.project.ProjectManager.getProject(ProjectManager.java:172)\n\tat
 
org.apache.kylin.rest.util.AclEvaluate.getProjectInstance(AclEvaluate.java:39)\n\tat
 
org.apache.kylin.rest.util.AclEvaluate.checkProjectReadPermission(AclEvaluate.java:61)\n\tat
 
org.apache.kylin.rest.service.HybridService.listHybrids(HybridService.java:115)\n\tat
 
org.apache.kylin.rest.controller.HybridController.list(HybridController.java:76)\n\tat
 sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat
 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
 java.lang.reflect.Method.invoke(Method.java:497)\n\tat 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)\n\tat
 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)\n\tat
 
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)\n\tat
 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)\n\tat
 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)\n\tat
 
org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)\n\tat
 
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:967)\n\tat
 
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:901)\n\tat
 
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)\n\tat
 
org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:861)\n\tat
 javax.servlet.http.HttpServlet.service(HttpServlet.java:624)\n\tat 
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)\n\tat
 javax.servlet.http.HttpServlet.service(HttpServlet.java:731)\n\tat 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)\n\tat
 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat
 org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\tat 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)\n\tat
 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)\n\tat
 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)\n\tat
 
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:127)\n\tat
 
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:91)\n\tat
 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)\n\tat
 
org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)\n\tat
 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)\n\tat
 
org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:137)\n\tat
 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)\n\tat
 
org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111)\n\tat
 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)\n\tat
 

[jira] [Created] (KYLIN-3222) The function of editing 'Advanced Dictionaries' in cube is unavailable.

[Peng Xing (JIRA)]

Peng Xing created KYLIN-3222:


 Summary: The function of editing 'Advanced Dictionaries' in cube 
is unavailable.
 Key: KYLIN-3222
 URL: https://issues.apache.org/jira/browse/KYLIN-3222
 Project: Kylin
  Issue Type: Bug
  Components: Web 
Affects Versions: v2.3.0
Reporter: Peng Xing
Assignee: Peng Xing
 Attachments: modify_advanced_dictionary.png, 
modify_advanced_dictionary_no_effect.png

There is a problem about editing 'Advanced Dictionaries' in cube, refer to 
'modify_advanced_dictionary.png' and 'modify_advanced_dictionary_no_effect.png'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)