[jira] [Created] (KYLIN-3266) Improve CI coverage

[liyang (JIRA)]

liyang created KYLIN-3266:
-

 Summary: Improve CI coverage
 Key: KYLIN-3266
 URL: https://issues.apache.org/jira/browse/KYLIN-3266
 Project: Kylin
  Issue Type: Improvement
Reporter: liyang
Assignee: liyang


The current CI, aka BuildCubeWithEngine, only test merge on the MR engine. The 
merge operation is not tested on Spark engine. Need to improve the test 
coverage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Can't delete segment

[Xixin]

Hello Shaofeng,

I also met this problem recently, but a little different with Youcheng's
problem. 

I assigned a timed task for a cube to add daily, but some env configure
changes leads the Kylin job to error.

then I drop the job, and want to refresh the segment, but failed.
then I try to delete that segment, failed again.

finally I got two solutions to solved this problem, A. purge that cube
contains that 0Mb segment. B. backup metadata, modify metadata of that
segment.

To write down so much, I want to explain, users are able to create segments,
why not let them can delete segments which build with error. like you said
delete the related segment when drop the error job or other ways to discuss.




--
Sent from: http://apache-kylin.74782.x6.nabble.com/

Please set kylin.env.hdfs-working-dir in kylin.properties Error

[rahulsingh]

Hi All,

I have installed hadoop cluster with CDH - 5.9 and I am running
apache-kylin-2.1.0-bin-cdh57.
While using bin/check-env.sh or kylin.sh start command its giving as,

Retrieving hadoop conf dir...
KYLIN_HOME is set to /opt/apache-kylin-2.1.0-bin-cdh57
Please set kylin.env.hdfs-working-dir in kylin.properties

Thanks,
Rahul Singh


--
Sent from: http://apache-kylin.74782.x6.nabble.com/

[GitHub] codecov-io commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix

[GitBox]

codecov-io commented on issue #105: KYLIN-2884 Add delete segment function for 
portal - bug fix
URL: https://github.com/apache/kylin/pull/105#issuecomment-368205395
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr=h1) Report
   > Merging [#105](https://codecov.io/gh/apache/kylin/pull/105?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/66ea154ecee74a18066e9b6ea706e7232fb19bf5?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/105/graphs/tree.svg?src=pr=650=JawVgbgsVo=150)](https://codecov.io/gh/apache/kylin/pull/105?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #105  +/-   ##
   
   - Coverage 21.47%   21.47%   -0.01% 
   + Complexity 3822 3820   -2 
   
 Files   992  992  
 Lines 5973459734  
 Branches   8638 8638  
   
   - Hits  1282612825   -1 
   - Misses4572745728   +1 
 Partials   1181 1181
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/105?src=pr=tree) | Coverage ? 
| Complexity ? | |
   |---|---|---|---|
   | 
[...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=)
 | `51.69% <0%> (-1.45%)` | `46% <0%> (-2%)` | |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `69.3% <0%> (-0.31%)` | `7% <0%> (?)` | |
   | 
[...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=)
 | `55.72% <0%> (+0.49%)` | `21% <0%> (?)` | :arrow_down: |
   | 
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
 | `72.29% <0%> (+1.35%)` | `8% <0%> (?)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr=footer). Last 
update 
[66ea154...23641a2](https://codecov.io/gh/apache/kylin/pull/105?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix

[GitBox]

coveralls commented on issue #105: KYLIN-2884 Add delete segment function for 
portal - bug fix
URL: https://github.com/apache/kylin/pull/105#issuecomment-368205238
 
 
   ## Pull Request Test Coverage Report for [Build 
2997](https://coveralls.io/builds/15677654)
   
   * **0** of **0**  **(NaN%)** changed or added relevant lines in **0** files 
are covered.
   * **6** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.002%**) to **23.451%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java](https://coveralls.io/builds/15677654/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FAbstractExecutable.java#L157)
 | 1 | 58.94% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15677654/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/15677654/badge)](https://coveralls.io/builds/15677654)
 |
   | :-- | --: |
   | Change from base [Build 2992](https://coveralls.io/builds/15667361): |  
-0.002% |
   | Covered Lines: | 14008 |
   | Relevant Lines: | 59734 |
   
   ---
   # ?  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sanjulian opened a new pull request #105: KYLIN-2884 Add delete segment function for portal - bug fix

[GitBox]

sanjulian opened a new pull request #105: KYLIN-2884 Add delete segment 
function for portal - bug fix
URL: https://github.com/apache/kylin/pull/105
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix

[GitBox]

asfgit commented on issue #105: KYLIN-2884 Add delete segment function for 
portal - bug fix
URL: https://github.com/apache/kylin/pull/105#issuecomment-36820
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/jobs" API

[Shaofeng SHI (JIRA)]

Shaofeng SHI created KYLIN-3265:
---

 Summary: Add "jobSearchMode" as a condition to "/kylin/jobs" API
 Key: KYLIN-3265
 URL: https://issues.apache.org/jira/browse/KYLIN-3265
 Project: Kylin
  Issue Type: Improvement
  Components: REST Service
Affects Versions: v2.3.0
Reporter: Shaofeng SHI


In kylin 2.3, the "/kylin/jobs" API will return both cubing job and checkpoint 
job together, this changed the API's behavior as there isn't checkpoint job 
before. We should keep the api only return cubing jobs to be compitable as 
before, and extend the API to add another condition 'jobSearchMode' to 
determine which kind of job should be returned. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KYLIN-3264) kylin.job.retry=1 cause build error

[readme_kylin (JIRA)]

readme_kylin created KYLIN-3264:
---

 Summary: kylin.job.retry=1 cause build error
 Key: KYLIN-3264
 URL: https://issues.apache.org/jira/browse/KYLIN-3264
 Project: Kylin
  Issue Type: Bug
  Components: Job Engine
Affects Versions: v2.3.0
Reporter: readme_kylin


when i set kylin.job.retry to 1,it cause build error at 6 step :Create HTable .

here is the error info.

java.lang.RuntimeException: HBase table KYLIN230_CFJ854DYZ4 exists!
 at 
org.apache.kylin.storage.hbase.steps.CubeHTableUtil.createHTable(CubeHTableUtil.java:100)
 at 
org.apache.kylin.storage.hbase.steps.CreateHTableJob.run(CreateHTableJob.java:111)
 at org.apache.kylin.engine.mr.MRUtil.runMRJob(MRUtil.java:97)
 at 
org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:63)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:162)
 at 
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:67)
 at 
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:162)
 at 
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:300)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[VOTE] Release apache-kylin-2.3.0 (RC2)

[Billy Liu]

Hi all,

The RC1 VOTE has been cancelled for the urgent issue. Now the known
issue has been fixed, and I have created a new build for Apache Kylin
2.3.0, release candidate 2.

Changes highlights:
   [KYLIN-2727] - Introduce cube planner able to select cost-effective
cuboids to be built by cost-based algorithms
   [KYLIN-2726] - Introduce a dashboard for showing kylin service
related metrics, like query count, query latency, job count, etc
   [KYLIN-3125] - Support SparkSql in Cube building step “Create
Intermediate Flat Hive Table”
   [KYLIN-3044] - Support SQL Server as data source
   [KYLIN-2960] - Support user/group and role authentication for LDAP

And more than 240 issues fixed.

Thanks to everyone who has contributed to this release.
Here's release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12341685=12316121

The commit to be voted upon:
https://github.com/apache/kylin/commit/3747b1291c1e0bd319bcc2a123fc83819775300d

Its hash is 3747b1291c1e0bd319bcc2a123fc83819775300d

The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/kylin/apache-kylin-2.3.0-rc2/

The hashes of the artifacts are as follows:
apache-kylin-2.3.0-src.tar.gz.md5 0d53c62782321fc18f00b0754e3401a5
apache-kylin-2.3.0-src.tar.gz.sha1 3324e8cfbea635357e589964b01c70e643d9f783

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachekylin-1047/

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/billyliu.asc

Please vote on releasing this package as Apache Kylin 2.3.0

The vote is open for the next 72 hours and passes if a majority of at
least three +1 PPMC votes are cast.

[ ] +1 Release this package as Apache Kylin 2.3.0
[ ]  0  I don't feel strongly about it, but I'm okay with the release
[ ] -1  Do not release this package because...

Here is my vote:

+1 (binding)

With Warm regards

Billy Liu

[GitHub] yiming187 closed pull request #104: KYLIN-3263, bugfix with AbstractExecutable's retry.

[GitBox]

yiming187 closed pull request #104: KYLIN-3263, bugfix with 
AbstractExecutable's retry.
URL: https://github.com/apache/kylin/pull/104
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java 
b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
index 91283f0f2d..dbe11c2ea3 100644
--- 
a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
+++ 
b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
@@ -165,7 +165,7 @@ public final ExecuteResult execute(ExecutableContext 
executableContext) throws E
 exception = e;
 }
 retry++;
-} while (needRetry(result, exception));
+} while (needRetry(this.retry, exception)); //exception in 
ExecuteResult should handle by user itself.
 
 if (exception != null) {
 onExecuteError(exception, executableContext);
@@ -221,13 +221,6 @@ private boolean isMetaDataPersistException(Exception e) {
 return false;
 }
 
-private boolean isRetryableExecutionResult(ExecuteResult result) {
-if (result != null && result.getThrowable() != null && 
isRetrableException(result.getThrowable())) {
-return true;
-}
-return false;
-}
-
 protected abstract ExecuteResult doWork(ExecutableContext context) throws 
ExecuteException;
 
 @Override
@@ -468,25 +461,20 @@ protected final boolean isPaused() {
 return status == ExecutableState.STOPPED;
 }
 
-protected boolean isRetrableException(Throwable t) {
-return 
ArrayUtils.contains(KylinConfig.getInstanceFromEnv().getJobRetryExceptions(), 
t.getClass().getName());
-}
-
 // Retry will happen in below cases:
 // 1) if property "kylin.job.retry-exception-classes" is not set or is 
null, all jobs with exceptions will retry according to the retry times.
 // 2) if property "kylin.job.retry-exception-classes" is set and is not 
null, only jobs with the specified exceptions will retry according to the retry 
times.
-protected boolean needRetry(ExecuteResult result, Throwable e) {
-if (this.retry > KylinConfig.getInstanceFromEnv().getJobRetry()) {
+public static boolean needRetry(int retry, Throwable t) {
+if (retry > KylinConfig.getInstanceFromEnv().getJobRetry() || t == 
null) {
 return false;
+} else {
+return isRetryableException(t.getClass().getName());
 }
-String[] retryableEx = 
KylinConfig.getInstanceFromEnv().getJobRetryExceptions();
-if (retryableEx == null || retryableEx.length == 0) {
-return true;
-}
-if ((result != null && isRetryableExecutionResult(result)) || e != 
null && isRetrableException(e)) {
-return true;
-}
-return false;
+}
+
+private static boolean isRetryableException(String exceptionName) {
+String[] jobRetryExceptions = 
KylinConfig.getInstanceFromEnv().getJobRetryExceptions();
+return ArrayUtils.isEmpty(jobRetryExceptions) || 
ArrayUtils.contains(jobRetryExceptions, exceptionName);
 }
 
 @Override
diff --git 
a/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java 
b/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java
deleted file mode 100644
index f656c44058..00
--- a/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java
+++ /dev/null
@@ -1,50 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.kylin.job;
-
-import org.apache.kylin.common.KylinConfig;
-import org.apache.kylin.job.execution.ExecutableContext;
-import org.apache.kylin.job.execution.ExecuteResult;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-/**
- */
-public class RetryableTestExecutable extends BaseTestExecutable {
-private static final Logger 

[GitHub] coveralls commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's retry.

[GitBox]

coveralls commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's 
retry.
URL: https://github.com/apache/kylin/pull/104#issuecomment-367983164
 
 
   ## Pull Request Test Coverage Report for [Build 
2991](https://coveralls.io/builds/15663717)
   
   * **5** of **5**  **(100.0%)** changed or added relevant lines in **1** file 
are covered.
   * **7** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.001%**) to **23.441%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15663717/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193)
 | 7 | 76.29% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/15663717/badge)](https://coveralls.io/builds/15663717)
 |
   | :-- | --: |
   | Change from base [Build 2978](https://coveralls.io/builds/15605811): |  
0.001% |
   | Covered Lines: | 14002 |
   | Relevant Lines: | 59734 |
   
   ---
   # ?  - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's retry.

[GitBox]

codecov-io commented on issue #104: KYLIN-3263, bugfix with 
AbstractExecutable's retry.
URL: https://github.com/apache/kylin/pull/104#issuecomment-367982611
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr=h1) Report
   > Merging [#104](https://codecov.io/gh/apache/kylin/pull/104?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/21ef4d6e4bb62eb3f5209b14daaa8ab404d0f4c5?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/104/graphs/tree.svg?height=150=650=JawVgbgsVo=pr)](https://codecov.io/gh/apache/kylin/pull/104?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #104  +/-   ##
   
   - Coverage 21.45%   21.45%   -0.01% 
   - Complexity 3815 3819   +4 
   
 Files   992  992  
 Lines 5974159734   -7 
 Branches   8639 8638   -1 
   
   - Hits  1281912813   -6 
   + Misses4574045734   -6 
   - Partials   1182 1187   +5
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/104?src=pr=tree) | Coverage ? 
| Complexity ? | |
   |---|---|---|---|
   | 
[...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=)
 | `51.69% <80%> (+3.55%)` | `46 <6> (+5)` | :arrow_up: |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `66.56% <0%> (-3.65%)` | `7% <0%> (?)` | |
   | 
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
 | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `65.35% <0%> (+0.78%)` | `0% <0%> (?)` | :arrow_down: |
   | 
[...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=)
 | `55.72% <0%> (+0.99%)` | `21% <0%> (?)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr=footer). Last 
update 
[21ef4d6...74dff9f](https://codecov.io/gh/apache/kylin/pull/104?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (KYLIN-3263) AbstractExecutable's retry has problem

[jiatao.tao (JIRA)]

jiatao.tao created KYLIN-3263:
-

 Summary: AbstractExecutable's retry has problem
 Key: KYLIN-3263
 URL: https://issues.apache.org/jira/browse/KYLIN-3263
 Project: Kylin
  Issue Type: Bug
Reporter: jiatao.tao
Assignee: jiatao.tao






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[CANCEL][VOTE] Release apache-kylin-2.3.0 (RC1)

[Billy Liu]

Due to the blocking issue at https://issues.apache.org/jira/browse/KYLIN-2913
I will cancel this vote, and prepare another vote when the blocking
issue is fixed.

With Warm regards

Billy Liu


2018-02-23 16:06 GMT+08:00 Billy Liu :
> Thanks Dong for the updates. I will cancel this vote.
>
> With Warm regards
>
> Billy Liu
>
>
> 2018-02-23 16:02 GMT+08:00 Dong Li :
>> Sorry to change my vote to -1.
>>
>> Just find a critical bug in 2.3.0-rc1 binary package.
>> See https://issues.apache.org/jira/browse/KYLIN-2913  reopened.
>> This will block cube merge and hurt job duration.
>>
>> Thanks,
>> Dong Li
>>
>> On 22/02/2018, 16:40, "Liukaige"  wrote:
>>
>> +1
>>
>> 2018-02-22 14:16 GMT+08:00 Jianhua Peng :
>>
>> > +1 binding
>> >
>> > On 2018/02/21 16:10:04, Billy Liu  wrote:
>> > > Hi all,
>> > >
>> > > I have created a build for Apache Kylin 2.3.0, release candidate 1.
>> > >
>> > > Changes highlights:
>> > >[KYLIN-2727] - Introduce cube planner able to select 
>> cost-effective
>> > > cuboids to be built by cost-based algorithms
>> > >[KYLIN-2726] - Introduce a dashboard for showing kylin service
>> > > related metrics, like query count, query latency, job count, etc
>> > >[KYLIN-3125] - Support SparkSql in Cube building step “Create
>> > > Intermediate Flat Hive Table”
>> > >[KYLIN-3044] - Support SQL Server as data source
>> > >[KYLIN-2960] - Support user/group and role authentication for LDAP
>> > >
>> > > And more than 240 issues fixed.
>> > >
>> > > Thanks to everyone who has contributed to this release.
>> > > Here's release notes:
>> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > version=12341685=12316121
>> > >
>> > > The commit to be voted upon:
>> > > https://github.com/apache/kylin/commit/cfe632125a6f8bfa043977c5cc657b
>> > b17258c3fe
>> > >
>> > > Its hash is cfe632125a6f8bfa043977c5cc657bb17258c3fe
>> > >
>> > > The artifacts to be voted on are located here:
>> > > https://dist.apache.org/repos/dist/dev/kylin/apache-kylin-2.3.0-rc1/
>> > >
>> > > The hashes of the artifacts are as follows:
>> > > apache-kylin-2.3.0-src.tar.gz.md5 a640f6c8d58a5ce2bf4262efcf38ee4d
>> > > apache-kylin-2.3.0-src.tar.gz.sha1 f60d9ccabd4e09db9d7799521a6186
>> > 2a68a37690
>> > >
>> > > A staged Maven repository is available for review at:
>> > > 
>> https://repository.apache.org/content/repositories/orgapachekylin-1046/
>> > >
>> > > Release artifacts are signed with the following key:
>> > > https://people.apache.org/keys/committer/billyliu.asc
>> > >
>> > > Please vote on releasing this package as Apache Kylin 2.3.0
>> > >
>> > > The vote is open for the next 72 hours and passes if a majority of at
>> > > least three +1 PPMC votes are cast.
>> > >
>> > > [ ] +1 Release this package as Apache Kylin 2.3.0
>> > > [ ]  0  I don't feel strongly about it, but I'm okay with the release
>> > > [ ] -1  Do not release this package because...
>> > >
>> > > Here is my vote:
>> > >
>> > > +1 (binding)
>> > >
>> > > With Warm regards
>> > >
>> > > Billy Liu
>> > >
>> >
>>
>>
>>
>> --
>> Best regards,
>>
>> Kaige Liu(刘凯歌)
>>
>> *"Do small things with great love." *
>>
>>
>>

Re: [VOTE] Release apache-kylin-2.3.0 (RC1)

[Billy Liu]

Thanks Dong for the updates. I will cancel this vote.

With Warm regards

Billy Liu


2018-02-23 16:02 GMT+08:00 Dong Li :
> Sorry to change my vote to -1.
>
> Just find a critical bug in 2.3.0-rc1 binary package.
> See https://issues.apache.org/jira/browse/KYLIN-2913  reopened.
> This will block cube merge and hurt job duration.
>
> Thanks,
> Dong Li
>
> On 22/02/2018, 16:40, "Liukaige"  wrote:
>
> +1
>
> 2018-02-22 14:16 GMT+08:00 Jianhua Peng :
>
> > +1 binding
> >
> > On 2018/02/21 16:10:04, Billy Liu  wrote:
> > > Hi all,
> > >
> > > I have created a build for Apache Kylin 2.3.0, release candidate 1.
> > >
> > > Changes highlights:
> > >[KYLIN-2727] - Introduce cube planner able to select cost-effective
> > > cuboids to be built by cost-based algorithms
> > >[KYLIN-2726] - Introduce a dashboard for showing kylin service
> > > related metrics, like query count, query latency, job count, etc
> > >[KYLIN-3125] - Support SparkSql in Cube building step “Create
> > > Intermediate Flat Hive Table”
> > >[KYLIN-3044] - Support SQL Server as data source
> > >[KYLIN-2960] - Support user/group and role authentication for LDAP
> > >
> > > And more than 240 issues fixed.
> > >
> > > Thanks to everyone who has contributed to this release.
> > > Here's release notes:
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > version=12341685=12316121
> > >
> > > The commit to be voted upon:
> > > https://github.com/apache/kylin/commit/cfe632125a6f8bfa043977c5cc657b
> > b17258c3fe
> > >
> > > Its hash is cfe632125a6f8bfa043977c5cc657bb17258c3fe
> > >
> > > The artifacts to be voted on are located here:
> > > https://dist.apache.org/repos/dist/dev/kylin/apache-kylin-2.3.0-rc1/
> > >
> > > The hashes of the artifacts are as follows:
> > > apache-kylin-2.3.0-src.tar.gz.md5 a640f6c8d58a5ce2bf4262efcf38ee4d
> > > apache-kylin-2.3.0-src.tar.gz.sha1 f60d9ccabd4e09db9d7799521a6186
> > 2a68a37690
> > >
> > > A staged Maven repository is available for review at:
> > > 
> https://repository.apache.org/content/repositories/orgapachekylin-1046/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/billyliu.asc
> > >
> > > Please vote on releasing this package as Apache Kylin 2.3.0
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PPMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Kylin 2.3.0
> > > [ ]  0  I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1  Do not release this package because...
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > With Warm regards
> > >
> > > Billy Liu
> > >
> >
>
>
>
> --
> Best regards,
>
> Kaige Liu(刘凯歌)
>
> *"Do small things with great love." *
>
>
>

Re: [VOTE] Release apache-kylin-2.3.0 (RC1)

[Dong Li]

Sorry to change my vote to -1.

Just find a critical bug in 2.3.0-rc1 binary package. 
See https://issues.apache.org/jira/browse/KYLIN-2913  reopened.
This will block cube merge and hurt job duration.

Thanks,
Dong Li

On 22/02/2018, 16:40, "Liukaige"  wrote:

+1

2018-02-22 14:16 GMT+08:00 Jianhua Peng :

> +1 binding
>
> On 2018/02/21 16:10:04, Billy Liu  wrote:
> > Hi all,
> >
> > I have created a build for Apache Kylin 2.3.0, release candidate 1.
> >
> > Changes highlights:
> >[KYLIN-2727] - Introduce cube planner able to select cost-effective
> > cuboids to be built by cost-based algorithms
> >[KYLIN-2726] - Introduce a dashboard for showing kylin service
> > related metrics, like query count, query latency, job count, etc
> >[KYLIN-3125] - Support SparkSql in Cube building step “Create
> > Intermediate Flat Hive Table”
> >[KYLIN-3044] - Support SQL Server as data source
> >[KYLIN-2960] - Support user/group and role authentication for LDAP
> >
> > And more than 240 issues fixed.
> >
> > Thanks to everyone who has contributed to this release.
> > Here's release notes:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> version=12341685=12316121
> >
> > The commit to be voted upon:
> > https://github.com/apache/kylin/commit/cfe632125a6f8bfa043977c5cc657b
> b17258c3fe
> >
> > Its hash is cfe632125a6f8bfa043977c5cc657bb17258c3fe
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/kylin/apache-kylin-2.3.0-rc1/
> >
> > The hashes of the artifacts are as follows:
> > apache-kylin-2.3.0-src.tar.gz.md5 a640f6c8d58a5ce2bf4262efcf38ee4d
> > apache-kylin-2.3.0-src.tar.gz.sha1 f60d9ccabd4e09db9d7799521a6186
> 2a68a37690
> >
> > A staged Maven repository is available for review at:
> > https://repository.apache.org/content/repositories/orgapachekylin-1046/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/billyliu.asc
> >
> > Please vote on releasing this package as Apache Kylin 2.3.0
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PPMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Kylin 2.3.0
> > [ ]  0  I don't feel strongly about it, but I'm okay with the release
> > [ ] -1  Do not release this package because...
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > With Warm regards
> >
> > Billy Liu
> >
>



-- 
Best regards,

Kaige Liu(刘凯歌)

*"Do small things with great love." *