[GitHub] coveralls commented on issue #274: KYLIN-3597 Improve code smell

coveralls commented on issue #274: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/274#issuecomment-425620750 ## Pull Request Test Coverage Report for [Build 3713](https://coveralls.io/builds/19260169) * **21** of **38** **(55.26%)** changed or added releva

[GitHub] codecov-io commented on issue #274: KYLIN-3597 Improve code smell

codecov-io commented on issue #274: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/274#issuecomment-425620454 # [Codecov](https://codecov.io/gh/apache/kylin/pull/274?src=pr&el=h1) Report > Merging [#274](https://codecov.io/gh/apache/kylin/pull/274?src=pr&el=desc)

[GitHub] hit-lacus opened a new pull request #274: KYLIN-3597 Improve code smell

hit-lacus opened a new pull request #274: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/274 https://issues.apache.org/jira/projects/KYLIN/issues/KYLIN-3597 This is an automated message from the Apache

[GitHub] asfgit commented on issue #274: KYLIN-3597 Improve code smell

asfgit commented on issue #274: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/274#issuecomment-425619076 Can one of the admins verify this patch? This is an automated message from the Apache Git Servi

[GitHub] asfgit commented on issue #274: KYLIN-3597 Improve code smell

asfgit commented on issue #274: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/274#issuecomment-425619077 Can one of the admins verify this patch? This is an automated message from the Apache Git Servi

Re: [DISCUSS] Columnar storage engine for Apache Kylin

Hi Yanghong, Thanks for your question. I think it is not required that other engines know how to read Kylin's storage, but it is a nice to have if possible. We can extend the file format if Parquet or ORC couldn't match Kylin's requirement, but not necessary to re-invent a new format. Zhong, Yang

[GitHub] codecov-io commented on issue #273: clearKylin 3597

codecov-io commented on issue #273: clearKylin 3597 URL: https://github.com/apache/kylin/pull/273#issuecomment-425618669 # [Codecov](https://codecov.io/gh/apache/kylin/pull/273?src=pr&el=h1) Report > Merging [#273](https://codecov.io/gh/apache/kylin/pull/273?src=pr&el=desc) into [master

[GitHub] coveralls commented on issue #273: clearKylin 3597

coveralls commented on issue #273: clearKylin 3597 URL: https://github.com/apache/kylin/pull/273#issuecomment-425618578 ## Pull Request Test Coverage Report for [Build 3712](https://coveralls.io/builds/19260056) * **0** of **57** **(0.0%)** changed or added relevant lines in **2**

[GitHub] caolijun1166 closed pull request #273: clearKylin 3597

caolijun1166 closed pull request #273: clearKylin 3597 URL: https://github.com/apache/kylin/pull/273 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] asfgit commented on issue #273: clearKylin 3597

asfgit commented on issue #273: clearKylin 3597 URL: https://github.com/apache/kylin/pull/273#issuecomment-425617489 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond

[GitHub] asfgit commented on issue #273: clearKylin 3597

asfgit commented on issue #273: clearKylin 3597 URL: https://github.com/apache/kylin/pull/273#issuecomment-425617490 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond

[GitHub] caolijun1166 opened a new pull request #273: clearKylin 3597

caolijun1166 opened a new pull request #273: clearKylin 3597 URL: https://github.com/apache/kylin/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

Re:Re: [DISCUSS] Columnar storage engine for Apache Kylin

I like parquet, it is very efficient format and supported by various projects, but there are some questions if we use parquet as the cube storage format: 1. Is it possible to locate a cuboid quickly in a parquet file? How to save cuboid metadata info in the parquet's FileMetaData, just in the m

[GitHub] luguosheng1314 closed pull request #265: KYLIN-3599 Bulk Add Measures

luguosheng1314 closed pull request #265: KYLIN-3599 Bulk Add Measures URL: https://github.com/apache/kylin/pull/265 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] coveralls edited a comment on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

coveralls edited a comment on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271#issuecomment-425606821 ## Pull Request Test Coverage Report for [Build 3709](https://coveralls.io/builds/19259293) * **0**

Re: [DISCUSS] Columnar storage engine for Apache Kylin

I have one question about the characteristics of Kylin columnar storage files. That is whether it should be a standard or common one. Since the data stored in the storage engine is Kylin specified, is it necessary for other engines to know how to build data into and how to read data from the sto

[GitHub] shaofengshi closed pull request #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

shaofengshi closed pull request #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prove

[GitHub] codecov-io edited a comment on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

codecov-io edited a comment on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271#issuecomment-425606722 # [Codecov](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=h1) Report > Merging [#271](https://co

[GitHub] asfgit commented on issue #272: KYLIN-3232 Add document for ops tools

asfgit commented on issue #272: KYLIN-3232 Add document for ops tools URL: https://github.com/apache/kylin/pull/272#issuecomment-425608683 Can one of the admins verify this patch? This is an automated message from the Apache G

[GitHub] asfgit commented on issue #272: KYLIN-3232 Add document for ops tools

asfgit commented on issue #272: KYLIN-3232 Add document for ops tools URL: https://github.com/apache/kylin/pull/272#issuecomment-425608684 Can one of the admins verify this patch? This is an automated message from the Apache G

[GitHub] GinaZhai opened a new pull request #272: KYLIN-3232 Add document for ops tools

GinaZhai opened a new pull request #272: KYLIN-3232 Add document for ops tools URL: https://github.com/apache/kylin/pull/272 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] coveralls commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

coveralls commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271#issuecomment-425606821 ## Pull Request Test Coverage Report for [Build 3706](https://coveralls.io/builds/19259026) * **0** of **3*

[GitHub] codecov-io commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

codecov-io commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271#issuecomment-425606722 # [Codecov](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=h1) Report > Merging [#271](https://codecov.i

[GitHub] yiming187 commented on issue #270: KYLIN-2924 enable google error-prone in compile phase

yiming187 commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425606016 @shaofengshi yes. I saw it. I have fixed all "ERROR" level issues, but the "WARNING" issues generated too much logs. Trying to ignor

[GitHub] shaofengshi commented on a change in pull request #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

shaofengshi commented on a change in pull request #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271#discussion_r221411226 ## File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/UpdateHT

[GitHub] caolijun1166 opened a new pull request #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

caolijun1166 opened a new pull request #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271 Close the HBase connection after used in UpdateHTableHostCLI T

[GitHub] asfgit commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

asfgit commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271#issuecomment-425605188 Can one of the admins verify this patch? This is an

[GitHub] asfgit commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI

asfgit commented on issue #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI URL: https://github.com/apache/kylin/pull/271#issuecomment-425605187 Can one of the admins verify this patch? This is an

[jira] [Created] (KYLIN-3603) HBase connection isn't closed in UpdateHTableHostCLI

Lijun Cao created KYLIN-3603: Summary: HBase connection isn't closed in UpdateHTableHostCLI Key: KYLIN-3603 URL: https://issues.apache.org/jira/browse/KYLIN-3603 Project: Kylin Issue Type: Bug

[GitHub] shaofengshi commented on issue #270: KYLIN-2924 enable google error-prone in compile phase

shaofengshi commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425600739 The travis-ci is failed with "The job exceeded the maximum log length, and has been terminated."

[GitHub] coveralls commented on issue #270: KYLIN-2924 enable google error-prone in compile phase

coveralls commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425479277 ## Pull Request Test Coverage Report for [Build 3705](https://coveralls.io/builds/19249459) * **1** of **12** **(8.33%)**

[GitHub] asfgit commented on issue #270: KYLIN-2924 enable google error-prone in compile phase

asfgit commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425467594 Can one of the admins verify this patch? This is an automated message

[GitHub] asfgit commented on issue #270: KYLIN-2924 enable google error-prone in compile phase

asfgit commented on issue #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270#issuecomment-425467595 Can one of the admins verify this patch? This is an automated message

[GitHub] yiming187 opened a new pull request #270: KYLIN-2924 enable google error-prone in compile phase

yiming187 opened a new pull request #270: KYLIN-2924 enable google error-prone in compile phase URL: https://github.com/apache/kylin/pull/270 This is an automated message from the Apache Git Service. To respond to the messag

Re: regarding creating and modifying cube

Hi, you can observe the Spark generated cuboid file size in kylin's working dir (for example: /kylin/kylin_metadata/kylin-fd785bab-b875-4626-8bc3-7d46e8862d88/kylin_sales_cube/cuboid/level_base_cuboid/, please replace the uuid and cube name with yours); If there are small files (e.g several Mbs), y

[jira] [Created] (KYLIN-3602) Enable more checkstyle rules

Yichen Zhou created KYLIN-3602: -- Summary: Enable more checkstyle rules Key: KYLIN-3602 URL: https://issues.apache.org/jira/browse/KYLIN-3602 Project: Kylin Issue Type: Improvement Comp

regarding creating and modifying cube

http://kylin.apache.org/docs20/tutorial/cube_spark.html In the above link there is mentioning about the affect of "kylin.engine.spark.rdd-partition-cut-mb" on cube building performance. how to decide  the optimum value of "kylin.engine.spark.rdd-partition-cut-mb" for cube creation?

[GitHub] shaofengshi closed pull request #262: KYLIN-3597 Improve code smell

shaofengshi closed pull request #262: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/262 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

[jira] [Created] (KYLIN-3601) PreparedContextPool生成的连接数据与配置不一致

huaicui created KYLIN-3601: -- Summary: PreparedContextPool生成的连接数据与配置不一致 Key: KYLIN-3601 URL: https://issues.apache.org/jira/browse/KYLIN-3601 Project: Kylin Issue Type: Bug Components: Quer

[GitHub] coveralls edited a comment on issue #262: KYLIN-3597 Improve code smell

coveralls edited a comment on issue #262: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/262#issuecomment-425150222 ## Pull Request Test Coverage Report for [Build 3701](https://coveralls.io/builds/19241540) * **4** of **70** **(5.71%)** changed or added r

[GitHub] codecov-io commented on issue #262: KYLIN-3597 Improve code smell

codecov-io commented on issue #262: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/262#issuecomment-425344030 # [Codecov](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=h1) Report > Merging [#262](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=desc)