Re: Java 8

2017-02-09 Thread Rajat Khandelwal
I'll create a jira and submit patch. Pre-commit job is already running with java 8. We have two post-commit jobs, one for java7 and one for java8. I'll modify jdk setting in the jenkins job of the java7 post commit job. Nothing else should be required. Please reply if I'm missing anything. On

Failure in Cube test setup

2017-02-09 Thread Rajat Khandelwal
I'm trying to build master branch and I'm getting this error: Tests run: 458, Failures: 1, Errors: 0, Skipped: 457, Time elapsed: 84.017 sec <<< FAILURE! - in TestSuite setup(org.apache.lens.cube.parse.TestCubeRewriter) Time elapsed: 81.989 sec <<< FAILURE!

Re: Java 8

2017-02-09 Thread Raju Bairishetti
+1 https://builds.apache.org/job/Lens-Commit-Java8/ job was configured more than a year ago :). Looks like build has been passing. Precommit lens job is also using java8 for builds. Updated java version to *JDK_1_8_0_92_HOME* from

[jira] [Commented] (LENS-1372) QueryRetryTest is flaky

2017-02-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860099#comment-15860099 ] Ted Yu commented on LENS-1372: --

Re: Java 8

2017-02-09 Thread Puneet Gupta
Then should we try building by setting source and target to 1.8 ? 1.7 1.7 Thanks, Puneet Gupta On Thu, Feb 9, 2017 at 4:27 PM, amareshwarisr . wrote: > Yes - we have latest build passed as well : > https://builds.apache.org/job/Lens-Commit-Java8/303/ > > On Thu, Feb 9,

Re: Java 8

2017-02-09 Thread amareshwarisr .
Yes - we have latest build passed as well : https://builds.apache.org/job/Lens-Commit-Java8/303/ On Thu, Feb 9, 2017 at 3:21 PM, Rajat Khandelwal wrote: > Yeah, I suppose. We have a build jenkins job for java8. I'll try running > tests on my local environment. > > On

Re: Java 8

2017-02-09 Thread Rajat Khandelwal
Yeah, I suppose. We have a build jenkins job for java8. I'll try running tests on my local environment. On Thu, Feb 9, 2017 at 2:42 PM Puneet Gupta wrote: > Can our code compile on Java 8 in current state ? > > Thanks, > Puneet Gupta > > On Thu, Feb 9, 2017 at 2:41 PM,

Re: Java 8

2017-02-09 Thread Puneet Gupta
Can our code compile on Java 8 in current state ? Thanks, Puneet Gupta On Thu, Feb 9, 2017 at 2:41 PM, amareshwarisr . wrote: > +1 > > On Thu, Feb 9, 2017 at 12:25 PM, Rajat Khandelwal > wrote: > > > It's been 2 years since we said "Lens won't compile

Re: Java 8

2017-02-09 Thread amareshwarisr .
+1 On Thu, Feb 9, 2017 at 12:25 PM, Rajat Khandelwal wrote: > It's been 2 years since we said "Lens won't compile on Java 6 anymore". > I've used Java 8 in other places and I like the new features and > capabilities and I think we can make use of them to make our complex code