Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review151149 --- Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 29,

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/ --- (Updated Sept. 29, 2016, 10:27 a.m.) Review request for lens. Bugs:

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

> On Sept. 29, 2016, 10:02 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 30 > > > > > > Can you also describe significance of

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150832 ---

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/ --- (Updated Sept. 29, 2016, 6:34 a.m.) Review request for lens. Bugs: LENS-1340

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

> On Sept. 29, 2016, 5:04 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 35 > > > > > > Will it be measure names here or measure

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150811 ---

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

> On Sept. 28, 2016, 8:59 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 34 > > > > > > Please add java for all method params,

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/ --- (Updated Sept. 28, 2016, 9:25 a.m.) Review request for lens. Bugs: LENS-1340

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

> On Sept. 26, 2016, 1:19 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 32 > > > > > > What interval are the keys in the map spaced over?

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150695 ---

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

> On Sept. 26, 2016, 1:19 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 32 > > > > > > What interval are the keys in the map spaced over?

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150396 ---

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

> On Sept. 26, 2016, 12:44 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java, > > line 29 > > > > > > Can you add documentation? e.g. What is the key

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/ --- (Updated Sept. 26, 2016, 1:03 p.m.) Review request for lens. Bugs: LENS-1340

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52259/#review150390 ---