Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review176761 --- Ship it! Ship It! - Amareshwari Sriramadasu On June 2,

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review176749 ---

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

> On May 16, 2017, 2:57 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > > Line 607 (original), 602 (patched) > > > > > > Should we create an interface for

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

> On May 25, 2017, 9:58 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 1226 (patched) > > > > > > should we say columns and storages will do > On May 25, 2017, 9:58

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/ --- (Updated June 2, 2017, 9:41 a.m.) Review request for lens, Rajat Khandelwal

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/ --- (Updated June 2, 2017, 7:20 a.m.) Review request for lens, Rajat Khandelwal

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review176051 --- lens-api/src/main/resources/cube-0.1.xsd Lines 1226 (patched)

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/ --- (Updated May 22, 2017, 10:59 a.m.) Review request for lens, Rajat Khandelwal

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review175246 ---

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review175244 ---

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > > Lines 95 (patched) > > > > > > Why would we need this mapping? Can

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/ --- (Updated May 17, 2017, 11:54 a.m.) Review request for lens, Rajat Khandelwal

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review175209 ---