Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-24 Thread Sushil Mohanty
> On Oct. 25, 2015, 2:19 a.m., Srikanth Sundarrajan wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java, > > line 1169 > > > > > > Will this replace ` in any expression

[jira] [Commented] (LENS-835) Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/LENS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972973#comment-14972973 ] Hadoop QA commented on LENS-835: Applied patch:

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2015-10-24 Thread Raju Bairishetti
> On Oct. 25, 2015, 1:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 89 > > > > > > Why is this required? There can be more than one

[jira] [Commented] (LENS-838) Literals with escaped quotes are not honoured in columnarSQLRewriter

2015-10-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/LENS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972972#comment-14972972 ] Hadoop QA commented on LENS-838: Applied patch:

Re: Review Request 39394: LENS-830: Checkstyle version should be picked from project version

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39394/#review103917 --- pom.xml (line 550)

[jira] [Updated] (LENS-835) Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-24 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-835: Status: Patch Available (was: Open) > Optimizing fact subquery by removing non aggregated expression

[jira] [Updated] (LENS-842) Replace backquote with double quote in column alias for JDBC query

2015-10-24 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-842: Status: Patch Available (was: Open) > Replace backquote with double quote in column alias for JDBC

[jira] [Updated] (LENS-842) Replace backquote with double quote in column alias for JDBC query

2015-10-24 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-842: Attachment: LENS-842.patch > Replace backquote with double quote in column alias for JDBC query >

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2015-10-24 Thread Amareshwari Sriramadasu
> On Oct. 25, 2015, 1:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 89 > > > > > > Why is this required? There can be more than one

Re: Review Request 39439: LENS-835 : Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39439/#review103915 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 19, 2015,

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2015-10-24 Thread Raju Bairishetti
> On Oct. 25, 2015, 1:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 89 > > > > > > Why is this required? There can be more than one

Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103931 --- I see the issue is still open, but review request is closed. So,

[jira] [Issue Comment Deleted] (LENS-832) Queued cube queries on JDBCDriver are not getting restored correctly

2015-10-24 Thread Srikanth Sundarrajan (JIRA)
[ https://issues.apache.org/jira/browse/LENS-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Sundarrajan updated LENS-832: -- Comment: was deleted (was: Will do a cursory check on this. If I think I can chip in on

[jira] [Commented] (LENS-832) Queued cube queries on JDBCDriver are not getting restored correctly

2015-10-24 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972995#comment-14972995 ] Amareshwari Sriramadasu commented on LENS-832: -- Review request updated at

[jira] [Updated] (LENS-838) Literals with escaped quotes are not honoured in columnarSQLRewriter

2015-10-24 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-838: - Resolution: Fixed Fix Version/s: 2.5 Status: Resolved (was: Patch

[jira] [Updated] (LENS-835) Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-24 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-835: - Resolution: Fixed Fix Version/s: 2.5 Status: Resolved (was: Patch

[jira] [Updated] (LENS-832) Queued cube queries on JDBCDriver are not getting restored correctly

2015-10-24 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-832: - Affects Version/s: 2.3 > Queued cube queries on JDBCDriver are not getting restored

[jira] [Updated] (LENS-832) Queued cube queries on JDBCDriver are not getting restored correctly

2015-10-24 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-832: - Attachment: LENS-832.patch Patch after review. > Queued cube queries on JDBCDriver

[jira] [Updated] (LENS-843) Columns in having clause not getting push down.

2015-10-24 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-843: Status: Patch Available (was: Open) > Columns in having clause not getting push down. >

[jira] [Updated] (LENS-843) Columns in having clause not getting push down.

2015-10-24 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-843: Attachment: LENS-843.patch > Columns in having clause not getting push down. >

[jira] [Commented] (LENS-832) Queued cube queries on JDBCDriver are not getting restored correctly

2015-10-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/LENS-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973036#comment-14973036 ] Hadoop QA commented on LENS-832: Applied patch:

Re: Review Request 39483: LENS-838 : Literals with escaped quotes are not honoured in columnarSQLRewriter

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39483/#review103914 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 20, 2015,

Re: Review Request 39606: LENS-843 : Columns in having clause not getting push down

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39606/#review103912 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 23, 2015,

[jira] [Updated] (LENS-838) Literals with escaped quotes are not honoured in columnarSQLRewriter

2015-10-24 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-838: Status: Patch Available (was: Open) > Literals with escaped quotes are not honoured in

[jira] [Updated] (LENS-838) Literals with escaped quotes are not honoured in columnarSQLRewriter

2015-10-24 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-838: Attachment: LENS-838_1.patch > Literals with escaped quotes are not honoured in columnarSQLRewriter >

[jira] [Updated] (LENS-835) Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-24 Thread Sushil Mohanty (JIRA)
[ https://issues.apache.org/jira/browse/LENS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushil Mohanty updated LENS-835: Attachment: LENS-835.patch > Optimizing fact subquery by removing non aggregated expression columns

[jira] [Commented] (LENS-843) Columns in having clause not getting push down.

2015-10-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/LENS-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972971#comment-14972971 ] Hadoop QA commented on LENS-843: Applied patch:

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2015-10-24 Thread Raju Bairishetti
> On Oct. 25, 2015, 1:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 89 > > > > > > Why is this required? There can be more than one