[jira] [Commented] (LENS-1168) Isolate submissions for each driver

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388944#comment-15388944
 ] 

Hadoop QA commented on LENS-1168:
-

Applied patch: 
[LENS-1168.5.patch|https://issues.apache.org/jira/secure/attachment/12819550/LENS-1168.5.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/696/

> Isolate submissions for each driver
> ---
>
> Key: LENS-1168
> URL: https://issues.apache.org/jira/browse/LENS-1168
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1168.4.patch, LENS-1168.5.patch
>
>
> We need to isolate query submitters for each driver to be different. We have 
> seen scenarios where hive submission takes time and other interactive queries 
> on jdbc are queued because querysubmitter was busy. 
> Also, each driver can have a pool of submitters - which should benefit 
> interactive queries with immediate submissions, especially the ones submitted 
> on EXECUTE_WITH_TIMEOUT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1168) Isolate submissions for each driver

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388909#comment-15388909
 ] 

Hadoop QA commented on LENS-1168:
-

Applied patch: 
[LENS-1168.5.patch|https://issues.apache.org/jira/secure/attachment/12819550/LENS-1168.5.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/695/

> Isolate submissions for each driver
> ---
>
> Key: LENS-1168
> URL: https://issues.apache.org/jira/browse/LENS-1168
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1168.4.patch, LENS-1168.5.patch
>
>
> We need to isolate query submitters for each driver to be different. We have 
> seen scenarios where hive submission takes time and other interactive queries 
> on jdbc are queued because querysubmitter was busy. 
> Also, each driver can have a pool of submitters - which should benefit 
> interactive queries with immediate submissions, especially the ones submitted 
> on EXECUTE_WITH_TIMEOUT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49371: LENS-1168 : Add query launcher pool

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49371/
---

(Updated July 22, 2016, 4:05 a.m.)


Review request for lens.


Changes
---

Test failure fixed


Bugs: LENS-1168
https://issues.apache.org/jira/browse/LENS-1168


Repository: lens


Description
---

Changes include :
- Add query launcher pool which would launch queries after applying constraint 
checks.
- Add max concurrent launching queries constraint - to limit number parallel 
launches at any time.
- Update StatusPoller to skip launching queries
- Update cancelQuery to interrupt launcher.
- Added test to verify parallel launches.


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java
 7fd2d81 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 8ba0689 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 d10ad09 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
 b2319a9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
 442cd99 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
 38b74ae 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 1e8d540 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 be0e2c8 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  lens-server/src/main/resources/lensserver-default.xml 3ce8fc1 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java d5e975a 
  
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 
0b38517 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java
 0df436a 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
6af4225 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
 c8ebd0c 
  lens-server/src/test/resources/logback.xml a345054 
  src/site/apt/admin/config.apt 852955b 

Diff: https://reviews.apache.org/r/49371/diff/


Testing
---


Thanks,

Amareshwari Sriramadasu

[jira] [Updated] (LENS-1168) Isolate submissions for each driver

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1168:
--
Attachment: LENS-1168.5.patch

Fix test failure.

> Isolate submissions for each driver
> ---
>
> Key: LENS-1168
> URL: https://issues.apache.org/jira/browse/LENS-1168
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1168.4.patch, LENS-1168.5.patch
>
>
> We need to isolate query submitters for each driver to be different. We have 
> seen scenarios where hive submission takes time and other interactive queries 
> on jdbc are queued because querysubmitter was busy. 
> Also, each driver can have a pool of submitters - which should benefit 
> interactive queries with immediate submissions, especially the ones submitted 
> on EXECUTE_WITH_TIMEOUT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-998) Partition skip is not logging correct start and end time in the logs.

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-998:
-
Status: Open  (was: Patch Available)

> Partition skip is not logging correct start and end time in the logs.
> -
>
> Key: LENS-998
> URL: https://issues.apache.org/jira/browse/LENS-998
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-998-1.patch, LENS-998-2.patch, LENS-998.patch
>
>
> Seeing below log lines in server log 
> {CODE}
> INFO org.apache.lens.cube.metadata.CubeMetastoreClient - List of partitions 
> skipped : {}, because they fall before fact start time : Sun Dec 02 16:47:04 
> UTC 292269055 and after fact end time : Sun Aug 17 07:12:55 UTC 292278994
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-998) Partition skip is not logging correct start and end time in the logs.

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388848#comment-15388848
 ] 

Amareshwari Sriramadasu commented on LENS-998:
--

[~sushilmohanty] Seems there are checkstyle issues with patch. Please update - 

/home/jenkins/jenkins-slave/workspace/PreCommit-Lens-Build/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java:976:93:
 '+' should be on a new line.


> Partition skip is not logging correct start and end time in the logs.
> -
>
> Key: LENS-998
> URL: https://issues.apache.org/jira/browse/LENS-998
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-998-1.patch, LENS-998-2.patch, LENS-998.patch
>
>
> Seeing below log lines in server log 
> {CODE}
> INFO org.apache.lens.cube.metadata.CubeMetastoreClient - List of partitions 
> skipped : {}, because they fall before fact start time : Sun Dec 02 16:47:04 
> UTC 292269055 and after fact end time : Sun Aug 17 07:12:55 UTC 292278994
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49770: Core scheduler

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review143174
---


Fix it, then Ship it!




Changes look good to me.


lens-server/src/main/resources/lensserver-default.xml (line 876)


why are we setting default value to 0 ?


- Amareshwari Sriramadasu


On July 21, 2016, 10:10 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 21, 2016, 10:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  fe2dfb3 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> c8a9ac6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  1e8d540 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
>  95057e4 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
>  d21cd05 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 63a7874 
>   lens-server/src/main/resources/lensserver-default.xml 6dc322e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  06883ae 
>   src/site/apt/admin/config.apt 5b76069 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Commented] (LENS-998) Partition skip is not logging correct start and end time in the logs.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388840#comment-15388840
 ] 

Hadoop QA commented on LENS-998:


Applied patch: 
[LENS-998-2.patch|https://issues.apache.org/jira/secure/attachment/12819035/LENS-998-2.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/694/

> Partition skip is not logging correct start and end time in the logs.
> -
>
> Key: LENS-998
> URL: https://issues.apache.org/jira/browse/LENS-998
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-998-1.patch, LENS-998-2.patch, LENS-998.patch
>
>
> Seeing below log lines in server log 
> {CODE}
> INFO org.apache.lens.cube.metadata.CubeMetastoreClient - List of partitions 
> skipped : {}, because they fall before fact start time : Sun Dec 02 16:47:04 
> UTC 292269055 and after fact end time : Sun Aug 17 07:12:55 UTC 292278994
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1168) Isolate submissions for each driver

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388833#comment-15388833
 ] 

Hadoop QA commented on LENS-1168:
-

Applied patch: 
[LENS-1168.4.patch|https://issues.apache.org/jira/secure/attachment/12819540/LENS-1168.4.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/693/

> Isolate submissions for each driver
> ---
>
> Key: LENS-1168
> URL: https://issues.apache.org/jira/browse/LENS-1168
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1168.4.patch
>
>
> We need to isolate query submitters for each driver to be different. We have 
> seen scenarios where hive submission takes time and other interactive queries 
> on jdbc are queued because querysubmitter was busy. 
> Also, each driver can have a pool of submitters - which should benefit 
> interactive queries with immediate submissions, especially the ones submitted 
> on EXECUTE_WITH_TIMEOUT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1218) Document the new ui in install and run step

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388818#comment-15388818
 ] 

Hudson commented on LENS-1218:
--

UNSTABLE: Integrated in Lens-Commit-Java8 #208 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/208/])
LENS-1218 : Document Lens UI in install and run steps (amareshwari: rev 
c33ef999112a0c784a2b78701af40cb17127d84d)
* src/site/apt/lenshome/install-and-run.apt
* src/site/apt/developer/contribute.apt


> Document the new ui in install and run step
> ---
>
> Key: LENS-1218
> URL: https://issues.apache.org/jira/browse/LENS-1218
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.6
>
> Attachments: LENS-1218.02.patch, LENS-1218.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1218) Document the new ui in install and run step

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388814#comment-15388814
 ] 

Hudson commented on LENS-1218:
--

UNSTABLE: Integrated in Lens-Commit #1296 (See 
[https://builds.apache.org/job/Lens-Commit/1296/])
LENS-1218 : Document Lens UI in install and run steps (amareshwari: rev 
c33ef999112a0c784a2b78701af40cb17127d84d)
* src/site/apt/lenshome/install-and-run.apt
* src/site/apt/developer/contribute.apt


> Document the new ui in install and run step
> ---
>
> Key: LENS-1218
> URL: https://issues.apache.org/jira/browse/LENS-1218
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.6
>
> Attachments: LENS-1218.02.patch, LENS-1218.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1217) Remove old java ui server

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1217:
--
Status: Open  (was: Patch Available)

[~prongs] org.apache.lens.server.TestLensServer.testUIServer has failed. Please 
have look.
 

> Remove old java ui server
> -
>
> Key: LENS-1217
> URL: https://issues.apache.org/jira/browse/LENS-1217
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: docs, server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.6
>
> Attachments: LENS-1217.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1217) Remove old java ui server

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1217:
--
Fix Version/s: 2.6
  Component/s: server
   docs
   Issue Type: Improvement  (was: Bug)

> Remove old java ui server
> -
>
> Key: LENS-1217
> URL: https://issues.apache.org/jira/browse/LENS-1217
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: docs, server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.6
>
> Attachments: LENS-1217.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1168) Isolate submissions for each driver

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1168:
--
Attachment: LENS-1168.4.patch

Patch from reviewboard

> Isolate submissions for each driver
> ---
>
> Key: LENS-1168
> URL: https://issues.apache.org/jira/browse/LENS-1168
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1168.4.patch
>
>
> We need to isolate query submitters for each driver to be different. We have 
> seen scenarios where hive submission takes time and other interactive queries 
> on jdbc are queued because querysubmitter was busy. 
> Also, each driver can have a pool of submitters - which should benefit 
> interactive queries with immediate submissions, especially the ones submitted 
> on EXECUTE_WITH_TIMEOUT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1168) Isolate submissions for each driver

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1168:
--
Status: Patch Available  (was: Open)

> Isolate submissions for each driver
> ---
>
> Key: LENS-1168
> URL: https://issues.apache.org/jira/browse/LENS-1168
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1168.4.patch
>
>
> We need to isolate query submitters for each driver to be different. We have 
> seen scenarios where hive submission takes time and other interactive queries 
> on jdbc are queued because querysubmitter was busy. 
> Also, each driver can have a pool of submitters - which should benefit 
> interactive queries with immediate submissions, especially the ones submitted 
> on EXECUTE_WITH_TIMEOUT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1218) Document the new ui in install and run step

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1218:
--
   Resolution: Fixed
Fix Version/s: 2.6
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~prongs]

> Document the new ui in install and run step
> ---
>
> Key: LENS-1218
> URL: https://issues.apache.org/jira/browse/LENS-1218
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.6
>
> Attachments: LENS-1218.02.patch, LENS-1218.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1218) Document the new ui in install and run step

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1218:
--
Component/s: docs

> Document the new ui in install and run step
> ---
>
> Key: LENS-1218
> URL: https://issues.apache.org/jira/browse/LENS-1218
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.6
>
> Attachments: LENS-1218.02.patch, LENS-1218.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1218) Document the new ui in install and run step

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387964#comment-15387964
 ] 

Hadoop QA commented on LENS-1218:
-

Applied patch: 
[LENS-1218.05.patch|https://issues.apache.org/jira/secure/attachment/12819326/LENS-1218.05.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/690/

> Document the new ui in install and run step
> ---
>
> Key: LENS-1218
> URL: https://issues.apache.org/jira/browse/LENS-1218
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1218.02.patch, LENS-1218.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1217) Remove old java ui server

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387927#comment-15387927
 ] 

Hadoop QA commented on LENS-1217:
-

Applied patch: 
[LENS-1217.03.patch|https://issues.apache.org/jira/secure/attachment/12819327/LENS-1217.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/691/

> Remove old java ui server
> -
>
> Key: LENS-1217
> URL: https://issues.apache.org/jira/browse/LENS-1217
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1217.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-996) Improvements in filters of query list api

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387895#comment-15387895
 ] 

Hadoop QA commented on LENS-996:


Applied patch: 
[LENS-996.04.patch|https://issues.apache.org/jira/secure/attachment/12819328/LENS-996.04.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/692/

> Improvements in filters of query list api
> -
>
> Key: LENS-996
> URL: https://issues.apache.org/jira/browse/LENS-996
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-996.04.patch
>
>
> 1. fromDate and endDate should also take human readable dates. 
> DateUtil.resolveDate can be used. 
> 2. the status filter should be case-insensitive. 
> 3. (maybe) the user filter and status filter can take multiple comma 
> separated values and return the union in the result. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-996) Improvements in filters of query list api

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-996:
--
Attachment: LENS-996.04.patch

> Improvements in filters of query list api
> -
>
> Key: LENS-996
> URL: https://issues.apache.org/jira/browse/LENS-996
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-996.04.patch
>
>
> 1. fromDate and endDate should also take human readable dates. 
> DateUtil.resolveDate can be used. 
> 2. the status filter should be case-insensitive. 
> 3. (maybe) the user filter and status filter can take multiple comma 
> separated values and return the union in the result. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-996) Improvements in filters of query list api

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387682#comment-15387682
 ] 

Rajat Khandelwal commented on LENS-996:
---

Taking patch from reviewboard and attaching

> Improvements in filters of query list api
> -
>
> Key: LENS-996
> URL: https://issues.apache.org/jira/browse/LENS-996
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-996.04.patch
>
>
> 1. fromDate and endDate should also take human readable dates. 
> DateUtil.resolveDate can be used. 
> 2. the status filter should be case-insensitive. 
> 3. (maybe) the user filter and status filter can take multiple comma 
> separated values and return the union in the result. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-996) Improvements in filters of query list api

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-996:
--
Status: Patch Available  (was: In Progress)

> Improvements in filters of query list api
> -
>
> Key: LENS-996
> URL: https://issues.apache.org/jira/browse/LENS-996
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-996.04.patch
>
>
> 1. fromDate and endDate should also take human readable dates. 
> DateUtil.resolveDate can be used. 
> 2. the status filter should be case-insensitive. 
> 3. (maybe) the user filter and status filter can take multiple comma 
> separated values and return the union in the result. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 50133: LENS-996: Improvements in filters of query list api

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
---

(Updated July 21, 2016, 7:05 p.m.)


Review request for lens.


Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996


Repository: lens


Description
---

1. fromDate and endDate should also take human readable dates. 
DateUtil.resolveDate can be used. 
2. the status filter should be case-insensitive. 
3. (maybe) the user filter and status filter can take multiple comma separated 
values and return the union in the result.


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
b82cd95b5633b91e03cf1df8ac2602cb7798099a 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 d10ad099b7220545802a3fcc7fd6e32a1c5b272a 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 be0e2c80a6c0081537feaea330192dc85949ad05 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
 803bbe3db982dc74ba2a1bdba94fc68879dcd351 
  
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 
304dc8efad8bd27c88b58b6ca319dfedcd4ac239 

Diff: https://reviews.apache.org/r/50133/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1217) Remove old java ui server

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387676#comment-15387676
 ] 

Rajat Khandelwal commented on LENS-1217:


Taking patch from reviewboard and attaching

> Remove old java ui server
> -
>
> Key: LENS-1217
> URL: https://issues.apache.org/jira/browse/LENS-1217
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1217.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1218) Document the new ui in install and run step

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387675#comment-15387675
 ] 

Rajat Khandelwal commented on LENS-1218:


Taking patch from reviewboard and attaching

> Document the new ui in install and run step
> ---
>
> Key: LENS-1218
> URL: https://issues.apache.org/jira/browse/LENS-1218
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1218.02.patch, LENS-1218.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 50131: LENS-1217: Remove old java ui server

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/
---

(Updated July 21, 2016, 7:02 p.m.)


Review request for lens.


Bugs: LENS-1217
https://issues.apache.org/jira/browse/LENS-1217


Repository: lens


Description
---


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab020b69d7f8b5b2f8ef5675995ef3b36f3 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java 
b6983f4c78a9a48c2503560b529663622a3efc36 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 
7618669d75a6aca25c8fdf9af1268758dbe7de38 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 
27388a7503508b26bdecf5266c98e4cbcc7a94a8 
  
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 
304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 
37bf094347955c5a211299d4367a20bb38dfbc08 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 
7e0758975cc4d991c24a1df963095d38189f5622 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java 
de4ce333082fb80cd0dd7cf64848ddc415336a9e 
  lens-server/src/main/resources/lensserver-default.xml 
3ce8fc1f12b279745d083b8249e942bb7dd6653a 
  lens-server/src/test/java/org/apache/lens/server/TestLensServer.java 
eb27f61f5f7e09993e5fd9a27695f07683fa7dff 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java 
f8c5bf28457074072d70fdb742b0300380f0679c 
  
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 
aa2874779d4d9e469f124aa9646a02742e2c4960 

Diff: https://reviews.apache.org/r/50131/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Updated] (LENS-1218) Document the new ui in install and run step

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1218:
---
Attachment: LENS-1218.05.patch

> Document the new ui in install and run step
> ---
>
> Key: LENS-1218
> URL: https://issues.apache.org/jira/browse/LENS-1218
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1218.02.patch, LENS-1218.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 50188: LENS-1218: Document the new ui in install and run step

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/
---

(Updated July 21, 2016, 7 p.m.)


Review request for lens.


Bugs: LENS-1218
https://issues.apache.org/jira/browse/LENS-1218


Repository: lens


Description
---


Diffs (updated)
-

  src/site/apt/developer/contribute.apt 
a2fd59eacbef1bd63eaf59f7d744893e495a6056 
  src/site/apt/lenshome/install-and-run.apt 
f13382263d88edae9ec78f59f3476910ff650453 

Diff: https://reviews.apache.org/r/50188/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 49154: LENS-1202: Add client side iterator for result in python client

[Rajat Khandelwal]

> On July 14, 2016, 12:38 p.m., Ajay Yadava wrote:
> > contrib/clients/python/README.md, line 15
> > 
> >
> > With all the special methods defined it makes the code unintuitive. You 
> > don't know whether to treat 'queries' as a method or as a datastructure.
> > 
> > It will be nice to change to something like below:
> > 
> > client.get_queries() :returns a list of queries
> > client.get_query() : returns details using query handle.
> > 
> > Explicit functions corresponding to various rest endpoints will ensure 
> > more readability and intuitive client api.

Valid points, but I wanted to design it a little differently. Will try to 
explain my thought process in this comment:

1. What you're suggesting would blow up soon since there will be one method for 
each REST endpoint. And I didn't want to have all those methods in one client 
instance.
2. Going by that, I decided to have one client for each grouping of endpoints. 
So `LensClient` as a top-level class doesn't have much functionality, the 
sub-clients it has are the points of interaction. 
3. So the user will be interacting with `client.queryClient`, 
`client.metadataClient`, `client.logClient`, ...
4. I considered the following options for the syntax of getquery:
4.1. `client.query_client.get_query(handle)`: too much use of `query`
4.2. `client.get_query(handle)`: Because of the first point.
4.3. `client.query_client.get(handle)`: A better version of 4.1, but the 
final function name is just `get`, which doesn't look nice. The answer to get 
`what` is only getting conveyed by the `query_client` part in the code.
4.4. Improving 4.3 further, `client.queries.get(handle)` looks much better 
because `queries` is a better answer to `what` than `query_client`. 
4.5. Built-in collection classes(e.g. dict), and other classes that behave 
like collections(e.g. MailBox) implement a function `get(x, default=None)` and 
accompany that with `__getitem__`. So I finally decided on using `__getitem__`. 
`get(x, default)` wouldn't make sense in our case, since a query is either 
there, or it's not there. No point of defaults. 
5. The above is supported when thinking about similar syntax for other clients, 
e.g. `client.metadata.cubes[name]`, or `client.logs[handle]`. 

So `client.queries` is indended to be an object, which can behave as a 
collection just to make the resulting code look more aligned with the inherent 
language syntax and features. 

So after deciding name for the sub-clients, For search I picked from 
`client.queries.search` and `client.search_queries`, settling in between at 
`client.queries`, since it's phonetically closer to `client.search_queries`, 
and syntactically concise.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49154/#review142196
---


On July 14, 2016, 11:22 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49154/
> ---
> 
> (Updated July 14, 2016, 11:22 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1202
> https://issues.apache.org/jira/browse/LENS-1202
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/README.md 00525fffe0c84421ca60cdb23bc9ed7f42963736 
>   contrib/clients/python/lens/client/main.py 
> dc604979415160ae17c9fcdcef3f258d5e38af38 
>   contrib/clients/python/lens/client/models.py 
> 7451fe92b29531f2bdb9219239c6f2b597fe7aac 
>   contrib/clients/python/lens/client/query.py 
> 88ce719890e8bf1c08410284583db14bb23c568c 
>   contrib/clients/python/lens/client/session.py PRE-CREATION 
>   contrib/clients/python/test/test_lensclient.py 
> d49c55bdca924eabd0b61f540372db4c3f3e695e 
> 
> Diff: https://reviews.apache.org/r/49154/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 49371: LENS-1168 : Add query launcher pool

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49371/
---

(Updated July 21, 2016, 11:56 a.m.)


Review request for lens.


Changes
---

Review comments incorporated


Bugs: LENS-1168
https://issues.apache.org/jira/browse/LENS-1168


Repository: lens


Description
---

Changes include :
- Add query launcher pool which would launch queries after applying constraint 
checks.
- Add max concurrent launching queries constraint - to limit number parallel 
launches at any time.
- Update StatusPoller to skip launching queries
- Update cancelQuery to interrupt launcher.
- Added test to verify parallel launches.


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java
 7fd2d81 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 8ba0689 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 d10ad09 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
 b2319a9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
 442cd99 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
 38b74ae 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 1e8d540 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 be0e2c8 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  lens-server/src/main/resources/lensserver-default.xml 3ce8fc1 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java d5e975a 
  
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 
0b38517 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java
 0df436a 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
6af4225 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
 c8ebd0c 
  src/site/apt/admin/config.apt 852955b 

Diff: https://reviews.apache.org/r/49371/diff/


Testing
---


Thanks,

Amareshwari Sriramadasu

Re: Review Request 50133: LENS-996: Improvements in filters of query list api

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/#review143075
---


Fix it, then Ship it!





lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 
(line 118)


Might conflict with other patch


- Amareshwari Sriramadasu


On July 21, 2016, 8:43 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50133/
> ---
> 
> (Updated July 21, 2016, 8:43 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-996
> https://issues.apache.org/jira/browse/LENS-996
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. fromDate and endDate should also take human readable dates. 
> DateUtil.resolveDate can be used. 
> 2. the status filter should be case-insensitive. 
> 3. (maybe) the user filter and status filter can take multiple comma 
> separated values and return the union in the result.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> b82cd95b5633b91e03cf1df8ac2602cb7798099a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
>  d10ad099b7220545802a3fcc7fd6e32a1c5b272a 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  be0e2c80a6c0081537feaea330192dc85949ad05 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
>  803bbe3db982dc74ba2a1bdba94fc68879dcd351 
>   
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java
>  304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
> 
> Diff: https://reviews.apache.org/r/50133/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 49371: LENS-1168 : Add query launcher pool

[Amareshwari Sriramadasu]

> On July 20, 2016, 8:36 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java,
> >  line 767
> > 
> >
> > Cancel code may require some synchronization.

Now that launchQuery is synchronized, this should not be required.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49371/#review142912
---


On July 12, 2016, 5:41 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49371/
> ---
> 
> (Updated July 12, 2016, 5:41 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1168
> https://issues.apache.org/jira/browse/LENS-1168
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include :
> - Add query launcher pool which would launch queries after applying 
> constraint checks.
> - Add max concurrent launching queries constraint - to limit number parallel 
> launches at any time.
> - Update StatusPoller to skip launching queries
> - Update cancelQuery to interrupt launcher.
> - Added test to verify parallel launches.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java
>  7fd2d81 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  8ba0689 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
>  d10ad09 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  b2319a9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  442cd99 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  38b74ae 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  1e8d540 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  2de098d 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   lens-server/src/main/resources/lensserver-default.xml 6dc322e 
>   lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 
> d5e975a 
>   
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java
>  0b38517 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java
>  0df436a 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 6af4225 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  c8ebd0c 
>   src/site/apt/admin/config.apt 5b76069 
> 
> Diff: https://reviews.apache.org/r/49371/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 49371: LENS-1168 : Add query launcher pool

[Amareshwari Sriramadasu]

> On July 20, 2016, 8:53 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java,
> >  line 1339
> > 
> >
> > Do we need to await termination of this pool ?
> > 
> > Cons : a query that takes lot of time to lauch will delay the shutdown.
> > 
> > Pros : on startup we do not need to handle the case where we get a 
> > query in LAUNCHING state.

As we are have await for cancellationPool in prepare stopping, we can add 
launcher pool as well. Adding it here.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49371/#review142915
---


On July 12, 2016, 5:41 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49371/
> ---
> 
> (Updated July 12, 2016, 5:41 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1168
> https://issues.apache.org/jira/browse/LENS-1168
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include :
> - Add query launcher pool which would launch queries after applying 
> constraint checks.
> - Add max concurrent launching queries constraint - to limit number parallel 
> launches at any time.
> - Update StatusPoller to skip launching queries
> - Update cancelQuery to interrupt launcher.
> - Added test to verify parallel launches.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java
>  7fd2d81 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  8ba0689 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
>  d10ad09 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  b2319a9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  442cd99 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  38b74ae 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  1e8d540 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  2de098d 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   lens-server/src/main/resources/lensserver-default.xml 6dc322e 
>   lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 
> d5e975a 
>   
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java
>  0b38517 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java
>  0df436a 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 6af4225 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  c8ebd0c 
>   src/site/apt/admin/config.apt 5b76069 
> 
> Diff: https://reviews.apache.org/r/49371/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 49770: Core scheduler

[Lavkesh Lahngir]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/
---

(Updated July 21, 2016, 10:10 a.m.)


Review request for lens.


Bugs: LENS-128
https://issues.apache.org/jira/browse/LENS-128


Repository: lens


Description
---

Implementaion of core scheduler:


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
7d06689 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 8158576 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
33ec9d9 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
 fe2dfb3 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
c8a9ac6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 3ca7eb9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 d0af876 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 74bc0be 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 1e8d540 
  lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 39c4d98 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
bf99fde 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 3952671 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 a4cdd83 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
 95057e4 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
 d21cd05 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 31783ad 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
63a7874 
  lens-server/src/main/resources/lensserver-default.xml 6dc322e 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 d76a586 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
 06883ae 
  src/site/apt/admin/config.apt 5b76069 

Diff: https://reviews.apache.org/r/49770/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 49371: LENS-1168 : Add query launcher pool

[Amareshwari Sriramadasu]

> On July 8, 2016, 10:45 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java,
> >  lines 787-793
> > 
> >
> > Do we need to synchronize the entire run method on context ? 
> > I can think of only one reason - cancel and launch happening parallely 
> > before this JIRA were synchronized. Not sure if there can be more reasons 
> > to do this.
> > 
> > If we do syncronize , this code will not be needed.
> 
> Amareshwari Sriramadasu wrote:
> Did not want to synchronize on the entire method, as other operations 
> like getStatus or cancelQuery would block threads for this launching thread.

Doing synchronization on the whole launch - same as the earlier flow. cancel 
and updatestatus will wait if launch takes more time.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49371/#review141266
---


On July 12, 2016, 5:41 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49371/
> ---
> 
> (Updated July 12, 2016, 5:41 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1168
> https://issues.apache.org/jira/browse/LENS-1168
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include :
> - Add query launcher pool which would launch queries after applying 
> constraint checks.
> - Add max concurrent launching queries constraint - to limit number parallel 
> launches at any time.
> - Update StatusPoller to skip launching queries
> - Update cancelQuery to interrupt launcher.
> - Added test to verify parallel launches.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java
>  7fd2d81 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  8ba0689 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
>  d10ad09 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java
>  b2319a9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java
>  442cd99 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
>  38b74ae 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  1e8d540 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  2de098d 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   lens-server/src/main/resources/lensserver-default.xml 6dc322e 
>   lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 
> d5e975a 
>   
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java
>  0b38517 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java
>  0df436a 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 6af4225 
>   
> lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
>  c8ebd0c 
>   src/site/apt/admin/config.apt 5b76069 
> 
> Diff: https://reviews.apache.org/r/49371/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 50188: LENS-1218: Document the new ui in install and run step

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/#review143065
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On July 21, 2016, 8:45 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50188/
> ---
> 
> (Updated July 21, 2016, 8:45 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1218
> https://issues.apache.org/jira/browse/LENS-1218
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   src/site/apt/developer/contribute.apt 
> a2fd59eacbef1bd63eaf59f7d744893e495a6056 
>   src/site/apt/lenshome/install-and-run.apt 
> f13382263d88edae9ec78f59f3476910ff650453 
> 
> Diff: https://reviews.apache.org/r/50188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 50188: LENS-1218: Document the new ui in install and run step

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/
---

(Updated July 21, 2016, 2:15 p.m.)


Review request for lens.


Bugs: LENS-1218
https://issues.apache.org/jira/browse/LENS-1218


Repository: lens


Description
---


Diffs (updated)
-

  src/site/apt/developer/contribute.apt 
a2fd59eacbef1bd63eaf59f7d744893e495a6056 
  src/site/apt/lenshome/install-and-run.apt 
f13382263d88edae9ec78f59f3476910ff650453 

Diff: https://reviews.apache.org/r/50188/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 50133: LENS-996: Improvements in filters of query list api

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
---

(Updated July 21, 2016, 2:13 p.m.)


Review request for lens.


Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996


Repository: lens


Description
---

1. fromDate and endDate should also take human readable dates. 
DateUtil.resolveDate can be used. 
2. the status filter should be case-insensitive. 
3. (maybe) the user filter and status filter can take multiple comma separated 
values and return the union in the result.


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
b82cd95b5633b91e03cf1df8ac2602cb7798099a 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 d10ad099b7220545802a3fcc7fd6e32a1c5b272a 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 be0e2c80a6c0081537feaea330192dc85949ad05 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
 803bbe3db982dc74ba2a1bdba94fc68879dcd351 
  
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 
304dc8efad8bd27c88b58b6ca319dfedcd4ac239 

Diff: https://reviews.apache.org/r/50133/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 50188: LENS-1218: Document the new ui in install and run step

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/#review143062
---




src/site/apt/lenshome/install-and-run.apt (line 246)


Seems incomplete here. Can you remove it from here ?


- Amareshwari Sriramadasu


On July 21, 2016, 7:20 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50188/
> ---
> 
> (Updated July 21, 2016, 7:20 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1218
> https://issues.apache.org/jira/browse/LENS-1218
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   src/site/apt/developer/contribute.apt 
> a2fd59eacbef1bd63eaf59f7d744893e495a6056 
>   src/site/apt/lenshome/install-and-run.apt 
> f13382263d88edae9ec78f59f3476910ff650453 
> 
> Diff: https://reviews.apache.org/r/50188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 50131: LENS-1217: Remove old java ui server

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/#review143061
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On July 21, 2016, 8:01 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50131/
> ---
> 
> (Updated July 21, 2016, 8:01 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1217
> https://issues.apache.org/jira/browse/LENS-1217
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab020b69d7f8b5b2f8ef5675995ef3b36f3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java 
> b6983f4c78a9a48c2503560b529663622a3efc36 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 
> 7618669d75a6aca25c8fdf9af1268758dbe7de38 
>   
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 
> 27388a7503508b26bdecf5266c98e4cbcc7a94a8 
>   
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java
>  304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
>   lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 
> 37bf094347955c5a211299d4367a20bb38dfbc08 
>   lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 
> 7e0758975cc4d991c24a1df963095d38189f5622 
>   lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java 
> de4ce333082fb80cd0dd7cf64848ddc415336a9e 
>   lens-server/src/main/resources/lensserver-default.xml 
> 3ce8fc1f12b279745d083b8249e942bb7dd6653a 
>   lens-server/src/test/java/org/apache/lens/server/TestLensServer.java 
> eb27f61f5f7e09993e5fd9a27695f07683fa7dff 
>   
> lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java 
> f8c5bf28457074072d70fdb742b0300380f0679c 
>   
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java
>  aa2874779d4d9e469f124aa9646a02742e2c4960 
> 
> Diff: https://reviews.apache.org/r/50131/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 50133: LENS-996: Improvements in filters of query list api

[Rajat Khandelwal]

> On July 20, 2016, 12:03 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java,
> >  line 134
> > 
> >
> > Removing default values would cause users to always pass the values for 
> > these params. they will basically become mandatory params.

It won't become mandatory. http://stackoverflow.com/a/13979349/459384


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/#review142910
---


On July 19, 2016, 3:15 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50133/
> ---
> 
> (Updated July 19, 2016, 3:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-996
> https://issues.apache.org/jira/browse/LENS-996
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. fromDate and endDate should also take human readable dates. 
> DateUtil.resolveDate can be used. 
> 2. the status filter should be case-insensitive. 
> 3. (maybe) the user filter and status filter can take multiple comma 
> separated values and return the union in the result.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> b82cd95b5633b91e03cf1df8ac2602cb7798099a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
>  d10ad099b7220545802a3fcc7fd6e32a1c5b272a 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  2de098d5f16b3fc7f6c5cfa78c6b9a694c1d 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
>  803bbe3db982dc74ba2a1bdba94fc68879dcd351 
>   
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java
>  304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
> 
> Diff: https://reviews.apache.org/r/50133/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 50131: LENS-1217: Remove old java ui server

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/
---

(Updated July 21, 2016, 1:31 p.m.)


Review request for lens.


Bugs: LENS-1217
https://issues.apache.org/jira/browse/LENS-1217


Repository: lens


Description
---


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab020b69d7f8b5b2f8ef5675995ef3b36f3 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java 
b6983f4c78a9a48c2503560b529663622a3efc36 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 
7618669d75a6aca25c8fdf9af1268758dbe7de38 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 
27388a7503508b26bdecf5266c98e4cbcc7a94a8 
  
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 
304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 
37bf094347955c5a211299d4367a20bb38dfbc08 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 
7e0758975cc4d991c24a1df963095d38189f5622 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java 
de4ce333082fb80cd0dd7cf64848ddc415336a9e 
  lens-server/src/main/resources/lensserver-default.xml 
3ce8fc1f12b279745d083b8249e942bb7dd6653a 
  lens-server/src/test/java/org/apache/lens/server/TestLensServer.java 
eb27f61f5f7e09993e5fd9a27695f07683fa7dff 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java 
f8c5bf28457074072d70fdb742b0300380f0679c 
  
lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java 
aa2874779d4d9e469f124aa9646a02742e2c4960 

Diff: https://reviews.apache.org/r/50131/diff/


Testing
---


Thanks,

Rajat Khandelwal