[jira] [Commented] (LENS-1363) Error While building Lens Site

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604242#comment-15604242
 ] 

Hadoop QA commented on LENS-1363:
-

Applied patch: 
[lens-1363.patch|https://issues.apache.org/jira/secure/attachment/12835068/lens-1363.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1132/

> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1363.patch
>
>
> 1. The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 
> 2. Download links are pointing to lens 2.6. Need to change to point to 2.6.1
> 3. Roles need to be updated in pom.xml for two team members 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1363:
---
Description: 
1. The output of enunciate had changed after upgrading it. 
Need to update tools/scripts/generate-site-public.sh accordingly. 

2. Download links are pointing to lens 2.6. Need to change to point to 2.6.1

3. Roles need to be updated in pom.xml for two team members 

  was:
The output of enunciate had changed after upgrading it. 
Need to update tools/scripts/generate-site-public.sh accordingly. 


> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1363.patch
>
>
> 1. The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 
> 2. Download links are pointing to lens 2.6. Need to change to point to 2.6.1
> 3. Roles need to be updated in pom.xml for two team members 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1363:
---
Status: Patch Available  (was: Open)

Small Change. Attaching patch directly for review

> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1363.patch
>
>
> The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1363:
---
Attachment: lens-1363.patch

> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1363.patch
>
>
> The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1250) Error while initializing saved query service on server start

[Archana H (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H updated LENS-1250:

Assignee: (was: Rajat Khandelwal)

> Error while initializing saved query service on server start
> 
>
> Key: LENS-1250
> URL: https://issues.apache.org/jira/browse/LENS-1250
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Archana H
> Fix For: 2.6
>
> Attachments: LENS-1250.2016-08-02_14:55:02.patch
>
>
> Error:
> {CODE}
> java.lang.RuntimeException: Cannot initialize saved query service
> at 
> org.apache.lens.server.query.save.SavedQueryServiceImpl.init(SavedQueryServiceImpl.java:75)
>  ~[classes/:na]
> at 
> org.apache.hive.service.CompositeService.init(CompositeService.java:59) 
> ~[hive-service-2.1.3-inm-SNAPSHOT.jar:2.1.3-inm-SNAPSHOT]
> at org.apache.lens.server.LensServices.init(LensServices.java:252) 
> ~[classes/:na]
> at 
> org.apache.lens.server.LensServer.startServices(LensServer.java:117) 
> ~[classes/:na]
> at org.apache.lens.server.LensServer.(LensServer.java:84) 
> ~[classes/:na]
> at 
> org.apache.lens.server.LensServer.createLensServer(LensServer.java:73) 
> ~[classes/:na]
> at org.apache.lens.server.LensServer.main(LensServer.java:173) 
> ~[classes/:na]
> Caused by: org.apache.lens.server.api.error.LensException: Error initializing 
> saved query dao
> at 
> org.apache.lens.server.query.save.SavedQueryDao.(SavedQueryDao.java:72) 
> ~[classes/:na]
> at 
> org.apache.lens.server.query.save.SavedQueryServiceImpl.init(SavedQueryServiceImpl.java:72)
>  ~[classes/:na]
> ... 6 common frames omitted
> Caused by: org.apache.lens.server.api.error.LensException: Cannot create 
> saved query table!
> at 
> org.apache.lens.server.query.save.SavedQueryDao.createSavedQueryTableIfNotExists(SavedQueryDao.java:85)
>  ~[classes/:na]
> at 
> org.apache.lens.server.query.save.SavedQueryDao.(SavedQueryDao.java:70) 
> ~[classes/:na]
> ... 7 common frames omitted
> Caused by: java.sql.SQLException: Incorrect table definition; there can be 
> only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE 
> clause Query: CREATE TABLE IF NOT EXISTS saved_query (id int(11) NOT NULL 
> AUTO_INCREMENT,name varchar(255) NOT NULL,description varchar(255) DEFAULT 
> NULL,query longtext,params_json longtext,created_at timestamp DEFAULT 
> CURRENT_TIMESTAMP,updated_at timestamp DEFAULT CURRENT_TIMESTAMP,  PRIMARY 
> KEY (id)) Parameters: []
> at 
> org.apache.commons.dbutils.AbstractQueryRunner.rethrow(AbstractQueryRunner.java:363)
>  ~[commons-dbutils-1.5.jar:1.5]
> at 
> org.apache.commons.dbutils.QueryRunner.update(QueryRunner.java:490) 
> ~[commons-dbutils-1.5.jar:1.5]
> at 
> org.apache.commons.dbutils.QueryRunner.update(QueryRunner.java:420) 
> ~[commons-dbutils-1.5.jar:1.5]
> at 
> org.apache.lens.server.query.save.SavedQueryDao.createSavedQueryTableIfNotExists(SavedQueryDao.java:83)
>  ~[classes/:na]
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1250) Error while initializing saved query service on server start

[Archana H (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H updated LENS-1250:

Assignee: Rajat Khandelwal

> Error while initializing saved query service on server start
> 
>
> Key: LENS-1250
> URL: https://issues.apache.org/jira/browse/LENS-1250
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Archana H
>Assignee: Rajat Khandelwal
> Fix For: 2.6
>
> Attachments: LENS-1250.2016-08-02_14:55:02.patch
>
>
> Error:
> {CODE}
> java.lang.RuntimeException: Cannot initialize saved query service
> at 
> org.apache.lens.server.query.save.SavedQueryServiceImpl.init(SavedQueryServiceImpl.java:75)
>  ~[classes/:na]
> at 
> org.apache.hive.service.CompositeService.init(CompositeService.java:59) 
> ~[hive-service-2.1.3-inm-SNAPSHOT.jar:2.1.3-inm-SNAPSHOT]
> at org.apache.lens.server.LensServices.init(LensServices.java:252) 
> ~[classes/:na]
> at 
> org.apache.lens.server.LensServer.startServices(LensServer.java:117) 
> ~[classes/:na]
> at org.apache.lens.server.LensServer.(LensServer.java:84) 
> ~[classes/:na]
> at 
> org.apache.lens.server.LensServer.createLensServer(LensServer.java:73) 
> ~[classes/:na]
> at org.apache.lens.server.LensServer.main(LensServer.java:173) 
> ~[classes/:na]
> Caused by: org.apache.lens.server.api.error.LensException: Error initializing 
> saved query dao
> at 
> org.apache.lens.server.query.save.SavedQueryDao.(SavedQueryDao.java:72) 
> ~[classes/:na]
> at 
> org.apache.lens.server.query.save.SavedQueryServiceImpl.init(SavedQueryServiceImpl.java:72)
>  ~[classes/:na]
> ... 6 common frames omitted
> Caused by: org.apache.lens.server.api.error.LensException: Cannot create 
> saved query table!
> at 
> org.apache.lens.server.query.save.SavedQueryDao.createSavedQueryTableIfNotExists(SavedQueryDao.java:85)
>  ~[classes/:na]
> at 
> org.apache.lens.server.query.save.SavedQueryDao.(SavedQueryDao.java:70) 
> ~[classes/:na]
> ... 7 common frames omitted
> Caused by: java.sql.SQLException: Incorrect table definition; there can be 
> only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE 
> clause Query: CREATE TABLE IF NOT EXISTS saved_query (id int(11) NOT NULL 
> AUTO_INCREMENT,name varchar(255) NOT NULL,description varchar(255) DEFAULT 
> NULL,query longtext,params_json longtext,created_at timestamp DEFAULT 
> CURRENT_TIMESTAMP,updated_at timestamp DEFAULT CURRENT_TIMESTAMP,  PRIMARY 
> KEY (id)) Parameters: []
> at 
> org.apache.commons.dbutils.AbstractQueryRunner.rethrow(AbstractQueryRunner.java:363)
>  ~[commons-dbutils-1.5.jar:1.5]
> at 
> org.apache.commons.dbutils.QueryRunner.update(QueryRunner.java:490) 
> ~[commons-dbutils-1.5.jar:1.5]
> at 
> org.apache.commons.dbutils.QueryRunner.update(QueryRunner.java:420) 
> ~[commons-dbutils-1.5.jar:1.5]
> at 
> org.apache.lens.server.query.save.SavedQueryDao.createSavedQueryTableIfNotExists(SavedQueryDao.java:83)
>  ~[classes/:na]
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1366) create schema cli command to list all failures at the end

[Archana H (JIRA)]

Archana H created LENS-1366:
---

 Summary: create schema cli command to list all failures at the end
 Key: LENS-1366
 URL: https://issues.apache.org/jira/browse/LENS-1366
 Project: Apache Lens
  Issue Type: Improvement
Reporter: Archana H


Currently if any creation/updation fails it prints at the end of same section 
(cube/fact), instead its better to print at the end when all schema creation is 
done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1365) REST Api docs generated via enunciate plugin 2.5 has two entries for JSON data type

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1365:
---
Description: See attached images

> REST Api docs generated via enunciate plugin 2.5 has two entries for JSON 
> data type
> ---
>
> Key: LENS-1365
> URL: https://issues.apache.org/jira/browse/LENS-1365
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Puneet Gupta
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> See attached images



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1365) REST Api docs generated via enunciate plugin 2.5 has two entries for JSON data type

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1365:
---
Attachment: screenshot-2.png

> REST Api docs generated via enunciate plugin 2.5 has two entries for JSON 
> data type
> ---
>
> Key: LENS-1365
> URL: https://issues.apache.org/jira/browse/LENS-1365
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Puneet Gupta
> Attachments: screenshot-1.png, screenshot-2.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1365) REST Api docs generated via enunciate plugin 2.5 has two entries for JSON data type

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1365:
---
Attachment: screenshot-1.png

> REST Api docs generated via enunciate plugin 2.5 has two entries for JSON 
> data type
> ---
>
> Key: LENS-1365
> URL: https://issues.apache.org/jira/browse/LENS-1365
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Puneet Gupta
> Attachments: screenshot-1.png, screenshot-2.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1365) REST Api docs generated via enunciate plugin 2.5 has two entries for JSON data type

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1365:
--

 Summary: REST Api docs generated via enunciate plugin 2.5 has two 
entries for JSON data type
 Key: LENS-1365
 URL: https://issues.apache.org/jira/browse/LENS-1365
 Project: Apache Lens
  Issue Type: Bug
Reporter: Puneet Gupta






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1364) CLI create schema command to handle xml syntax errors

[Archana H (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H updated LENS-1364:

Summary: CLI create schema command to handle xml syntax errors  (was: CLI 
create schema to handle xml syntax errors)

> CLI create schema command to handle xml syntax errors
> -
>
> Key: LENS-1364
> URL: https://issues.apache.org/jira/browse/LENS-1364
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Archana H
>
> create schema --db test --path /tmp/schema
> Command failed Error Code: 500
> Error Message: Internal Server Error.: Database test already exists
> Successfully switched to test
> create storage --path /tmp/schema/storages/storage_1.xml
> failed
> Created storage storage_1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1364) CLI create schema to handle xml syntax errors

[Archana H (JIRA)]

Archana H created LENS-1364:
---

 Summary: CLI create schema to handle xml syntax errors
 Key: LENS-1364
 URL: https://issues.apache.org/jira/browse/LENS-1364
 Project: Apache Lens
  Issue Type: Improvement
Reporter: Archana H


create schema --db test --path /tmp/schema
Command failed Error Code: 500
Error Message: Internal Server Error.: Database test already exists
Successfully switched to test
create storage --path /tmp/schema/storages/storage_1.xml
failed
Created storage storage_1




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (LENS-968) Monitor run time for queries and terminate long running queries

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu reassigned LENS-968:


Assignee: Amareshwari Sriramadasu  (was: Puneet Gupta)

> Monitor run time for queries and terminate long running queries
> ---
>
> Key: LENS-968
> URL: https://issues.apache.org/jira/browse/LENS-968
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Amareshwari Sriramadasu
>
> server should be able to kill queries that are taking more than x number of 
> hours in RUNNING state and intimate the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1363:
--

 Summary: Error While building Lens Site
 Key: LENS-1363
 URL: https://issues.apache.org/jira/browse/LENS-1363
 Project: Apache Lens
  Issue Type: Sub-task
Reporter: Puneet Gupta
Assignee: Puneet Gupta


The output of enunciate had changed after upgrading it. 
Need to update tools/scripts/generate-site-public.sh accordingly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601360#comment-15601360
 ] 

Hadoop QA commented on LENS-1360:
-

Applied patch: 
[LENS-1360.logging.patch|https://issues.apache.org/jira/secure/attachment/12834885/LENS-1360.logging.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1131/

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch, LENS-1360.05.patch, LENS-1360.logging.patch, 
> LENS-1360.logging.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1360:
--
Attachment: LENS-1360.logging.patch

Appending log on STDOUT as well, for test report to show.

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch, LENS-1360.05.patch, LENS-1360.logging.patch, 
> LENS-1360.logging.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601200#comment-15601200
 ] 

Hadoop QA commented on LENS-1360:
-

Applied patch: 
[LENS-1360.logging.patch|https://issues.apache.org/jira/secure/attachment/12834880/LENS-1360.logging.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1128/

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch, LENS-1360.05.patch, LENS-1360.logging.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601195#comment-15601195
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.08.patch|https://issues.apache.org/jira/secure/attachment/12834157/LENS-1359.08.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1129/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52982: Adding a message based retry policy

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52982/#review153674
---




lens-server-api/src/main/java/org/apache/lens/server/api/retry/ConfiguredPolicyDecider.java
 (line 35)


Name is a bit ambiguous regarding the functionality. Can we rename it to 
reflect that it's checking `contains` in error message?



lens-server-api/src/main/java/org/apache/lens/server/api/retry/ConfiguredPolicyDecider.java
 (line 45)


We should handle for cases when either of the above two are null.



lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java
 (line 37)


The arguments are int, long, long



lens-server-api/src/test/java/org/apache/lens/server/api/retry/TestConfiguredPolicyDecider.java
 (lines 54 - 56)


This seems like a problem in `ImmediateRetryHandler`. Instead of 
```
  @Override
  public boolean hasExhaustedRetries(FC failContext) {
return ++retriesDone > retries;
  }
```
It should be

```
  @Override
  public boolean hasExhaustedRetries(FC failContext) {
failContext.getFailCount() > retries;
  }

```

Can you make the change?


- Rajat Khandelwal


On Oct. 20, 2016, 6:27 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52982/
> ---
> 
> (Updated Oct. 20, 2016, 6:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> If any one of the configured messages are found then the retry will happen
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml 
> f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 89726c4f352a6e57dd81b6ae84cca221a345ebb6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6ca126f0a3535974352adf97e7a495838f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/retry/ConfiguredPolicyDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java
>  01da25d12393615cfb4e4680c97c7445df0bbe83 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/retry/ImmediateRetryHandler.java
>  c1c0126ae9ac89cb4a50fe5948075094f10cb518 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/retry/TestConfiguredPolicyDecider.java
>  PRE-CREATION 
>   src/site/apt/admin/hivedriver-config.apt 
> b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 
>   src/site/apt/admin/jdbcdriver-config.apt 
> c64d6ee0d4ac1dff9fadd02826e67a8e4839d99f 
> 
> Diff: https://reviews.apache.org/r/52982/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Updated] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1360:
--
Attachment: LENS-1360.logging.patch

Adding logging patch to understand cause of the failure

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch, LENS-1360.05.patch, LENS-1360.logging.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)