Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
> On Oct. 25, 2015, 3:40 a.m., Amareshwari Sriramadasu wrote: > > I see the issue is still open, but review request is closed. So, reopened. > > > > Gabor, Do you still see errors on generated doc? > > Raju/Gabor, Is that resulting in build failure in java-8? > > Raju Bairishetti wrote: > We have fixed all the javadoc errors earlier. We may get new javadoc > errors as many patches were in. > > Right now, build won't be failed as we are not generating the javadocs as > part of build. We need to fix all warnings & errors before adding javadoc to > build cycle. > > Amareshwari Sriramadasu wrote: > Raju/Gabor, Are you planning to do more work on this jira? If so, what is > pending? Capturing in a review comment would make sense. If not, we should > get this in. Yes, I had no solution to correct the javadoc errors in the generated code. mvn site does fail when running under Java8. - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103931 ------- On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 19, 2015, 1:33 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > 971e794930e67a25404b4da75d596cfd26a7e17e > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > 92a936a91b7882e4de0b71b6aa9e4f3707770dce > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java > 9dfde0db7edad0c30528425479af8d4d64e894a7 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > cc627cfcbcb266cf8586195d56742ab6ec8cbfba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
> On Oct. 18, 2015, 1:54 a.m., Raju Bairishetti wrote: > > Could you please verify javadoc errors/warnigns by running **mvn > > javadoc:javadoc **? I'm uploading progress to allow early comments. - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103046 --- On Oct. 18, 2015, 2:02 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 18, 2015, 2:02 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > 971e794930e67a25404b4da75d596cfd26a7e17e > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > 92a936a91b7882e4de0b71b6aa9e4f3707770dce > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > cc627cfcbcb266cf8586195d56742ab6ec8cbfba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
[jira] [Commented] (LENS-824) Fix all javadoc warnings/errors
[
https://issues.apache.org/jira/browse/LENS-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962143#comment-14962143
]
Gabor Liptak commented on LENS-824:
---
Working this at https://reviews.apache.org/r/39419/
> Fix all javadoc warnings/errors
> ---
>
> Key: LENS-824
> URL: https://issues.apache.org/jira/browse/LENS-824
> Project: Apache Lens
> Issue Type: Task
> Components: build
>Reporter: Raju Bairishetti
> Labels: newbie
> Fix For: 2.5
>
>
> Creating this jira to find and fix the javadoc warnings and errors.
> With JDK 8, we are unable to get Javadoc unless your tool meets the standards
> of doclint.
> Some of its rules are:
> -
> {noformat}
> no self-closed HTML tags, such as or
> no unclosed HTML tags, such as without matching
> no invalid HTML end tags, such as
> no invalid HTML attributes, based on doclint's interpretation of W3C HTML 4.01
> no duplicate HTML id attribute
> no empty HTML href attribute
> no incorrectly nested headers, such as class documentation must have ,
> not
> no invalid HTML tags, such as List (where you forgot to escape using
> )
> no broken @link references
> no broken @param references, they must match the actual parameter name
> no broken @throws references, the first word must be a class name
> {noformat}
> We don't get any output if it breaks any of the above rule. It throws errors.
> We can turn off doclint by configuring the following propery for javadoc
> plugin
> *-Xdoclint:none*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/ --- (Updated Oct. 18, 2015, 2:02 a.m.) Review request for lens. Repository: lens Description --- LENS-824 Fix all javadoc warnings/errors Diffs (updated) - lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java 971e794930e67a25404b4da75d596cfd26a7e17e lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java e6152b87cf008b4b4fcb57985c56d1449272b23d lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java 92a936a91b7882e4de0b71b6aa9e4f3707770dce lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java deb857213dc2e113d98f3cf854d0f84813455170 lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java cc627cfcbcb266cf8586195d56742ab6ec8cbfba lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 3ea75246cb2b72376395e04eacacca1f88f8e347 lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 22497ca31d710de0dcf3aef2a2a73f814e042f33 Diff: https://reviews.apache.org/r/39419/diff/ Testing --- Thanks, Gabor Liptak
[jira] [Updated] (LENS-615) Refactoring of testQueryCommands test case
[
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Liptak updated LENS-615:
--
Attachment: rb39191.patch
> Refactoring of testQueryCommands test case
> --
>
> Key: LENS-615
> URL: https://issues.apache.org/jira/browse/LENS-615
> Project: Apache Lens
> Issue Type: Improvement
> Components: client
>Reporter: Himanshu Gahlaut
>Assignee: Gabor Liptak
> Labels: newbie
> Attachments: rb39191.patch
>
>
> There are too many test cases running in testQueryCommands test case. It is
> considerably time consuming to debug a failing test case within
> testQueryCommands. If these test cases are modularized and broken into
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
> public void testQueryCommands() throws Exception {
> client = new LensClient();
>
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver",
> "false");
> setup(client);
> LensQueryCommands qCom = new LensQueryCommands();
> qCom.setClient(client);
> resDir = new File("target/results");
> assertTrue(resDir.exists() || resDir.mkdirs());
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> // run all query commands with query metrics enabled.
> client = new LensClient();
>
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver",
> "false");
> client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
> qCom.setClient(client);
> String result = qCom.getAllPreparedQueries("all", "", -1, -1);
> assertEquals(result, "No prepared queries");
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/ --- (Updated Oct. 15, 2015, 11:14 p.m.) Review request for lens. Bugs: LENS-615 https://issues.apache.org/jira/browse/LENS-615 Repository: lens Description --- LENS-615 Refactoring of testQueryCommands test case Diffs (updated) - lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 Diff: https://reviews.apache.org/r/39191/diff/ Testing --- Thanks, Gabor Liptak
Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case
> On Oct. 15, 2015, 12:41 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line > > 207 > > <https://reviews.apache.org/r/39191/diff/3/?file=1097957#file1097957line207> > > > > Can you reset hive.exec.driver.run.hooks to be empty string? Can you also review the TODO in purgedFinishedResultSet()? - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/#review102735 --- On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39191/ > --- > > (Updated Oct. 14, 2015, 1:30 a.m.) > > > Review request for lens. > > > Bugs: LENS-615 > https://issues.apache.org/jira/browse/LENS-615 > > > Repository: lens > > > Description > --- > > LENS-615 Refactoring of testQueryCommands test case > > > Diffs > - > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 > > Diff: https://reviews.apache.org/r/39191/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case
> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line > > 451 > > <https://reviews.apache.org/r/39191/diff/3/?file=1097957#file1097957line451> > > > > can you take care of the TODO? Rajat, what is the recommended way to reset this value? This key might or might not exists, the getConnectionParam() returns a List and there doesn't seem to be a method to delete a key ... Thanks - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/#review102598 --- On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39191/ > --- > > (Updated Oct. 14, 2015, 1:30 a.m.) > > > Review request for lens. > > > Bugs: LENS-615 > https://issues.apache.org/jira/browse/LENS-615 > > > Repository: lens > > > Description > --- > > LENS-615 Refactoring of testQueryCommands test case > > > Diffs > - > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 > > Diff: https://reviews.apache.org/r/39191/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case
> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line > > 451 > > <https://reviews.apache.org/r/39191/diff/3/?file=1097957#file1097957line451> > > > > can you take care of the TODO? > > Gabor Liptak wrote: > Rajat, what is the recommended way to reset this value? This key might or > might not exists, the getConnectionParam() returns a List and there > doesn't seem to be a method to delete a key ... Thanks > > Amareshwari Sriramadasu wrote: > This config is removed now and the setting and unsetting here can be > removed as well. Removed as in I should delete both set/TODO lines? - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/#review102598 ------- On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39191/ > --- > > (Updated Oct. 14, 2015, 1:30 a.m.) > > > Review request for lens. > > > Bugs: LENS-615 > https://issues.apache.org/jira/browse/LENS-615 > > > Repository: lens > > > Description > --- > > LENS-615 Refactoring of testQueryCommands test case > > > Diffs > - > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 > > Diff: https://reviews.apache.org/r/39191/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case
> On Oct. 13, 2015, 8:08 a.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, > > lines 281-291 > > <https://reviews.apache.org/r/39191/diff/2/?file=1096776#file1096776line281> > > > > Data providers. You can look at > > org.apache.lens.cube.metadata.TestTimePartition and > > org.apache.lens.cube.metadata.UpdatePeriodTest for examples. Thank you for the pointers - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/#review102406 ------- On Oct. 12, 2015, 11:27 p.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39191/ > --- > > (Updated Oct. 12, 2015, 11:27 p.m.) > > > Review request for lens. > > > Bugs: LENS-615 > https://issues.apache.org/jira/browse/LENS-615 > > > Repository: lens > > > Description > --- > > LENS-615 Refactoring of testQueryCommands test case > > > Diffs > - > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 > > Diff: https://reviews.apache.org/r/39191/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/ --- (Updated Oct. 9, 2015, 10:14 p.m.) Review request for lens. Bugs: LENS-615 https://issues.apache.org/jira/browse/LENS-615 Repository: lens Description --- LENS-615 Refactoring of testQueryCommands test case Diffs - lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 Diff: https://reviews.apache.org/r/39191/diff/ Testing --- Thanks, Gabor Liptak
[jira] [Updated] (LENS-615) Refactoring of testQueryCommands test case
[
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Liptak updated LENS-615:
--
Attachment: LENS-615.1.patch
WIP
> Refactoring of testQueryCommands test case
> --
>
> Key: LENS-615
> URL: https://issues.apache.org/jira/browse/LENS-615
> Project: Apache Lens
> Issue Type: Improvement
>Reporter: Himanshu Gahlaut
> Labels: newbie
> Attachments: LENS-615.1.patch
>
>
> There are too many test cases running in testQueryCommands test case. It is
> considerably time consuming to debug a failing test case within
> testQueryCommands. If these test cases are modularized and broken into
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
> public void testQueryCommands() throws Exception {
> client = new LensClient();
>
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver",
> "false");
> setup(client);
> LensQueryCommands qCom = new LensQueryCommands();
> qCom.setClient(client);
> resDir = new File("target/results");
> assertTrue(resDir.exists() || resDir.mkdirs());
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> // run all query commands with query metrics enabled.
> client = new LensClient();
>
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver",
> "false");
> client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
> qCom.setClient(client);
> String result = qCom.getAllPreparedQueries("all", "", -1, -1);
> assertEquals(result, "No prepared queries");
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
