Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-15 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review156012 ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-14 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review155416 ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-08 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/ --- (Updated Nov. 8, 2016, 10:18 a.m.) Review request for lens. Changes ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-08 Thread Sushil Mohanty
> On Nov. 4, 2016, 6:35 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java, > > line 97 > > > > > > Database does not exists, but jar can be added? It

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-08 Thread Sushil Mohanty
> On Oct. 26, 2016, 6:01 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java, > > line 169 > > > > > > not sure how its corresponding local

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-04 Thread Amareshwari Sriramadasu
> On Oct. 26, 2016, 6:01 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java, > > line 169 > > > > > > not sure how its corresponding local

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-04 Thread Amareshwari Sriramadasu
> On Nov. 4, 2016, 6:35 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java, > > line 104 > > > > > > command should be throwing NullPointerException on

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-04 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review154869 ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-03 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/ --- (Updated Nov. 3, 2016, 5:31 p.m.) Review request for lens. Changes ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-11-03 Thread Sushil Mohanty
> On Oct. 26, 2016, 6:01 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java, > > line 339 > > > > > > Why are we passing null name? We should

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-26 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review153851 ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-25 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/ --- (Updated Oct. 25, 2016, 10:11 a.m.) Review request for lens. Changes ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-25 Thread Sushil Mohanty
> On Oct. 21, 2016, 1:03 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java, > > line 576 > > > > > > Just a thought - Should this

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-21 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review153535 ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-20 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/ --- (Updated Oct. 20, 2016, 1:24 p.m.) Review request for lens. Changes ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-20 Thread Sushil Mohanty
> On Oct. 18, 2016, 2:09 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > line 1397 > > > > > > Are two commands required for Hive ? yes,

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-17 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review152818 ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-10-14 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/ --- (Updated Oct. 14, 2016, 8:29 a.m.) Review request for lens. Changes ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-09-22 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review149956 ---

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

2016-09-22 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review149953 ---

Review Request 51964: LENS-317: Server side calls for updating database jars

2016-09-16 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/ --- Review request for lens. Bugs: LENS-317