Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/
---

(Updated Oct. 15, 2015, 11:14 p.m.)


Review request for lens.


Bugs: LENS-615
https://issues.apache.org/jira/browse/LENS-615


Repository: lens


Description
---

LENS-615 Refactoring of testQueryCommands test case


Diffs (updated)
-

  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 

Diff: https://reviews.apache.org/r/39191/diff/


Testing
---


Thanks,

Gabor Liptak

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 416)


can you take care of the TODO?


- Rajat Khandelwal


On Oct. 14, 2015, 7 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 7 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?
> 
> Gabor Liptak wrote:
> Rajat, what is the recommended way to reset this value? This key might or 
> might not exists, the getConnectionParam() returns a List and there 
> doesn't seem to be a method to delete a key ... Thanks

This config is removed now and the setting and unsetting here can be removed as 
well.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

> On Oct. 15, 2015, 12:41 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 207
> > 
> >
> > Can you reset hive.exec.driver.run.hooks to be empty string?

Can you also review the TODO in purgedFinishedResultSet()?


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102735
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?

Rajat, what is the recommended way to reset this value? This key might or might 
not exists, the getConnectionParam() returns a List and there doesn't 
seem to be a method to delete a key ... Thanks


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102735
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 183)


Can you reset hive.exec.driver.run.hooks to be empty string?


- Amareshwari Sriramadasu


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?
> 
> Gabor Liptak wrote:
> Rajat, what is the recommended way to reset this value? This key might or 
> might not exists, the getConnectionParam() returns a List and there 
> doesn't seem to be a method to delete a key ... Thanks
> 
> Amareshwari Sriramadasu wrote:
> This config is removed now and the setting and unsetting here can be 
> removed as well.

Removed as in I should delete both set/TODO lines?


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?
> 
> Gabor Liptak wrote:
> Rajat, what is the recommended way to reset this value? This key might or 
> might not exists, the getConnectionParam() returns a List and there 
> doesn't seem to be a method to delete a key ... Thanks
> 
> Amareshwari Sriramadasu wrote:
> This config is removed now and the setting and unsetting here can be 
> removed as well.
> 
> Gabor Liptak wrote:
> Removed as in I should delete both set/TODO lines?

Yes. Please go ahead.
The config is already removed from server side, by a different jira.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 15, 2015, 1:25 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 15, 2015, 1:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102403
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 69)


I think it should be @BeforeTest instead of @BeforeClass


- Amareshwari Sriramadasu


On Oct. 12, 2015, 11:27 p.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 12, 2015, 11:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

> On Oct. 13, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, 
> > lines 281-291
> > 
> >
> > Data providers. You can look at 
> > org.apache.lens.cube.metadata.TestTimePartition  and 
> > org.apache.lens.cube.metadata.UpdatePeriodTest for examples.

Thank you for the pointers


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102406
---


On Oct. 12, 2015, 11:27 p.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 12, 2015, 11:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Raju Bairishetti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102212
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 45)


Why this import is moved below to "import lombok.extern.slf4j.Slf4j;". 
Seems it will throw a checkstyle error.


- Raju Bairishetti


On Oct. 9, 2015, 10:14 p.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 9, 2015, 10:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/
---

(Updated Oct. 9, 2015, 10:14 p.m.)


Review request for lens.


Bugs: LENS-615
https://issues.apache.org/jira/browse/LENS-615


Repository: lens


Description
---

LENS-615 Refactoring of testQueryCommands test case


Diffs
-

  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 

Diff: https://reviews.apache.org/r/39191/diff/


Testing
---


Thanks,

Gabor Liptak