Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-24 Thread Sushil Mohanty
> On Oct. 25, 2015, 2:19 a.m., Srikanth Sundarrajan wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java, > > line 1169 > > > > > > Will this replace ` in any expression th

Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-24 Thread Srikanth Sundarrajan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39598/#review103920 --- lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/Columna

Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39598/#review103913 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 23, 2015, 4

Re: Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-23 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39598/ --- (Updated Oct. 23, 2015, 4:15 p.m.) Review request for lens. Changes ---

Review Request 39598: LENS-842 : Replace backquote with double quote in column alias for JDBC query

2015-10-23 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39598/ --- Review request for lens. Bugs: LENS-842 https://issues.apache.org/jira/brow