Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-15 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/#review106554 --- Ship it! Ship It! - Ajay Yadava On Nov. 12, 2015, 10:40 a.m., R

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-12 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/ --- (Updated Nov. 12, 2015, 4:10 p.m.) Review request for lens. Bugs: LENS-719

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-05 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/#review105366 --- Ship it! Ship It! - Amareshwari Sriramadasu On Nov. 2, 2015, 9:

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-02 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/ --- (Updated Nov. 2, 2015, 3:05 p.m.) Review request for lens. Bugs: LENS-719

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-02 Thread Rajat Khandelwal
> On Oct. 30, 2015, 8:55 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java, line 66 > > > > > > What are these changes for? Just simplifying the regular express

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-02 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/ --- (Updated Nov. 2, 2015, 1:48 p.m.) Review request for lens. Bugs: LENS-719

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-10-30 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/#review104567 --- lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUti

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-10-30 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/#review104556 --- Chnages look ok. +1 - Puneet Gupta On Oct. 30, 2015, 11:24 a.m.,

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-10-30 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/ --- (Updated Oct. 30, 2015, 4:54 p.m.) Review request for lens. Bugs: LENS-719

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-10-30 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/#review104535 --- lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.j

Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-10-30 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/ --- Review request for lens. Bugs: LENS-719 https://issues.apache.org/jira/brow