Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-10-03 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review151149
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Sept. 29, 2016, 10:27 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 29, 2016, 10:27 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Narayan Periwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/
---

(Updated Sept. 29, 2016, 10:27 a.m.)


Review request for lens.


Bugs: LENS-1340
https://issues.apache.org/jira/browse/LENS-1340


Repository: lens


Description
---

The data completeness API will take the factTag, startDate, endDate and 
measure's list as input. 
It will return the completeness percentage for each of the measures for the 
given factTag and time range.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52259/diff/


Testing
---


Thanks,

Narayan Periwal

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Narayan Periwal 


> On Sept. 29, 2016, 10:02 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 30
> > 
> >
> > Can you also describe significance of tagging here ?

Added the description for significance of tags.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150832
---


On Sept. 29, 2016, 10:27 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 29, 2016, 10:27 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150832
---




lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 30)


Can you also describe significance of tagging here ?


- Amareshwari Sriramadasu


On Sept. 29, 2016, 6:34 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 29, 2016, 6:34 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Narayan Periwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/
---

(Updated Sept. 29, 2016, 6:34 a.m.)


Review request for lens.


Bugs: LENS-1340
https://issues.apache.org/jira/browse/LENS-1340


Repository: lens


Description
---

The data completeness API will take the factTag, startDate, endDate and 
measure's list as input. 
It will return the completeness percentage for each of the measures for the 
given factTag and time range.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52259/diff/


Testing
---


Thanks,

Narayan Periwal

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-29 Thread Narayan Periwal 


> On Sept. 29, 2016, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 35
> > 
> >
> > Will it be measure names here or measure tags?

Will use measure tags for it.


> On Sept. 29, 2016, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 34
> > 
> >
> > Mention end date is exclusive

Will add this in the comment.


> On Sept. 29, 2016, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 32
> > 
> >
> > Give more details about what does tag mean here.

Added description for the fact tag.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150811
---


On Sept. 28, 2016, 9:25 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 28, 2016, 9:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150811
---




lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 32)


Give more details about what does tag mean here.



lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 34)


Mention end date is exclusive



lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 35)


Will it be measure names here or measure tags?



lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 38)


Should start and end dates be string to accept relative ranges like 
now.day-2days and etc ?

If so, we should fix the format for passing date fields as string.


- Amareshwari Sriramadasu


On Sept. 28, 2016, 9:25 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 28, 2016, 9:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Narayan Periwal 


> On Sept. 28, 2016, 8:59 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 34
> > 
> >
> > Please add java for all method params, describing what they are.

Added documentation for all method params.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150695
---


On Sept. 28, 2016, 9:25 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 28, 2016, 9:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Narayan Periwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/
---

(Updated Sept. 28, 2016, 9:25 a.m.)


Review request for lens.


Bugs: LENS-1340
https://issues.apache.org/jira/browse/LENS-1340


Repository: lens


Description
---

The data completeness API will take the factTag, startDate, endDate and 
measure's list as input. 
It will return the completeness percentage for each of the measures for the 
given factTag and time range.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52259/diff/


Testing
---


Thanks,

Narayan Periwal

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Amareshwari Sriramadasu 


> On Sept. 26, 2016, 1:19 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 32
> > 
> >
> > What interval are the keys in the map spaced over?
> > 
> > Perhaps we need an UpdatePeriod argument?
> > 
> > Also, do keep in mind that end date should be exclusive. 
> > 
> > And, if we are passing start, end and UpdatePeriod, it might be better 
> > to use `org.apache.lens.cube.metadata.TimePartitionRange`
> 
> Narayan Periwal wrote:
> Keys are spaced over hourly intervals, this is fixed. 
> Sure, will take care of this fact that end date is exclusive.

I would not recommend using org.apache.lens.cube.metadata.TimePartitionRange, 
as those are not public classes.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150396
---


On Sept. 26, 2016, 1:03 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 26, 2016, 1:03 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-28 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150695
---




lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 34)


Please add java for all method params, describing what they are.


- Amareshwari Sriramadasu


On Sept. 26, 2016, 1:03 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 26, 2016, 1:03 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-26 Thread Narayan Periwal 


> On Sept. 26, 2016, 1:19 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 32
> > 
> >
> > What interval are the keys in the map spaced over?
> > 
> > Perhaps we need an UpdatePeriod argument?
> > 
> > Also, do keep in mind that end date should be exclusive. 
> > 
> > And, if we are passing start, end and UpdatePeriod, it might be better 
> > to use `org.apache.lens.cube.metadata.TimePartitionRange`

Keys are spaced over hourly intervals, this is fixed. 
Sure, will take care of this fact that end date is exclusive.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150396
---


On Sept. 26, 2016, 1:03 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 26, 2016, 1:03 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-26 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150396
---




lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 32)


What interval are the keys in the map spaced over?

Perhaps we need an UpdatePeriod argument?

Also, do keep in mind that end date should be exclusive. 

And, if we are passing start, end and UpdatePeriod, it might be better to 
use `org.apache.lens.cube.metadata.TimePartitionRange`


- Rajat Khandelwal


On Sept. 26, 2016, 6:33 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 26, 2016, 6:33 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-26 Thread Narayan Periwal 


> On Sept. 26, 2016, 12:44 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java,
> >  line 29
> > 
> >
> > Can you add documentation? e.g. What is the key `String` and what is 
> > supposed to be in the map.

Added the Documentation.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150390
---


On Sept. 26, 2016, 1:03 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 26, 2016, 1:03 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-26 Thread Narayan Periwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/
---

(Updated Sept. 26, 2016, 1:03 p.m.)


Review request for lens.


Bugs: LENS-1340
https://issues.apache.org/jira/browse/LENS-1340


Repository: lens


Description
---

The data completeness API will take the factTag, startDate, endDate and 
measure's list as input. 
It will return the completeness percentage for each of the measures for the 
given factTag and time range.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52259/diff/


Testing
---


Thanks,

Narayan Periwal

Re: Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-26 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/#review150390
---




lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
(line 29)


Can you add documentation? e.g. What is the key `String` and what is 
supposed to be in the map.


- Rajat Khandelwal


On Sept. 26, 2016, 5:12 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52259/
> ---
> 
> (Updated Sept. 26, 2016, 5:12 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1340
> https://issues.apache.org/jira/browse/LENS-1340
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Review Request 52259: Adding API for data completeness checker (LENS-1340)

2016-09-26 Thread Narayan Periwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52259/
---

Review request for lens.


Bugs: LENS-1340
https://issues.apache.org/jira/browse/LENS-1340


Repository: lens


Description
---

The data completeness API will take the factTag, startDate, endDate and 
measure's list as input. 
It will return the completeness percentage for each of the measures for the 
given factTag and time range.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/DataCompletenessChecker.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52259/diff/


Testing
---


Thanks,

Narayan Periwal