Re: [Snowdrift-dev] [PATCH] User nicknames as public user IDs: Change UserR route

[Aaron Wolf]

On 03/07/2016 09:10 PM, Bryan Richter wrote:
> On Tue, Mar 08, 2016 at 04:39:11AM +0200, fr33domlover wrote:
>> On Mon, 7 Mar 2016 16:39:11 -0800
>> Bryan Richter  wrote:
>>
>>> Can I pass the tasks on to someone else who can take the time to
>>> figure out the best way to use OpenProject?
>>
>> Personally I'm not exactly excited about taking that role, unless OP
>> can be used conveniently from the terminal / text-based web browser
>> / email client, but regardless - do we have a documented workflow
>> for using it? Maybe you can push tasks to some TODO file / etherpad
>> / email. So far I like the use of the dev ML and IRC for that: You
>> mention a task, a dev picks it up and sends a patch or MR.
> 
> I like the idea of the ML too, though only for pushing notifications
> and discussing tasks. It's not gonna cut it for tracking them. Design,
> development, *and* users need to be able to track tasks.
> 
> Sadly, I just checked, and OpenProject flatly does not work without
> Javascript. That is unfortunate. I still suspect OpenProject will
> become THE tool for tracking tasks.
> 
>> The same applies to me and any other volunteer here: When someone
>> has some idea / proposal / problem / suggestion, where do they put
>> it? OP or mailing list or Snowdrift wiki?
> 
> Everyone is always welcome to send suggestions to the mailing list,
> and somebody will take care of triaging it. In the shortest of terms,
> that could even just mean I add it to my large list of tasks.
> 
> Eventually, everything will end up in OpenProject, however.
> 
> The "Snowdrift wiki" is one of the things being removed, by the way.
> 

All this needs to keep in mind that our absolute focus is on getting a
working MVP situation and getting the core thing finally launched.
Decisions made now have ramifications for longer term, but we're not
deciding one way or the other about the particular tools and issues in
the long-term. The point is to have a core working MVP.

Once we're on track to have an MVP, how we handle wiki and discussion
things and whatever else isn't set in stone. What matters right now is
that we use something workable to manage our immediate needs to get MVP.

I still want to see us use Gitit2 for a wiki connected to the eventually
launched system. I'm just accepting that the wiki we have on the site
right now is not going to stay as is and *cannot* be a distraction in
the building of the MVP. Once we have a working dev MVP thing, how we
*launch* it in relation to maintaining the content of the wiki and other
stuff is something to not get distracted with discussing today.

-Aaron




signature.asc
Description: OpenPGP digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

Re: [Snowdrift-dev] [PATCH] User nicknames as public user IDs: Change UserR route

[fr33domlover]

On Mon, 7 Mar 2016 16:39:11 -0800
Bryan Richter  wrote:

> Doing so, of course, massively conflicts with the changes you (fr33)
> are making; changes that are hard to make precisely because there's so
> much dead weight. This causes me — and presumably you — some tension.

Ah, I didn't know you were removing old code. Please don't let my patches
interfere though. I worked hard (in the sense of lots of git grep and stack
build, not intellectualy challenging or anything :P) to make all the chaos build
after changing all the routes, but it can wait until you clean the code and
re-do the /u/ changes on much smaller and simpler code.

Actually, with such huge changes I expected conflicts. Here they are :P

> 
> [ ... ]
> 
> To be more *on* topic, the act of stripping out dead code is creating
> some new tasks. I definitely want to share them and all that.
> OpenProject is the tool to do it with. Can I pass the tasks on to
> someone else who can take the time to figure out the best way to use
> OpenProject?

Personally I'm not exactly excited about taking that role, unless OP can be
used conveniently from the terminal / text-based web browser / email client, but
regardless - do we have a documented workflow for using it? Maybe you can push
tasks to some TODO file / etherpad / email. So far I like the use of the dev ML
and IRC for that: You mention a task, a dev picks it up and sends a patch or MR.

The same applies to me and any other volunteer here: When someone has some
idea / proposal / problem / suggestion, where do they put it? OP or mailing
list or Snowdrift wiki?

--fr33
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

Re: [Snowdrift-dev] [PATCH] User nicknames as public user IDs: Change UserR route

[Aaron Wolf]

On 03/07/2016 04:39 PM, Bryan Richter wrote:
> On Mon, Mar 07, 2016 at 02:39:07PM -0800, Aaron Wolf wrote:
>> In this case, I'm fine with moving forward but only if it's otherwise
>> clean progress.
> 
> Ok, if design is fine with it (which was expected) we come to a bigger
> problem.
> 
> Right now I'm working to strip out unnecessary features and prototype
> code. So far, that has resulted in 9,000 lines of code removed.
> 
> 9,000.
> 
> Yes, that is more than what's left. It's also as many as a good-sized
> novel.
> 
> https://github.com/snowdriftcoop/snowdrift/compare/master...chreekat:reboot?expand=1
> 
> IMO this project is dead and we don't know it yet. We HAVE to continue
> stripping out unusable code in order to resuscitate it.
> 
> Doing so, of course, massively conflicts with the changes you (fr33)
> are making; changes that are hard to make precisely because there's so
> much dead weight. This causes me — and presumably you — some tension.
> 
>> I definitely want to see *all* the stuff connected to work packages in
>> OP when it's not just minor typo fixes etc. And to that end, I hope the
>> dev team will already work to add stuff to OP and add more concrete
>> tasks to the existing user stories to make the already entered items
>> complete.
> 
> I still can't make heads or tails of OpenProject. I don't think I can
> take on the project manager role of managing that tool. And it
> *should* be managed, by some one person or another. I guess that's
> a different topic.
> 
> To be more *on* topic, the act of stripping out dead code is creating
> some new tasks. I definitely want to share them and all that.
> OpenProject is the tool to do it with. Can I pass the tasks on to
> someone else who can take the time to figure out the best way to use
> OpenProject?
> 
> (Apologies for cross posting to discuss@, but there's some larger
> topics here and I want to include more people.)
> 
> 

It seems to me that declaring a "freeze" on things makes sense while
making it clear that people can still do isolated valuable things like
figuring out what some CSS should be or discussing what some
architecture needs to look like.

I think resuscitating the code is as broadly simple as learning from all
the experience and work so far, but starting with a core MVP thing with
maximum segregation of parts, clear names for terms, clear tests… i.e.
what you're doing now.

All the design of tools and content and interest and everything else
provides valuable data from which to draw on going forward. The fact
that we already have working notifications being sent by email doesn't
mean we have to stick to the existing code, but it does mean we have
some code to draw on as we rewrite the core MVP. etc. I think when we
have a core clean MVP, it will be easy to say "oh, we need X, can we
just pull that in or adapt it easily enough from the original version?"
and the answers will vary from case to case.

Anyway, we absolutely need some leadership on Open Project. I hope we
can find people to step up and take that lead.





signature.asc
Description: OpenPGP digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

Re: [Snowdrift-dev] [PATCH] User nicknames as public user IDs: Change UserR route

[Bryan Richter]

On Tue, Mar 08, 2016 at 04:39:11AM +0200, fr33domlover wrote:
> On Mon, 7 Mar 2016 16:39:11 -0800
> Bryan Richter  wrote:
> 
> > Can I pass the tasks on to someone else who can take the time to
> > figure out the best way to use OpenProject?
> 
> Personally I'm not exactly excited about taking that role, unless OP
> can be used conveniently from the terminal / text-based web browser
> / email client, but regardless - do we have a documented workflow
> for using it? Maybe you can push tasks to some TODO file / etherpad
> / email. So far I like the use of the dev ML and IRC for that: You
> mention a task, a dev picks it up and sends a patch or MR.

I like the idea of the ML too, though only for pushing notifications
and discussing tasks. It's not gonna cut it for tracking them. Design,
development, *and* users need to be able to track tasks.

Sadly, I just checked, and OpenProject flatly does not work without
Javascript. That is unfortunate. I still suspect OpenProject will
become THE tool for tracking tasks.

> The same applies to me and any other volunteer here: When someone
> has some idea / proposal / problem / suggestion, where do they put
> it? OP or mailing list or Snowdrift wiki?

Everyone is always welcome to send suggestions to the mailing list,
and somebody will take care of triaging it. In the shortest of terms,
that could even just mean I add it to my large list of tasks.

Eventually, everything will end up in OpenProject, however.

The "Snowdrift wiki" is one of the things being removed, by the way.



signature.asc
Description: Digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

Re: [Snowdrift-dev] [PATCH] Add new route /u/

[Bryan Richter]

On Mon, Mar 07, 2016 at 03:30:00AM +0200, fr33domlover wrote:
> On Tue, 1 Mar 2016 16:27:41 -0800 Bryan Richter wrote:
> 
> > ** Tech action items
> > 
> > - UserHandle should be redefined to Text
> > - The existing route should be renamed getUserByIdR and should use
> >   UserId instead of UserHandle
> > - The new route should get the original name UserR
> 
> One thing I noticed when I started working on the code is that
> UserHandle is confusing. I checked what that type is used for. And
> it's used exactly for one thing: The type of the path piece in the
> routes file.

... So far. :) It was only just created. I did so to provide a layer
of abstraction. I'd rather have it than a bare Int or Text.


signature.asc
Description: Digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

Re: [Snowdrift-dev] [PATCH] User nicknames as public user IDs: Change UserR route

[Bryan Richter]

Before I comment on this patch, I think we should make sure that
Snowdrift.coop at large is ok with this change, and that that "ok" is
made real by adding the feature to OpenProject.

I want to get in the habit of doing feature-work that is in
OpenProject, and only that is in OpenProject. From the designer/owner
side, that ensures they get a chance to approve and prioritize work,
and from the developer side, it means we have a clear understanding of
new development we're responsible for. I think both aspects are
equally important.

Still, this is probably a good thing, so I've pushed this commit to a
new branch to ease collaboration.

https://git.gnu.io/snowdrift/snowdrift/tree/user-nicknames

On Mon, Mar 07, 2016 at 02:13:07PM +0200, fr33domlover wrote:
> From: fr33domlover 
> 
> Making UserR take a Text that refers to a whole new User field is a big
> change. Many handlers and templates need to be updated. Therefore please
> read below carefully to understand my plan and what exactly this commit
> does.
> 
> The GOAL is to move all UserId-based routes to use UserHandle instead,
> which is Text. That "handle" references a new 'userNick` field in the
> User table. But since this is a huge change, this commit does a smaller
> change. The rest will come in the next patches. What this commit does
> is:
> 
> 1. Update the UserR route and add a deprecated UserByIdR route
> 2. Add the 'userNick' field to account creation and account update forms
> 3. Require a pattern for the 'userNick' field to avoid all-digit
>nicknames and other potential issues
> 4. Fix all handlers and templates to pass the 'userNick' to 'UserR'
>instead of the 'userId'. That includes inserting 'get404' calls in
>several places just to get the User value, and other helpers that
>will be removed later. They are used just so that the code builds and
>works after applying this patch.
> 
> The next patch(es) will update all the other handlers and probably
> change some of the helper functions to work with the new 'userNick'
> field.
> 
> Before this gets committed, some input/review from dev and desig teams
> will be great. But don't be pedantic, as the next commits will change
> many things and will remove some of the ugly parts used here
> temporarily.
> 
> I suggest we make this change in 2 steps because it's so big:
> 
> 1. Change the routes and UI as needed, and do whatever is needed to make the
>code build again
> 2. When done, refactor and add helpers and put all the chaos back to order
> ---
>  config/models|   7 +
>  config/routes|   3 +-
>  src/Foundation.hs|  24 +++-
>  src/Handler/NewDesign.hs |  19 ++-
>  src/Handler/Project.hs   |  20 +--
>  src/Handler/User/Comment.hs  |   1 +
>  src/Handler/User/Delete.hs   |   3 +-
>  src/Handler/User/Edit.hs |   7 +-
>  src/Handler/User/NewDiscussion.hs|   1 +
>  src/Handler/User/Notifications.hs|   3 +-
>  src/Handler/User/ProjectNotifications.hs |   3 +-
>  src/Handler/User/SelectProject.hs|   3 +-
>  src/Handler/User/User.hs |   3 +-
>  src/Handler/User/Utils.hs|   2 +-
>  src/Handler/Who.hs   |  10 +-
>  src/Model/Transaction.hs |   2 +-
>  src/Model/User.hs|   7 +-
>  src/Model/User/Internal.hs   |  18 +--
>  src/View/SnowdriftEvent.hs   |  22 +--
>  src/View/User.hs |  37 -
>  templates/application.hamlet |   2 +-
>  templates/auth/create-user-form.hamlet   |  12 +-
>  templates/comment.hamlet |   7 +-
>  templates/default/navbar.hamlet  |  35 ++---
>  templates/invite.hamlet  |   8 +-
>  templates/navbar.hamlet  |   8 +-
>  templates/project_patrons.hamlet |   2 +-
>  templates/project_transactions.hamlet|   2 +-
>  templates/sponsors.hamlet| 226 
> +++
>  templates/tag.hamlet |   2 +-
>  templates/user.hamlet|   2 +-
>  templates/user_discuss.hamlet|   2 +-
>  templates/user_discussion_wrapper.hamlet |   2 +-
>  templates/user_tickets.hamlet|   2 +-
>  templates/users.hamlet   |   2 +-
>  templates/who.hamlet |   4 +-
>  templates/wiki_history.hamlet|   2 +-
>  tests/TestImport.hs  |   2 +-
>  38 files changed, 295 insertions(+), 222 deletions(-)
> 
> diff --git a/config/models b/config/models
> index a592753..bf64b14 100644
> --- a/config/models
> +++ b/config/models
> @@ -16,6 +16,12 @@ Transaction
>  
>  User
>  ident Text
> +-- ^ Private login name, never shown in UI, may be an email address in 
> the
> +--   case of Persona logins.
> +

Re: [Snowdrift-dev] Updating to work with github-0.14 (in LTS)

[Bryan Richter]

On Sun, Mar 06, 2016 at 12:09:07PM +0200, fr33domlover wrote:
> On Wed, 2 Mar 2016 13:31:59 -0800
> Bryan Richter  wrote:
> 
> > The github package is in LTS now, but it changed its interface to use
> > better types (Text, Vector, and vanilla UTCTime). I spent a bit of
> > time trying to upgrade the code, but decided to pass on it for now. If
> > someone else wants to update the code to work with github-0.14, so we
> > can drop github-0.13.2 from the list of extra-deps in stack.yaml, that
> > would be great.
> > 
> > -B
> 
> I sent a patch. It's not perfect (e.g. contains a TODO comment which suggests
> some further polishing) but handles all the module and type changes.

Applied. Thanks!


signature.asc
Description: Digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

[Snowdrift-dev] [PATCH 1/2] 'userDisplayName' now takes a User, not Entity User

[fr33domlover]

From: fr33domlover 

Username display is going to use only the 'userNick' and 'userName'
fields. The ID column and the login ident are internal details.
Therefore it becomes easier to the widely used 'userDisplayName'
function to take just a 'User' value.

To make the change gradual, there's a new userDisplayName' function
which has the old type signature, and we should gradually move code to
the new function. I'll try to do that later in a single dedicated commit
to avoid long-tern pain.
---
 src/Handler/NewDesign.hs |  4 ++--
 src/Handler/Project.hs   |  4 ++--
 src/Handler/User/Balance.hs  |  2 +-
 src/Handler/User/ChangePassphrase.hs |  2 +-
 src/Handler/User/ConfirmDelete.hs|  2 +-
 src/Handler/User/Delete.hs   |  2 +-
 src/Handler/User/Discussion.hs   |  2 +-
 src/Handler/User/Edit.hs |  2 +-
 src/Handler/User/Notifications.hs|  2 +-
 src/Handler/User/Pledges.hs  |  2 +-
 src/Handler/User/ProjectNotifications.hs |  2 +-
 src/Handler/User/ResetPassphrase.hs  |  2 +-
 src/Handler/User/SelectProject.hs|  2 +-
 src/Handler/User/Tickets.hs  |  2 +-
 src/Model/SnowdriftEvent.hs  | 12 ++--
 src/Model/Transaction.hs |  2 +-
 src/Model/User.hs| 15 ---
 src/SnowdriftEventHandler.hs |  6 +++---
 src/View/SnowdriftEvent.hs   | 22 +++---
 src/View/User.hs |  2 +-
 templates/application.hamlet |  2 +-
 templates/comment.hamlet |  6 +++---
 templates/dashboard/edit-profile.hamlet  |  2 +-
 templates/dashboard/overview.hamlet  |  2 +-
 templates/dashboard/pledges.hamlet   |  2 +-
 templates/dashboard/roles.hamlet |  2 +-
 templates/dashboard/transactions.hamlet  |  2 +-
 templates/project_patrons.hamlet |  2 +-
 templates/project_transactions.hamlet|  2 +-
 templates/tag.hamlet |  2 +-
 templates/tags.hamlet|  2 +-
 templates/user.hamlet|  4 ++--
 templates/user_discuss.hamlet|  4 ++--
 templates/user_tickets.hamlet|  6 +++---
 templates/users.hamlet   |  2 +-
 templates/wiki_history.hamlet|  2 +-
 36 files changed, 72 insertions(+), 63 deletions(-)

diff --git a/src/Handler/NewDesign.hs b/src/Handler/NewDesign.hs
index 99b8622..24cc985 100644
--- a/src/Handler/NewDesign.hs
+++ b/src/Handler/NewDesign.hs
@@ -28,7 +28,7 @@ import Model.User
 , fetchProjectNotificationsDB
 , fetchUserNotificationsDB
 , fetchUserProjectsAndRolesDB
-, userDisplayName
+, userDisplayName'
 , userReadNotificationsDB
 )
 import View.Project.Signup (projectSignupForm)
@@ -227,7 +227,7 @@ getUserR nickname = do
 
 defaultLayoutNew "user" $ do
 snowdriftDashTitle "User Profile" $
-userDisplayName (Entity user_id user)
+userDisplayName' (Entity user_id user)
 alphaRewriteNotice
 renderUser mviewer_id user_id user projects_and_roles
 
diff --git a/src/Handler/Project.hs b/src/Handler/Project.hs
index 4c7eff9..191fe96 100644
--- a/src/Handler/Project.hs
+++ b/src/Handler/Project.hs
@@ -220,7 +220,7 @@ getApplicationR project_handle application_id = do
 defaultLayoutNew "application" $ do
 snowdriftDashTitle
 (projectName project <> " Volunteer Application")
-(userDisplayName user)
+(userDisplayName' user)
 $(widgetFile "application")
 
 

@@ -463,7 +463,7 @@ getInviteR project_handle = do
  in fromMaybe (userNick user) $ userName user
 
 format_inviter user_id =
-userDisplayName $ fromMaybe (error "getInviteR(#2): user_id not 
found in users map")
+userDisplayName' $ fromMaybe (error "getInviteR(#2): user_id not 
found in users map")
 (M.lookup user_id users)
 
 defaultLayoutNew "invite" $ do
diff --git a/src/Handler/User/Balance.hs b/src/Handler/User/Balance.hs
index 5683482..ebe9ef6 100644
--- a/src/Handler/User/Balance.hs
+++ b/src/Handler/User/Balance.hs
@@ -42,7 +42,7 @@ getUserBalanceR' user_id = do
 
 defaultLayout $ do
 snowdriftDashTitle "User Balance" $
-userDisplayName (Entity user_id user)
+userDisplayName' (Entity user_id user)
 $(widgetFile "user_balance")
   where
 -- Warning: We can do better than 'read'.
diff --git a/src/Handler/User/ChangePassphrase.hs 
b/src/Handler/User/ChangePassphrase.hs
index 2ca4459..cbab6c5 100644
--- a/src/Handler/User/ChangePassphrase.hs
+++ b/src/Handler/User/ChangePassphrase.hs
@@ -16,7 +16,7 @@ getUserChangePassphraseR user_id = do
 (form, enctype) <- 

Re: [Snowdrift-dev] [PATCH] User nicknames as public user IDs: Change UserR route

[Aaron Wolf]

In this case, I'm fine with moving forward but only if it's otherwise
clean progress.

I definitely want to see *all* the stuff connected to work packages in
OP when it's not just minor typo fixes etc. And to that end, I hope the
dev team will already work to add stuff to OP and add more concrete
tasks to the existing user stories to make the already entered items
complete.

I like the direction fr33domlover is going here anyway.



signature.asc
Description: OpenPGP digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

Re: [Snowdrift-dev] [PATCH] User nicknames as public user IDs: Change UserR route

[Stephen Michel]

I think this is the kind of thing that it's important for you 
(chreekat) to get input on, but is ultimately your decision. It's also 
the kind of thing I'm having trouble working through on my own.


Originally I had more to this email but then decided it's a separate 
topic and deserves its own email. Sending it shortly.


On Mon, Mar 7, 2016 at 3:00 PM, Bryan Richter  
wrote:

Before I comment on this patch, I think we should make sure that
Snowdrift.coop at large is ok with this change, and that that "ok" is
made real by adding the feature to OpenProject.

I want to get in the habit of doing feature-work that is in
OpenProject, and only that is in OpenProject. From the designer/owner
side, that ensures they get a chance to approve and prioritize work,
and from the developer side, it means we have a clear understanding of
new development we're responsible for. I think both aspects are
equally important.

Still, this is probably a good thing, so I've pushed this commit to a
new branch to ease collaboration.

https://git.gnu.io/snowdrift/snowdrift/tree/user-nicknames

On Mon, Mar 07, 2016 at 02:13:07PM +0200, fr33domlover wrote:

 From: fr33domlover 

 Making UserR take a Text that refers to a whole new User field is a 
big
 change. Many handlers and templates need to be updated. Therefore 
please
 read below carefully to understand my plan and what exactly this 
commit

 does.

 The GOAL is to move all UserId-based routes to use UserHandle 
instead,
 which is Text. That "handle" references a new 'userNick` field in 
the
 User table. But since this is a huge change, this commit does a 
smaller
 change. The rest will come in the next patches. What this commit 
does

 is:

 1. Update the UserR route and add a deprecated UserByIdR route
 2. Add the 'userNick' field to account creation and account update 
forms

 3. Require a pattern for the 'userNick' field to avoid all-digit
nicknames and other potential issues
 4. Fix all handlers and templates to pass the 'userNick' to 'UserR'
instead of the 'userId'. That includes inserting 'get404' calls 
in

several places just to get the User value, and other helpers that
will be removed later. They are used just so that the code 
builds and

works after applying this patch.

 The next patch(es) will update all the other handlers and probably
 change some of the helper functions to work with the new 'userNick'
 field.

 Before this gets committed, some input/review from dev and desig 
teams
 will be great. But don't be pedantic, as the next commits will 
change

 many things and will remove some of the ugly parts used here
 temporarily.

 I suggest we make this change in 2 steps because it's so big:

 1. Change the routes and UI as needed, and do whatever is needed to 
make the

code build again
 2. When done, refactor and add helpers and put all the chaos back 
to order

 ---
  config/models|   7 +
  config/routes|   3 +-
  src/Foundation.hs|  24 +++-
  src/Handler/NewDesign.hs |  19 ++-
  src/Handler/Project.hs   |  20 +--
  src/Handler/User/Comment.hs  |   1 +
  src/Handler/User/Delete.hs   |   3 +-
  src/Handler/User/Edit.hs |   7 +-
  src/Handler/User/NewDiscussion.hs|   1 +
  src/Handler/User/Notifications.hs|   3 +-
  src/Handler/User/ProjectNotifications.hs |   3 +-
  src/Handler/User/SelectProject.hs|   3 +-
  src/Handler/User/User.hs |   3 +-
  src/Handler/User/Utils.hs|   2 +-
  src/Handler/Who.hs   |  10 +-
  src/Model/Transaction.hs |   2 +-
  src/Model/User.hs|   7 +-
  src/Model/User/Internal.hs   |  18 +--
  src/View/SnowdriftEvent.hs   |  22 +--
  src/View/User.hs |  37 -
  templates/application.hamlet |   2 +-
  templates/auth/create-user-form.hamlet   |  12 +-
  templates/comment.hamlet |   7 +-
  templates/default/navbar.hamlet  |  35 ++---
  templates/invite.hamlet  |   8 +-
  templates/navbar.hamlet  |   8 +-
  templates/project_patrons.hamlet |   2 +-
  templates/project_transactions.hamlet|   2 +-
  templates/sponsors.hamlet| 226 
+++

  templates/tag.hamlet |   2 +-
  templates/user.hamlet|   2 +-
  templates/user_discuss.hamlet|   2 +-
  templates/user_discussion_wrapper.hamlet |   2 +-
  templates/user_tickets.hamlet|   2 +-
  templates/users.hamlet   |   2 +-
  templates/who.hamlet |   4 +-
  templates/wiki_history.hamlet|   2 +-
  tests/TestImport.hs  |   2 +-
  38 files changed, 295 insertions(+), 222 

[Snowdrift-dev] [PATCH 2/2] Change all /u routes to use UserHandle

[fr33domlover]

From: fr33domlover 

---
 config/routes|  68 -
 src/Handler/NewDesign.hs |   5 +-
 src/Handler/ResetPassphrase.hs   |   3 +-
 src/Handler/User/Balance.hs  |  28 ++--
 src/Handler/User/ChangePassphrase.hs |  20 +--
 src/Handler/User/Comment.hs  | 234 ++-
 src/Handler/User/ConfirmDelete.hs|  23 +--
 src/Handler/User/Delete.hs   |  25 ++--
 src/Handler/User/Discussion.hs   |  23 ++-
 src/Handler/User/Edit.hs |  19 ++-
 src/Handler/User/EstEligible.hs  |   8 +-
 src/Handler/User/NewDiscussion.hs|  16 +--
 src/Handler/User/Notifications.hs|  21 ++-
 src/Handler/User/Pledges.hs  |  10 +-
 src/Handler/User/ProjectNotifications.hs |  16 +--
 src/Handler/User/ResetPassphrase.hs  |  33 +++--
 src/Handler/User/SelectProject.hs|  21 ++-
 src/Handler/User/Tickets.hs  |  10 +-
 src/Handler/User/User.hs |   8 +-
 src/Handler/User/Utils.hs|   3 +-
 src/Handler/User/VerifyEmail.hs  |  15 +-
 src/Model/Comment.hs |   4 +-
 src/Model/Comment/HandlerInfo.hs |   5 +-
 src/Model/Comment/Routes.hs  |  34 ++---
 src/Model/Markdown.hs|   4 +-
 src/View/SnowdriftEvent.hs   |   4 +-
 src/View/User.hs |   3 +-
 src/Widgets/UserPledges.hs   |   3 +-
 templates/change-passphrase.hamlet   |   2 +-
 templates/dashboard/nav.hamlet   |   2 +-
 templates/dashboard/notifications.hamlet |   4 +-
 templates/delete_user.hamlet |   2 +-
 templates/edit_user.hamlet   |   2 +-
 templates/project_feed.hamlet|   4 +-
 templates/project_notifications.hamlet   |   2 +-
 templates/set-passphrase.hamlet  |   2 +-
 templates/user.hamlet|  25 ++--
 templates/user_confirm_delete.hamlet |   2 +-
 templates/user_discuss.hamlet|  14 +-
 templates/user_discussion_wrapper.hamlet |   4 +-
 templates/user_notifications.hamlet  |   2 +-
 templates/user_select_project.hamlet |   2 +-
 42 files changed, 389 insertions(+), 346 deletions(-)

diff --git a/config/routes b/config/routes
index 7118d51..1c9c934 100644
--- a/config/routes
+++ b/config/routes
@@ -113,20 +113,20 @@
 
 -- User
 
-/u  UsersR GET
-/u/#UserId/balance  UserBalanceR   GET POST
-/u/#UserId/tUserTicketsR   GET
-/u/#UserId/change-passphraseUserChangePassphraseR  GET POST
-/u/#UserId/delete   DeleteUserRGET POST
-/u/#UserId/confirm-delete/#Text UserConfirmDeleteR GET POST
-/u/#UserId/edit EditUserR  GET POST
-/u/#UserId/elig UserEstEligibleR   POST
-/u/#UserId/user-notifications   UserNotificationsR GET POST
-/u/#UserId/pledges  UserPledgesR   GET
-/u/#UserId/project-notifications/#ProjectId ProjectNotificationsR  GET POST
-/u/#UserId/reset-passphrase/#Text   UserResetPassphraseR   GET POST
-/u/#UserId/select-project   UserSelectProjectR GET POST
-/u/#UserId/verify-email/#Text   UserVerifyEmailR   GET
+/u  UsersR GET
+/u/#UserHandle/balance  UserBalanceR   GET POST
+/u/#UserHandle/tUserTicketsR   GET
+/u/#UserHandle/change-passphraseUserChangePassphraseR  GET POST
+/u/#UserHandle/delete   DeleteUserRGET POST
+/u/#UserHandle/confirm-delete/#Text UserConfirmDeleteR GET POST
+/u/#UserHandle/edit EditUserR  GET POST
+/u/#UserHandle/elig UserEstEligibleR   POST
+/u/#UserHandle/user-notifications   UserNotificationsR GET POST
+/u/#UserHandle/pledges  UserPledgesR   GET
+/u/#UserHandle/project-notifications/#ProjectId ProjectNotificationsR  GET POST
+/u/#UserHandle/reset-passphrase/#Text   UserResetPassphraseR   GET POST
+/u/#UserHandle/select-project   UserSelectProjectR GET POST
+/u/#UserHandle/verify-email/#Text   UserVerifyEmailR   GET
 
 -- Notifications
 
@@ -200,26 +200,26 @@
 /c/#CommentId   CommentDirectLinkR
GET  DELETE
 /c/#CommentId/tag/#TagIdCommentTagR   
GET POST
 
-/u/#UserId/dUserDiscussionR   
GET POST
-/u/#UserId/d/new

Re: [Snowdrift-dev] [PATCH] User nicknames as public user IDs: Change UserR route

[Bryan Richter]

On Mon, Mar 07, 2016 at 02:39:07PM -0800, Aaron Wolf wrote:
> In this case, I'm fine with moving forward but only if it's otherwise
> clean progress.

Ok, if design is fine with it (which was expected) we come to a bigger
problem.

Right now I'm working to strip out unnecessary features and prototype
code. So far, that has resulted in 9,000 lines of code removed.

9,000.

Yes, that is more than what's left. It's also as many as a good-sized
novel.

https://github.com/snowdriftcoop/snowdrift/compare/master...chreekat:reboot?expand=1

IMO this project is dead and we don't know it yet. We HAVE to continue
stripping out unusable code in order to resuscitate it.

Doing so, of course, massively conflicts with the changes you (fr33)
are making; changes that are hard to make precisely because there's so
much dead weight. This causes me — and presumably you — some tension.

> I definitely want to see *all* the stuff connected to work packages in
> OP when it's not just minor typo fixes etc. And to that end, I hope the
> dev team will already work to add stuff to OP and add more concrete
> tasks to the existing user stories to make the already entered items
> complete.

I still can't make heads or tails of OpenProject. I don't think I can
take on the project manager role of managing that tool. And it
*should* be managed, by some one person or another. I guess that's
a different topic.

To be more *on* topic, the act of stripping out dead code is creating
some new tasks. I definitely want to share them and all that.
OpenProject is the tool to do it with. Can I pass the tasks on to
someone else who can take the time to figure out the best way to use
OpenProject?

(Apologies for cross posting to discuss@, but there's some larger
topics here and I want to include more people.)


signature.asc
Description: Digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev