Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
Oops - Greg s/b Gary. Ralph > On Nov 19, 2017, at 11:21 PM, Ralph Goers wrote: > > Oh, and I wouldn’t be surprised if the problem is caused by you using MS932 > and Greg using cp1252. > > Ralph > > >> On Nov 19, 2017, at 11:12 PM, Remko Popma wrote: >> >> Building current master (211326b)

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
Oh, and I wouldn’t be surprised if the problem is caused by you using MS932 and Greg using cp1252. Ralph > On Nov 19, 2017, at 11:12 PM, Remko Popma wrote: > > Building current master (211326b) succeeds for me when running `mvn clean > verify` on > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
Can you test the release candidate? If you do you might as well vote on it. Ralph > On Nov 19, 2017, at 11:12 PM, Remko Popma wrote: > > Building current master (211326b) succeeds for me when running `mvn clean > verify` on > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 20

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Remko Popma
Building current master (211326b) succeeds for me when running `mvn clean verify` on Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T01:41:47+09:00) Maven home: C:\apps\apache-maven-3.3.9\bin\.. Java version: 1.8.0_131, vendor: Oracle Corporation Java home: C:\apps\jdk1.8.

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Remko Popma
When I upgraded picocli to 2.0.3 a few weeks ago I made sure all tests passed on Windows. CI builds are ok. I also did a successful Log4j2 build on Windows yesterday when looking at pull request #134. This is very odd. > On Nov 20, 2017, at 12:49, Ralph Goers wrote: > > All of these erro

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
All of these errors seem to be against a single test class which tests the help text of the command line tool. Frankly, I don’t even know what that tool does. Second, I’ve not had any problems on MacOS nor seem complaints on Linux. Have you run a full build on Windows since JCommander replaced P

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Gary Gregory
-1 >From src zip: ASC OK, MD5 OK, SHA1 OK. Building with 'mvn clean verify' using: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T03:58:13-04:00) Maven home: C:\Java\apache-maven-3.5.2 Java version: *1.7.0_80*, vendor: *Oracle* Corporation Java home: C:\Program Files\Ja

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Gary Gregory
FTR, it would be good to note the svn revision of svn links. Gary On Sun, Nov 19, 2017 at 11:11 AM, Ralph Goers wrote: > This is a vote to release Log4j 2.10.0, the next version of the Log4j 2 > project. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, relea

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Mikael Ståldal
+1 * Maven artifacts works in my test project. * Build of tags/log4j-2.10-rc1 works. On 2017-11-19 19:11, Ralph Goers wrote: This is a vote to release Log4j 2.10.0, the next version of the Log4j 2 project. Please download, test, and cast your votes on the log4j developers list. [] +1, release

[VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
This is a vote to release Log4j 2.10.0, the next version of the Log4j 2 project. Please download, test, and cast your votes on the log4j developers list. [] +1, release the artifacts [] -1, don't release because... The vote will remain open for 72 hours (or more if required). All votes are welco

Re: Failing unit test

2017-11-19 Thread Ralph Goers
Thanks, I think your adding volatile may be the key. I don’t think the thread.interrupt does anything as the socket methods don’t declare that they throw InterruptedException. After I added the System.println statements I was able to get the release build to work. I am still in the process of

Re: Failing unit test

2017-11-19 Thread Mikael Ståldal
I made an attempt to make that test more reliable. On 2017-11-19 00:57, Ralph Goers wrote: I am preparing to do the release build and am getting the following error: Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.25 s <<< FAILURE! - in org.apache.logging.log4j.core.appender.

Re: logging-log4j2 git commit: Always delete temporary file created in test

2017-11-19 Thread Mikael Ståldal
OK, but it's probably good to have appender.stop() there as well, to try to end cleanly. And if you to try/catch around the deleteIfExists, it would be good to log any error, since that might be useful to troubleshoot any future file permission errors on Jenins. But I'll let you fix it. On

Re: logging-log4j2 git commit: Always delete temporary file created in test

2017-11-19 Thread Remko Popma
I have a fix, but I’ll hold off pushing it until Ralph is done with the release that’s in progress. (It’s just a try/catch FileSystemException around the deleteIfExists in the finally block on line 174) (Shameless plug) Every java main() method deserves http://picocli.info > On Nov 19, 2017,

Re: logging-log4j2 git commit: Always delete temporary file created in test

2017-11-19 Thread Mikael Ståldal
Does it help if you add: appender.stop(10, TimeUnit.SECONDS); after line 171 in Log4j1ConfigurationFactoryTest.java (last in the try block)? On 2017-11-19 05:41, Remko Popma wrote: The build now fails on windows. I always see this error: expected: C:\Users\remko\AppData\Local\Temp\/had