Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Robert Middleton
Some(most?) of the settings should be saved: https://github.com/apache/logging-chainsaw/blob/5ccb3c8e55dffd4361c549c3bcdac3f3675f79e5/src/main/java/org/apache/log4j/chainsaw/prefs/SettingsManager.java#L191 The stuff that is commented out should just be the old saving code that used XStream to

Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Christian Grobmeier
On Sun, Oct 1, 2023, at 22:09, Scott Deboy wrote: > I pushed branch "chainsaw-with-log4j1-dep" representing the working > log4j1 code for those that want to easily see what used to exist. > > I'll probably selectively incorporate pieces from that branch into master. I think thats a great idea.

Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Scott Deboy
I pushed branch "chainsaw-with-log4j1-dep" representing the working log4j1 code for those that want to easily see what used to exist. I'll probably selectively incorporate pieces from that branch into master. On 10/1/23, Christian Grobmeier wrote: > > On Sun, Oct 1, 2023, at 21:28, Scott Deboy

Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Christian Grobmeier
On Sun, Oct 1, 2023, at 21:28, Scott Deboy wrote: > The ability to route events to tabs is a core feature in the code - > that's how Chainsaw log messages end up in a Chainsaw-specific tab - > but the ability to control that routing via a 'routing expression' was > nuked from app-wide

Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Scott Deboy
The ability to route events to tabs is a core feature in the code - that's how Chainsaw log messages end up in a Chainsaw-specific tab - but the ability to control that routing via a 'routing expression' was nuked from app-wide preferences - another thing we should bring back. It looks like we

Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Robert Middleton
I would say the saving/loading of settings is probably the main thing to fix - if I remember correctly, it kinda works at the moment. Part of the issue with what it did before was that the settings were scattered among several different files with no apparent rhyme or reason, and converting them

Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Scott Deboy
We lost the initial 'Load Chainsaw Configuration' dialog (and menu item) that gave folks a way to set up a Chainsaw configuration. I'd like to see us restore that functionality, along with a menu support. Right now, you have to define a receiver by hand, and it has to be redefined on each app

Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Christian Grobmeier
On Sun, Oct 1, 2023, at 20:59, Scott Deboy wrote: > It's great to see the contribution, thanks Christian! > > I pulled down latest master and it looks like there are some UI > glitches we should fix - for example, resizing the logger tree pane > doesn't render correctly. > > As I mentioned before,

Re: [chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Scott Deboy
It's great to see the contribution, thanks Christian! I pulled down latest master and it looks like there are some UI glitches we should fix - for example, resizing the logger tree pane doesn't render correctly. As I mentioned before, I assume there are a bunch of features we lost when we moved

[chainsaw] What is necessary for a 2.2 release?

2023-10-01 Thread Christian Grobmeier
Hello, I am moving things around a lot. There is much refactoring that is necessary alone LogPanel had ~4500 lines of code. I believe this lot of LOCs is so complicated to understand that it prevents people from contributing - let alone Swing, but we can't change that. Apart from usual

Re: [VOTE] Release Apache Log4j Kotlin API 1.3.0

2023-10-01 Thread Gary Gregory
I wonder if the moditect plug in would do the heavy lifting for us here. It will automatically generate module info files. That's what we in over at Commons FWIW. Gary On Sat, Sep 30, 2023, 5:29 PM Piotr P. Karwasz wrote: > Hi Volkan, > > On Thu, 28 Sept 2023 at 15:25, Volkan Yazıcı wrote: >

Re: [VOTE] Release Apache Log4j Tools 0.5.0

2023-10-01 Thread Piotr P. Karwasz
Hi Gary, On Sun, 1 Oct 2023 at 14:20, Gary Gregory wrote: > > [Note to reviewers: You MUST review a src package, not a git tag.] > > -1: Failure running 'mvn clean verify' Nice catch. The problem comes from the modification date of each file in the source archive (i.e. start of the epoch). In

Re: [VOTE] Release Apache Log4j Tools 0.5.0

2023-10-01 Thread Gary Gregory
[Note to reviewers: You MUST review a src package, not a git tag.] -1: Failure running 'mvn clean verify' mvn clean verify Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /usr/local/Cellar/maven/3.9.4/libexec Java version: 17.0.8.1, vendor: Homebrew, runtime:

Re: [VOTE] Release Apache Log4j Tools 0.5.0

2023-10-01 Thread Gary Gregory
One day this will work in my fantasy world: shasum --check apache-log4j-tools-0.5.0-src.zip.sha512 shasum: apache-log4j-tools-0.5.0-src.zip.sha512: no properly formatted SHA checksum lines found ;-) Gary On Fri, Sep 29, 2023 at 5:03 PM Christian Grobmeier wrote: > > +1 > > > > On Fri, Sep 29,