Re: [ANNOUNCE] Apache Log4j 2.21.0 released

2023-10-16 Thread Gary Gregory
Thank you for RM'ing Christian! Gary On Mon, Oct 16, 2023, 4:28 PM Christian Grobmeier wrote: > Apache Log4j team is pleased to announce the 2.21.0 > release. Apache Log4j is a versatile, industrial-strength > Java logging framework composed of an API, its implementation, > and components to

Re: JDBC optimizations in 3.x

2023-10-16 Thread Gary Gregory
Below... On Mon, Oct 16, 2023 at 7:38 AM Piotr P. Karwasz wrote: > > Hi all, > > While checking out the module descriptors of `3.x` I have some > propositions of improvements to `log4j-jdbc` that I would like to run > by you before creating the appropriate Github issues: > > 1. The `log4j-jdbc`

[ANNOUNCE] Apache Log4j 2.21.0 released

2023-10-16 Thread Christian Grobmeier
Apache Log4j team is pleased to announce the 2.21.0 release. Apache Log4j is a versatile, industrial-strength Java logging framework composed of an API, its implementation, and components to assist the deployment for various use cases. For further information (support, download, etc.) see the

Re: Failing tests (was: [VOTE] Release Apache Log4j 2.21.0)

2023-10-16 Thread Piotr P. Karwasz
Hi Matt, On Mon, 16 Oct 2023 at 19:10, Matt Sicker wrote: > > I’ve seen that test fail in CI before as well. I wonder if there’s any > firewall issues that can interfere with it, or if it relies on some > potentially unusable state like a common port number. I switched to ephemeral ports

Re: [VOTE] Release Apache Log4j 2.21.0

2023-10-16 Thread Christian Grobmeier
Here is my own +1 With that, this vote passes with 5x +1 from: Volkan Yazici Piotr Karawasz Gary Gregory Ralph Goers Christian Grobmeier I will proceed with the following steps soon Thanks to everybody who voted! Christian On Fri, Oct 13, 2023, at 11:08, Christian Grobmeier wrote: > This is

Re: Failing tests (was: [VOTE] Release Apache Log4j 2.21.0)

2023-10-16 Thread Matt Sicker
I’ve seen that test fail in CI before as well. I wonder if there’s any firewall issues that can interfere with it, or if it relies on some potentially unusable state like a common port number. > On Oct 16, 2023, at 8:06 AM, Ralph Goers wrote: > > I enabled that profile. Log4j-core-test failed

Re: JDBC optimizations in 3.x

2023-10-16 Thread Matt Sicker
> On Oct 16, 2023, at 6:38 AM, Piotr P. Karwasz wrote: > > 2. There are two ways to map event data to columns: ColumnConfig and > ColumnMapping. It is unclear to me which way is the recommended one. > Since we can perform breaking changes in 3.x, could we remove one of > these methods? I added

Re: Failing tests (was: [VOTE] Release Apache Log4j 2.21.0)

2023-10-16 Thread Ralph Goers
I enabled that profile. Log4j-core-test failed after just over 23 minutes. [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR]

Re: JDBC optimizations in 3.x

2023-10-16 Thread Gary Gregory
Great questions and I will address each one, hopefully later today. Gary On Mon, Oct 16, 2023, 7:38 AM Piotr P. Karwasz wrote: > Hi all, > > While checking out the module descriptors of `3.x` I have some > propositions of improvements to `log4j-jdbc` that I would like to run > by you before

JDBC optimizations in 3.x

2023-10-16 Thread Piotr P. Karwasz
Hi all, While checking out the module descriptors of `3.x` I have some propositions of improvements to `log4j-jdbc` that I would like to run by you before creating the appropriate Github issues: 1. The `log4j-jdbc` module depends on the optional presence of `log4j-jndi`. Maybe we should split