Re: [log4j] Bump default status logger level to WARN

2023-07-26 Thread Gary Gregory
One think that turns me off big time about slf4j is that it logs to the console a warning about binding jars, almost always, in large apps (it does not matter why). Let's not do that if there is a chance it will annoy users. Gary On Wed, Jul 26, 2023, 06:14 Piotr P. Karwasz wrote: > Hi all, > >

Re: Supported Cassandra version

2023-07-17 Thread Gary Gregory
I think we can wait. Gary On Mon, Jul 17, 2023, 10:59 Piotr P. Karwasz wrote: > Hi all, > > As Dependabot often reminds us[1], Cassandra has a new 4.x major > version and version 3.x will reach end-of-life at the end of the > year[2]. > The appender is either perfect or rarely used: the last SO

Re: [Discuss][VOTE] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Gary Gregory
IMO the email subject and text MUST contain the RC number. It's a small change that makes a huge difference. Gary On Mon, Jul 3, 2023, 18:33 Ralph Goers wrote: > I am confused. We had a vote thread for 0.4.0. Did you close that vote? > Maybe I just didn’t get that email again. > > The commit t

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Gary Gregory
Well, don't use my ID in your clone ;-) Gary On Mon, Jul 3, 2023 at 9:16 AM Gary Gregory wrote: > > Hi Volkan > > Have a look at what we do in Commons where I generate the vote email's text > to a file for the RM to review. For example: > > git clone https://g

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Gary Gregory
ase!) > > This VOTE is for the 0.4.0 release of Apache Log4j Tools. > > On Mon, Jul 3, 2023 at 12:01 AM Gary Gregory > wrote: > > > Is it 0.4.0 or 7.8.0? ;-) > > > > Gary > > > > On Sun, Jul 2, 2023, 14:54 Volkan Yazıcı wrote: > > > > >

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-02 Thread Gary Gregory
Is it 0.4.0 or 7.8.0? ;-) Gary On Sun, Jul 2, 2023, 14:54 Volkan Yazıcı wrote: > This is a lazy vote to release the Apache Log4j Tools 7.8.0. > > This minor release contains small enhancements. Most importantly, this > marks the first release where the project uses itself to generate > release

Re: [log4j] Separate BOM releases

2023-06-23 Thread Gary Gregory
On Fri, Jun 23, 2023 at 8:49 AM Piotr P. Karwasz wrote: > > Hi Gary, > > On Fri, 23 Jun 2023 at 10:20, Gary Gregory wrote: > > Releasing the BOM every 6 months is not good IMO: It should be released > > every time one of its module is released, making it obvious that all

Re: [log4j] Separate BOM releases

2023-06-23 Thread Gary Gregory
Releasing the BOM every 6 months is not good IMO: It should be released every time one of its module is released, making it obvious that all latest versions work together _as should be expected_, otherwise we are putting the work on our users. If we end up with one repository per jar file, it's go

Re: [I] Drop or move JANSI support (logging-log4j2)

2023-06-22 Thread Gary Gregory
On Thu, Jun 22, 2023 at 7:19 AM Gary Gregory wrote: > > On Thu, Jun 22, 2023 at 7:06 AM Piotr P. Karwasz > wrote: > > > > Hi Gary, > > > > On Thu, 22 Jun 2023 at 12:05, Gary Gregory wrote: > > > > > > But is it enabled in cmd.exe? Windows

Re: [I] Drop or move JANSI support (logging-log4j2)

2023-06-22 Thread Gary Gregory
On Thu, Jun 22, 2023 at 7:06 AM Piotr P. Karwasz wrote: > > Hi Gary, > > On Thu, 22 Jun 2023 at 12:05, Gary Gregory wrote: > > > > But is it enabled in cmd.exe? Windows Terminal is a separate download, at > > least on Windows 10. > > You are right: remov

Re: Renaming `log4j-core`

2023-06-22 Thread Gary Gregory
I'm all for it. Finding a good new name is challenging, sure "impl" seems obvious, but maybe this is where slf4j/logback can be a lesson with it's clear split. Having a separate site for the API only might help. Gary On Thu, Jun 22, 2023, 04:35 Piotr P. Karwasz wrote: > Hi all, > > I think one

Re: [I] Drop or move JANSI support (logging-log4j2)

2023-06-22 Thread Gary Gregory
But is it enabled in cmd.exe? Windows Terminal is a separate download, at least on Windows 10. Gary On Thu, Jun 22, 2023, 03:55 ppkarwasz (via GitHub) wrote: > > ppkarwasz opened a new issue, #1529: > URL: https://github.com/apache/logging-log4j2/issues/1529 > >Since microsoft/terminal#2824

Re: MongoDB 3 appender

2023-06-21 Thread Gary Gregory
Ok to remove by me. Gary On Tue, Jun 20, 2023, 23:04 Piotr P. Karwasz wrote: > Hi all, > > According to MongoDB's lifecycle page: > > https://www.mongodb.com/support-policy/lifecycles > > MongoDB 3.x reached end-of-life in 2021. > > Should we drop the `log4j-mongodb3` module in Log4j 3.x? > > P

Re: Apache Log4cxx 1.1.0

2023-06-20 Thread Gary Gregory
Do we even still support 32-bit builds? Gary On Tue, Jun 20, 2023, 17:09 Ghori, Asif [US] (AS) wrote: > Hi > > I downloaded the Apache Log4cxx 1.1.0 and tried to compile using the > instructions of cmake/make file for 32 bit build. > I get the following error: > > Call of overloaded > 'Appender

Re: [VOTE] Release Apache Log4j 3.0.0-alpha1-rc2

2023-06-20 Thread Gary Gregory
asses are to be considered private. (for LOG4J2-2224 by Remko > Popma) > • Move time-related classes from core.util to core.time. Classes > considered private moved to core.time.internal. (for LOG4J2-2225 by Remko > Popma) > • Split off Kafka support into a new module log4j-

Re: Optional dependencies in `log4j-core` 3.x

2023-06-19 Thread Gary Gregory
> > Hi Gary, > > > > On Mon, 19 Jun 2023 at 15:01, Gary Gregory > wrote: > >> > >> I like the idea of not having any optional dependencies by using Maven > >> modules. > > > > I would also like to remove optional dependencies enti

Re: Optional dependencies in `log4j-core` 3.x

2023-06-19 Thread Gary Gregory
I like the idea of not having any optional dependencies by using Maven modules. Gary On Mon, Jun 19, 2023, 07:24 Piotr P. Karwasz wrote: > Hi all, > > While the list of optional dependencies in `log4j-core` version 3.x is > much shorter than the one in the 2.x series, we could probably still >

Re: Making compression extensible

2023-06-18 Thread Gary Gregory
I agree with Volkan, we should not accept a one-off. Instead, I would prefer we generically support whatever Apache Commons Compress supports. I can help beef up Compress if we need anything in there to make Log4j better. Gary On Sun, Jun 18, 2023, 14:52 Volkan Yazıcı wrote: > Recently, somebod

Re: [VOTE] Release Apache Log4j 3.0.0-alpha1-rc1

2023-06-16 Thread Gary Gregory
I'm ok either way, this is an alpha after all. Gary On Fri, Jun 16, 2023, 15:16 Matt Sicker wrote: > I agree the OSGi metadata should be fixed for this release. > > > On Jun 16, 2023, at 1:41 PM, Piotr P. Karwasz > wrote: > > > > Hi Ralph, > > > > On Thu, 15 Jun 2023 at 22:12, Ralph Goers >

Re: [log4j] Base Java version requirements for the future?

2023-06-07 Thread Gary Gregory
Something like: 3.0 : Java 11 ... Maintenance ~3.5 : Java 17 On Tue, Jun 6, 2023, 06:10 Gary Gregory wrote: > Note that if we decide to go with Java 17 instead of 11, I won't stand in > the way ;-) > > Gary > > On Tue, Jun 6, 2023, 06:09 Gary Gregory wrote: > >

Re: [log4j] Base Java version requirements for the future?

2023-06-06 Thread Gary Gregory
Note that if we decide to go with Java 17 instead of 11, I won't stand in the way ;-) Gary On Tue, Jun 6, 2023, 06:09 Gary Gregory wrote: > The case for maven is quite different IMO because it is a development tool > and does not or should not affect the runtime requirements of th

Re: [log4j] Base Java version requirements for the future?

2023-06-06 Thread Gary Gregory
The case for maven is quite different IMO because it is a development tool and does not or should not affect the runtime requirements of the artifacts built. Gary On Tue, Jun 6, 2023, 03:28 Piotr P. Karwasz wrote: > Hi, > > On Mon, 5 Jun 2023 at 18:33, Matt Sicker wrote: > > Piotr raised an in

Re: [log4j] Base Java version requirements for the future?

2023-06-05 Thread Gary Gregory
them. > > On Mon, Jun 5, 2023 at 10:00 PM Gary Gregory > wrote: > > > The latest LTS always view is not realistic if you want users to migrate > to > > our latest version. My experience is that this will only achieve > excluding > > apps from migrating because u

Re: [log4j] Base Java version requirements for the future?

2023-06-05 Thread Gary Gregory
The latest LTS always view is not realistic if you want users to migrate to our latest version. My experience is that this will only achieve excluding apps from migrating because updating the underlying Java platform is non-trivial for larger enterprise grade stacks. Gary On Mon, Jun 5, 2023, 14:

Re: [log4j] Base Java version requirements for the future?

2023-06-05 Thread Gary Gregory
I feel we should base 3.0 on Java 11 and later go to 17, then 21, these all being Java LTS versions. >From what I see at work and in the wild, the move from Java 8 to 11 was a big deal. Sure, we are looking at 17 at work for the future but there is no big rush because on some of the OSs/customers

Re: [log4j] Snowflake Appender

2023-05-11 Thread Gary Gregory
Just don't use an Apache group ID in your maven coordinates. Gary On Thu, May 11, 2023, 19:14 Piotr P. Karwasz wrote: > Hi Paweł, > > On Thu, 11 May 2023 at 21:59, Pawel Urbanowicz > wrote: > > I would like to contribute to log4j by implementing the Snowflake > appender > > which will use Snow

Re: [log4j] Snowflake Appender

2023-05-11 Thread Gary Gregory
Pawel, Your best bet is to provide this code in your own GitHub (or GitLab, or wherever) repository and publish to Maven Central. This will give you the freedom of providing features, bug fixes, and releases as you best see fit. Gary On Thu, May 11, 2023, 16:01 Pawel Urbanowicz wrote: > Hello

Re: [ANNOUNCE] Apache Log4j Transformation Tools 0.1.0 released

2023-05-07 Thread Gary Gregory
Thanks Piotr! Gary On Sat, May 6, 2023, 15:16 Piotr P. Karwasz wrote: > The Apache Log4j 2 team is pleased to announce the Apache Log4j > Transformation Tools 0.1.0 release! > > Apache Log4j Transformation Tools is a subproject of Apache Log4j that > provides binary manipulation tools for Log4j

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

2023-05-04 Thread Gary Gregory
subject to provenance, IMO. > Wanted to share my 2 cents. > This is not a mountain I am willing to die on. > > On Tue, May 2, 2023 at 9:40 PM Gary Gregory wrote: > > > What you are proposing IMO is confusing and clutters up the release tag > > space: "rel" stands fo

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

2023-05-02 Thread Gary Gregory
Uh? It should NOT contain an exact copy of a git repository, what do I need a ".github" folder for in order to build the project? I don't, it just clutter things up for no good reason. None of the Apache projects I've seen do this. It sounds like a convenience because it's easy as opposed to using

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

2023-05-02 Thread Gary Gregory
What you are proposing IMO is confusing and clutters up the release tag space: "rel" stands for "releases", not for "candidates for releases that may be completely broken" :-( It is of zero use to downstream users, and it is only being proposed out of the convenience because some tool does it, not

Re: Discuss [VOTE] Release Apache Log4j Transformation Tools 0.1.0

2023-05-01 Thread Gary Gregory
To refine Ralph's point, once the vote passes, you create the rel/ tag which should point to the SAME commit as the successful RC tag. Gary On Mon, May 1, 2023, 18:09 Ralph Goers wrote: > 1. As noted below you tagged with red/0.1.0-rc2. You really shouldn’t be > using rel/ as a tag for candid

Re: Formatting changes in Log4j

2023-04-18 Thread Gary Gregory
" The header is indented using ' * ' for Java, ' ~ ' for XML and '# ' for YAML." Also # for property files. Gary On Tue, Apr 18, 2023, 17:29 Piotr P. Karwasz wrote: > Hi all, > > As discussed during Sunday's meeting, in the following weeks I would > like to perform these cleanup jobs on our

Re: Making all date-time formatters follow `DateTimeFormatter` syntax

2023-04-10 Thread Gary Gregory
The PR talks about SDT which is...? Gary On Mon, Apr 10, 2023, 12:13 Volkan Yazıcı wrote: > As reported by Piotr in #1416 > (and causing the > JTL > issue in #1420 ), > certain formattin

Re: [log4net] About the language of comments in the code

2023-03-16 Thread Gary Gregory
Based on this email, your English is great! I'd say any documentation is better than none. Gary On Thu, Mar 16, 2023 at 11:07 AM 夏月 梨幸 wrote: > > Hello. > > I do not speak English, so please excuse the machine translation. > I would like to propose and provide code for MaxDateRollBackups in >

Re: [log4j] 2.x changelog

2023-03-10 Thread Gary Gregory
Thank you Volkan :-) Gary On Fri, Mar 10, 2023, 08:53 Volkan Yazıcı wrote: > In `/CHANGELOG.adoc`. There is nothing special about it. Create a > `/src/changelog/.2.x.x/-.xml` file, you can use the > existing ones for inspiration, that is it. > > On Fri, Mar 10, 2023 at 1:51 PM Gary D. Gregory

Re: [log4j] Checkout from git is broken

2023-03-10 Thread Gary Gregory
So the branch renaming broke cloning and checking out code with the most basic git command? At least that's what the side effect seems to me. What's the fix? Or will no one ever be able to say 'git clone' as below and have it just work? Gary On Fri, Mar 10, 2023, 05:18 Volkan Yazıcı wrote: > We

Re: Phasing out Jenkins page

2023-03-03 Thread Gary Gregory
Sounds good to me. Gary On Fri, Mar 3, 2023, 10:07 Volkan Yazıcı wrote: > It has been more than a year since Jenkins stopped doing anything for > Log4j. I want to create an INFRA ticket to phase-out Jenkins Logging page > and anything else related to

Re: [log4j] Release 2.20.0 missing tests.jar

2023-03-01 Thread Gary Gregory
It's been renamed in a new Maven module without using a qualifier. AFK. See elsewhere on this list for details. Gary On Wed, Mar 1, 2023, 14:41 Mikael Ståldal wrote: > It seems like the 2.20.0 release is missing the > log4j-core-2.20.0-tests.jar, that used to be part of the releases. Is > that

Re: On publishing test JARs

2023-02-22 Thread Gary Gregory
I should add that I don't expect any kind of BC compatibility, I take them as they are and adapt. Gary On Wed, Feb 22, 2023, 07:23 Gary Gregory wrote: > Please keep publishing test jars, at least the core and api jars. One of > these contains Junit rules and utilities that are very

Re: On publishing test JARs

2023-02-22 Thread Gary Gregory
Please keep publishing test jars, at least the core and api jars. One of these contains Junit rules and utilities that are very useful and I reply on those for many projects. Gary On Wed, Feb 22, 2023, 03:04 Volkan Yazıcı wrote: > I don't know what was our earlier policy on test JARs (if we hav

Re: Release plans for log4j-api-kotlin

2023-02-14 Thread Gary Gregory
There are quite a few jars out there that use "-jre8" type of postfixes strings in artifact IDs, so we should do the same IMO. But... The first question to ask is whether or not we should go through the pain of even supporting different Kotlin platforms. I wouldn't bother if it were me, but I'm n

Re: [Log4j] Branch naming

2023-02-08 Thread Gary Gregory
Having both master and 3.x is confusing IMO unless I missed something. For my money I'd keep it simple with either: - master and 2.x - 2.x and 3.x I don't care for the out of context presentism of main. Gary On Wed, Feb 8, 2023, 10:59 Volkan Yazıcı wrote: > Given we create a major release once

Re: Releases?

2023-02-07 Thread Gary Gregory
FWIW, I am around to review this weekend. Gary On Tue, Feb 7, 2023, 16:14 Piotr P. Karwasz wrote: > On Sat, 4 Feb 2023 at 22:46, Piotr P. Karwasz > wrote: > > https://github.com/apache/logging-log4j2/milestone/3 > > As far as I am concerned, 2.20.0 is good to go! > > Ralph, I leave you the las

Re: log4j-tools tags, checksums, JDK

2023-02-06 Thread Gary Gregory
FWIW, the rel/ prefix is mentioned here: https://commons.apache.org/releases/release.html as well as on the pages of some other Apache projects. But not that you could have guessed to look there ;-) This was announced quite a while back on the infra ML IIRC but now I could not find it. Gary On

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-02 Thread Gary Gregory
Warning: I am frustrated. I'm not going to -1 this but I'm not going to +1 because it is a giant pain to build without deleting a bunch of files from the source zip file. There are HIDDEN and not hidden Maven files/folders in there? Why? I f*k hate it when downloads try to take over my tooling.

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-02 Thread Gary Gregory
Another minor note: Doubling SHA checksums seems over-the-top in https://dist.apache.org/repos/dist/dev/logging/log4j/ I'd stick to 512. Gary On Tue, Jan 31, 2023 at 12:18 PM Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.2.0 release is now available for voting. > > This release contains the

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-02 Thread Gary Gregory
A minor note: The tags don't look to me like they are named properly. In other projects, I see and do, for example: someartifact-1.0.2-rc1 is the tag for an RC rel/someartifact-1.0.2 is the tag for the release where infra makes rel/ tags read-only, at least I'm pretty sure they do. Having a tag f

Re: Requiring signed commits

2023-01-13 Thread Gary Gregory
Sounds reasonable to sign commits if you think it could catch problems sooner, I onky sign tags usually. Gary On Fri, Jan 13, 2023, 04:56 Volkan Yazıcı wrote: > [I am resurrecting this post from March 2022 > .] > > I am in favor

Re: LOG4J2-3228 - Remove support for Serializable

2023-01-11 Thread Gary Gregory
Is the generic needed at all? Gary On Wed, Jan 11, 2023, 12:19 Matt Sicker wrote: > I’ve opened https://github.com/apache/logging-log4j2/pull/1199 to handle > this issue. The vast majority of the changes are from replacing `Layout extends Serializable` with just `Layout`. Please take a look and

Re: [VOTE] Release Apache Log4j Tools 0.1.0

2023-01-10 Thread Gary Gregory
better to stick > to some form of standard. > > On Tue, Jan 10, 2023 at 12:51 PM Gary Gregory > wrote: > > > > Curious: > > > > In the "classic" changelog, we use "add", "fix", and so on, simple > enough. > > Here, we use

Re: [VOTE] Release Apache Log4j Tools 0.1.0

2023-01-10 Thread Gary Gregory
Curious: In the "classic" changelog, we use "add", "fix", and so on, simple enough. Here, we use the past tense "added", and so on, except that we don't use "secured", we use "security", an odd inconsistency I guess. Any reason for that? FWIW, I like the simpler shorter words "add" and so on. Ga

Re: Builder methods: should we use setFoo, withFoo, foo, or else?

2023-01-09 Thread Gary Gregory
Hm, I've never been fond of "with" names, it feels rather odd to me. If the receiver is a builder then it's (usually) mutable, so I know that setters return "this". If the class is not a builder, the I check the Javadoc. Gary On Sun, Jan 8, 2023, 16:49 Matt Sicker wrote: > In my experience, I’v

Re: Syncing `master`

2023-01-03 Thread Gary Gregory
Sounds like it could backfire in some cases creating busy work: What happens when I commit to 2.x for code that has been deprecated or removed in 3.x? Certainly we don't want to create tickets for those. Do I have to remember to put a special comment in the commit message? Gary On Tue, Jan 3, 202

Re: Maven site failure

2022-12-30 Thread Gary Gregory
Should that setting be flipped such that a Maven module ask to be Javadoc'd? Gary On Fri, Dec 30, 2022, 07:23 Volkan Yazıcı wrote: > Agreed. > > Ralph, I see that you have only added `true` to > `log4j-layout-template-json-test` module, why don't we add it to all > `*-test` and `*-its` modules?

Re: [logging-log4j2] branch master updated: Fix NPE in Log4jMarker

2022-12-25 Thread Gary Gregory
Thank you for the clarification, Piotr. I missed the fact that this is for slf4j. Gary On Sun, Dec 25, 2022 at 5:03 PM Piotr P. Karwasz wrote: > > Hi Gary, > > On Sun, 25 Dec 2022 at 22:53, Gary Gregory wrote: > > > > I think using Objects.requireNonNull() is more p

Re: [logging-log4j2] branch master updated: Fix NPE in Log4jMarker

2022-12-25 Thread Gary Gregory
I think using Objects.requireNonNull() is more precise FWIW. Gary On Sun, Dec 25, 2022, 16:38 wrote: > This is an automated email from the ASF dual-hosted git repository. > > pkarwasz pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git > > > T

Re: Dancing with dependabot

2022-12-02 Thread Gary Gregory
Very cool, I wonder how GH knows not to merge if any build in the PR failed. Gary On Fri, Dec 2, 2022, 13:43 Volkan Yazıcı wrote: > Via GitHub Actions: > > https://github.com/apache/logging-log4j-tools/blob/master/.github/workflows/build.yml#L71 > > On Fri, Dec 2, 2022 at 2:17

Re: Dancing with dependabot

2022-12-02 Thread Gary Gregory
That's cool! How is that set up? Gary On Fri, Dec 2, 2022 at 8:11 AM Volkan Yazıcı wrote: > > In the context of LOG4J2-3628 (replacing `maven-changes-plugin`), I am > overhauling the `log4j-tools` project. I have done something, if I may say, > A-W-E-S-O-M-E, which I would like to repeat for Log

Re: Log4j-tools

2022-11-28 Thread Gary Gregory
I would prefer logging-log4j-server. Gary On Mon, Nov 28, 2022, 11:31 Ralph Goers wrote: > We currently have logging-log4j-tools which contains the log server code. > The log4j server isn’t really a tool so I would propose that the repo > either be renamed to logging-log4j-samples or logging-lo

Re: `src/ide` folder

2022-11-24 Thread Gary Gregory
But yeah, if you want to drop it, that's likely ok. Gary On Thu, Nov 24, 2022 at 1:33 PM Gary Gregory wrote: > > I think the idea is to let us store settings for IJ and Eclipse for > formatting and whatever else helps. > > Gary > > On Thu, Nov 24, 2022 at 1:

Re: `src/ide` folder

2022-11-24 Thread Gary Gregory
I think the idea is to let us store settings for IJ and Eclipse for formatting and whatever else helps. Gary On Thu, Nov 24, 2022 at 1:14 PM Volkan Yazıcı wrote: > > Does anybody use this relic? If there are no objects, I will remove it.

Re: Dropping `log4j-redis` in `master`

2022-11-24 Thread Gary Gregory
I am ok either way as the in-memory logging I've done in the past has been much simpler. Gary On Thu, Nov 24, 2022, 08:45 Volkan Yazıcı wrote: > `RedisAppender` has been in the making in `master` for several years > without much interest from the community. Next to that there are > battle-teste

Re: Broken build

2022-11-17 Thread Gary Gregory
The stack bottom shows java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) I hope we are not running tests in parallel or else how can we be reliable and reproducible? And compare builds between developers? Gary On Wed, Nov 16, 2022, 19:23 Matt Sicker wrote: > Is this

Fwd: [DISCUSS] Quo Vadis Maven Site

2022-11-16 Thread Gary Gregory
Just FYI from the Maven list regarding site generation. -- Forwarded message - From: Tamás Cservenák Date: Wed, Nov 16, 2022, 05:19 Subject: [DISCUSS] Quo Vadis Maven Site To: Maven Developers List Howdy, This is really just a brainstorming thread I'd like to spin, regarding M

Re: Exposing internal testing facilities (was: ETA for 2.19.1?)

2022-11-12 Thread Gary Gregory
FWIW, I reply on some of the test framework like JUnit rules in work projects, it would be lame to have to reinvent the wheel. Gary On Sat, Nov 12, 2022, 08:41 Volkan Yazıcı wrote: > I am concerned that users rely on test modules intended for internal usage. > I would rather skip all `*-test`

Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

2022-11-10 Thread Gary Gregory
log is an important aspect of the website, too. > >>> > >>>> On Nov 9, 2022, at 1:43 PM, Ralph Goers > wrote: > >>>> > >>>> See my comments in the issue. I’d rather focus on web site changes > that provide real value. > >>>&g

Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

2022-11-08 Thread Gary Gregory
I do like all the details in the Jira ticket! :-) Gary On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı wrote: > In the context of migrating away from JIRA to GitHub Issues, I want to > replace the current maven-changes-plugin setup with a merge-conflict-free > Markdown-based solution. I have elaborate

Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

2022-11-07 Thread Gary Gregory
Just FYI, There is a release note discussion going on on the Maven list and someone said the following when I mentioned our plan to switch to GitHub Issues: "So you mean using ONLY gh for issues? So by doing this, you will exclude people living in countries banned from Github. Is it acceptable fr

Re: Switch Log4j to GitHub Issues

2022-11-05 Thread Gary Gregory
What I like best about switching to GitHub is dealing with fewer or zero spam tickets. I will also relay that I've had push back in the past from folks who refuse to get a GitHub account in order to provide PRs. I have no idea how we can integrate changes.xml with GitHub, maybe that's something t

Re: [ANNOUNCE] Changes to Jira Account Creation (issues.a.o/jira)

2022-10-23 Thread Gary Gregory
Using 2 issue tracking system sounds like a pain... :-( Gary On Sun, Oct 23, 2022, 16:34 Ralph Goers wrote: > Yup, I somehow missed that sentence. > > So they are suggesting that development continue to use Jira but users > report issues via GitHub. I would expect if we do that then we would al

Re: Dependabot emails are filling my mailbox

2022-09-24 Thread Gary Gregory
ing anymore. > > — > Matt Sicker > > > On Sep 23, 2022, at 17:06, Gary Gregory wrote: > > > > Have you ever heard the expression "Don't shoot the messenger"? ;-) > > > > Dependabot is a great tool IMO. > > > > I think someone had pro

Re: Dependabot emails are filling my mailbox

2022-09-23 Thread Gary Gregory
Have you ever heard the expression "Don't shoot the messenger"? ;-) Dependabot is a great tool IMO. I think someone had proposed a different email address for bot emails that that obviously did not happen. Then there is classic "inbox rules" reply. Whomever wants to drive this can go ahead... Ga

Re: [VOTE] Release Apache Log4j 2.19.0-rc2

2022-09-16 Thread Gary Gregory
FYI, as a sanity check, you should also check the ASC and SHA512 file for the zip or tar you validated. Gary On Fri, Sep 16, 2022, 12:34 Piotr P. Karwasz wrote: > Ralph, > > You have my +1 of course. I built from the source distribution with: > > Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718

Re: [VOTE] Release Apache Log4j 2.19.0-rc2

2022-09-14 Thread Gary Gregory
Make JsonTemplateLayout stack trace truncation > operate for each label block. Thanks to Arthur Gavlyukovskiy. > >> • LOG4J2-3550: SystemPropertyArbiter was assigning the value as > the name. Thanks to DongjianPeng. > >> • LOG4J2-3560: Logger$PrivateConfig.filter(Le

Re: Nasty surprise in 2.18.0

2022-09-12 Thread Gary Gregory
Hi Piotr, I see in the release notes that the fix made it in 2.19.0 RC1, thank you! Gary On Thu, Jul 21, 2022, 17:33 Gary Gregory wrote: > Hi Piotr, > > Thank you so much for the quick analysis! > > Gary > > > On Thu, Jul 21, 2022, 17:35 Piotr P. Karwasz > wrote

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Gary Gregory
n, Sep 12, 2022 at 11:24 AM Gary Gregory > wrote: > > > > Check, I am using Java 8 (with a Maven toolchain obviously). > > > > Gary > > > > On Mon, Sep 12, 2022, 08:45 Ralph Goers > wrote: > > > > > I believe Matt is referring to the errors Ron

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Gary Gregory
ide the toolchain > > to use) with Java 11 as a toolchain entry to compile the Java 9 and > > Java 11 modules. > > > > On Mon, Sep 12, 2022 at 9:05 AM Gary Gregory > wrote: > >> > >> I'm not sure I understand, but the bottom line is I can't build

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Gary Gregory
xed mode) > > > > [ERROR] > log4j-2.19.0-rc1\log4j-api\src\test\java\org\apache\logging\log4j\util\StackLocatorUtilTest.java:[31,18] > error: cannot find symbol > > [ERROR] symbol: class Reflection > > [ERROR] location: package sun.reflect > > > >

Re: Dist directories

2022-09-11 Thread Gary Gregory
are voted on and there is no vote open. That would mean they > were moved to the release directory. Sometimes the artifacts are > copied and then deleted when the next release comes along. > > Ralph > > > On Sep 10, 2022, at 4:29 PM, Gary Gregory > wrote: > > > > Is

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-10 Thread Gary Gregory
f different > directory. > • LOG4J2-3579: Fix ServiceLoaderUtil behavior in the presence of a > SecurityManager. Thanks to Boris Unckel. > • LOG4J2-3559: Fix resolution of properties not starting with > log4j2.. Thanks to Gary Gregory. > • LOG4J2-3557: Fix r

Re: SLF4J 1.8 and SLF4J 2.0

2022-08-26 Thread Gary Gregory
Makes sense. Gary On Fri, Aug 26, 2022, 15:55 Ralph Goers wrote: > Ceki never released a GA version of SLF4J 1.8. Since we are adding > support for SLF4J 2.0 in the next release I would suggest we also remove > log4j-slf4j18-impl. > > Ralph

Re: timestamp and thread name in StatusLogger

2022-08-26 Thread Gary Gregory
I've found that odd myself just like Maven output does not contain timestamps, might be for "simplest possible output". I'm all for adding these. Gary On Fri, Aug 26, 2022, 03:36 Volkan Yazıcı wrote: > Is there any particular reason we don't render the timestamp and thread > name in StatusLogge

Re: Running under a SecurityManager

2022-08-21 Thread Gary Gregory
Side note: The SecurityManager will eventually go away, which might not matter for us for a long time! See https://openjdk.org/jeps/411 Gary On Sun, Aug 21, 2022 at 8:12 AM Piotr P. Karwasz wrote: > Hello, > > As noticed by Boris Unckel in LOG4J2-3579[1], there are some issues > when running Lo

Re: Nasty surprise in 2.18.0

2022-07-21 Thread Gary Gregory
Hi Piotr, Thank you so much for the quick analysis! Gary On Thu, Jul 21, 2022, 17:35 Piotr P. Karwasz wrote: > Hi Gary, > > > The script that starts our app uses an environment variable called > > LOG4J and starting with 2.18.0, Log4j puts the content of this > > environment variable in ALL s

Nasty surprise in 2.18.0

2022-07-21 Thread Gary Gregory
Hi All, I just got an unfortunate surprise after updating to 2.18.0. A user reported that our app broke this like (edited to hide some stuff): 2022-07-21 09:08:31,010 main ERROR Could not create plugin of type class org.apache.logging.log4j.core.appender.ConsoleAppender for element Console: java.

Re: Performance blog

2022-07-11 Thread Gary Gregory
> But > he doesn’t say what versions he is using. I also didn’t see mention of where > the > source is. > > Ralph > > > On Jul 11, 2022, at 4:03 AM, Gary Gregory wrote: > > > > Found this randomly: > > https://blog.sebastian-daschner.com/entries/logging-performance-comparison > > > > Gary >

Performance blog

2022-07-11 Thread Gary Gregory
Found this randomly: https://blog.sebastian-daschner.com/entries/logging-performance-comparison Gary

Re: Source location static inlining

2022-07-10 Thread Gary Gregory
On Sun, Jul 10, 2022 at 4:58 PM Ralph Goers wrote: > > Because I don’t see how it can work. > > A ThreadLocal is a run time construct. If you are saving location information > in > a ThreadLocal then it is only good for the life of the request and/or thread. > But > the location information will

Re: Source location static inlining

2022-07-09 Thread Gary Gregory
There might be something to reuse from https://projectlombok.org/ Gary On Sat, Jul 9, 2022, 06:05 Volkan Yazıcı wrote: > Inspired by this SO post > and > with some help from Piotr , > I > have drafted a

Re: [VOTE] Release Apache Log4j 2.18.0-rc1

2022-06-30 Thread Gary Gregory
> — > Matt Sicker > > > On Jun 29, 2022, at 12:13, Ralph Goers wrote: > > > > I believe I have seen this or a similar error in the past but I haven’t > > seen it myself in quite a while. > > > > I’d bet it is a problem with the test. > > > > Ra

Re: [VOTE] Release Apache Log4j 2.18.0-rc1

2022-06-29 Thread Gary Gregory
I get a test failure: ERROR] Tests run: 21, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 121.852 s <<< FAILURE! - in org.apache.logging.log4j.core.config.TestConfigurator [ERROR] org.apache.logging.log4j.core.config.TestConfigurator.testReconfiguration Time elapsed: 15.035 s <<< FAILURE! j

Re: change.xml

2022-06-28 Thread Gary Gregory
"commit ID" -> "Apache ID" Gary On Tue, Jun 28, 2022, 06:24 Gary Gregory wrote: > The way I've been using changes.xml is slightly different: I record my > commit ID in dev and in due-to I usually list whomever participated by > looking at the Jira and/or

Re: change.xml

2022-06-28 Thread Gary Gregory
The way I've been using changes.xml is slightly different: I record my commit ID in dev and in due-to I usually list whomever participated by looking at the Jira and/or PR. Gary On Tue, Jun 28, 2022, 02:13 Ralph Goers wrote: > I don’t always check the changes.xml and during the frenzy of the CV

Re: [log4j] Default configuration for 3.x

2022-06-13 Thread Gary Gregory
Let me relate the path we took with some of our products. Ages ago, we started by logging just to the console, then customers would ask for help and we'd ask for logs, sometimes we got back a copy-paste, other times a screenshot, nothing helpful, so we then gave the users steps to enable file loggi

Re: Release-2.x failure

2022-05-30 Thread Gary Gregory
It the db location could be changed to the target folder. Gary On Mon, May 30, 2022, 07:33 Gary Gregory wrote: > I've run into this before and yes the test should delete its database on > completion but obviously does not. > > Gary > > On Mon, May 30, 2022, 03:10 Pi

Re: Release-2.x failure

2022-05-30 Thread Gary Gregory
I've run into this before and yes the test should delete its database on completion but obviously does not. Gary On Mon, May 30, 2022, 03:10 Piotr P. Karwasz wrote: > On Mon, 30 May 2022 at 09:01, Ralph Goers > wrote: > > > I always run mvn clean install. If there is something else that needs

Re: Log4j 2.18.0

2022-05-20 Thread Gary Gregory
Sounds good to me. I'll see if I have anything pending over the weekend but if I do it is not critical. Gary On Fri, May 20, 2022, 12:06 Ralph Goers wrote: > I am working through the last few issues I want to resolve for 2.18.0. > I’d like to hope I can have them done today but I might not. I w

Re: Log4j 3.x features

2022-05-18 Thread Gary Gregory
On Wed, May 18, 2022 at 5:37 PM Ralph Goers wrote: > > I don’t really care what doc format the manual uses, so long as they are all > the > same and it is easy to update the manual outside of a release. +1 Gary > > Ralph > > > On May 18, 2022, at 4:15 AM, Volkan Yazıcı wrote: > > > > 5. Manua

Re: o.a.l.log4j.util.Supplier versus j.u.f.Supplier.

2022-05-13 Thread Gary Gregory
I certainly would hope that collapsing Foo2, Foo3 into their parent is up for consideration for 3.0. Memories of Microsoft COM and DCOM... Gary On Fri, May 13, 2022, 13:36 Matt Sicker wrote: > The only realistic way to break compatibility in the API is to > introduce a v3 API and make the v3 Co

<    1   2   3   4   5   6   7   8   9   10   >