Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-12 Thread Matt Sicker
I’m canceling this vote and will start a new one for the updates in progress. > On Dec 12, 2021, at 21:41, Remko Popma wrote: > > Okay. Would it be a good idea to retain support for the %m{nolookups} > configuration format? > (Silently accept and ignore it.) Yes, I think it would be a good ide

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-12 Thread Matt Sicker
If you can handle that change, I can roll a new release candidate. Matt Sicker > On Dec 12, 2021, at 14:07, Volkan Yazıcı wrote: > > I know. I want them to be removed, not disabled. > >> On Sun, Dec 12, 2021 at 9:01 PM Matt Sicker wrote: >> >> Those w

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-12 Thread Matt Sicker
Those were already disabled in 2.15.0. Matt Sicker > On Dec 12, 2021, at 13:41, Volkan Yazıcı wrote: > > I very well recognize your heroic effort on tackling this issue and I am > very thankful for that. > I vote -1, because I want message (not configuration!) lookups

Re: [VOTE] Release Log4j 2.15.0-rc2

2021-12-12 Thread Matt Sicker
This vote thread is already closed. Did you mean to vote on the 2.15.1-rc1 thread? > On Dec 12, 2021, at 11:49, Carter Kozak wrote: > > +1 > > mvn clean && mvn install > rat passes > $ mvn -v > Apache Maven 3.6.3 > Maven home: /usr/share/maven > Java version: 1.8.0_282, vendor: Azul Systems, I

Re: [VOTE] Release Log4j 2.15.1-rc1

2021-12-11 Thread Matt Sicker
If possible, let’s try to get this vote done over the next 24 hours. Matt Sicker > On Dec 11, 2021, at 21:48, Matt Sicker wrote: > > This is a vote to release Log4j 2.15.1, the next version of the Log4j 2 > project. > > Please download, test, and cast your votes on the log

[VOTE] Release Log4j 2.15.1-rc1

2021-12-11 Thread Matt Sicker
This is a vote to release Log4j 2.15.1, the next version of the Log4j 2 project. Please download, test, and cast your votes on the log4j developers list. [] +1, release the artifacts [] -1, don't release because... The vote will remain open for 72 hours (or more if required). All votes are welco

Re: Removing message lookups in master

2021-12-11 Thread Matt Sicker
Agreed. I didn’t realize this feature existed like that until recently, and it’s not worth salvaging. Matt Sicker > On Dec 11, 2021, at 09:25, Ralph Goers wrote: > > I agree. Remove it from master. > > Ralph > >> On Dec 11, 2021, at 7:42 AM, Carter Kozak wrote

Re: [VOTE] Release Log4j 2.15.0-rc2

2021-12-09 Thread Matt Sicker
+1 Build good, sigs good, etc. Still has an issue running the Cassandra integration test on my machine, but not a blocker. Environment info: Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: /opt/homebrew/Cellar/maven/3.8.4/libexec Java version: 1.8.0_312, vendor: Azul S

Re: [VOTE] Release Log4j 2.15.0-rc1

2021-12-07 Thread Matt Sicker
Java 7 was only used in older releases. Java 9 can be replaced with 11 as there’s a module that requires 11. Matt Sicker > On Dec 7, 2021, at 16:49, Ron Grabowski > wrote: > >  I built with Java 8 because that's the default JDK on this Windows 10 box. > Based on https:

Re: [VOTE] Release Log4j 2.15.0-rc1

2021-12-07 Thread Matt Sicker
Run maven using Java 8. The build doesn’t specify requirements on that, so the default JDK is used, not a specific toolchain entry. Matt Sicker > On Dec 7, 2021, at 14:25, Gary Gregory wrote: > > Hi Matt: > > When I run 'mvn clean install' on Java 11 I get: >

Re: [VOTE] Release Log4j 2.15.0-rc1

2021-12-06 Thread Matt Sicker
+1 Signatures good, tests pass, etc. Environment (mixed toolchain depending on which module is being tested): openjdk version "1.8.0_312" OpenJDK Runtime Environment (Zulu 8.58.0.13-CA-macos-aarch64) (build 1.8.0_312-b07) OpenJDK 64-Bit Server VM (Zulu 8.58.0.13-CA-macos-aarch64) (build 25.312-

Re: Programmatically creating layout from configuration source

2021-12-03 Thread Matt Sicker
I do not, no, though that sounds like the default configuration you’re looking at? Matt Sicker > On Dec 3, 2021, at 16:36, Volkan Yazıcı wrote: > > I think I have pulled it out: after doing a configuration.start(), > configuration.getAppenders().values().iterator().next().getL

Re: Programmatically creating layout from configuration source

2021-12-03 Thread Matt Sicker
I don't think that's possible in the current plugin system without copying a bunch of code from AbstractConfiguration or similar. The code for translating configurations into objects works starting from the root configuration object. Ideally, the next gen plugin system will be able to support somet

Re: Logging to Datadog

2021-11-27 Thread Matt Sicker
How about the header and footer options of appenders? Matt Sicker > On Nov 27, 2021, at 12:30, Ralph Goers wrote: > > I’ve updated the Jira with a second option of enhancing the PatternLayout > which I like better. > > I will say that I find what DataDog is doing here to b

Re: [VOTE] Release log4net 2.0.13

2021-10-29 Thread Matt Sicker
Just reply to the old vote thread with a message saying you’re cancelling the vote. > On Oct 29, 2021, at 9:29 AM, Davyd McColl wrote: > > Hi Ralph > > I'm not sure how to cancel, other than saying here - it's cancelled? I'll > raise a new vote now with updated links. > > -d > On 2021/10/29

Re: log4cxx crashes after upgrade to Monterey

2021-10-27 Thread Matt Sicker
Could this be a firewall configuration issue? Matt Sicker > On Oct 27, 2021, at 11:52, Bob Kirnum wrote: > > I am concerned that something may have changed on my system not directly > related to the Monterey upgrade. We normally just use the dynamic library, > I only built it

Re: How to inject a dependency into a custom filter.

2021-10-22 Thread Matt Sicker
The script filters are already dynamic for script engines. Have you looked at that? Matt Sicker > On Oct 22, 2021, at 03:22, Gary Gregory wrote: > > Why not reuse the feature that lets log4j automatically reload a > configuration file if it detects the file has changed? >

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-19 Thread Matt Sicker
I put the Scala and Kotlin sites inside the log4j site repo mostly because that’s where they used to be in SVN. They could be split out at some point. Matt Sicker > On Oct 19, 2021, at 17:52, Ralph Goers wrote: > > Log4j-kotlin and log4j-scala could have had their own website rep

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Matt Sicker
The Maven shade plugin thing. On Mon, Oct 18, 2021 at 2:44 PM Apache wrote: > > What new plug-in? > > Ralph > > > On Oct 18, 2021, at 12:32 PM, Matt Sicker wrote: > > > > Testing the website publishing from the new plugin. It’s probably easier > > to ke

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Matt Sicker
set up. Matt Sicker > On Oct 18, 2021, at 14:16, Ralph Goers wrote: > > I feel like I am going in circles. > > Testing of what? I still don’t understand what the use case is for GitHub > Pages. What problem is it solving? > > Ralph > >> On Oct 18, 2021

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Matt Sicker
I’d imagine it’s for testing purposes initially. We should integrate it into the main domain when it’s ready for release. This should all be controllable via the .asf.yaml file. Matt Sicker > On Oct 18, 2021, at 12:32, Ralph Goers wrote: > > Why? > > Ralph > >> On

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-15 Thread Matt Sicker
Apache for that, but it doesn’t cover the GPG signature). There’s also some ASF rule I think about releases needing to be done by a human, but that might be more about reproducible builds. Matt Sicker > On Oct 15, 2021, at 05:57, Volkan Yazıcı wrote: > > I long had the ambition to

Re: maven-shaded-log4j-transformer

2021-10-15 Thread Matt Sicker
I’m in favor of making this its own repo. Making the build, site, and release process as simple as possible would be great. I can help with the release process at least. Matt Sicker > On Oct 15, 2021, at 09:56, Volkan Yazıcı wrote: > > License headers, `changes.xml` integrat

Re: Continuous performance test bed using GitHub Actions

2021-10-13 Thread Matt Sicker
That's really cool! Do note that we can publish to the ASF-specific branches, too, for hosting a site. On Wed, Oct 13, 2021 at 10:37 AM Volkan Yazıcı wrote: > > Do this: > > git fetch -p > git checkout -B gh-pages origin/gh-pages > python -m http.server > open http://localhost:8000/benchmark/resu

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

2021-10-13 Thread Matt Sicker
The 3.x code loads plugins from generated Java classes that correspond to ServiceLoader-loadable classes. Since each jar tends to end up with their generated plugin class going into different package names, the result of shading them together works naturally with combining the META-INF/services/ fi

Re: JsonTemplateLayout exclusions

2021-10-11 Thread Matt Sicker
I've used a negative lookahead regex for that like so: "labels": { "$resolver": "mdc", "pattern": "(?!(?i:x-spinnaker-accounts)).+" }, On Mon, Oct 11, 2021 at 7:26 PM Ralph Goers wrote: > > Volkan, > > I am currently including the ThreadContextMap in my JSON. I need to exclude > some of the ke

Re: Continuous performance testing tooling

2021-10-04 Thread Matt Sicker
CI tooling might help here if we can run the tests on a dedicated agent (or at least one where only a single perf test happens concurrently). Without a dedicated agent, running the tests repeatedly might help smooth the noisy neighbors. Matt Sicker > On Oct 4, 2021, at 02:48, Ralph Go

Re: [VOTE] Release log4cxx 0.12.1

2021-10-02 Thread Matt Sicker
This vote passes with 3 explicit +1 votes and one implicit +1 vote (Robert's). I don't remember seeing the result email, so here we go. On Wed, Sep 29, 2021 at 1:47 AM Ralph Goers wrote: > > +1 > > Verified the signature and that the LICENSE AND NOTICE were present on the > distribution artifact

Re: Cek's new log4j vs logback benchmark

2021-09-23 Thread Matt Sicker
I don't think we should get rid of the Java 8 specific performance options in the 2.x branch. In 3.x, we can simplify things to default to appropriate options for Java 11+ and also removing the less useful variants. On Thu, Sep 23, 2021 at 11:29 AM Carter Kozak wrote: > > Thanks, Ralph! > > You'r

Re: Maven test fails due to "module not found"

2021-09-22 Thread Matt Sicker
Based on how we had to structure the multiple compile passes to generate the proper module info, you need to run `clean` before `test`. Even if you don't call clean, in log4j-core, it has to invoke clean to remove some incorrectly-generated module info to replace it with the correct one. On Wed, S

[ANN] Release of Apache Log4j Kotlin API 1.1.0

2021-09-12 Thread Matt Sicker
://logging.apache.org/log4j/kotlin/download.html Make sure to verify downloaded artifacts with our GPG keys found here: https://www.apache.org/dist/logging/KEYS Maven artifacts are available from Maven Central: https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-api-kotlin/1.1.0/ -- Matt

Re: [VOTE] Release Log4j Kotlin API 1.1.0 RC1

2021-09-11 Thread Matt Sicker
I accidentally deleted the 1.0.0 artifacts from dist before waiting for the mirrors to sync, but no big deal. I'd imagine most users are downloading from Maven Central anyways. I'll commit the site and send the release announcement tomorrow. On Sat, Sep 11, 2021 at 5:01 PM Matt Sic

Re: [VOTE] Release Log4j Kotlin API 1.1.0 RC1

2021-09-11 Thread Matt Sicker
This vote passes with 3 +1 votes and no -1 votes. I'll continue with the release. On Sat, Sep 11, 2021 at 11:19 AM Ralph Goers wrote: > > My +1 > > Ralph > > > On Sep 11, 2021, at 9:03 AM, Matt Sicker wrote: > > > > My +1. Still looking for a third vote. &

Re: [VOTE] Release Log4j Kotlin API 1.1.0 RC1

2021-09-11 Thread Matt Sicker
My +1. Still looking for a third vote. On Thu, Sep 2, 2021 at 11:42 PM Raman Gupta wrote: > > +1 > > > On Sat, Aug 28, 2021 at 4:11 PM Matt Sicker wrote: > > > Hey everyone, we have a new release candidate for Log4j Kotlin API. > > This is a vote to release

[VOTE] Release Log4j Kotlin API 1.1.0 RC1

2021-08-28 Thread Matt Sicker
Hey everyone, we have a new release candidate for Log4j Kotlin API. This is a vote to release Log4j Kotlin API 1.1.0. Please download, validate, and cast your votes here. [] +1, release the artifacts [] -1, don't release because... The vote will remain open for 72 hours (or more if required). All

Re: [VOTE] Release Log4j Kotlin API 1.0.1 RC1

2021-08-28 Thread Matt Sicker
Apologies, cancelling this release. The changelog wasn't updated yet, and upon reviewing it, the version number proposed doesn't make sense. I'll follow up shortly with a 1.1-rc1. On Sat, Aug 28, 2021 at 2:34 PM Matt Sicker wrote: > > Hey everyone, we have a new releas

[VOTE] Release Log4j Kotlin API 1.0.1 RC1

2021-08-28 Thread Matt Sicker
Hey everyone, we have a new release candidate for Log4j Kotlin API. This is a vote to release Log4j Kotlin API 1.0.1. Please download, validate, and cast your votes here. [] +1, release the artifacts [] -1, don't release because... The vote will remain open for 72 hours (or more if required). All

Re: Cek's new log4j vs logback benchmark

2021-08-20 Thread Matt Sicker
Does it help that we have five different ways to do async logging? Matt Sicker > On Aug 20, 2021, at 19:19, Carter Kozak wrote: > > The benchmark itself sets the system property to opt into > AsyncLoggerContextSelector: > https://github.com/ceki/lo

Quarterly reporting for subprojects

2021-08-07 Thread Matt Sicker
Hi everyone, it’s that time again. Let’s collect our updates on what’s been happening the past quarter to help Ron fill out his first PMC report. Matt Sicker

Re: [general] Recommended event log storage?

2021-08-04 Thread Matt Sicker
ation queries. I see two main issues that they fall short of > > addressing in my experience: 1) Many users reach out to queries combined > > with aggregations (e.g., show me a histogram of mdc.httpStatusCode in the > > last month for this long query of mine) and RDBMSes are treme

[general] Recommended event log storage?

2021-08-03 Thread Matt Sicker
Hey all, I have a somewhat practical question related to logging here. For those of you maintaining a structured event log or audit log of some sort, what types of event log stores are you using to append them to? I feel like solutions like Splunk, ELK, etc., are geared toward diagnostic logs which

Re: Any plans to release log4j TCP server?

2021-07-18 Thread Matt Sicker
I had a thought recently that this mobile client sending logs problem could potentially be modelled using gRPC. This would make it simple for generating stubs (clients) for iOS/Android and server code for whatever language you want. There's also Apache Thrift which does the same thing except with m

Re: Log4j master branch

2021-07-11 Thread Matt Sicker
I’ve been making good progress on the bean stuff. Hopefully untangling the annotation processor from the annotations and the service class will help IDE compatibility. As it is, I’ve been running tests from the command line in individual modules as suggested by Ralph. While not ideal, it’s turned o

Re: Rolling tests / writing X log messages per second

2021-07-04 Thread Matt Sicker
When testing the passage of time, you can always try mocking the clock itself to simulate things like that. In some cases, use of count down latches or cyclic barriers can coordinate the various async actions rather than relying on clocks. Once you start testing and modeling these things like that,

Re: JsonTemplateLayout for Google Cloud Logging

2021-07-01 Thread Matt Sicker
As a committer, yes, feel free to use the dev field. The due-to field is used for contributions from outside the project. On Thu, Jul 1, 2021 at 4:48 PM Raman Gupta wrote: > > FYI: > > https://issues.apache.org/jira/browse/LOG4J2-3116 > > https://github.com/apache/logging-log4j2/pull/543 > > One

Re: JsonTemplateLayout for Google Cloud Logging

2021-07-01 Thread Matt Sicker
Looks like a nifty feature! On Wed, Jun 30, 2021 at 5:09 PM Raman Gupta wrote: > > I was thinking about contributing a JsonTemplateLayout for the structured > logging format expected by Google Cloud Logging [1]. > > This is what I've come up with so far: any comments are welcome: > https://gist

Thoughts on Java 11 style guide updates?

2021-06-27 Thread Matt Sicker
Since log4j 3.x is based on Java 11, that adds several new features that we can use. In particular, I've found two syntax additions that may be useful (besides the various API updates in the standard class library): * var keyword for local variables (annoyingly requires the use of "final var") * p

Re: Bazel for builds

2021-06-19 Thread Matt Sicker
I think the idea would be to separate the reusable test code into their own main modules which depend on JUnit and such which are only consumed by test modules. I think this approach could potentially work, but we’d end up with a few more published jars. On Sat, Jun 19, 2021 at 11:28 Ralph Goers

Re: [Chainsaw] JSON Support

2021-06-18 Thread Matt Sicker
A couple other common log collection setups I've come across over time: * Logging to stdout/stderr in a standard format, then use a log collection API from your orchestration engine (common in the Kubernetes world to avoid logging to a file). * Logging to a log file as normal, but running a log fo

Re: Bazel for builds

2021-06-16 Thread Matt Sicker
to pretty much any build system. As for the Maven modularity (below), this might be something that can be addressed during the plugin system updates (potentially making log4j-plugins purely the annotation processor). On Wed, Jun 16, 2021 at 9:09 AM Matt Sicker wrote: > > I’ve noticed that

Re: Bazel for builds

2021-06-16 Thread Matt Sicker
I’ve noticed that attempting to support Java modules properly with Maven requires a lot of non standard configuration. I don’t know if anything can help there. On Wed, Jun 16, 2021 at 07:11 Jeanderson wrote: > Thanks for the input Volkan! > > > > By switching to another build tool (Bazel or anyt

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Matt Sicker
Bazel could be interesting, but does anyone here know how to configure it? On Fri, 11 Jun 2021 at 15:00, Volkan Yazıcı wrote: > > Since all of us are on board with the idea – except Gary, whom I will > address below – shall we work out the structuring? I already shared my > proposal. What is your

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Matt Sicker
We can certainly set up CI to build on upstream snapshot releases or even nightly jobs. For improving the build time of core, that will require parallelizing tests like in api. On Fri, Jun 11, 2021 at 13:48 Volkan Yazıcı wrote: > I agree with all the points (both pros and cons) you have shared.

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Matt Sicker
un 11, 2021, at 7:43 AM, Volkan Yazıcı wrote: > > > > I definitely agree with this. This is such a convenience while using Spring. > > > > On Fri, Jun 11, 2021 at 4:07 PM Matt Sicker wrote: > > > >> If we end up breaking up the modules and releasing them indep

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Matt Sicker
If we end up breaking up the modules and releasing them independently, I suggest we also adopt a release train mechanism to collect them together into single version BOM-style POM files. Also, if independent releases are faster to make and faster to verify, then we can make them more often. On Fri

Re: [CI][FAILURE] Logging/chainsaw/master#25 has potential issues

2021-06-09 Thread Matt Sicker
experience, it’s slightly easier to use and set up than GPG. On Wed, Jun 9, 2021 at 10:19 Ralph Goers wrote: > Another option. Perform the release build on your personal Mac. I’ve done > that for every Log4j release. > > Ralph > > > On Jun 9, 2021, at 7:40 AM, Matt Sicker w

Re: [CI][FAILURE] Logging/chainsaw/master#25 has potential issues

2021-06-09 Thread Matt Sicker
Another possibility is that PMCs can get a virtual machine allocated to them. Perhaps we could request a macOS EC2 instance for our VM? Or there may even be wider interest for a shared build agent. On Sun, Jun 6, 2021 at 19:15 Matt Sicker wrote: > I don't see any Mac build agents for

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-06-06 Thread Matt Sicker
tails. > > FWIW, the bug reported in > https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8265826 was > fixed in Java 17, so if we want to require Java 17 to be able to build > Log4j I could get around at least that part of the problem. > > Ralph > > > On Jun 6, 202

Re: [CI][FAILURE] Logging/chainsaw/master#25 has potential issues

2021-06-06 Thread Matt Sicker
happens(there's > probably an easier way to do it on my side). > > Somewhat related question: does the ASF Jenkins have any Mac builders? > It would be nice to make sure that the DMG gets generated on builds(I > suppose I could use github actions instead). > > -Robert Middlet

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-06-06 Thread Matt Sicker
Apr 8, 2021 at 5:17 AM Volkan Yazıcı > wrote: > > > I have also tried that too, but no luck so far. @Matt, are you able to run > > any tests from IDEA using the most recent "master"? > > > > On Wed, Apr 7, 2021 a

Re: [CI][FAILURE] Logging/chainsaw/master#25 has potential issues

2021-06-06 Thread Matt Sicker
I've fixed this issue. The problem was that while the version in master doesn't have a -SNAPSHOT, it can't be deployed to the snapshots repository (duh). I've updated the pipeline to check the maven project version for this before attempting to run a deploy step to publish snapshot builds. As a bon

Re: [VOTE] Release Apache Chainsaw 2.1.0-RC2

2021-06-06 Thread Matt Sicker
Nits (not blockers, but useful to fix for next release): * Source archive should be created by adding the option --prefix=apache-chainsaw-2.1.0/ so that the archives are inside a directory. As is, they don't have a containing directory which can be unexpected. +1 Signatures good, built and tested

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-06-05 Thread Matt Sicker
a but in javac but I suspect it would be a major change to > > fix it. > > > > I have meant to write a blog post on all of this basically to ask the > > question, > > “Is JPMS really worth it”? > > > > Ralph > > > >> On May 29, 2021, at 11:06

Re: [VOTE] Release Apache Chainsaw 2.1.0

2021-06-03 Thread Matt Sicker
Minimal source releases can be made by using git archive on the tag and signing/hashing the file. Then commit those to the release candidate repo. On Wed, Jun 2, 2021 at 23:22 Ralph Goers wrote: > Unfortunately, without a source zip or gz there is no release to approve. > > Ralph > > > On Jun 1,

Re: [apache/logging-log4j2] Liquibase 4.x Compatibility (#503)

2021-06-03 Thread Matt Sicker
It was probably contributed as a logging bridge/adapter similar to the SLF4J, JCL, JUL, etc, modules. Normally I’d say that this is the appropriate place to add anything related to log4j, but there are so many customizations out in the wild (see for instance the Spring Boot initialization stuff), I

Re: [VOTE] Release Apache Chainsaw 2.1.0

2021-06-01 Thread Matt Sicker
The NOTICE file still has a copyright from 2007, but that was already a problem in the previous release, so that can be fixed in another release. Also, it looks like you didn't commit the source archives to svn yet? On Tue, 1 Jun 2021 at 20:58, Robert Middleton wrote: > > This vote is to release

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Matt Sicker
t it would be a major change to > fix it. > > I have meant to write a blog post on all of this basically to ask the > question, > “Is JPMS really worth it”? > > Ralph > > > On May 29, 2021, at 11:06 AM, Matt Sicker wrote: > > > > Hey all, that itch is

[LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Matt Sicker
Hey all, that itch is back to figure out how to complete my previous attempt at the plugin system updates (started a little over a year ago and put on pause at some point). I'm currently working on getting that branch back up to working again with master (mostly needing to update module-info files)

Re: LOG4J2-3075 Formatting timestamps with nanosecond precision

2021-05-08 Thread Matt Sicker
Do note that the FastDateFormat et al. classes are copied directly from Apache Commons. Most changes done there are relevant to upstream. :) On Fri, 7 May 2021 at 10:14, Volkan Yazıcı wrote: > > Hello, > > I am trying to tackle LOG4J2-3075 > rep

Re: Quarterly project status updates - please check in

2021-05-08 Thread Matt Sicker
. It is a clear indication that JSON is a pretty > prominent encoding format for logs and users enjoy customizing it via > templating. In short, it was and still is definitely worth the effort. > > On Sat, May 1, 2021 at 5:39 PM Matt Sicker wrote: > > > Hey all, it’s that time of

Re: [Chainsaw] Minor fixes

2021-05-08 Thread Matt Sicker
CI fixed as of https://ci-builds.apache.org/job/Logging/job/chainsaw/job/master/16/ now using Java 11 to build. On Sat, 8 May 2021 at 14:41, Robert Middleton wrote: > > > > On Sat, May 8, 2021, 11:19 AM Matt Sicker wrote: > > > > As for committing the repository, >

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-05-08 Thread Matt Sicker
e time I pushed this update, so we'll have to check back later to see if this worked. :) On Tue, 6 Apr 2021 at 09:31, Matt Sicker wrote: > > Oh right, that could be done various ways. I'll figure something out. > Maybe the tool DSL works properly now (I think it was buggy whe

Re: [Chainsaw] Minor fixes

2021-05-08 Thread Matt Sicker
merge requests. > > On Sat, May 8, 2021, 11:19 AM Matt Sicker wrote: > > > It appears that Chainsaw updated its minimum Java version to 9. I'll > > get that fixed in the Jenkins build. As for committing the repository, > > you are a committer and can do so. We do comm

Re: [Chainsaw] Minor fixes

2021-05-08 Thread Matt Sicker
It appears that Chainsaw updated its minimum Java version to 9. I'll get that fixed in the Jenkins build. As for committing the repository, you are a committer and can do so. We do commit-then-review here which allows people to asynchronously review changes with lazy consensus. On Fri, 7 May 2021

Re: [VOTE] Announce EOL for Java 6 and Java 7

2021-05-06 Thread Matt Sicker
y > about it. > > :-) > > > > > On Mar 16, 2021, at 5:01, Matt Sicker wrote: > > > > The files will always be available on > > https://archive.apache.org/dist/logging/log4j/ including all our > > historical releases. I'm not so sure we need to keep the EOL

Re: Chainsaw build

2021-05-04 Thread Matt Sicker
https://infra.apache.org/apple-dev-program.html for more info about that. On Fri, 30 Apr 2021 at 09:34, Matt Sicker wrote: > > I think you'll need a signing key to make a dmg, too. There's a new > service from Infra available for that I think. > > On Fri, 30 Apr 2021 at

Re: [VOTE] Release log4cxx 0.12.0-RC2

2021-05-03 Thread Matt Sicker
If you don't feel the NOTICE file is a problem, then please make sure to update it in git for the next release. :) Signatures checked out, source archives look good. +1 On Mon, 3 May 2021 at 10:54, Thorsten Schöning wrote: > > Guten Tag Robert Middleton, > am Samstag, 1. Mai 2021 um 23:07 schrie

Re: Log levels on a schedule

2021-05-03 Thread Matt Sicker
Might be able to use a time filter? http://logging.apache.org/log4j/2.x/manual/filters.html#TimeFilter On Mon, May 3, 2021 at 09:12 Apache wrote: > That would be exactly right. I would create a TimeFilter that is very much > like the DynamicThresholdFilter but instead of using an MDC key it woul

Re: [DISCUSS][VOTE] Release log4cxx 0.12.0-RC2

2021-05-01 Thread Matt Sicker
The NOTICE file has copyright 2007 in it. That's pretty outdated at this point. On Sat, 1 May 2021 at 16:38, Ralph Goers wrote: > > > Why? I have never referenced gitbox in any of the Log4j releases. As far as I > am concerned https://github.com/apache is an ASF repo. > > Ralph > > > On May 1, 2

Quarterly project status updates - please check in

2021-05-01 Thread Matt Sicker
Hey all, it’s that time of year again! Please share a list of accomplishments, kudos, plans, etc, for use in this quarter’s board report. I have stats and such generated, so this is more of a narrative explanation of what’s going on. I’ll also review the recent list activity for anything that’s mis

Re: Chainsaw build

2021-04-30 Thread Matt Sicker
I think you'll need a signing key to make a dmg, too. There's a new service from Infra available for that I think. On Fri, 30 Apr 2021 at 01:20, Ralph Goers wrote: > > Yes, I agree it has been a long time. But I am not aware of anyone else who > has performed a release. Who did it last time? Whe

Re: Garbage Free Precise Time

2021-04-20 Thread Matt Sicker
Will that work in Java 16+ where internals are no longer accessible without additional compiler/runtime flags? This still seems like it may require explicit support in the standard class library like how other sun.misc classes got standardized eventually (like VarHandle). On Tue, 20 Apr 2021 at 07

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-20 Thread Matt Sicker
> > > On Thu, Apr 8, 2021 at 5:17 AM Volkan Yazıcı > > wrote: > > > >> I have also tried that too, but no luck so far. @Matt, are you able to > run > >> any tests from IDEA using the most recent "master"? > >> > >> On Wed, A

Re: Log4j core

2021-04-13 Thread Matt Sicker
Manager > but that module could be built before core and then could be optional. > > Ralph > > > On Apr 13, 2021, at 9:17 AM, Matt Sicker wrote: > > > > The SQL code is all related to JDBC and related appenders which could go in > > their own module. The naming

Re: Log4j core

2021-04-13 Thread Matt Sicker
The SQL code is all related to JDBC and related appenders which could go in their own module. The naming is primarily used for EE stuff which could all be split out (plus, I don’t think it’s in the default Android variant of Java). The RMI thing can probably be replaced as you suggested. JMX/manage

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3004 Add plugin support to JsonTemplateLayout. (#476)

2021-04-07 Thread Matt Sicker
Sounds like annotation processing has managed to get disabled in your IDE. IDEs tend to disable that by default due to the ability to run arbitrary code in annotation processors (but now IntelliJ has a "trusted project" feature for its own metadata, so maybe that's changed). Without the processor,

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-07 Thread Matt Sicker
See also https://lists.apache.org/thread.html/2ba2225043a6ca7d2c43e4293323309b041bd8d486516cc50fec61cd%40%3Cdev.logging.apache.org%3E On Wed, 7 Apr 2021 at 09:17, Ralph Goers wrote: > > mvn surefire:test -Dtest=TestClass -Dmaven.surefire.debug=“remote debug > options” > > Ralph > > > On Apr 7,

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-06 Thread Matt Sicker
t; control the behavior? > > Ralph > > > On Apr 6, 2021, at 6:45 AM, Matt Sicker wrote: > > > > Oops, good point. I need to make the version selection a little more > > sophisticated. Probably a branch or something for the shared lib. > > > >> On Tue, A

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-06 Thread Matt Sicker
er pushed a commit to branch master > >> in repository https://gitbox.apache.org/repos/asf/logging-pipelines.git > >> > >> > >> The following commit(s) were added to refs/heads/master by this push: > >>new 10333f7 Use Java 11 for master branch > >

Re: Jenkins build

2021-04-05 Thread Matt Sicker
The Windows build doesn't seem to be the issue. It seems to be related to running mvn deploy for the snapshot. See logs: https://ci-builds.apache.org/job/Logging/job/log4j/job/master/256/console On Mon, 5 Apr 2021 at 16:34, Matt Sicker wrote: > > Alright, the Linux side passed, but

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3004 Add plugin support to JsonTemplateLayout. (#476)

2021-04-05 Thread Matt Sicker
TypeConverterRegistry updates should be fine, just note I had to structure some of the code as it is as it can't rely on much else being set up quite yet. Even with the DI-rewrite, I think this area would still have limited ability to inject any configuration state as it's used for parsing and inje

Re: Jenkins build

2021-04-05 Thread Matt Sicker
Alright, the Linux side passed, but the Windows side had a module-related import error with OSGi. On Mon, 5 Apr 2021 at 16:21, Matt Sicker wrote: > > I've updated the mvn step to use Java 11 on the master branch. That > will apply to any other pipelines using this at the mo

Re: Jenkins build

2021-04-05 Thread Matt Sicker
I've updated the mvn step to use Java 11 on the master branch. That will apply to any other pipelines using this at the moment, but that shouldn't be a problem for now. On Mon, 5 Apr 2021 at 09:30, Matt Sicker wrote: > > Also, Jenkins docs are usually in Jenkins itself like thes

Re: Jenkins build

2021-04-05 Thread Matt Sicker
: loong page) https://ci-builds.apache.org/job/Logging/job/log4j/pipeline-syntax/globals On Mon, 5 Apr 2021 at 09:27, Matt Sicker wrote: > > https://github.com/apache/struts/blob/777caaade067b755b9aa4638f28ba8579d1c7a1d/Jenkinsfile#L32-L34 > is the gist of how it's normally supposed to be

Re: Jenkins build

2021-04-05 Thread Matt Sicker
to being a > novice when it comes to Jenkins pipelines. We use them at work and almost no > engineers understand them. > > Ralph > > > On Apr 4, 2021, at 9:17 PM, Matt Sicker wrote: > > > > Yeah, I can update it. I used a workaround a while ago with hard coded J

Re: Jenkins build

2021-04-04 Thread Matt Sicker
Yeah, I can update it. I used a workaround a while ago with hard coded JDKs which probably has a simpler approach now. The mvn command is in the vars directory. On Sun, Apr 4, 2021 at 21:09 Ralph Goers wrote: > Matt, > > I just noticed that the build for Log4j 2 Master is failing. I guess you >

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-02 Thread Matt Sicker
The maven verify error is something that affects the master branch too. Something to do with snapshots and depending on them inter-module. I don’t know enough about maven to explain why, but some modules require other modules to have been installed and not just packaged. On Fri, Apr 2, 2021 at 17:

Re: Please do not commit to log4j2 master - but review this PR.

2021-03-31 Thread Matt Sicker
and it had to be upgraded too. > > > > Ralph > > > >> On Mar 29, 2021, at 3:51 PM, Matt Sicker wrote: > >> > >> I’ll make sure to look more closely at it this week. Nice work on > >> simplifying the modules a bit! > >> > >> On S

Re: Please do not commit to log4j2 master - but review this PR.

2021-03-29 Thread Matt Sicker
I’ll make sure to look more closely at it this week. Nice work on simplifying the modules a bit! On Sun, Mar 28, 2021 at 18:24 Ralph Goers wrote: > I have created https://github.com/apache/logging-log4j2/pull/480 for you > to review. It has many changes and merge conflicts will be painful to fix

Re: release-2.x EventLogger

2021-03-24 Thread Matt Sicker
Any tests that rely on shared state that can’t be safely multithreaded needs to be categorized as such. I thought I covered everything in API already, but perhaps not. On Wed, Mar 24, 2021 at 21:38 Ralph Goers wrote: > I believe Matt made the tests in the API run in parallel. I’ve often > wonder

<    1   2   3   4   5   6   7   8   9   10   >