ConsoleAppender

2016-05-30 Thread Mikael Ståldal
The documentation says: Note that the follow attribute cannot be used with Jansi on Windows. However, this is not enforced in the code. Should it be? Is the deprecated createAppender method still needed? -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal

Re: 2.6 is not source compatible with 2.5

2016-05-30 Thread Mikael Ståldal
manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46 Stoc

Re: logging-log4j2 git commit: FastConsoleAppender

2016-05-26 Thread Mikael Ståldal
ommit/06c55468 > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/06c55468 > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/06c55468 > > Branch: refs/heads/LOG4J2-1395 > Commit: 06c55468948efdce95a591801d5f9e2ffdb69dd4 > Parents: e012269 > Author: Mik

Re: Garbage-free Log4j docs preview

2016-05-26 Thread Mikael Ståldal
I just tried, gives a 5x performance boost. See Git branch LOG4J2-1395 <https://issues.apache.org/jira/browse/LOG4J2-1395> . On Tue, May 24, 2016 at 4:27 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > Could we avoid that by using FileDescriptor.out / FileDescripto

Re: Build site

2016-05-26 Thread Mikael Ståldal
C (actually, any Apache committer can get commit rights to > Commons just by asking) and the discussion about this comes up from time to > time. > > Ralph > > On May 26, 2016, at 2:11 AM, Mikael Ståldal <mikael.stal...@magine.com> > wrote: > > When I try t

Re: Garbage-free Log4j docs preview

2016-05-26 Thread Mikael Ståldal
> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org > For additional commands, e-mail: log4j-dev-h...@logging.apache.org > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Tu

Re: [VOTE] Log4j 2.6 rc1

2016-05-26 Thread Mikael Ståldal
uot;git clone > https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then "git > checkout tags/log4j-2.6-rc1” > b) for an existing working copy to “git pull” and then “git checkout > tags/log4j-2.6-rc1” > > Web Site: > <http://rgoers.github.io/log4j2-sit

Build site

2016-05-26 Thread Mikael Ståldal
al org.apache.maven.plugins:maven-site-plugin:3.4:site failed: Invalid byte tag in constant pool: 18 -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] F

Re: How to deploy the site

2016-05-26 Thread Mikael Ståldal
- > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org > For additional commands, e-mail: log4j-dev-h...@logging.apache.org > > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magi

Re: Garbage-free Log4j docs preview

2016-05-26 Thread Mikael Ståldal
en to stdout (in containers) for simpler log configuration and > handling. It would be nice if we can support that scenario better. > > On 25 May 2016 at 09:18, Mikael Ståldal <mikael.stal...@magine.com> wrote: > >> There are use cases for logging to standard out/err and redirecting

Re: Garbage-free Log4j docs preview

2016-05-25 Thread Mikael Ståldal
016 at 4:09 PM, Matt Sicker <boa...@gmail.com> wrote: >>> >>>> All the PrintStream.write() methods have locks. >>>> >>>> On 24 May 2016 at 02:56, Mikael Ståldal <mikael@magine.com> wrote: >>>> >>>>> Do we know why Conso

Re: Garbage-free Log4j docs preview

2016-05-25 Thread Mikael Ståldal
rantees what it is referencing. > > Sent from my iPad > > On May 25, 2016, at 12:49 AM, Mikael Ståldal <mikael.stal...@magine.com> > wrote: > > > but I would guess the the FileDescriptor may just be a reference to the > PrintStream. > > I think it's the other way around,

Re: Garbage-free Log4j docs preview

2016-05-25 Thread Mikael Ståldal
bout us trying to use the FileDescriptor while the > application might be writing to System.out. > > Ralph > > On May 24, 2016, at 10:30 AM, Remko Popma <remko.po...@gmail.com> wrote: > > > On Tuesday, May 24, 2016 at 11:27:33 PM UTC+9, Mikael Ståldal wrote: >> >> Could

Re: Garbage-free Log4j docs preview

2016-05-24 Thread Mikael Ståldal
Could we avoid that by using FileDescriptor.out / FileDescriptor.err instead of System.out / System.err ? On Tue, May 24, 2016 at 4:09 PM, Matt Sicker <boa...@gmail.com> wrote: > All the PrintStream.write() methods have locks. > > On 24 May 2016 at 02:56, Mikael Ståld

Re: 2.6 Release

2016-05-24 Thread Mikael Ståldal
Fixed. On Tue, May 24, 2016 at 3:41 PM, Remko Popma <remko.po...@gmail.com> wrote: > Good catch! Can you fix the manual? > > Sent from my iPhone > > On 2016/05/24, at 17:03, Mikael Ståldal <mikael.stal...@magine.com> wrote: > > The manual says that the d

Re: 2.6 Release

2016-05-24 Thread Mikael Ståldal
t;>> >>>>> On May 21, 2016, at 10:41 PM, Remko Popma <remko.po...@gmail.com> >>>>> wrote: >>>>> >>>>> Good stuff! >>>>> This reminded me I need to take a look at my backup strategy. :-) >>>>> >>&g

Re: Garbage-free Log4j docs preview

2016-05-24 Thread Mikael Ståldal
gging.apache.org > For additional commands, e-mail: log4j-dev-h...@logging.apache.org > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Infor

Re: Garbage-free Log4j docs preview

2016-05-23 Thread Mikael Ståldal
reactive >>>>>>>> applications that need to respond quickly to external events. It is >>>>>>>> especially useful if the application needs to deal with occasional >>>>>>>> bursts >>>>>>>> of work (and accompanied bursts of logging). Th

Re: Garbage-free Log4j docs preview

2016-05-23 Thread Mikael Ståldal
gt;>>>> On 17 May 2016 at 18:13, Remko Popma <remko...@gmail.com> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> First, my thanks to the many people who gave helpful advice and >

Re: Garbage-free Log4j docs preview

2016-05-23 Thread Mikael Ståldal
reactive >>>>>>>> applications that need to respond quickly to external events. It is >>>>>>>> especially useful if the application needs to deal with occasional >>>>>>>> bursts >>>>>>>> of work (and accompanied bursts of logging). Th

Re: 2.6 Release

2016-05-23 Thread Mikael Ståldal
> > On Sat, May 21, 2016 at 2:47 PM, Remko Popma <remko.po...@gmail.com> > wrote: > >> Mikael, I finally had a chance to look at the update for the Layout page. >> Looks good. I like the new table with parameters for the JSON layout. >> >> On Fri, May 20,

Re: Garbage-free Log4j docs preview

2016-05-23 Thread Mikael Ståldal
t;>>>>>>> logging just often enough that these costs materially impact >>>>>>>> throughput, >>>>>>>> but not often enough that they suddenly disappear. >>>>>>>> >>>>>>>> Even though a majority of systems *do not need this*, because it >>

Re: 2.6 Release

2016-05-20 Thread Mikael Ståldal
candidate in process > right now thanks to shitty hotel internet. ;) > > On 20 May 2016 at 11:01, Mikael Ståldal <mikael.stal...@magine.com> wrote: > >> I have a fix for this issue: >> https://issues.apache.org/jira/browse/LOG4J2-1390 >> >> Do we want to in

Re: 2.6 Release

2016-05-20 Thread Mikael Ståldal
I have a fix for this issue: https://issues.apache.org/jira/browse/LOG4J2-1390 Do we want to include it in the release? On Fri, May 20, 2016 at 10:26 AM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > I have updated the layout manual page a bit. Please have a look at it. > >

Re: 2.6 Release

2016-05-20 Thread Mikael Ståldal
I have updated the layout manual page a bit. Please have a look at it. On Fri, May 20, 2016 at 10:15 AM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > What about the format for thread context map in JsonLayout and YamlLayout? > > https://issues.apache.org/jira/browse/LOG4J2

Re: 2.6 Release

2016-05-20 Thread Mikael Ståldal
>>> > wrote: >>> >>>> The performance page has been completed. Is there anything left to do >>>> before the 2.6 release build? If not I can start it tonight - I hope. The >>>> wireless speed at my hotel is terrible so I have to use the hotspot on my

Garbage-free string encoding performance with UTF-16 charset

2016-05-18 Thread Mikael Ståldal
: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Information may be contained in this message. If you are not the addressee indicated in this message

Re: Site preview

2016-05-16 Thread Mikael Ståldal
a draft of the new pages is > available here > http://home.apache.org/~rpopma/log4j/2.6/performance.html > and here > http://home.apache.org/~rpopma/log4j/2.6/manual/garbagefree.html > > Feedback welcome! > > Remko > -- [image: MagineTV] *Mikael Ståldal* Senior softwa

Re: Site preview

2016-05-16 Thread Mikael Ståldal
ll working on the performance page, but a draft of the new pages is >> available here >> http://home.apache.org/~rpopma/log4j/2.6/performance.html >> and here >> http://home.apache.org/~rpopma/log4j/2.6/manual/garbagefree.html >> >> Feedback welcom

Re: Location performance

2016-05-12 Thread Mikael Ståldal
Ah, OK, that makes sense. On Thu, May 12, 2016 at 2:50 PM, Ralph Goers <ralph.go...@dslextreme.com> wrote: > Yes. Right now we have a chance to get a fix if one is required. > > Ralph > > On May 12, 2016, at 12:58 AM, Mikael Ståldal <mikael.stal...@magine.com> >

Re: Location performance

2016-05-12 Thread Mikael Ståldal
;> Mode Samples Score Error Units >>> o.a.l.l.p.j.AsyncAppenderLog4j2LocationBenchmark.throughputSimple >>> thrpt 20 124819.285 ± 3003.918 ops/s >>> >>> java version "1.8.0_65" >>> >>> Benchmark >>> Mode Samples Score

Re: Register Log4j 2 in Graylog marketplace

2016-05-10 Thread Mikael Ståldal
Did we get anywhere on this? On Thu, Apr 28, 2016 at 9:47 AM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > Like this: ![Log4j 2.x]( > http://logging.apache.org/log4j/2.x/images/logo.jpg) > > See: https://guides.github.com/features/mastering-markdown/#syntax > > I t

Re: [jira] [Commented] (LOG4J2-1382) Performance regression in RewriteAppender

2016-05-09 Thread Mikael Ståldal
nce of Log4jLogEvent, but now we are passing > in MutableLogEvent. > > The fix is to update Log4jLogEvent.Builder to also avoid calling > getSource when copying from a MutableLogEvent. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > >

Re: Interesting little read

2016-05-06 Thread Mikael Ståldal
Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> >> >> > > >

Re: The LOG4J2-1347 branch

2016-05-04 Thread Mikael Ståldal
would need to do more analysis to see if using new > Log4jLogEvent.Builder(this) would give the exact same result but I > suspect there are differences. > > > On Thu, May 5, 2016 at 1:09 AM, Mikael Ståldal <mikael.stal...@magine.com> > wrote: > >> I just

Re: The LOG4J2-1347 branch

2016-05-04 Thread Mikael Ståldal
n LOG4J2-1347 is a separate thing and > will require more work.) > > Remko > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Informa

Re: Register Log4j 2 in Graylog marketplace

2016-04-28 Thread Mikael Ståldal
April 2016 at 11:25, Mikael Ståldal <mikael.stal...@magine.com> > wrote: > >> I think the README is good enough now. >> >> Should we register it? https://marketplace.graylog.org/ >> >> On Wed, Apr 27, 2016 at 12:25 PM, Mikael Ståldal < >

Re: Register Log4j 2 in Graylog marketplace

2016-04-27 Thread Mikael Ståldal
I think the README is good enough now. Should we register it? https://marketplace.graylog.org/ On Wed, Apr 27, 2016 at 12:25 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > Just selected parts of src/site/** > > The current README.md is basically just copy

Re: Register Log4j 2 in Graylog marketplace

2016-04-27 Thread Mikael Ståldal
Goers <ralph.go...@dslextreme.com> wrote: > >> src/site/** ? What exactly are you wanting to generate a readme from? >> Certainly not everything under src/site. >> >> Ralph >> >> >> On Apr 26, 2016, at 2:27 AM, Mikael Ståldal <mikael.stal...@magine

Re: [jira] [Closed] (LOG4J2-1357) GelfLayout should have option to not log stacktraces for logged Throwables

2016-04-26 Thread Mikael Ståldal
ig? > > Gary > -- Forwarded message -- > From: "Mikael Ståldal (JIRA)" <j...@apache.org> > Date: Apr 26, 2016 5:43 AM > Subject: [jira] [Closed] (LOG4J2-1357) GelfLayout should have option to > not log stacktraces for logged Throwables > To: <l

Re: Register Log4j 2 in Graylog marketplace

2016-04-26 Thread Mikael Ståldal
; On 25 April 2016 at 11:12, Mikael Ståldal <mikael.stal...@magine.com> > wrote: > >> I just added a README.md file as a starting point. We might want to add >> information about how to fetch it. >> >> On Mon, Apr 25, 2016 at 5:57 PM, Mikael Ståldal < >

Re: Register Log4j 2 in Graylog marketplace

2016-04-25 Thread Mikael Ståldal
I just added a README.md file as a starting point. We might want to add information about how to fetch it. On Mon, Apr 25, 2016 at 5:57 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > We need a public GitHub repository with: > - a README.md file in Markdown format (as usu

Re: Register Log4j 2 in Graylog marketplace

2016-04-25 Thread Mikael Ståldal
be about log4j2 in > general? I don't have time to investigate... > > Sent from my iPhone > > On 2016/04/24, at 4:57, Matt Sicker <boa...@gmail.com> wrote: > > That's not even the right GitHub repository. Here: > https://github.com/apache/logging-log4j2 > > On

Re: Register Log4j 2 in Graylog marketplace

2016-04-18 Thread Mikael Ståldal
t; > > On Mon, Apr 18, 2016 at 11:49 PM, Mikael Ståldal < > mikael.stal...@magine.com> wrote: > >> Perhaps someone from PMC should register Log4j 2 here: >> http://docs.graylog.org/en/latest/pages/marketplace.html >> >> now when we have a GelfLayout.

[no subject]

2016-04-18 Thread Mikael Ståldal
on GitHub. -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Information may be contained in this message. If you are not the addressee indicated

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

2016-04-18 Thread Mikael Ståldal
. > > See the first paragraph of the Configuration section in the manual page. > > Please let me know if this is not clear. (The fact that you asked means > this probably needs improvement...) > > Sent from my iPhone > > On 2016/04/18, at 20:18, Mikael Ståldal <mikael

Re: Layout extends Encoder

2016-04-13 Thread Mikael Ståldal
istence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.co

Duplicate String to bytes code

2016-03-23 Thread Mikael Ståldal
We have to very similar methods StringEncoder.toBytes() and AbstractStringLayout.getBytes(). Would it make sense to let AbstractStringLayout.getBytes() use StringEncoder.toBytes()? -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev

Re: Allocation free stacktrace formatting?

2016-03-23 Thread Mikael Ståldal
Then we should probably document that this is not supported in allocation free configuration. On Wed, Mar 23, 2016 at 5:56 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > OK. > > On Wed, Mar 23, 2016 at 5:52 PM, Remko Popma <remko.po...@gmail.com> > wrote: > &

Re: Allocation free stacktrace formatting?

2016-03-23 Thread Mikael Ståldal
d in from >> native code, so it already seems like a bad idea for high-throughput >> production logging unless you need it. >> >> On 23 March 2016 at 11:38, Mikael Ståldal <mikael.stal...@magine.com> >> wrote: >> >>> Do we have any strategy for all

Allocation free stacktrace formatting?

2016-03-23 Thread Mikael Ståldal
Do we have any strategy for allocation free stacktrace formatting (PatternLayout %throwable), or is that just non-supported for allocation-free configuration? -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46

Re: Allocation free timestamp formatting for GELF

2016-03-23 Thread Mikael Ståldal
return builder; } } On Wed, Mar 23, 2016 at 5:34 PM, Remko Popma <remko.po...@gmail.com> wrote: > In that case you may need to surround that logic with a check that the > long value exceeds 999. Could this ever happen though? > > On Thu, Mar 24, 2016 at 1:18 AM, Mikael Stå

Re: Allocation free timestamp formatting for GELF

2016-03-23 Thread Mikael Ståldal
ngBuilder, then insert a period at > StringBuilder.length() - 3? > > On Thu, Mar 24, 2016 at 12:13 AM, Mikael Ståldal < > mikael.stal...@magine.com> wrote: > >> I am trying to make GelfLayout allocation free, and got stuck at >> timestamp formatting. GELF need the timestam

Allocation free timestamp formatting for GELF

2016-03-23 Thread Mikael Ståldal
free: static CharSequence formatTimestamp(final long timeMillis) { return new BigDecimal(timeMillis).divide(TIME_DIVISOR).toPlainString(); } (see also unit test in GelfLayoutTest.java) Any ideas on how do fix this? -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV

Re: Message.getFormattedMessage() return type widening

2016-03-23 Thread Mikael Ståldal
d of a String? >> >> I believe this change would be backwards compatible (all Message >> implementations that return a String will work as is), and it opens the way >> for Message implementations to return a cached StringBuilder as Mikael >> suggested. >> &g

Re: Potential problem in PatternLayout

2016-03-22 Thread Mikael Ståldal
che.logging.log4j.spi.AbstractLogger.throwing(AbstractLogger.java:1244) > at com.rs.jdbc.dv.DvLogger.throwingIOException(DvLogger.java:245) > > With a recent 2.6 SNAPSHOT. > > Gary > > On Tue, Mar 22, 2016 at 4:58 AM, Mikael Ståldal <mikael.stal...@magine.com > > wrote:

Re: RingBufferLogEvent#StringBuilderWrapperMessage is incomplete

2016-03-22 Thread Mikael Ståldal
Should we to the trimming in getFormattedMessage() as well as in toFormat()? On Tue, Mar 22, 2016 at 4:38 PM, Remko Popma <remko.po...@gmail.com> wrote: > Thanks! Done. > > Sent from my iPhone > > On 2016/03/23, at 0:10, Mikael Ståldal <mikael.stal...@magine

RingBufferLogEvent#StringBuilderWrapperMessage is incomplete

2016-03-22 Thread Mikael Ståldal
I think that RingBufferLogEvent#StringBuilderWrapperMessage need to have a proper implementation of getFormattedMessage(), otherwise layouts and appenders which does not use formatTo() will not work. -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal

Re: Potential problem in PatternLayout

2016-03-22 Thread Mikael Ståldal
I fixed it while moving the field and method to AbstractStringLayout (to be able to use from GelfLayout as well). On Tue, Mar 22, 2016 at 12:55 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > I am working on a fix. > > On Tue, Mar 22, 2016 at 11:52 AM, Remko Popma <rem

Re: Potential problem in PatternLayout

2016-03-22 Thread Mikael Ståldal
I am working on a fix. On Tue, Mar 22, 2016 at 11:52 AM, Remko Popma <remko.po...@gmail.com> wrote: > I think you're right. This should be an instance field, not a static > field. Good catch! > > > On Tuesday, 22 March 2016, Mikael Ståldal <mikael.sta

Potential problem in PatternLayout

2016-03-22 Thread Mikael Ståldal
harset()); textEncoderHelper.set(result); } return result; } Does this really work properly? What if we have several instance of PatternLayout with different charsets? -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Tureg

Re: Fastest no logging config

2016-03-15 Thread Mikael Ståldal
t; Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magin

Re: Fastest no logging config

2016-03-15 Thread Mikael Ståldal
Perhaps we need to optimize the isEnabled methods? On Tue, Mar 15, 2016 at 4:07 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > On Tue, Mar 15, 2016 at 3:15 AM, Mikael Ståldal <mikael.stal...@magine.com > > wrote: > >> Is this for testing purposes only? >> &

Re: Fastest no logging config

2016-03-15 Thread Mikael Ståldal
Is this for testing purposes only? On Tue, Mar 15, 2016 at 10:36 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > On Tue, Mar 15, 2016 at 1:56 AM, Mikael Ståldal <mikael.stal...@magine.com > > wrote: > >> How would you use such a thing? >> > > (1) R

Re: Fastest no logging config

2016-03-15 Thread Mikael Ståldal
Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygreg

Re: GC lean way to convert StringBuilder to byte[]

2016-03-14 Thread Mikael Ståldal
It is only used by GelfLayout now, but my intention is that other layouts should use it as well. On Mon, Mar 14, 2016 at 11:03 AM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > I am mostly unsure about the new method I added to AbstractStringLayout. I > am quite sure t

Re: GC lean way to convert StringBuilder to byte[]

2016-03-14 Thread Mikael Ståldal
don't have the bandwidth to > look at it yet. > > > On Sat, Mar 12, 2016 at 1:33 AM, Mikael Ståldal <mikael.stal...@magine.com > > wrote: > >> Is it OK to merge to master? >> >> Remko, can you help me to verify that it is properly allocation-free >&g

Re: GC lean way to convert StringBuilder to byte[]

2016-03-11 Thread Mikael Ståldal
Is it OK to merge to master? Remko, can you help me to verify that it is properly allocation-free (when using )? On Tue, Mar 8, 2016 at 5:36 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > I did it a bit differently, but now there are unit tests for > GelfLayout.encode()

Re: [10/10] logging-log4j2 git commit: Unit test for GelfLayout.encode

2016-03-09 Thread Mikael Ståldal
4j2/diff/58152b79 >> >> Branch: refs/heads/gelf-layout-gc-free >> Commit: 58152b79b0c883ba6df57b06bbb4e2c96353232e >> Parents: 7467e5d >> Author: Mikael Ståldal <mikael.stal...@magine.com> >> Authored: Tue Mar 8 17:34:

Re: GC lean way to convert StringBuilder to byte[]

2016-03-08 Thread Mikael Ståldal
I did it a bit differently, but now there are unit tests for GelfLayout.encode(). On Tue, Mar 8, 2016 at 3:51 PM, Remko Popma <remko.po...@gmail.com> wrote: > I added some tests to PatternLayoutTest, please take a look. > > On Tue, Mar 8, 2016 at 11:56 PM, Mikael Ståld

Re: GC lean way to convert StringBuilder to byte[]

2016-03-08 Thread Mikael Ståldal
TextEncoderHelper class. No objects are >>> created during this conversion. >>> >>> The final piece is (Rolling)RandomAccessFileAppender, whose manager >>> implements ByteBufferDestination. This appender calls the #encode() methos >>> on the layout

Error messages when running unit tests

2016-03-08 Thread Mikael Ståldal
] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Privileged and/or Confidential Information may be contained in this message. If you are not the addressee indicated in this message (or responsible

Re: Fast and Furious

2016-03-03 Thread Mikael Ståldal
t;>>>>>> so if you've got a decent way to ask about it, I could see if he >>>>>>>>>>>> can help >>>>>>>>>>>> figure out this regression. I can at least show off the >>>>>>>>>>>> SimplePerfTest and

Re: Can't build log4j from IntelliJ, any ideas?

2016-03-02 Thread Mikael Ståldal
rg/apache/logging/log4j/core/config/plugins/processor/PluginCache > > Everything works fine in Maven. I enabled annotation processing, yet I get > this error every time in log4j-core. > > -- > Matt Sicker <boa...@gmail.com> > -- [image: MagineTV] *Mikael Ståldal* Senior soft

Re: Education

2016-02-29 Thread Mikael Ståldal
.setLevel() API. > > For good or bad, some folks DO want an abstracted logging API, and this is > required to get a large stack of 3rd party components working together WRT > logging. > > Gary > > On Mon, Feb 29, 2016 at 8:36 AM, Mikael Ståldal <mikael.stal...@magine.com

Re: Education

2016-02-29 Thread Mikael Ståldal
6, at 8:27 AM, Matt Sicker <boa...@gmail.com> wrote: > > Because some people think that log4j-api isn't analogous to slf4j-api > where log4j-core is like logback. It's a naming confusion I'd guess. > > On 29 February 2016 at 03:38, Mikael Ståldal <mikael.stal...@magine.co

Re: Education

2016-02-29 Thread Mikael Ståldal
t; Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> >> >> > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Acti

Re: GC lean way to convert StringBuilder to byte[]

2016-02-24 Thread Mikael Ståldal
unnecessary copying of data. On Wed, Feb 24, 2016 at 12:06 PM, Remko Popma <remko.po...@gmail.com> wrote: > I don't understand though: appenders should only call encode() if they > can offer the Layout a ByteBuffer to write into... > > Sent from my iPhone > > On 2016/02/24,

Re: GC lean way to convert StringBuilder to byte[]

2016-02-24 Thread Mikael Ståldal
deText: from CharBuffer to ByteBufferDestination >> >> We don't want to create the byte[] array object so we write directly into >> the ByteBuffer. >> >> On Wednesday, 24 February 2016, Mikael Ståldal <mikael.stal...@magine.com> >> wrote: >> >>

Re: GC lean way to convert StringBuilder to byte[]

2016-02-23 Thread Mikael Ståldal
rg/jira/browse/LOG4J2-1270. > > Sent from my iPhone > > On 2016/02/23, at 23:56, Mikael Ståldal <mikael.stal...@magine.com> wrote: > > Do we have any way to convert a StringBuilder to a byte[], without any > intermediate String? > > It seems like org.

Re: New traceEntry code

2016-02-11 Thread Mikael Ståldal
;>>>>>>>>> > This allows the Entry/Exit log events to match nicely, >>>>>>>>>>>> especially in our >>>>>>>>>>>> > multi-threaded use cases. It's easier to tell which exit >>>>

Re: logging-log4j2 git commit: LOG4J2-124 - Add shutdown methods to LogManager

2016-01-27 Thread Mikael Ståldal
ers and appenders will wait until their queue has >> been cleared by the background thread, it is a blocking call. >> >> We should probably add a sentence to the java doc to clarify this. >> >> Sent from my iPhone >> >> On 2016/01/26, at 18:15, Mikael Ståldal

Re: logging-log4j2 git commit: LOG4J2-124 - Add shutdown methods to LogManager

2016-01-27 Thread Mikael Ståldal
OK, also done. On Wed, Jan 27, 2016 at 2:07 PM, Remko Popma <remko.po...@gmail.com> wrote: > Perhaps you also want to add this to the LogManager.shutdown() methods, > since I imagine that's what people will actually use/look at. > > Sent from my iPhone > > On 2016/01/27,

Re: logging-log4j2 git commit: LOG4J2-124 - Add shutdown methods to LogManager

2016-01-26 Thread Mikael Ståldal
gt;> +public interface ShutdownCapable { >>>>>>> + >>>>>>> +/** >>>>>>> + * Requests that the logging implementation shut down. >>>>>>> + */ >>>>>>> +void shutdown(); >>>>>&

Re: LMAX vs Lampart

2016-01-26 Thread Mikael Ståldal
/JCTools/blob/master/jctools-core/src/main/java/org/jctools/queues/MpscArrayQueue.java > > Best regards, > > Guido. > -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magine.com Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com Pr

Re: LMAX vs Lampart

2016-01-26 Thread Mikael Ståldal
APIs that rely on > Slf4j I have the jar bridge to Log4j2. > I'm using a RollingRandomAccessFile with all asynchronous appenders > including root. > > On Tue, Jan 26, 2016 at 9:08 AM, Mikael Ståldal <mikael.stal...@magine.com > > wrote: > >> Are you using Lo

Re: LMAX vs Lampart

2016-01-26 Thread Mikael Ståldal
I guess that if you would do all logging through Akka's actor logging, they async logging of Log4j would be unnecessary since Akka gives you the asynchronicity. But you probably like the Log4j 2 native API better than Akka's logging API. On Tue, Jan 26, 2016 at 1:44 PM, Mikael Ståldal

Re: LMAX vs Lampart

2016-01-26 Thread Mikael Ståldal
It would be nice if you could leverage the asynchronicity of Akka while still using the Log4j 2 API. On Tue, Jan 26, 2016 at 1:50 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > I guess that if you would do all logging through Akka's actor logging, > they async logging of

Re: syslog-ng disconnect causes thread to silently die?

2016-01-20 Thread Mikael Ståldal
gt; > > >>>>>>>> > > >>>>>>>> 2016-01-19T14:26:34-05:00 ERR syslog-ng[87462]: - Incoming frame > > >> larger than log_msg_size(); log_msg_size='8192', frame_length='100233' > > >>>>>>>> > > >>&g

Re: Log4j for Scala

2016-01-13 Thread Mikael Ståldal
y to > take a look at it this evening and make suggestions. > > Ralph > > On Jan 12, 2016, at 9:49 AM, Mikael Ståldal <mikael.stal...@magine.com> > wrote: > > In branch LOG4J-1181 > > On Tue, Jan 12, 2016 at 5:43 PM, Ralph Goers <ralph.go...@dslextreme.com>

Re: Log4j for Scala

2016-01-13 Thread Mikael Ståldal
We need two Maven artifacts, with artifactId:s log4j-api-scala_2.10 and log4j-api-scala_2.11. They could use the same source, but needs to be compiled separately and have different dependencies on scala-library and scala-reflect. The Scala build tool SBT can do this from the same source, but I

Re: JeroMqAppender and layouts

2016-01-12 Thread Mikael Ståldal
Done: https://issues.apache.org/jira/browse/LOG4J2-1252 On Tue, Jan 5, 2016 at 12:47 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > I think you are right! Darn. Can you create a Jira? > > Gary > > On Mon, Nov 9, 2015 at 1:22 AM, Mikael Ståldal <mikael.sta

Re: List vs. Set

2016-01-12 Thread Mikael Ståldal
, we should keep it as List. On Tue, Jan 12, 2016 at 12:59 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > If you want it more generic, it should be Iterable rather than Iterator. > > On Tue, Jan 12, 2016 at 6:34 AM, sampath kumar <sampath...@gmail.com> > wrote: &g

Re: List vs. Set

2016-01-12 Thread Mikael Ståldal
gt; Tweet! http://twitter.com/GaryGregory >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> E-Mail:

Re: JSONLayout serializes the MDC as a List<Map<String,String>>?

2016-01-12 Thread Mikael Ståldal
e":"com.xxx.xxx.handler.event.FailoverHandler"},{"key":"ROUTINGKEY","value":"elasticsearch-rollover"}]} >>>> >>>> I'm curious why the contextMap is represented as the more complex List >>>> of si

Re: Questions on submitting changes to the Log4j2 code base

2016-01-12 Thread Mikael Ståldal
you, > > -- > Bryan Krol > Software Engineer > Technergetics, LLC > bryan.k...@technergetics.com > Phone: (315) 271-2096 > Fax: (886) 307-4382 > > > ----- > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org > For additional commands, e-mail: log4j-dev-h...@logging.apac

Re: Log4j for Scala

2016-01-12 Thread Mikael Ståldal
alph > > On Jan 12, 2016, at 9:49 AM, Mikael Ståldal <mikael.stal...@magine.com> > wrote: > > In branch LOG4J-1181 > > On Tue, Jan 12, 2016 at 5:43 PM, Ralph Goers <ralph.go...@dslextreme.com> > wrote: > >> First off, where is the code right now? &

Re: JSONLayout serializes the MDC as a List<Map<String,String>>?

2016-01-12 Thread Mikael Ståldal
walking the list wrapper. > > On Tue, Jan 12, 2016 at 6:05 AM, Mikael Ståldal <mikael.stal...@magine.com > > wrote: > >> I think that the current JSONLayout format is unfortunate, and I would >> prefer to have it as you propose. But we cannot change it now

Re: Log4j for Scala

2016-01-12 Thread Mikael Ståldal
So where are we on this? On Mon, Dec 14, 2015 at 6:21 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > Sounds good then. > > On Mon, Dec 14, 2015 at 6:13 PM, Ralph Goers <ralph.go...@dslextreme.com> > wrote: > >> Sure. >> >> Ralph >

Re: JSONLayout serializes the MDC as a List<Map<String,String>>?

2016-01-12 Thread Mikael Ståldal
ld be generated when the flag is not set. > > Ralph > > On Jan 12, 2016, at 9:14 AM, Mikael Ståldal <mikael.stal...@magine.com> > wrote: > > But I guess that you won't get any performance gain if we keep the old > structure besides the new one, since then both will b

<    1   2   3   4   5   6   7   >