Re: Any plans to release log4j TCP server?

2021-07-04 Thread Ralph Goers
>> Cheers >> -- >> Sent from my phone. Typos are a kind gift to anyone who happens to find >> them. >> >> On Tue, Jun 29, 2021, 20:46 Gary Gregory wrote: >> >>> FWIW, we use the server at work to listen to JSON log events. There is >>&

Re: Custom Appenders not getting initialized for Log4j-2.14.1

2021-07-03 Thread Ralph Goers
Does the jar containing the BWLogFileAppender contain a Log4j2Plugins.data file under the META-INF directory? If not are you compiling your code with annotation processing enabled? Ralph > On Jul 1, 2021, at 11:29 PM, Nilay Prafulla Dhamecha > wrote: > > I am migrating the log4j library fr

Re: Log4Go

2021-07-01 Thread Ralph Goers
that explains a bit more, what I'm proposing. > > Chris > > > > > On 30.06.21 23:45, Ralph Goers wrote: >> Well, I am on board with part of what you want. >> >> When I looked at various Go logging libraries most of them defined where the >> lo

Re: Log4Go

2021-07-01 Thread Ralph Goers
outside world. For one, I am pretty sure there should be Go experts >>> within the Apache community, hence having expert reviews should be >>> relatively easy. Second, Apache has such a good track record in delivering >>> high quality software, even an inferior project mig

Re: Log4Go

2021-06-30 Thread Ralph Goers
ne, I am pretty sure there should be Go experts >> within the Apache community, hence having expert reviews should be >> relatively easy. Second, Apache has such a good track record in delivering >> high quality software, even an inferior project might get quite some >> attr

Re: Any plans to release log4j TCP server?

2021-06-29 Thread Ralph Goers
Right now the server is more or less a sample we expect you will want to copy and modify, so releasing it doesn’t have a lot of value. On the “Online Drinks” call this weekend I mentioned that I had been asked about being able to send logs from mobile devices to a backend collector securely (h

Re: Thoughts on Java 11 style guide updates?

2021-06-27 Thread Ralph Goers
I would suggest: a) Looking to see what, if anything, the latest version of Effective Java says. b) Looking for style guides from others that cover these newer versions of Java to see what they say. IOW, I don’t think we should adopt our own rules if they are not common practice. Ralph > On Ju

Log4j master branch

2021-06-22 Thread Ralph Goers
I have asked on the Maven dev list about the process of building modules that contain test jars. It seems the recommended approach for test jars in general has changed and it is now recommended to build them in their own project. This means log4j-core would only contain the main source and tha

Re: Bazel for builds

2021-06-19 Thread Ralph Goers
template-json > log4j-plugins > > layout testJars are needed by perf. jdbc testJar is needed by jdbc-dbcp2. > We can work these both out and avoid them. There remains only 3 modules > that we need to create a -test module for: api, core, and plugins. > > > > On Sat,

Re: Bazel for builds

2021-06-19 Thread Ralph Goers
k this approach could potentially work, but we’d end up with > a few more published jars. > > On Sat, Jun 19, 2021 at 11:28 Ralph Goers > wrote: > >> >> >>> On Jun 19, 2021, at 3:45 AM, Volkan Yazıcı >> wrote: >>> >>> That README is

Re: Bazel for builds

2021-06-19 Thread Ralph Goers
> On Jun 19, 2021, at 3:45 AM, Volkan Yazıcı wrote: > > That README is such a gem Ralph! Thanks for documenting all that suffering. > (README says Log4j 2 supports JPMS, shouldn't it rather be Log4j 3?) No, I consider it Log4j 2 version 3.0. IOW, the 2 is just part of the name. I can see wh

Re: Bazel for builds

2021-06-18 Thread Ralph Goers
> On Jun 18, 2021, at 2:19 PM, Jochen Wiedmann > wrote: > > On Fri, Jun 18, 2021 at 6:20 PM Ralph Goers > wrote: > >> 2. The configuration does “strange things” because Maven doesn’t support >> creating a >> JPMS module, JPMS test module, and

Re: [Chainsaw] JSON Support

2021-06-18 Thread Ralph Goers
> On Jun 18, 2021, at 10:40 AM, Matt Sicker wrote: > > A couple other common log collection setups I've come across over time: > > * Logging to stdout/stderr in a standard format, then use a log > collection API from your orchestration engine (common in the > Kubernetes world to avoid logging

Re: Bazel for builds

2021-06-18 Thread Ralph Goers
> On Jun 18, 2021, at 8:05 AM, Jochen Wiedmann > wrote: > > On Wed, Jun 16, 2021 at 1:31 PM Volkan Yazıcı wrote: > >> In essence, the build is taking more than it should. Maven "verify" is >> taking more than half an hour and "site" is taking ages. This in addition >> to impeding the develo

Re: [Chainsaw] JSON Support

2021-06-17 Thread Ralph Goers
You should look at one of the formats that JsonTemplateLayout supports out of the box. Ralph > On Jun 17, 2021, at 6:09 PM, Robert Middleton wrote: > > I'm looking into adding some more modern JSON support into Chainsaw > for processing log statements from applications, but I'm not sure what >

Re: Bazel for builds

2021-06-16 Thread Ralph Goers
> On Jun 16, 2021, at 8:29 AM, Matt Sicker wrote: > > I should note some possible benefits we could get from Bazel in theory: > > * Ability to offload builds/tests/etc. to remote build clusters. If > you've ever used things like distcc for compiling things across > multiple machines (handy fo

Re: Bazel for builds

2021-06-16 Thread Ralph Goers
Actually, Maven has done a decent job of supporting modules for “standard” projects. Our issue is that we are creating a test jars in log4j-api, log4j-core, and log4j-plugins. These also need to comply with JPMS which means they can’t use the same package space as the module they are part of.

Re: Breaking up modules into separate sub-projects

2021-06-13 Thread Ralph Goers
with your remarks about the website. > > Ralph, what do you mean by *"I like having both [Jenkins and GitHub > Actions] simply because we can get more coverage"*? In theory, their > coverages are identical. In my experience, having two separate CI pipelines > adds nothing b

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Ralph Goers
t above breakdown contains every available module in master, >>> except log4j-samples, which has the following sub-modules: >>> >>> log4j-samples-loggerProperties (contains 2 very trivial example classes, >>> log4j-core [tests] contains more comprehensive a

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Ralph Goers
ogging-log4j-osgi* >>>> log4j-osgi >>>> >>>> *logging-log4j-spring* >>>> log4j-spring-boot >>>> log4j-spring-cloud-config >>>> >>>> Note that above breakdown contains every available module in master, >>>

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Ralph Goers
single log4j train or multiple trains like how > Spring has multiple projects (probably too much overhead for us?). > > On Fri, 11 Jun 2021 at 10:44, Ralph Goers wrote: >> >> I agree with you there. Gary is correct that it would be difficult for users >> to >>

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Ralph Goers
;> >>>> *logging-log4j-spring* >>>> log4j-spring-boot >>>> log4j-spring-cloud-config >>>> >>>> Note that above breakdown contains every available module in master, >>> except >>>> log4j-samples, which has the follo

Re: Breaking up modules into separate sub-projects

2021-06-10 Thread Ralph Goers
elease to 2022. This will probably break the backward compatibility at >> least for the artifact groupId, am I wrong? Not to mention that the entire >> website needs to be adapted to this multi-project setup too. Is there >> anything else? >> >> On Thu, Jun 3, 2021 at 5:

Re: [CI][FAILURE] Logging/chainsaw/master#25 has potential issues

2021-06-09 Thread Ralph Goers
Another option. Perform the release build on your personal Mac. I’ve done that for every Log4j release. Ralph > On Jun 9, 2021, at 7:40 AM, Matt Sicker wrote: > > Another possibility is that PMCs can get a virtual machine allocated to > them. Perhaps we could request a macOS EC2 instance for o

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-06-06 Thread Ralph Goers
olkan Yazıcı >> wrote: >> >>> I have also tried that too, but no luck so far. @Matt, are you able to run >>> any tests from IDEA using the most recent "master"? >>> >>> On Wed, Apr 7, 2021 at 5:57 PM Matt Sicker wrote: >>> >&g

[DISCUSS] [VOTE] Release Apache Chainsaw 2.1.0

2021-06-05 Thread Ralph Goers
ve on the tag and > signing/hashing the file. Then commit those to the release candidate repo. > > On Wed, Jun 2, 2021 at 23:22 Ralph Goers wrote: > >> Unfortunately, without a source zip or gz there is no release to approve. >> >> Ralph >> >>>

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-06-05 Thread Ralph Goers
Lazy initialization of required beans > * Determine if and how bean managers should communicate (i.e., one > bean manager per LoggerContext, or one per LoggerContextFactory?) > * Refactor plugins to use new API > > On Sat, 29 May 2021 at 20:58, Ralph Goers wrote: >> >>

Re: [apache/logging-log4j2] Liquibase 4.x Compatibility (#503)

2021-06-03 Thread Ralph Goers
Yeah - I have proposed moving all these extra integrations to a separate repo but I’ve never gotten consensus. I’d prefer to have a project like log4j-pubsub where things like JMS, JeroMQ, etc can go live, log4j-nosql for all the nosql modules, etc. The problem seems to be that some people bel

Re: [VOTE] Release Apache Chainsaw 2.1.0

2021-06-02 Thread Ralph Goers
Unfortunately, without a source zip or gz there is no release to approve. Ralph > On Jun 1, 2021, at 6:58 PM, Robert Middleton wrote: > > This vote is to release Apache Chainsaw 2.1.0. This fixes a few > annoying issues with chainsaw and some other bugs, as well as updating > some dependencies

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Ralph Goers
at 5:40 PM, Ralph Goers wrote: > > We do need better docs on this. 3.0 is going to be a mixed bag. It will be > easier > for “normal” applications because plugins now use ServiceLoader instead of > the Log4jPlugins.dat file. However, it is going to be more challenging for >

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Ralph Goers
We do need better docs on this. 3.0 is going to be a mixed bag. It will be easier for “normal” applications because plugins now use ServiceLoader instead of the Log4jPlugins.dat file. However, it is going to be more challenging for those developing plugins if they use the Java Platform Module

Re: [VOTE] Release Apache Commons IO 2.9.0 based on RC1

2021-05-22 Thread Ralph Goers
I don’t think the Commons PMC would be too happy if the Logging PMC started voting on its releases. ;-) Ralph > On May 22, 2021, at 10:09 AM, Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons IO > 2.8.0 was released, so I would like to release Apache

Re: Large commit incoming

2021-05-13 Thread Ralph Goers
analysis. Ralph > On May 13, 2021, at 11:39 AM, Carter Kozak wrote: > > Looking forward to it, thank you for the work, Ralph! > > -ck > >> On May 13, 2021, at 2:14 PM, Ralph Goers wrote: >> >> Just a word of warning that I will be pushing a large commit

Re: Large commit incoming

2021-05-13 Thread Ralph Goers
I should have added that I suspect this may require at least Maven 3.6.1. That is the version I have been using and haven’t tried it with older versions but Maven has been fixing quite a few JPMS issues so older versions might not work. Ralph > On May 13, 2021, at 11:14 AM, Ralph Goers wr

Large commit incoming

2021-05-13 Thread Ralph Goers
Just a word of warning that I will be pushing a large commit to master. This one makes log4j-core a JPMS compliant module. Ralph

Re: [VOTE] Release log4cxx 0.12.0-RC2

2021-05-08 Thread Ralph Goers
+1 Ralph > On May 8, 2021, at 8:28 PM, Remko Popma wrote: > > +1 > > On Sun, May 9, 2021 at 12:21 PM Stephen Webb wrote: > >> +1 >> >> On Sun, May 9, 2021 at 1:13 PM Robert Middleton >> wrote: >> >>> As a reminder, this vote is still outstanding. >>> >>> -Robert Middleton >>> >>> On Tue

Re: [VOTE] Announce EOL for Java 6 and Java 7

2021-05-06 Thread Ralph Goers
Yes. I thought I posted results. Ralph > On May 6, 2021, at 7:59 AM, Matt Sicker wrote: > > Is this vote finished, Ralph? > > On Mon, Mar 15, 2021 at 15:53 Remko Popma wrote: > >> We should at least retain the information of which older version of Log4j >> maps to which older version of Java

Re: Log levels on a schedule

2021-05-03 Thread Ralph Goers
I don’t understand. The TimeFilter filters totally based on time. We would need to create a new TimeThresholdFilter. Ralph > On May 3, 2021, at 10:45 AM, Gary Gregory wrote: > > You're talking about a custom class? What about adding a defaultThreshold > to TimeFilter? Would that be reasonable?

Re: Log levels on a schedule

2021-05-03 Thread Ralph Goers
Almost, but not quite. It looks like the TimeFilter will completely disable logging during the interval. Ralph > On May 3, 2021, at 7:50 AM, Matt Sicker wrote: > > Might be able to use a time filter? > http://logging.apache.org/log4j/2.x/manual/filters.html#TimeFilter > > On Mon, May 3, 2021

Re: Javac/Maven issues issues

2021-05-01 Thread Ralph Goers
ore interest from my day job about Java 11 since for us > Java everyone must include IBM hardware. > > Gary > > > On Wed, Apr 28, 2021, 03:14 Ralph Goers wrote: > >> I just thought I would update you that I have created >> https://github.com/rgoers/jpms-comp

Re: [DISCUSS][VOTE] Release log4cxx 0.12.0-RC2

2021-05-01 Thread Ralph Goers
Why? I have never referenced gitbox in any of the Log4j releases. As far as I am concerned https://github.com/apache is an ASF repo. Ralph > On May 1, 2021, at 2:11 PM, Gary Gregory wrote: > > FYI the repo of record should be an Apache repo, not a GitHub repo. > > Gary > > > On Sat, May 1

Re: Quarterly project status updates - please check in

2021-05-01 Thread Ralph Goers
It does NOT require the boards attention. Ralph > On May 1, 2021, at 10:22 AM, Gary Gregory wrote: > > JPMS: Worth mentioning FTR as a growing pain but requiring board attention. > > Gary > > On Sat, May 1, 2021, 13:11 Ralph Goers wrote: > >> Not sure it is

Re: Quarterly project status updates - please check in

2021-05-01 Thread Ralph Goers
Not sure it is worth mentioning in the board report but I have been working on getting Log4j master to fully support JPMS without a lot of success. Ralph > On May 1, 2021, at 8:39 AM, Matt Sicker wrote: > > Hey all, it’s that time of year again! Please share a list of > accomplishments, kudos

Re: Chainsaw build

2021-04-29 Thread Ralph Goers
Yes, I agree it has been a long time. But I am not aware of anyone else who has performed a release. Who did it last time? Where does the DMG reside for download? In the ASF downloads folder? The current downloads folder doesn’t have them. Looking at the old release site in GitHub it looks like

Re: Fix windows build on master (via Tim Perry)

2021-04-28 Thread Ralph Goers
That would be up to you. If you have been working on the same branch there shouldn’t be a problem. But if it is going to cause merge conflicts then I wouldn’t bother as you can just link to the prior PR for the history. Ralph > On Apr 28, 2021, at 7:55 AM, Tim Perry wrote: > > > > It assume

Re: Fix windows build on master (via Tim Perry)

2021-04-28 Thread Ralph Goers
Tim, Go ahead and create a PR and note that it still has unit test failures that need to be looked into. I can’t guarantee one of us will get to it before you but at least that way we might be able to. Ralph > On Apr 28, 2021, at 7:55 AM, Tim Perry wrote: > > Volkan, > > I should probably w

Re: Javac/Maven issues issues

2021-04-28 Thread Ralph Goers
e file paths but I haven’t figured out where the compiler is creating the symbols despite my trying under the debugger. I still believe I can get around this but the maven gymnastics to do it are going to be ugly. Ralph > On Apr 22, 2021, at 11:18 PM, Ralph Goers wrote: > &

Re: Javac/Maven issues issues

2021-04-22 Thread Ralph Goers
FYI - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8265826 <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8265826> has been created. Ralph > On Apr 17, 2021, at 4:04 PM, Ralph Goers wrote: > > Sorry, I should have added that I am sure I can work ar

Re: Garbage Free Precise Time

2021-04-20 Thread Ralph Goers
nges to > the modules config. > > Is there a JIRA ticket for this issue? > > On Thu, Apr 8, 2021 at 16:10 Ralph Goers wrote: > >> I spoke too soon. It didn’t really pass on Java 16. The allocation >> instrumenter was unable to instrument anything so it didn’t gene

Re: Javac/Maven issues issues

2021-04-17 Thread Ralph Goers
Sorry, I should have added that I am sure I can work around the issues listed below but it is going to make the build uglier than it should be. Ralph > On Apr 17, 2021, at 3:56 PM, Ralph Goers wrote: > > I have created a module-info.java file and added it to the project. I then

Javac/Maven issues issues

2021-04-17 Thread Ralph Goers
I have created a module-info.java file and added it to the project. I then ran mvn clean install in log4j-core. I expected it to have problems but not these. 1. Activator.java is getting an error saying it can’t find the Log4jPlugins class. However, after the compile fails you can clearly see th

Re: Missing nanosecond precision in FastDateFormat

2021-04-16 Thread Ralph Goers
timestampMillis); > formatResolverContext.timestampFormat.format( >formatResolverContext.calendar, >formatResolverContext.formattedTimestampBuilder); > > > On Fri, Apr 16, 2021 at 6:00 PM Ralph Goers > wrote: > >> Something is defi

Re: Missing nanosecond precision in FastDateFormat

2021-04-16 Thread Ralph Goers
Something is definitely odd here. We use FastDateFormat in the DatePatternConverter that is used to print timestamps in the log. It most definitely displays milliseconds while yours are all 0. I don’t know that I have ever tried it with more than 3 though. Are you calling void formatToBuffer

Re: Log4j core

2021-04-13 Thread Ralph Goers
base. >> >> As for exports, that would likely depend on what’s left in core after >> splitting out the above mentioned things. >> >> On Tue, Apr 13, 2021 at 10:43 Ralph Goers >> wrote: >> >>> I started doing the work to modularize log4j-core

Re: Log4j core

2021-04-13 Thread Ralph Goers
That is what is concerning. A lot of those items have already been moved to their own modules in master. Yet we still have these dependencies. Ralph > On Apr 13, 2021, at 10:53 AM, Jochen Wiedmann > wrote: > > On Tue, Apr 13, 2021 at 5:44 PM Ralph Goers > wrote: >

Re: Log4j core

2021-04-13 Thread Ralph Goers
h that it only supports programmatic configuration and > properties files since every other format requires additional modules > besides base. > > As for exports, that would likely depend on what’s left in core after > splitting out the above mentioned things. > > On Tue, Apr 13,

Log4j core

2021-04-13 Thread Ralph Goers
I started doing the work to modularize log4j-core last night. We have a blocker in that the disruptor has not had a release in 3 years. They committed the change to make it an automatic module over a year ago and since have fully modularized it. They simply haven’t performed a release. As I was

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-08 Thread Ralph Goers
e used by other modules. > > If it would simplify the build setup, why don't we migrate test-jars to > their individual Maven modules? For instance, log4j-core and > log4j-core-test, etc. > > On Tue, Apr 6, 2021 at 5:11 AM Ralph Goers > wrote: > >> >>

Re: Garbage Free Precise Time

2021-04-08 Thread Ralph Goers
I spoke too soon. It didn’t really pass on Java 16. The allocation instrumenter was unable to instrument anything so it didn’t generate the errors the test looks for. I tried with Java 12-14 and those all failed. In Java 15 the JVM crashed. Ralph > On Apr 7, 2021, at 11:36 PM, Ralph Go

Re: Garbage Free Precise Time

2021-04-07 Thread Ralph Goers
I have modified the test to allow -DusePreciseClock=true to be passed in. When I set it to true and run it in JDK 16 the test passes! However, I tried 3 versions of JDK 11 and it failed in all of them. Ralph > On Apr 2, 2021, at 2:54 PM, Ralph Goers wrote: > > I just tried adding

Re: JsonTemplateLayout failures after Java 11 upgrade (Was: Running "master" tests in IntelliJ IDEA after Java 11 upgrade)

2021-04-07 Thread Ralph Goers
Source-JDK and X-Compile-Target-JDK manifestEntries in > pom.xml. I was expecting something like X-Compile-Release-JDK exposing > maven.compiler.release property. Isn't there such a thing? > > On Wed, Apr 7, 2021 at 7:29 AM Ralph Goers > wrote: > >> I have found the problem with th

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-07 Thread Ralph Goers
.idea directory), compile the sources via Maven, and open the folder >> in >>> IDEA, can you run *any* tests? If so, do you have any custom IDEA >>> configurations? Which IDEA version are you using? If you are not using >> the >>> wrapper, which Maven versio

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-06 Thread Ralph Goers
test on GitHub. I’ve never seen the issue on Jenkins. Ralph > On Apr 6, 2021, at 4:49 PM, Ralph Goers wrote: > > There was one test I saw saying it couldn’t find the ListAppender. So I ran > that test with -X and -Dlog4j2.debug=true and got > > DEBUG StatusLogger Returnin

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-06 Thread Ralph Goers
usly lots wrong here. I’ll keep looking into this. Ralph > On Apr 6, 2021, at 4:16 PM, Ralph Goers wrote: > > I deleted the files from my local repo and restarted the build. It is running > along just fine - at least until it hits json template layout. > > Is there a reason you

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-06 Thread Ralph Goers
. Ralph > On Apr 6, 2021, at 4:10 PM, Ralph Goers wrote: > > I’ve never seen that. What is maven-annotations-production:log4j-api? > > Let me try removing the files from my maven local repo as you did. > > Ralph > >> On Apr 6, 2021, at 1:14 PM, Volkan Yazıcı wro

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-06 Thread Ralph Goers
I’ve never seen that. What is maven-annotations-production:log4j-api? Let me try removing the files from my maven local repo as you did. Ralph > On Apr 6, 2021, at 1:14 PM, Volkan Yazıcı wrote: > > As subject hints, I am not able to run tests in IDEA anymore after Java 11 > upgrade. I have de

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-05 Thread Ralph Goers
I took care of the failure on verify. I added a clean to log4j-api so it will clean every time. Ralph > On Apr 5, 2021, at 10:55 PM, Ralph Goers wrote: > > Matt, > > A couple of comments > This doesn’t seem right. Log4j-audit, Kotlin, and Chainsaw all use the mvn > comm

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-05 Thread Ralph Goers
Matt, A couple of comments This doesn’t seem right. Log4j-audit, Kotlin, and Chainsaw all use the mvn command. This will modify them to use Java 11 instead of Java 8. Did we really want to do that? The Jenkins build is still failing. The first phase that compiles works but the second phase that

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3004 Add plugin support to JsonTemplateLayout. (#476)

2021-04-05 Thread Ralph Goers
Registry will > use the Comparable interface to determine the effective one. > > I think it is a nice feature to support multiple TypeConverter's, as my use > case demonstrates. Do you agree? What else would you recommend me to > implement this customization support needed for &g

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-05 Thread Ralph Goers
> On Apr 5, 2021, at 1:31 PM, Volkan Yazıcı wrote: > >> ... this weird structure with two test source directories ... > > doesn't seem okay to me. Please, don't get me wrong. Not that I know of > JPMS or anything, though this sttructure doesn't resemble anything I have > ever seen. I don't wan

Re: Jenkins build

2021-04-04 Thread Ralph Goers
now. The mvn command is in the vars > directory. > > On Sun, Apr 4, 2021 at 21:09 Ralph Goers wrote: > >> Matt, >> >> I just noticed that the build for Log4j 2 Master is failing. I guess you >> must have modified the configuration a while ago. I had thought e

Jenkins build

2021-04-04 Thread Ralph Goers
Matt, I just noticed that the build for Log4j 2 Master is failing. I guess you must have modified the configuration a while ago. I had thought each project had their own Jenkins file but it appears they are all now sharing one in the logging-pipelines project. I took a look at that project but

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3004 Add plugin support to JsonTemplateLayout. (#476)

2021-04-03 Thread Ralph Goers
full build before you commit. This should be standard practice for everyone. Ralph > On Apr 3, 2021, at 1:27 PM, Ralph Goers wrote: > > Volkan, > > I haven’t looked at the details of what you changed in JsonTemplateLayout yet > but the below concerns me a bit…. > >

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-3004 Add plugin support to JsonTemplateLayout. (#476)

2021-04-03 Thread Ralph Goers
Volkan, I haven’t looked at the details of what you changed in JsonTemplateLayout yet but the below concerns me a bit…. Ralph > On Apr 3, 2021, at 3:48 AM, v...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > Why were changes to the registry requi

Master is merged

2021-04-02 Thread Ralph Goers
I’ve merged the Java 11 changes to the master branch. To summarize: Toolchains are no longer required. Java11 (or later?) is required to build and run. However, I have only tried with Java 11. Log4j-api and log4j-plugins are JPMS modules. Log4j-core will be attacked next. We will want to review

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-02 Thread Ralph Goers
don’t > know enough about maven to explain why, but some modules require other > modules to have been installed and not just packaged. > > On Fri, Apr 2, 2021 at 17:04 Ralph Goers wrote: > >> Well, log4j-api, log4j-plugins and log4j-core each have unit tests and >> te

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-02 Thread Ralph Goers
practiced part of the Maven rituals. This said, shall we prevent them > from getting published? That is, do we need to publish them to the Maven > Central, given they are only needed for internal testing? > > On Mon, Mar 29, 2021 at 1:24 AM Ralph Goers > wrote: > >>

Re: Garbage Free Precise Time

2021-04-02 Thread Ralph Goers
thousands of warmup cycles? Admittedly I haven't > taken a look at the failures yet and there's a great deal of subtlety around > this. I can try to take a closer look later, unfortunately I've been > overwhelmed lately. > > On Fri, Apr 2, 2021, at 03:59, Ralph Go

Re: Garbage Free Precise Time

2021-04-02 Thread Ralph Goers
Looking at the source repo I don’t see anything that changed after support for the higher precision was added. Ralph > On Apr 2, 2021, at 12:44 AM, Ralph Goers wrote: > > Yes, I was just thinking that. But if there was a bug fix along the way that > added a single line of code th

Re: Garbage Free Precise Time

2021-04-02 Thread Ralph Goers
Yes, I was just thinking that. But if there was a bug fix along the way that added a single line of code that could now be causing the code not to be inlined. Ralph > On Apr 2, 2021, at 12:38 AM, Remko Popma wrote: > > On Fri, Apr 2, 2021 at 4:26 PM Ralph Goers > wrote: > &

Re: Garbage Free Precise Time

2021-04-02 Thread Ralph Goers
use since AdoptOpenJDK doesn’t have access to the Java test kit so can’t be Java certified. Although I have Oracle’s Java 11 installed I rarely use it due to the licensing issues. Ralph > On Apr 2, 2021, at 12:25 AM, Ralph Goers wrote: > > I will take a look at the link. What you are

Re: Garbage Free Precise Time

2021-04-02 Thread Ralph Goers
gt; Profiles tend to disable the optimizations that allow escape analysis, so > our method may show up as allocating when looked at in a profiler, while in > real life it will not (after sufficient warmup). > > > > On Fri, Apr 2, 2021 at 2:46 PM Ralph Goers > wrote: >

Re: Garbage Free Precise Time

2021-04-02 Thread Ralph Goers
s. (We actually ran into this in a work project.) > Profiles tend to disable the optimizations that allow escape analysis, so > our method may show up as allocating when looked at in a profiler, while in > real life it will not (after sufficient warmup). > > > > On Fri, A

Re: Garbage Free Precise Time

2021-04-01 Thread Ralph Goers
> On Apr 1, 2021, at 10:38 PM, Ralph Goers wrote: > > In thinking about this problem I suspect we never noticed that the > PreciseClock version of our SystemClock class is not garbage free is because > we previously ran all of our unit tests with Java 8. Now that they are u

Garbage Free Precise Time

2021-04-01 Thread Ralph Goers
In thinking about this problem I suspect we never noticed that the PreciseClock version of our SystemClock class is not garbage free is because we previously ran all of our unit tests with Java 8. Now that they are using Java 11 that code is being exercised. I’ve looked at java.time.Clock and

Re: Please do not commit to log4j2 master - but review this PR.

2021-03-31 Thread Ralph Goers
FYI - I plan on merging this code Friday morning MST unless my schedule changes between now and then. Ralph > On Mar 29, 2021, at 3:58 PM, Ralph Goers wrote: > > I should have added that you may need a recent version of the JDK. I forget > what error I was encountering but upgra

Another JsonTemplateLayout question on StackOverflow....

2021-03-30 Thread Ralph Goers
https://stackoverflow.com/questions/66832654/how-to-set-jsontemplatelayout-eventtemplateuri-outside-of-classpath-in-log4j2 Ralph

Re: Please do not commit to log4j2 master - but review this PR.

2021-03-29 Thread Ralph Goers
021, at 3:51 PM, Matt Sicker wrote: > > I’ll make sure to look more closely at it this week. Nice work on > simplifying the modules a bit! > > On Sun, Mar 28, 2021 at 18:24 Ralph Goers > wrote: > >> I have created https://github.com/apache/logging-log4j2/pull/480 for

Please do not commit to log4j2 master - but review this PR.

2021-03-28 Thread Ralph Goers
I have created https://github.com/apache/logging-log4j2/pull/480 for you to review. It has many changes and merge conflicts will be painful to fix so please do not commit to master until this PR is merged. Although I could merge this now I would prefer if you could checkout the branch on your l

Re: [apache/logging-log4j2] MapMessage put methods should not mandate String values (#477)

2021-03-25 Thread Ralph Goers
Object instead of just String > into the map, then shouldn't we provide a way to get the object out? > > Sorry about my poor proofreading. > > > On Thu, Mar 25, 2021 at 12:17 PM Ralph Goers > wrote: > >> You getObject method below returns a String. That i

Re: [apache/logging-log4j2] MapMessage put methods should not mandate String values (#477)

2021-03-25 Thread Ralph Goers
values in the map, then we would need a new > method. > > Maybe I lost the plot, but I don't see the point of allowing people to put > non-string objects into the map unless they can get non-string objects back. > > On Thu, Mar 25, 2021 at 10:51 AM Ralph Goers > wrote: &

Re: [apache/logging-log4j2] MapMessage put methods should not mandate String values (#477)

2021-03-25 Thread Ralph Goers
25, 2021 at 8:02 AM Gary Gregory wrote: > >> The 2 postfix gives me flashbacks of Microsoft COM interfaces! :-p >> putObject is less shudder inducing than put2... for me at least. >> >> Gary >> >> >> On Thu, Mar 25, 2021, 01:08 Remko Popma wrote: >

Re: [apache/logging-log4j2] MapMessage put methods should not mandate String values (#477)

2021-03-25 Thread Ralph Goers
.. for me at least. > > Gary > > > On Thu, Mar 25, 2021, 01:08 Remko Popma wrote: > >> Haha! >> putObject? >> >> >> >>> On Mar 25, 2021, at 11:39, Ralph Goers >> wrote: >>> >>> I’m sure that will drive Gary nu

Re: [apache/logging-log4j2] MapMessage put methods should not mandate String values (#477)

2021-03-24 Thread Ralph Goers
Wed, Mar 24, 2021, at 19:29, Remko Popma wrote: >>> I called it StringMap because the keys must be Strings. Admittedly not a >>> great name. :-) >>> >>> Not sure exactly, but there may be cases where this change could cause an >>> issue: >>> p

Re: release-2.x EventLogger

2021-03-24 Thread Ralph Goers
I believe Matt made the tests in the API run in parallel. I’ve often wondered about that since LogManager is creating contexts meant to be shared across multiple threads. I have no idea how all that will behave in a multi-threaded environment since most unit tests create and destroy LoggerContex

Re: [apache/logging-log4j2] MapMessage put methods should not mandate String values (#477)

2021-03-24 Thread Ralph Goers
I looked the other day and wondered the same thing Volkan did. There are no unit tests and the contributor didn’t even indicate that he had tried it. I was initially concerned that the underlying Map wouldn’t support it since it has StringMap in its name. It turns out the values are objects.

Re: Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-03-22 Thread Ralph Goers
I will try to get to it this evening. Ralph > On Mar 22, 2021, at 1:26 PM, Volkan Yazıcı wrote: > > Hello, > > I have created a GitHub PR (#476) > addressing LOG4J2-3004 > JsonTemplateLayout plugin support >

Re: The Logging Services PMC is pleased to announce our newest PMC member, Robert Middleton!

2021-03-21 Thread Ralph Goers
Congratulations Robert! This is well deserved. Please check Jira and see if you now have all the permissions that you need. Ralph > On Mar 21, 2021, at 6:30 PM, Matt Sicker wrote: > > The PMC has recently invited Robert to join the PMC which he has > accepted. Please join me in welcoming our n

JsonTemplateLayout questions on StackOverflow.

2021-03-19 Thread Ralph Goers
Volkan, Perhaps you could look at https://stackoverflow.com/questions/0379/jsontemplatelayout-can-log-level-be-converted-to-lower-case . I don’t know that answer to this. You might als

(RESULT][VOTE] Announce EOL for Java 6 and Java 7

2021-03-18 Thread Ralph Goers
This vote has passed with 6 binding +1 votes. No other votes or concerns were expressed. I will prepare an announcement email for the PMC’s approval before sending it. Given the concerns about the Download page, while I will remove the actual download links I will leave the information regardin

<    3   4   5   6   7   8   9   10   11   12   >