Re: Spring 3 and Log4j 3

2024-01-11 Thread Ralph Goers
On 2024/01/10 09:27:22 Volkan Yazıcı wrote: > Thanks for chasing this Ralph, it is indeed a nice step forwards. > > The aforementioned Log4j issue is fixed in #2062 > : > >1. You submitted the PR on Dec 5 at 04:15 (GMT+1) and merged it at

Re: Spring 3 and Log4j 3

2024-01-10 Thread Piotr P. Karwasz
Hi Ralph, On Thu, 11 Jan 2024 at 01:38, Ralph Goers wrote: > I fixed two bugs. One was reported against 2.x ages ago. The second was first > reported in the Spring issue. > > Yes, they can be ported to 2.x but if we release 3.0.0 in the next couple of > months I would prefer to tell users just

Re: Spring 3 and Log4j 3

2024-01-10 Thread Ralph Goers
> On Jan 10, 2024, at 11:29 AM, Piotr P. Karwasz > wrote: > > Hi Matt, > > On Wed, 10 Jan 2024 at 18:45, Matt Sicker wrote: >> >> This might affect 2.x, though it’s largely in the Spring environment >> property source. Given the application lifecycle there, Spring doesn’t seem >> to remo

Re: Spring 3 and Log4j 3

2024-01-10 Thread Matt Sicker
Oh, in that case, assuming it’s a bug in log4j 2.x as well, then yes, seems worth fixing. > On Jan 10, 2024, at 12:29 PM, Piotr P. Karwasz > wrote: > > Hi Matt, > > On Wed, 10 Jan 2024 at 18:45, Matt Sicker wrote: >> >> This might affect 2.x, though it’s largely in the Spring environment >

Re: Spring 3 and Log4j 3

2024-01-10 Thread Piotr P. Karwasz
Hi Matt, On Wed, 10 Jan 2024 at 18:45, Matt Sicker wrote: > > This might affect 2.x, though it’s largely in the Spring environment property > source. Given the application lifecycle there, Spring doesn’t seem to remove > its own closed property sources at shutdown, hence the exception. The issu

Re: Spring 3 and Log4j 3

2024-01-10 Thread Matt Sicker
This might affect 2.x, though it’s largely in the Spring environment property source. Given the application lifecycle there, Spring doesn’t seem to remove its own closed property sources at shutdown, hence the exception. The issue was only reported against Spring 3, though. > On Jan 10, 2024, a

Re: Spring 3 and Log4j 3

2024-01-10 Thread Piotr P. Karwasz
Hi Ralph, On Tue, 9 Jan 2024 at 22:45, Ralph Goers wrote: > > FYI - in > https://github.com/spring-projects/spring-boot/issues/33450#issuecomment-1883014368 > has confirmed that Log4j 3.0.0-beta1 now works correctly with Spring 3.x. Are you planning to backport that patch or is it specific to

Re: Spring 3 and Log4j 3

2024-01-10 Thread Volkan Yazıcı
Thanks for chasing this Ralph, it is indeed a nice step forwards. The aforementioned Log4j issue is fixed in #2062 : 1. You submitted the PR on Dec 5 at 04:15 (GMT+1) and merged it at 05:58. Next time, would you mind giving us a couple of

Re: Spring 3 and Log4j 3

2024-01-09 Thread Gary Gregory
Nice! 😀 On Tue, Jan 9, 2024, 4:45 PM Ralph Goers wrote: > FYI - in > https://github.com/spring-projects/spring-boot/issues/33450#issuecomment-1883014368 > has confirmed that Log4j 3.0.0-beta1 now works correctly with Spring 3.x. > > Ralph

Spring 3 and Log4j 3

2024-01-09 Thread Ralph Goers
FYI - in https://github.com/spring-projects/spring-boot/issues/33450#issuecomment-1883014368 has confirmed that Log4j 3.0.0-beta1 now works correctly with Spring 3.x. Ralph