Re: logging-log4j2 git commit: Always delete temporary file created in test

2017-11-19 Thread Mikael Ståldal
OK, but it's probably good to have appender.stop() there as well, to try to end cleanly. And if you to try/catch around the deleteIfExists, it would be good to log any error, since that might be useful to troubleshoot any future file permission errors on Jenins. But I'll let you fix it. On

Re: logging-log4j2 git commit: Always delete temporary file created in test

2017-11-19 Thread Remko Popma
I have a fix, but I’ll hold off pushing it until Ralph is done with the release that’s in progress. (It’s just a try/catch FileSystemException around the deleteIfExists in the finally block on line 174) (Shameless plug) Every java main() method deserves http://picocli.info > On Nov 19, 2017,

Re: logging-log4j2 git commit: Always delete temporary file created in test

2017-11-19 Thread Mikael Ståldal
Does it help if you add: appender.stop(10, TimeUnit.SECONDS); after line 171 in Log4j1ConfigurationFactoryTest.java (last in the try block)? On 2017-11-19 05:41, Remko Popma wrote: The build now fails on windows. I always see this error: expected: C:\Users\remko\AppData\Local\Temp\/had

Re: logging-log4j2 git commit: Always delete temporary file created in test

2017-11-18 Thread Remko Popma
The build now fails on windows. I always see this error: expected: C:\Users\remko\AppData\Local\Temp\/hadoop.log Actual: C:\Users\remko\AppData\Local\Temp\/hadoop.log java.nio.file.FileSystemException: C:\Users\remko\AppData\Local\Temp\hadoop.log: The process cannot access the file because it is