Fwd: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a uniform Log4j 1.x message factory

2022-03-04 Thread Gary Gregory
Hi Piotr and welcome aboard. I usually update changes.xml but not in a PR, we generate the release notes from changes.xml. Gary -- Forwarded message - From: GitBox Date: Fri, Mar 4, 2022 at 2:57 PM Subject: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a

Re: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a uniform Log4j 1.x message factory

2022-03-04 Thread Gary Gregory
That's up to you ;-) Gary On Fri, Mar 4, 2022, 17:20 Piotr P. Karwasz wrote: > Thanks Gary, > > I updated the change list, although I am still not sure which changes > should be there and which are irrelevant for the users. > > Piotr > > > On Fri, Mar 4, 2022 at 9:10 PM Gary Gregory > wrote:

Re: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a uniform Log4j 1.x message factory

2022-03-04 Thread Piotr P. Karwasz
Thanks Gary, I updated the change list, although I am still not sure which changes should be there and which are irrelevant for the users. Piotr On Fri, Mar 4, 2022 at 9:10 PM Gary Gregory wrote: > > Hi Piotr and welcome aboard. > > I usually update changes.xml but not in a PR, we generate

Re: [Chainsaw] Removal of Log4j1

2022-03-04 Thread Scott Deboy
I'll check out your branch - there are a ton of features, I'll put some documentation together on what exists. Advertiser support is already there now btw. Scott On 2/21/22, Robert Middleton wrote: > I've finished removing log4j1 from Chainsaw. If anybody would like to take > a look, it is in

Re: [Chainsaw] Removal of Log4j1

2022-03-04 Thread Robert Middleton
I just merged it in a few hours ago, but if you are able to check it out that would be nice too! It is still a little buggy at the moment, so some changes still need to be done. I've started updating at least some of the documentation here:

Re: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a uniform Log4j 1.x message factory

2022-03-04 Thread Ralph Goers
In general, if it requires a Jira issue then it should require a changes.xml entry. Usually, PRs require Jira issues. However, simple doc updates and dependency updates don’t necessarily require Jira issues although I would prefer to see it handled differently. But since Gary is the one who

Re: MacOS: Unit tests failing on release-2.x branch

2022-03-04 Thread Volkan Yazıcı
There is already a ticket for that: LOG4J2-3019. He better shares that detail in the ticket comments. On Thu, 3 Mar 2022, 18:38 Matt Sicker wrote: > That timezone issue sounds like a bug either way, so you can file a > Jira issue about that. > > On Thu, Mar 3, 2022 at 12:25 AM Atul Pendse >