Re: [OT] Java 9 module vote results

2017-05-09 Thread Matt Sicker
Even though they weren't part of the vote, my local JUG has the same opinion as the London JUG. We have some OSGi developers there as well (e.g., from Felix). The sounds of some of those votes are "it's almost ready, and it might be good enough now, but what was submitted is not what exists at

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

2017-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003880#comment-16003880 ] ASF GitHub Bot commented on LOG4J2-1874: Github user leventov commented on the issue:

Re: [OT] Java 9 module vote results

2017-05-09 Thread Gary Gregory
Right, they have 30 days to adjust. Gary On Tue, May 9, 2017 at 5:53 PM, Ralph Goers wrote: > My understanding is that this is still an interim ballot. I believe the > final vote is supposed to happen around June 1. Still 9 for and 13 against > is mighty

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

2017-05-09 Thread leventov
Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @remkop I did that for log4j-core only. Yes, it passes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Java 9 modules

2017-05-09 Thread Ralph Goers
I’m not sure what that means. I may try to refactor log4j-api to be a Multi-Release jar so that the IDEs have less of an issue. However, once the next Java 9 JDK is released I believe whatever the issue with the tests was that Gary found will be fixed, so he should just be able to use Java 9

Re: Java 9 modules

2017-05-09 Thread Matt Sicker
So similar to the OSGi bundle loading strategy, for Java 9, we'll need a layer loading strategy? On 9 May 2017 at 11:36, Ralph Goers wrote: > As I understand it, what you are saying is possible but Log4j doesn’t > currently need to load these dependencies

[OT] Java 9 module vote results

2017-05-09 Thread Gary Gregory
FYI: https://jcp.org/en/jsr/results?id=5959 Notice the comments in the text box. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

2017-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002951#comment-16002951 ] ASF GitHub Bot commented on LOG4J2-1874: Github user remkop commented on the issue:

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

2017-05-09 Thread remkop
Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/71 Do all tests pass when you run `mvn clean install` on your machine? (may take ~20 minutes) On Wednesday, May 10, 2017 12:34 AM, Roman Leventov wrote:

Re: Java 9 modules

2017-05-09 Thread Pedro Lamarão
Hello all! I have been lurking on the list for a while, as a user of both log4j and log4cxx. This Java 9 module situation greatly interests me. About the circularity problem, isn't it the case that loading modules at runtime will solve the circularity problem? As far as I understand the new

Re: Java 9 modules

2017-05-09 Thread Ralph Goers
While it may sound reasonable, it is not. Matt’s point about LoggerFinder and our support of NoSQL appenders and the like is proof that there are valid reasons for circularities. We are just lucky that Jackson and Disruptor don’t seem to do logging or we would have circularities there too. BTW

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

2017-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002881#comment-16002881 ] ASF GitHub Bot commented on LOG4J2-1874: Github user leventov commented on the issue:

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

2017-05-09 Thread leventov
Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @remkop this test used to depend on specific line numbers in this test. Made it more generic. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

2017-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002872#comment-16002872 ] ASF GitHub Bot commented on LOG4J2-1874: Github user remkop commented on the issue:

Re: Java 9 modules

2017-05-09 Thread Gary Gregory
On May 9, 2017 12:18 AM, "Remko Popma" wrote: (Shameless plug) Every java main() method deserves http://picocli.info > On May 9, 2017, at 15:35, Gary Gregory wrote: > > Hi All, > > On Mon, May 8, 2017 at 10:46 PM, Ralph Goers

[GitHub] logging-log4j2 pull request #71: [LOG4J2-1874] Add ByteBufferDestionation.wr...

2017-05-09 Thread leventov
Github user leventov commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/71#discussion_r115515373 --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/StringBuilderEncoder.java --- @@ -32,9 +32,14 @@ public class

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

2017-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002845#comment-16002845 ] ASF GitHub Bot commented on LOG4J2-1874: Github user leventov commented on a diff in the pull

[GitHub] logging-log4j2 pull request #71: [LOG4J2-1874] Add ByteBufferDestionation.wr...

2017-05-09 Thread leventov
Github user leventov commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/71#discussion_r115512718 --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/StringBuilderEncoder.java --- @@ -32,9 +32,14 @@ public class

[jira] [Commented] (LOG4J2-1874) Add ByteBufferDestionation.write(ByteBuffer) and write(byte[], int, int) methods and call them from TextEncoderHelper whenever possible

2017-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002782#comment-16002782 ] ASF GitHub Bot commented on LOG4J2-1874: Github user jvz commented on a diff in the pull request:

Re: Java 9 modules

2017-05-09 Thread Gary Gregory
On Tue, May 9, 2017 at 12:34 AM, Apache wrote: > Technically you are considered modularized just by adding a manifest entry > providing the module name. But all the packages are exported. You cannot do > more than that until all your dependencies do at least that

[jira] [Commented] (LOG4J2-1798) InterruptedException on RollingFileManager#rollover()

2017-05-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002211#comment-16002211 ] Gary Gregory commented on LOG4J2-1798: -- Hi Karel, Feel free to provide a patch if you are willing

[jira] [Commented] (LOG4J2-1798) InterruptedException on RollingFileManager#rollover()

2017-05-09 Thread Karel Cerman (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002209#comment-16002209 ] Karel Cerman commented on LOG4J2-1798: -- Hello is there any information about fix for this, please?

[jira] [Commented] (LOG4J2-864) RollingFile - bad naming of files within zipped archives

2017-05-09 Thread Karel Cerman (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002208#comment-16002208 ] Karel Cerman commented on LOG4J2-864: - Hello is there any chance that this will be fixed? Thanks for

[jira] [Commented] (LOG4J2-1725) RollingFileAppender's filePattern not reloaded when using monitorInterval

2017-05-09 Thread Karel Cerman (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002204#comment-16002204 ] Karel Cerman commented on LOG4J2-1725: -- Hello, is there any possibility that this will be fixed

Re: Java 9 modules

2017-05-09 Thread Remko Popma
(Shameless plug) Every java main() method deserves http://picocli.info > On May 9, 2017, at 15:35, Gary Gregory wrote: > > Hi All, > > On Mon, May 8, 2017 at 10:46 PM, Ralph Goers > wrote: > >> So I keep reading up on Java modules and

Re: Java 9 modules

2017-05-09 Thread Gary Gregory
Hi All, On Mon, May 8, 2017 at 10:46 PM, Ralph Goers wrote: > So I keep reading up on Java modules and the more I do the more confused I > get about how this can ever work properly. > > 1. I am confused about how we are supposed to create a module and > reference