Re: maven-shaded-log4j-transformer

Here it is: https://github.com/apache/logging-log4j-tools Gary On Fri, Oct 15, 2021, 14:12 Ralph Goers wrote: > Yeah, that makes sense. It is less specific than just Maven plugins. > > Ralph > > > On Oct 15, 2021, at 9:51 AM, Gary Gregory > wrote: > > > > I think Ralph started a tools repo

Re: maven-shaded-log4j-transformer

Yeah, that makes sense. It is less specific than just Maven plugins. Ralph > On Oct 15, 2021, at 9:51 AM, Gary Gregory wrote: > > I think Ralph started a tools repo which we should reuse for this component > IMO. > > Gary > > On Fri, Oct 15, 2021, 11:22 Matt Sicker wrote: > >> I’m in

Re: maven-shaded-log4j-transformer

I think Ralph started a tools repo which we should reuse for this component IMO. Gary On Fri, Oct 15, 2021, 11:22 Matt Sicker wrote: > I’m in favor of making this its own repo. Making the build, site, and > release process as simple as possible would be great. I can help with the > release

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

I don’t really understand this. When I was migrating the web site from the ASF CMS to GitHub it was made clear that web site hosting using GitHub Pages wasn’t supported. I am not sure what the proposal here is. Ralph > On Oct 15, 2021, at 8:27 AM, Matt Sicker wrote: > > I’m not exactly

Re: maven-shaded-log4j-transformer

The ASF has automated creating new git repos. PMC members can do it on a simple web form. We just have to have consensus on what we want to do. Whatever we decide to do, you can either make the changes needed in your PR or it can be done after the fact. Although I like Volkan’s idea of using

Re: maven-shaded-log4j-transformer

Hello Volkan, Ralph Please let me mention that the transformer is quite tiny (3 java classes) extension for the existing Maven Shade Plugin therefore I would suggest *Artifact ID:* shade-plugin-log4j-transformer Regarding the class name

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

I’m not exactly sure how we can get a beta subdomain, though the staging one is built in. And while it would be great to automate as much as possible about the release process in GHA, the code signing aspect is still not possible (though we might be able to integrate with another service at

Re: maven-shaded-log4j-transformer

I’m in favor of making this its own repo. Making the build, site, and release process as simple as possible would be great. I can help with the release process at least. Matt Sicker > On Oct 15, 2021, at 09:56, Volkan Yazıcı wrote: > > License headers, `changes.xml` integration, JPMS

Re: maven-shaded-log4j-transformer

License headers, `changes.xml` integration, JPMS shizzle(?), etc. I guess we will need to copy quite some plumbing code from Log4j 2. Nevertheless, they are all doable. I am also in favor of using GitHub all the way down: GitHub Issues for issue tracking, GitHub Actions for CI/CD (yes, even CD!),

Re: maven-shaded-log4j-transformer

Hello Gary, thanks for note, it's simple to add -- Best regards, Ed On Fri, Oct 15, 2021 at 5:48 PM Gary Gregory wrote: > Hi Ed, > > Your files must have the Apache License header comment, otherwise running > 'mvn apache-rat:check' will fail. > > Gary > > > On Fri, Oct 15, 2021, 09:49 Eduard

Re: maven-shaded-log4j-transformer

Hi Ed, Your files must have the Apache License header comment, otherwise running 'mvn apache-rat:check' will fail. Gary On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin wrote: > Hello dear log4j team > > Volkan Yazıcı asked me to make maven-shaded-log4j-transformer >

Re: maven-shaded-log4j-transformer

I also support the idea of moving it to a separate project. `logging-log4j2` is already bloated a lot and it hurts compilation & test times, severely. I think we have already agreed on breaking up the project into individual projects. My proposal: - *GitHub project name:*

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

I've had to use this plugin in the past. I'm glad to hear of this agreement!: -) Gary On Fri, Oct 15, 2021, 06:42 Volkan Yazıcı wrote: > I have gotten in touch with the author of the > maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly > accepted to contribute this plugin

Re: maven-shaded-log4j-transformer

Question: Do we want it as a sub-module or as a new git repo with its own release? Ralph > On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin wrote: > > Hello dear log4j team > > Volkan Yazıcı asked me to make maven-shaded-log4j-transformer >

Re: maven-shaded-log4j-transformer

Hello dear log4j team Volkan Yazıcı asked me to make maven-shaded-log4j-transformer a part of log4j2 and I tend to accomplish the proposal. Can you please confirm that new sub-module name log4j-maven-shade-plugin is ok Any

Re: Continuous Log4j-vs-Logback benchmarks

I won’t be back to a dev machine until Sunday, but I’d be happy to put together a list at that point! -ck > On Oct 15, 2021, at 7:16 AM, Volkan Yazıcı wrote: > > I am looking for certain JMH benchmarks to assess the Log4j-vs-Logback > performance. I plan to integrate these into the

Re: Cek's new log4j vs logback benchmark

Thanks :-) That works for me. -ck > On Oct 15, 2021, at 7:07 AM, Volkan Yazıcı wrote: > > Welcome back and great work Carter! I am inclined to merge the > `release-2.x` changes to clear out the way for the 2.15.0 release. (I guess > Ralph's changes will be the only blocker after that.)

Continuous Log4j-vs-Logback benchmarks

I am looking for certain JMH benchmarks to assess the Log4j-vs-Logback performance. I plan to integrate these into the `benchmark` CI workflow I have recently added. `log4j-perf` is an endless well, difficult to pinpoint the crucial ones. Carter, given you have the most up-to-date knowledge on

Re: Cek's new log4j vs logback benchmark

Welcome back and great work Carter! I am inclined to merge the `release-2.x` changes to clear out the way for the 2.15.0 release. (I guess Ralph's changes will be the only blocker after that.) Porting those to `master` can be tackled in parallel. On Fri, Oct 15, 2021 at 1:03 PM Carter Kozak

Re: Cek's new log4j vs logback benchmark

I’ve been on vacation with limited network access since Saturday, but I’ll be back on Sunday. My PR is ready to merge into release-2.x, I haven’t done so yet because I began the cherry-pick to master but was unable to complete the relatively painful conflict resolution before my flight out.

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

This sounds great. Thanks, Volkan! -ck > On Oct 15, 2021, at 6:42 AM, Volkan Yazıcı wrote: > > I have gotten in touch with the author of the > maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly > accepted to contribute this plugin in the form of a PR to the project. I >

Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

I long had the ambition to move the entire site & manual to gh-pages. In an ideal world, I would even move the release process to GitHub Actions too. But these are, for now, pretty ambitious goals. What I would really appreciate is to access gh-pages content via, say,

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

I have gotten in touch with the author of the maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly accepted to contribute this plugin in the form of a PR to the project. I gave him a briefing about the ICLA, Jira ticket, GitHub PR, etc. process and told him to first send an